09:03:10 <nishanth> #startmeeting check-in_20161223 09:03:10 <zodbot> Meeting started Fri Dec 23 09:03:10 2016 UTC. The chair is nishanth. Information about MeetBot at http://wiki.debian.org/MeetBot. 09:03:10 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic. 09:03:10 <zodbot> The meeting name has been set to 'check-in_20161223' 09:04:22 <nishanth> #topic brainfunked 's updates 09:05:38 <brainfunked> am working on the node agent spec, #87 09:05:56 <brainfunked> expect it to be up for review by Monday morning 09:06:36 <brainfunked> did all the pending reviews yesterday 09:06:49 <brainfunked> and I keep suggesting improvements to gowtham's node inventory specs 09:07:06 <brainfunked> also, got the common logging folks to review our logging specification 09:07:14 <brainfunked> they've added comments, which I'll take a look at and address 09:07:28 <nishanth> #accept brainfunked working on https://github.com/Tendrl/specifications/issues/87 09:07:44 <brainfunked> also talked to Rakesh regarding the end-user documentation upstream 09:07:58 <brainfunked> that's about it I suppose 09:08:14 <brainfunked> focus now is solely on finishing that spec 09:09:13 <nishanth> #accept brainfunked working with logging framework folks to review the looging specification 09:09:40 <nishanth> #topic gowtham's updates 09:09:56 <gowtham> Adding disk details in hardware inventory 09:09:56 <gowtham> git-issue: https://github.com/Tendrl/node_agent/issues/7 09:09:56 <gowtham> spec file: https://github.com/Tendrl/specifications/pull/21 09:09:56 <gowtham> code-PR: https://github.com/Tendrl/node_agent/pull/64 09:10:13 <gowtham> as per brainfunked suggestion have completed implement fro disk 09:10:34 <gowtham> brainfunked, http://10.70.42.112:2379/v2/keys/nodes/b899ec5f-db61-4fb4-a15d-f0021bf5eef0/Disks can you please look this 09:11:00 <gowtham> i have added all possible values from hwinfo and lsblk 09:11:03 <brainfunked> gowtham, could you give me the dump on pastebin or some such? 09:11:27 <gowtham> brainfunked, ok 09:11:53 <gowtham> Adding Network details in hardware inventory 09:11:54 <gowtham> git-issue: https://github.com/Tendrl/node_agent/issues/78 09:11:54 <gowtham> spc file: https://github.com/Tendrl/specifications/pull/19 09:11:54 <gowtham> code-PR: https://github.com/Tendrl/node_agent/pull/79 09:12:06 <brainfunked> btw, I'll get to all the reviews towards the end of the day or maybe over the weekend 09:12:17 <brainfunked> would really like to concentrate on the node agent spec 09:12:37 <gowtham> brainfunked, i have updated spec also for disk.. 09:12:38 <brainfunked> do let me know if this means someone would be blocked, in which case, I can prioritise those reviews 09:12:49 <brainfunked> nishanth, would you mind adding action items on me for pending reviews? 09:13:09 <nishanth> brainfunked, sure 09:13:24 <gowtham> brainfunked, you told some minor comments yesterday for disks i am done also in spec 09:13:42 <nishanth> gowtham, both of these specs are yet to be approved right? 09:13:46 <gowtham> brainfunked, totaly 47 fields added for disks details from both commands 09:13:53 <gowtham> brainfunked, yes 09:14:14 <gowtham> nigelb, yes 09:14:18 <gowtham> nishanth, yes 09:14:31 <brainfunked> gowtham, one comment I'd make about the code is that it could be more object oriented 09:14:32 <gowtham> nishanth, brainfunked told to add possible values from all comments 09:14:54 <nishanth> #info gowtham is working on https://github.com/Tendrl/node_agent/issues/7, https://github.com/Tendrl/node_agent/issues/78 09:15:02 <gowtham> brainfunked, yes i have implemented like that only 09:15:27 <gowtham> brainfunked, as per your comment i have inhered used and free disk from diks 09:15:32 <gowtham> *disk 09:15:42 <gowtham> *inherited 09:15:44 <brainfunked> ok 09:15:52 <gowtham> brainfunked, only testing is pending 09:16:09 <brainfunked> what about test cases? 09:16:17 <nishanth> #action brainfunked and nishanth to review https://github.com/Tendrl/node_agent/issues/7, https://github.com/Tendrl/node_agent/issues/78 09:16:30 <gowtham> brainfunked, almost done , i will send pr within one hour 09:16:58 <nishanth> gowtham, disk and network ? 09:17:09 <gowtham> nishanth, yes 09:17:29 <brainfunked> gowtham, have you checked the comments from the common logging folks on the logging spec? 09:17:46 <gowtham> nishanth, bonded interface we can add in another spec, i already talk about this in brainfunked 09:17:46 <brainfunked> nishanth, btw, I've commented that that spec also contributes towards your updates for in flight operations spec 09:18:02 <brainfunked> gowtham, that's fine, add an issue for bonded interfaces, spec it out separately 09:18:03 <gowtham> brainfunked, ya i saw it 09:18:10 <gowtham> brainfunked, i will add that also 09:18:32 <gowtham> brainfunked, and i have commented for t0ffel questions 09:18:40 <nishanth> brainfunked, sure, I will have a look 09:18:47 <gowtham> brainfunked, please give your comments also for that 09:19:01 <gowtham> nishanth, ok 09:19:16 <gowtham> status: good 09:19:20 <gowtham> not blocked 09:19:25 <brainfunked> will do 09:19:41 <gowtham> brainfunked, ok 09:20:01 <nishanth> gowtham, the logging spec also up for review or you have some pending comments? 09:20:37 <gowtham> nishanth, i have to update that flight operation details 09:20:50 <nishanth> #action gowtham to send the PR with test cases for https://github.com/Tendrl/node_agent/issues/78 andhttps://github.com/Tendrl/node_agent/issues/7 09:21:02 <nishanth> gowtham, I will take care of that 09:21:26 <gowtham> nishanth, ok 09:21:33 <nishanth> gowtham, thanks for the updates 09:21:44 <gowtham> nishanth, thanks 09:21:54 <nishanth> #topic kaverma 's updates 09:23:35 <kaverma> have done with host-listing .. but my pr is some-way dependent on neha's cluster list pr in order to get the cluster info for nodes 09:23:35 <kaverma> and working on file share listing (volume list)[60% completed] i will try to complete it today. 09:25:34 <kaverma> end 09:26:01 <nishanth> kaverma, PR's send for review? 09:26:30 <neha> nishanth, Kamlesh PR is dependent on mine PR 09:26:35 <kaverma> not yet send the pr for host-list .. but this is ready .. only waiting for neha's cluster-list pr 09:27:00 <kaverma> actually my host-list is dependent on cluster info as well 09:27:39 <nishanth> kaverma, neha, will you able to send the PR today? what is ETA? 09:28:18 <neha> I have already sent PR for cluster list 09:28:32 <neha> for pool list I will send on Monday 09:28:41 <kaverma> nishanth, i can send host-list pr quickly but after neha pr get merged ..so that i can take cluster info from there 09:29:07 <kaverma> nishanth, and for file share i will send pr by monday 09:29:27 <nishanth> kaverma, you don't need to wait till the PR gets merged, later you can rebase 09:29:37 <kaverma> nishanth, ok 09:29:51 <kaverma> will send it right wasy 09:29:55 <kaverma> *away 09:30:29 <nishanth> #action kaverma to send the PR for host listing today for review 09:31:23 <nishanth> #info kaverma work in progress for the Fileshare listing , will send the PR by Monday 26th Dec 09:31:47 <nishanth> kaverma, anything blocking the progress? 09:32:02 <kaverma> nishanth, nup .. 09:32:52 <nishanth> kaverma, thanks for the updates 09:33:03 <nishanth> #topic neha 's updates 09:33:30 <neha> I have sent PR for cluster list, incorporating review comments 09:33:42 <neha> after that will start with pool list view 09:34:12 <nishanth> who should review the PR's ? 09:34:24 <kaverma> nishanth, i am reviewing .. 09:35:06 <nishanth> neha, can you please provide the link of the PR? 09:35:37 <neha> https://github.com/Tendrl/tendrl_frontend/pull/70 09:36:07 <nishanth> #action kamlesh to review https://github.com/Tendrl/tendrl_frontend/pull/70 09:37:05 <nishanth> #accept cluster list view work is progressing. send the PR https://github.com/Tendrl/tendrl_frontend/pull/70 09:37:22 <nishanth> neha, any ETA for pool list? 09:39:51 <nishanth> neha^^ 09:40:31 <nishanth> #topic shu6h3ndu 's updates 09:40:43 <Shu6h3ndu> nishanth, at https://paste.fedoraproject.org/511503/14824857/ 09:41:14 <Shu6h3ndu> Summary: worked on specs https://github.com/Tendrl/specifications/pull/93 and https://github.com/Tendrl/specifications/pull/98 09:41:32 <Shu6h3ndu> nishanth, sent a code change PR today for https://github.com/Tendrl/specifications/pull/93 09:41:38 <Shu6h3ndu> reviews required :) 09:43:08 <nishanth> shu6h3ndu, reviews pending on me :) 09:43:37 <Shu6h3ndu> nishanth, few. I have mentioned in status update. and I have taken care of comments on refactoring changes. need to re-review 09:44:36 <nishanth> #accept shu6h3ndu reworked and pushed the patches for re-factoring. Requires review 09:46:00 <nishanth> #action nishanth to review https://github.com/Tendrl/specifications/issues/97,https://github.com/Tendrl/specifications/issues/80,https://github.com/Tendrl/specifications/issues/30 ,https://github.com/Tendrl/specifications/issues/31,https://github.com/Tendrl/gluster_integration/issues/74,https://github.com/Tendrl/gluster_integration/issues/73 09:46:36 <nishanth> shu6h3ndu, thanks for the update 09:46:59 <nishanth> #topic nishanth 's updates 09:47:24 <nishanth> #info nishanth was on sick leave 22md dec 09:47:53 <nishanth> #action nishanth to complete all pending reviews 09:48:58 <nishanth> #info nishanth working on https://github.com/Tendrl/specifications/issues/55 09:49:17 <nishanth> #endmeeting