23:59:03 #startmeeting Ansible Azure Working Group 23:59:03 Meeting started Wed Dec 6 23:59:03 2017 UTC. The chair is jborean93. Information about MeetBot at http://wiki.debian.org/MeetBot. 23:59:03 Useful Commands: #action #agreed #halp #info #idea #link #topic. 23:59:03 The meeting name has been set to 'ansible_azure_working_group' 23:59:48 Just wanted to let you know that we should prefix the name of the meeting with Ansible, e.g. `Ansible Azure Working Group` as we've had some requests from the meetbot people 23:59:58 Opened this meeting for today just so we can start that trend 00:00:53 Ok. Make sense 00:01:41 * nitzmahone lurks 00:01:53 Kylie_: any topics you wanted to discuss in the meeting 00:02:06 I believe nitzmahone and I went through the PR list you had that were ready for review 00:05:35 Thank you for taking crare of that. 00:05:42 #topic PR 00:05:55 yes, i made all the major changes in sql server and database modules. i still want to add a few default values this morning, could you check if there's anything else you would like to change? 00:05:59 @Yuwei and @zikalino, what do you want to discuss here? 00:08:23 no from my side 00:08:36 nitzmahone flattened response in container registry module, so i assume this should be the rule for all the modules, i have made this change to our other modules as well. 00:09:12 zikalino: yep we want to move away from storing results in that `state` dict, also try to only return the values that the user doesn't already know like id of a created instance 00:09:48 fact modules are different though, we would want to return all the relevant information about the resource in those cases 00:09:53 https://github.com/ansible/ansible/pull/32756 00:09:57 sometimes there's nothing left except of changed = true :-) 00:10:10 Some questions about Key Vault from Ian 00:10:45 sure fire away 00:12:14 or are you just wanting a review from us? 00:12:20 He also submitted https://github.com/ansible/ansible/pull/33607, https://github.com/ansible/ansible/pull/33606 00:13:12 His question is Integration testing is going to be difficult for these modules. They require an existing keyvault be present to create keys and secrets. Currently the keyvault management module is being reviewed, so we have no automated way (using ansible) to actually create a target keyvault. How should this be handled? 00:13:53 So once the management module is in we should be able to create a keyvault to be used in the tests? 00:16:06 I guess so. 00:16:40 #action item @zikalino, @Yuwei, @jhawkesworth_, review #32756 00:16:55 #contribution guide 00:17:02 #topic contribution guide 00:17:07 I would say that is the best way forward, at a minimum we can have tests in check mode where we assert that a failure occured but if all we need to do is merge this module in let's review it and get it in 00:19:47 Last time we learned some guidances, such as two "ship it" trigger merge, add ready_for_review. 00:20:17 Any contribution guide could we learn what's mean for tags and how to use tags? 00:21:25 this has pretty much all the info on how the bot works https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md 00:21:38 It includes the tags you can call and who has permission to do what 00:22:05 Great. Thank you. 00:22:12 you're welcome 00:22:45 #topic doc 00:23:16 http://docs.ansible.com/ansible/latest/list_of_cloud_modules.html. Are all of the contents on docs.ansible.com auto-generated from modules on GitHub? 00:23:47 yes they are, but the default site is based on the stable-2.4 branch (or whatever release is current) 00:24:11 If you want to get info based on the devel branch you need to change `latest` in the url to `devel` 00:24:16 like so http://docs.ansible.com/ansible/devel/list_of_cloud_modules.html 00:24:50 you can also specify previous version explicitly by changing the value to something like `2.3` or `2.4` 00:25:03 e.g. http://docs.ansible.com/ansible/2.3/list_of_cloud_modules.html 00:26:39 Let me have a check. 00:27:02 Welcome ryansb join us. @ryansb, could you please introduce yourself? 00:28:26 Jordan, how about http://docs.ansible.com/ansible/latest/guide_azure.html? Is this auto-generated too? If not, how could we keep it update? 00:30:07 It is auto generated and comes under the same rules for the versioning as the module docs 00:30:18 If you want to update those pages then you can see them here https://github.com/ansible/ansible/tree/devel/docs/docsite/rst 00:30:44 That particular one is here https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/guide_azure.rst 00:31:16 Keep in mind the non module docs are written in RST so it follows those conventions 00:33:08 If you want to test out how the docs actually look when developing you can run `MODULES= make webdocs` when in the main ansible directory. This will generate the html pages in `/docs/docsite/_build/html` 00:33:36 Got. Thanks. 00:33:40 No more topic from me. 00:33:57 For example, if you want to generate the docs for the module azure_rm_virtualmachine, run `MODULES=azure_rm_virtualmachine make webdocs`, if you want to just generate the non modules docs run `MODULES=none make webdocs` 00:35:09 How frequent will the doc is synced up? 00:35:23 pretty frequently but I'm not sure on the actual times 00:35:31 Ok. 00:35:37 I find when I've merged a change it should appear in the next 2 days on the devel site 00:35:38 Thank you Jordan. 00:36:37 #endmeeting 00:36:39 info as a reference http://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#testing-documentation 00:36:48 sorry I should have added you as a chair 00:36:50 #endmeeting