00:00:02 <nitzmahone> #startmeeting Ansible Azure Working Group
00:00:02 <zodbot> Meeting started Thu Jan  4 00:00:02 2018 UTC.  The chair is nitzmahone. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:00:02 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:00:02 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:00:29 <nitzmahone> #chair Kylie_
00:00:29 <zodbot> Current chairs: Kylie_ nitzmahone
00:00:29 <jborean93> Hey
00:00:35 <nitzmahone> #chair jborean93
00:00:35 <zodbot> Current chairs: Kylie_ jborean93 nitzmahone
00:00:45 <nitzmahone> #chair yuwei
00:00:45 <zodbot> Current chairs: Kylie_ jborean93 nitzmahone yuwei
00:01:08 <Kylie_> Hi Matt and Jordan, happy new year
00:01:14 <nitzmahone> #chair zikalino
00:01:14 <zodbot> Current chairs: Kylie_ jborean93 nitzmahone yuwei zikalino
00:01:16 <zodbot> Kylie_: Error: Can't start another meeting, one is in progress.
00:01:18 <nitzmahone> Same to you!
00:01:19 <jborean93> happy new year to yourself
00:01:19 <yuwei> Happy new year
00:01:36 <nitzmahone> #info agenda https://github.com/ansible/community/issues/281
00:01:58 <Kylie_> Noticed it. Thank you Matt.
00:02:07 <Kylie_> Propose topic for 1/4/2018: Final plan for upcoming 2.5; Ansible + Azure python SDK
00:02:15 <Kylie_> #topic upcoming 2.5
00:02:27 <nitzmahone> So apparently the freezes have all been pushed out a week
00:02:42 <nitzmahone> So Jan 22 and Feb 6 now
00:02:44 <Kylie_> The code freeze date for 2.5 is the first week of Feb now. Right?
00:02:48 <nitzmahone> Yep
00:03:32 <Kylie_> Jan 22 is for core. Then for us, we need to review PRs with you before Feb 6. Right?
00:04:12 <jborean93> for new features yes
00:04:17 <nitzmahone> Yeah, and really they need to be in a few days before that so we have time to review and any last minute changes addressed
00:04:38 <nitzmahone> New feature PRs coming in on Feb 5/6 are probably not going to make it
00:05:03 <nitzmahone> Bugfix activity can go on through the betas
00:05:29 <nitzmahone> But anything that significantly changes functionality, adds args, etc needs to happen by freeze
00:06:51 <Kylie_> Understand. Now new modules - SQL, MYSQL, PostgreSQL and Key Vault are still under review. Key Vault failed to pass CI. We will discuss it with Ian. Could you please help review Zim's PR for SQL, MySQL and PostgreSQL (#33210, #33173, 33566, 33567, 33568, 33569)? Any missing @zikalino?
00:07:44 <Kylie_> And new module ACI (#32025) https://github.com/ansible/ansible/pull/32025
00:07:45 <jborean93> I haven't looked but are the MySQL and Postgress database PR's updated since the last review before Christmas?
00:07:47 <nitzmahone> Yep, we'll take another pass over those this week.
00:08:12 <zikalino> mysql and postgresql server has all the updateds done, so pls check
00:08:21 <jborean93> sounds good, will do
00:08:30 <nitzmahone> I'm going to try and wrap up the CLI auth stuff this week
00:08:52 <zikalino> once these are merged i will update databases as well.
00:09:07 <Kylie_> And Yuwei updated azure_rm_networkinterface: support the multiple ip configuration #32882 . Could you please prioritize it? Some customers are asking this feature.
00:09:10 <zikalino> and nitzmahone, could you look again at container instance?
00:09:21 <nitzmahone> yep
00:10:36 <Kylie_> And Matt, please also take care of https://github.com/ansible/ansible/pull/33623 which fix test case failure for ACS. We plan to add it into our playbook role which only took the ones merged and passed Ansible CI. Thank you.
00:11:37 <nitzmahone> OK, just merged #33623
00:12:13 <Kylie_> 👍
00:12:24 <Kylie_> #topic Ansible + Azure python SDK
00:13:13 <nitzmahone> What about?
00:13:18 <Kylie_> Now it blocked running most Azure modules.
00:14:03 <Kylie_> https://github.com/ansible/ansible/pull/33897
00:14:04 <nitzmahone> Is this around positional arg reordering?
00:14:12 <Kylie_> https://github.com/ansible/ansible/pull/33624
00:15:30 <Kylie_> This is about how to define the dependency on python SDK to avoid breaking in the future.
00:16:06 <jborean93> So choosing one of the 3 solutions presented in https://github.com/ansible/ansible/pull/33624#issuecomment-353642042?
00:16:40 <Kylie_> yes
00:16:41 <jborean93> plus moving to kwargs
00:18:01 <jborean93> The 3rd option, is `1.5.0` the version of the Azure Python SDK? That seems like the best option and if we are already in 2.0.0 then seems to be ok with me
00:22:18 <nitzmahone> Yeah, I hadn't seen Laurent's latest comments on that while I was on vacation
00:22:19 <Kylie_> https://www.irccloud.com/pastebin/wtKnrb4t/
00:22:39 <Kylie_> @Yuwei? Can you confirm it?
00:25:44 <Kylie_> Currently CloudShell is using v2.4 version. Then fail to create a VM with networking security group :(.  And also fail to build the playbook role (https://galaxy.ansible.com/Azure/azure_modules/). Could you please help review https://github.com/ansible/ansible/pull/33897/files in your working hour? We want to unblock new users.
00:25:48 <nitzmahone> Yeah, I like option 3 the best as well
00:26:21 <yuwei> Yes, to fix the SDK version the code change is in https://github.com/ansible/ansible/pull/33897
00:26:51 <Kylie_> Great. Then we are aligned. Please review details to see whether we could move forward.
00:27:02 <yuwei> The previous one is to fix the ordering bug
00:27:13 <Kylie_> And once this is accepted, can it merged back to 2.4?
00:27:24 <Kylie_> @Yuwei, so we need both. Right?
00:27:28 <jborean93> Just having a brief look, shouldn't those models be declared within the module and not in the shared code
00:28:14 <Kylie_> Need both https://github.com/ansible/ansible/pull/33897/files and https://github.com/ansible/ansible/pull/33624? @Yuwei to unblock? Or only 33897 only?
00:28:16 <nitzmahone> Yeah- 2.4.3b3 shipped today, and the RC is Jan 10- I'll try to get those reviewed and backported in time for 2.4.3rc1
00:28:49 <nitzmahone> The kwarg conversion would still be necessary if the pinned model version has the wrong order, so yeah
00:29:02 <Kylie_> Nice. Let us move fast to catch Jan 10.
00:29:06 <Kylie_> Ok. then both.
00:29:29 <nitzmahone> #action nitzmahone to review/merge/backport 33897/33624 for 2.4.3rc1
00:29:45 <nitzmahone> Tower folks are going to hate us
00:29:53 <Kylie_> @Yuwei, could you please work with Jordan for his comment "Just having a brief look, shouldn't those models be declared within the module and not in the shared code" today? Pull Zhijun in if needed. Thank you.
00:29:54 <yuwei> The 33624 is a small change to fix the specific parameters ordering bug
00:30:31 <nitzmahone> With some of the architectural changes though, hopefully they can stop shipping the Azure SDK in the box, at least having two copies of it like they do now
00:31:45 <nitzmahone> Anyway- anything else pressing?
00:32:36 <nitzmahone> Once we get through the current set of open PRs, we should probably come up with a 2.5 "punch list" of anything else that needs to happen before it ships.
00:33:52 <Kylie_> https://github.com/ansible/ansible/pull/33366, could this merged back to v2.4?
00:35:40 <nitzmahone> Why can't it just use the same key that already exists?
00:36:32 <nitzmahone> We shouldn't need to add a user-agent extension string for every possible thing that could be driving it- cloud shell and VSCode can't coexist as it is, so why not just use the same value?
00:37:37 <Kylie_> They can coexist. In VSCode, you could select running Ansible on local, docker or CloudShell.
00:37:40 <nitzmahone> Or is that hardcoded into VSCode already
00:38:32 <nitzmahone> Right, but I'm assuming the client env isn't going to propagate across to CloudShell
00:38:58 <nitzmahone> So all you'd get in that case is the CloudShell value, unless something's explicitly propagating it
00:39:46 <nitzmahone> If that key's already hardcoded into VSCode though, I guess that's not an option
00:40:43 <jborean93> Can VSCode use an existing value instead?
00:41:04 <Kylie_> End users can use CloudShell only or VS Code + CloudShell. So I think they cannot use the same key.
00:42:49 <Kylie_> Sorry, I don't know details about the VSCode value. But VSCode has some common values.
00:43:01 <nitzmahone> To answer the initial question though: yes, we can backport that, since it's not really a user-visible feature and nothing breaks if it's there or not there.
00:43:15 <Kylie_> Thank you Matt.
00:43:30 <Kylie_> And yes for punch list of 2.5. Here it is.
00:44:10 <Kylie_> New Module
00:44:10 <Kylie_> Azure Container Registry (merged)
00:44:10 <Kylie_> Azure Container Instance (in review)
00:44:10 <Kylie_> Azure Image (merged)-32589
00:44:10 <Kylie_> Azure SQL (in review)
00:44:10 <Kylie_> Azure MySQL (in review)
00:44:10 <Kylie_> Azure PostgreSQL (in review)
00:44:11 <Kylie_> Ian
00:44:11 <Kylie_> Azure Key Vault (in review)
00:44:12 <Kylie_> The team fixed blocking issues to get existing modules as followings work from E2E
00:44:12 <Kylie_> Azure VMSS  (merged)
00:44:13 <Kylie_> Azure Container Service (merged, test case failure)
00:45:08 <yuwei> also the network interface still in review
00:46:32 <nitzmahone> 33366 has been cherry-picked to stable-2.4
00:46:49 <Kylie_> So far I only list items we contributed. I will work with Zim and Yuwei these two days to review all PRs and issues to see what should be added into the list. Then I will send out the list to you and Jordan. Thank you in advance.
00:46:58 <Kylie_> Nice. Thank you Matt.
00:47:13 <Kylie_> When will 2.5 be officially released? March?
00:47:44 <jborean93> That's the ETA
00:47:59 <Kylie_> Got it. Then that's all topics I have.
00:48:01 <Kylie_> Any other topic?
00:48:06 <nitzmahone> Not for me
00:48:08 <jborean93> For the keyvault stuff, there's been no action on https://github.com/ansible/ansible/pull/32756 since the last review 20 days ago
00:48:35 <jborean93> I see it on your action list but not sure if someone is going to follow up on it
00:48:43 <Kylie_> Yes. I asked Ian and will schedule a meeting with him this week or early of next week to see how to move forward.
00:48:59 <Kylie_> Yes, we will take the responsibility.
00:49:09 <jborean93> ok sounds good
00:49:27 <Kylie_> The blocking issue is python one.
00:49:54 <Kylie_> #33897 and #33624. Please help add your comments. Yuwei and Zhijun will look at them today.
00:49:56 <Kylie_> Thank you guys.
00:50:02 <Kylie_> #endmeeting