00:02:31 <jborean93> #startmeeting Ansible Azure Working Group
00:02:31 <zodbot> Meeting started Thu Mar 22 00:02:31 2018 UTC.  The chair is jborean93. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:02:31 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:02:31 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:02:53 <jborean93> hey yuwei when starting a meeting you need to set the meeting name `Ansible Azure Working Group`
00:02:59 <jborean93> #chair yuwei
00:02:59 <zodbot> Current chairs: jborean93 yuwei
00:02:59 <zikalino> i guess not so many people today
00:03:06 <jborean93> #chair zikalino
00:03:06 <zodbot> Current chairs: jborean93 yuwei zikalino
00:03:18 <jborean93> nitzmahone is out today and I believe Kylie said she won't be here
00:03:23 <yuwei> Yes I m looking for the sentence
00:04:17 <zikalino> i think my only topic is prs today.
00:04:40 <jborean93> Yep
00:04:42 <zikalino> i have one urgent pr, as seems like container instance is broken now
00:05:02 <jborean93> I am working through them, currently testing the networkinterface with the vnet being in a different resource group
00:05:15 <jborean93> there is one more networkinterface PR I am aware of and that was the end of the list I had
00:05:48 <zikalino> this one: https://github.com/ansible/ansible/pull/37714
00:06:02 <zikalino> but i think i have to disable tests as they are not stable
00:06:18 <jborean93> I have added myself as a reviewer for that one
00:06:24 <zikalino> anyway, container instance didn't have version limitation <0.4.0
00:06:40 <zikalino> and 0.4.0 seems to be broken
00:06:53 <jborean93> At some point soon we need to look into the unstable tests and get them stable again
00:07:02 <zikalino> so i think we should have fixed version 0.3.1 (or i can change to 0.4.0)
00:07:27 <zikalino> i am actually looking into all unstable / disabled tests this week
00:07:42 <zikalino> so there are 9 right now
00:09:10 <zikalino> i also have two following prs:
00:09:12 <zikalino> https://github.com/ansible/ansible/pull/36826
00:09:43 <zikalino> https://github.com/ansible/ansible/pull/36768
00:10:07 <jborean93> I'm just about to merge 36768, my local tests were successful
00:10:30 <zikalino> and less urgent one:
00:10:32 <zikalino> https://github.com/ansible/ansible/pull/36818
00:10:54 <zikalino> but i need to add some more explanation so i will ping you later about this
00:11:12 <jborean93> ok, for the latter one it would be great if we can get a test for it
00:11:33 <yuwei> Hi Jordan how about this https://github.com/ansible/ansible/pull/36109
00:12:08 <yuwei> I found about 7 same PR sent in the past year
00:13:52 <jborean93> that sounds like a good option, we would need a way to configure what variable to use for `ansible_host` though. Have a look at `ec2.py` and I would try and replicate a similar setup to how they define it in `ec2.ini`
00:14:26 <zikalino> 36818? yes, actually tests are disabled for deployment template, i am changing tests at the moment to use different template, so i will add tests for this one as well.
00:15:50 <jborean93> sounds good
00:16:24 <jborean93> yuwei: if you can find the best implementation of that feature (or do your own) with a way to configure the variable used as the host connection, send it through and we can merge it in
00:17:21 <yuwei> Okay, I will add it to my backlog
00:17:33 <jborean93> thanks
00:17:37 <yuwei> Also I find a PR very out of date, can we close it https://github.com/ansible/ansible/pull/19669
00:18:01 <jborean93> If it is either fixed or superseeded by another PR then yes we can
00:18:06 <jborean93> Are you asking me to close it?
00:18:59 <yuwei> Seems a PR to fix a bug in 2016, but not reproduce in later version
00:19:27 <yuwei> Affect 2.3
00:19:37 <zikalino> so i think it shoudl be closed, but we can't close it, right Yuwei?
00:19:41 <jborean93> ok, will close saying they can re-open and rebase if it is still an issue
00:20:38 <zikalino> i also created following pr, to fix the doc:
00:20:38 <jborean93> closed
00:20:39 <zikalino> https://github.com/ansible/ansible/pull/37626
00:21:11 <zikalino> but seems like there are lot of tests disabled because of this particular problem.
00:21:22 <zikalino> so i was wondering if theres' any reason not to fix it
00:21:37 <jborean93> hmm, shouldn't we just add the default choice to the azure_rm_common arg spec?
00:21:45 <zikalino> or should i just go ahead, enable tests again and merge it?
00:22:13 <jborean93> nitzmahone may be the best to ask on that as he understands Azure stack more than I do
00:23:04 <zikalino> well, what puzzles me is why to keep documentation out of sync? ok, anyway i will bother him
00:23:38 <yuwei> Small pr about inventory https://github.com/ansible/ansible/pull/34980
00:23:40 <jborean93> ¯\_(ツ)_/¯ he usually does things for a reason
00:23:46 <zikalino> ok, and last issue from me, or actually from another developer, i am just helping him to review:
00:23:49 <zikalino> https://github.com/ansible/ansible/pull/37333
00:25:34 <jborean93> the latter may take some more time, I'm mostly focusing on bug fixes and not new modules right now but have added myself as a reviewer
00:26:04 <zikalino> ok, thanks!
00:26:06 <jborean93> the inventory pr seems like a simple fix, will look at it today
00:26:35 <yuwei> hi Jordan, these days I work for AKS module, when I write integration test, since the AKS need a pair of valid Service Principal as parameter, can I get them in integration test?
00:27:12 <jborean93> mattclay is the best person to ask about that
00:27:32 <yuwei> Okay I will bother him
00:27:36 <yuwei> Thanks
00:28:13 <mattclay> yuwei: Are you able to use the service principal used for the rest of the tests, or do you require a dedicated one for AKS?
00:29:18 <yuwei> I want to use the auth one of integration test
00:29:55 <yuwei> Like "{{ Azure_Client_id }}"
00:30:39 <yuwei> But seems when running integration playbook, the azure.py only sends in resource group
00:30:59 <mattclay> yuwei: You can use `{{ lookup('env', 'VAR_NAME') }}` to access env vars, including the service principal details.
00:31:03 <zikalino> yes, i think this would be useful for some other tests too
00:31:21 <zikalino> i was working on authorization module and it will also require such things
00:31:40 <yuwei> Oh yes thank you. I will have a try
00:32:23 <mattclay> yuwei: All the vars I listed here should be available: https://github.com/ansible/ansible/pull/35888#issuecomment-375136747
00:34:22 <yuwei> Thanks I will try
00:35:17 <zikalino> ok, i disabled test in container instance pr, as still unstable, but fix should be merged urgently: https://github.com/ansible/ansible/pull/37714/files
00:35:30 <zikalino> i will try to figure out test failures later today
00:36:02 <zikalino> should be also backported to 2.5
00:39:02 <jborean93> ok, is there anything else we want to discuss?
00:39:20 <yuwei> No from my side
00:40:22 <jborean93> sounds good, I'll close the meeting if that is it
00:40:24 <zikalino> yes, i think that's all from me
00:41:10 <jborean93> sounds good
00:41:12 <jborean93> #endmeeting