00:03:37 <jborean93> #startmeeting Ansible Azure Working Group
00:03:37 <zodbot> Meeting started Thu Jul 26 00:03:37 2018 UTC.
00:03:37 <zodbot> This meeting is logged and archived in a public location.
00:03:37 <zodbot> The chair is jborean93. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:03:37 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:03:37 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:03:40 <zodbot> Kylie_: Error: Can't start another meeting, one is in progress.
00:03:48 <jborean93> #chair Kylie_ yungezz
00:03:48 <zodbot> Current chairs: Kylie_ jborean93 yungezz
00:04:29 <Kylie_> Hi Jordan, will Matt join us?
00:04:30 <yungezz> For keyvault, I still work on how to embed into cloud auth
00:04:34 <yungezz> No
00:04:47 <Kylie_> Ok. Catherine, you could go ahead.
00:04:54 <jborean93> Kylie_: no sorry, he had something come up today
00:04:57 <yungezz> Jordan mentioned Matt has conflict
00:05:29 <yungezz> Jordan, do you know is there POc of cloud auth for testing?
00:05:59 <jborean93> not yet, the dev is planning on starting it this/next week
00:07:27 <yungezz> Ok, is it possible to try it? I have problem on understanding what’s user interface for it, or maybe I can ask in proposal directly
00:07:58 <jborean93> it's yet to be developed so nothing to try out unfortunately
00:08:16 <jborean93> might be better to ask on the proposal to get some more info
00:08:22 <yungezz> Let me ask owner directly
00:08:50 <yungezz> For prs, I have updated web app pr per comments
00:09:02 <yungezz> Pls help to have a look
00:09:04 * jborean93 looks
00:09:43 <yungezz> I think app service plan is simple module
00:10:59 <yungezz> yuwei: do you have any questions on pr?
00:11:13 <yuwei> no
00:11:32 <yungezz> Jordan are you there?
00:11:47 <jborean93> yep, just glancing over the web app one
00:12:00 <jborean93> is Zim on holidays?
00:12:08 <yungezz> Actually I have a question on role maintain best practices
00:12:13 <yungezz> Yes he is
00:12:24 <jborean93> ok, is someone going ot try and resolve the auth source PR?
00:12:36 <yungezz> I will
00:12:39 <jborean93> basically just needs the changelog fragment and we can start merging into devel/2.6
00:12:40 <jborean93> https://github.com/ansible/ansible/pull/40005/files#r204967454
00:12:58 <yungezz> Back port it and add changlog segments
00:13:07 <jborean93> Currently this option takes in a list of dicts
00:13:29 <jborean93> it seems like it is easier to just take in a dict where the key is the `name` and the value is the `value` for each option
00:15:11 <jborean93> for example, this is a lot cleaner than before https://www.irccloud.com/pastebin/oZiJzlfc/
00:15:43 <jborean93> I'm also curious where those settings values come from?
00:15:59 <jborean93> Do they align with any documentation/api that we can link the user to?
00:17:21 <yungezz> Hello
00:17:35 <yungezz> Sorry I dropped off due to network
00:17:49 <jborean93> do you see my previous comments or need me to repost them?
00:17:56 <yungezz> Yes
00:18:15 <yungezz> I can update it to key value directly
00:18:47 <yungezz> Yes there’s supported value list in azure doc
00:19:05 <yungezz> And I have add link in module doc
00:19:10 <jborean93> is it in the snake_case format or camelCase/PascalCase?
00:19:22 <yungezz> Value?
00:19:27 <jborean93> the keys
00:19:38 <jborean93> e.g. how would the user know what keys they can control with `settings`?
00:19:40 <yungezz> Snake case
00:19:58 <jborean93> cool, so the Azure docs explicitly say you specify `java_container`
00:20:03 <jborean93> and gives you valid values?
00:20:35 <yungezz> Azure doc list supported value for java_container
00:21:06 <jborean93> nice, would be good to link that or give some info on how the users can find what settings can actually be defined outside of a hard coded list
00:21:16 <yungezz> Agree
00:21:39 <jborean93> There's still a few comments from the review that haven't been addressed
00:21:57 <yungezz> Let me check them
00:22:04 <jborean93> like the return values, some minor doc questions as well
00:22:35 <yungezz> I have updated return value to return is
00:22:48 <yungezz> I’d
00:22:48 <yungezz> Id
00:23:04 <yungezz> Instead of facts
00:23:32 <yungezz> Will check comments and update pr today
00:23:37 <jborean93> cool, just need to update the docs for that
00:23:44 <jborean93> I see you've done that in the code which is great thanks
00:23:51 <yungezz> I have questions about role
00:24:41 <yungezz> We have role which works with 2.5, as you know, we updated azure sdk version in 2.6
00:25:13 <yungezz> So some module in role will not work on 2.6 anymore
00:25:33 <jborean93> due to bugs or other issues?
00:25:51 <yungezz> But if we update role dependencies same as 2.6, role will not work with 2.5
00:26:08 <yungezz> New feature or behavior change
00:26:11 <jborean93> do you mean Python deps?
00:26:16 <yungezz> Yes
00:26:44 <jborean93> that sounds more like a documentation problem where you document the deps for each version
00:26:59 <yungezz> You mean in role?
00:27:16 <jborean93> depends if the role installs the deps or not?
00:27:33 <yungezz> Yes role need dependencies
00:28:22 <jborean93> yep, but does the role install that for the user or require the user to install them?
00:29:20 <yungezz> Yes role might have new module not up streamed so requires user to install dependencies
00:29:46 <jborean93> oh, so not Python dependencies but Ansible modules in the `library` folder?
00:30:07 <yungezz> And role also have some module already upstreamed but with new features or bug fixing
00:31:07 <yungezz> Role has its own dependencies file, most of dependencies is same as core, but with some difference
00:31:25 <jborean93> we need to define what you mean by dependencies first as it can mean multiple things
00:31:43 <yungezz> Python dependencies
00:31:43 <jborean93> do you mean
00:31:43 <jborean93> 1. Python library dependencies like the azure sdk
00:31:49 <jborean93> 2. Ansible modules
00:31:53 <jborean93> 3. System packages
00:31:54 <yungezz> 1
00:32:46 <jborean93> ok so if it Python libraries, we probably need to look into why different versions are breaking the modules
00:33:07 <jborean93> I know this has been a big conversation for the past few months
00:33:38 <yungezz> Yes
00:33:57 <jborean93> and not really a question around Ansible roles
00:34:04 <yungezz> You’re right, we need identify what’s breaking change there
00:35:23 <yungezz> Suspect due to new features in new version sdk
00:35:55 <jborean93> yea it's a deeper issue that's been troublesome for a while
00:36:29 <jborean93> I can't remember where we ended up but one of the ways we tried to avoid it is to use kwargs instead of relying on positional args
00:36:51 <yungezz> Ok
00:37:16 <jborean93> but that's a tiny piece of the puzzle
00:37:49 <yungezz> Understand
00:38:19 <yungezz> Thanks for the hints
00:38:26 <jborean93> you're welcome
00:38:31 <jborean93> anything else we wanted to talk about?
00:38:38 <yungezz> No for me
00:38:48 <yuwei> me neither
00:39:21 <jborean93> Kylie_ anything from you?
00:40:06 <Kylie_> https://github.com/ansible/ansible/pull/42109
00:40:06 <Kylie_> I saw spmp approved it. Not sure who spmp is. But since he can approve it, it mean it will be merged soon. Right?
00:40:51 <jborean93> he's a community member, but has the `Contributor` label so it should
00:41:03 <yungezz> We reviewed this pr yuwei and myself
00:41:06 <jborean93> probably just depends on whether he's part of the azure_ namespace
00:41:34 <yungezz> Since it’s adding new argument like new feature I didn’t merge it
00:41:38 <jborean93> seems innocent enough, if you think it's good, feel free to merge
00:41:57 <yungezz> Ok thanks
00:41:57 <Kylie_> Good to know. Thank you Jordan.
00:42:31 <Kylie_> No more from us. Yuwei and Catherine, I saw Jordan added comments for Web App and routetable, App Gateway, please help follow up. THank you.
00:42:43 <yungezz> Sure
00:42:43 <jborean93> cool, closing the meeting for today
00:42:45 <jborean93> thanks everyone
00:42:50 <yungezz> Thanks all
00:42:52 <jborean93> #endmeeting