00:07:25 <jborean93> #startmeeting Ansible Azure Working Group
00:07:25 <zodbot> Meeting started Thu Sep  6 00:07:25 2018 UTC.
00:07:25 <zodbot> This meeting is logged and archived in a public location.
00:07:25 <zodbot> The chair is jborean93. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:07:25 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:07:25 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:07:32 <nitzmahone> o/
00:07:40 <yungezz> Hello Matt
00:07:42 <jborean93> yungezz: you need to set the topic as `Ansible Azure Working Group` whens tarting a meeting
00:07:51 <zikalino82> ok, so first topic, the doc: https://github.com/ansible/ansible/pull/45141
00:07:53 <jborean93> #chair nitzmahone zikalino82 yungezz
00:07:53 <zodbot> Current chairs: jborean93 nitzmahone yungezz zikalino82
00:07:58 <yungezz> Got it thanks for reminder
00:08:22 <jborean93> no worries
00:08:41 <yungezz> The guideline is summary of our previous discussion and learning from code review
00:09:34 <zikalino82> we noticed that aws and some other guys have guide md file just in their modules subdirectory, is it ok to create it there?
00:10:22 <nitzmahone> Probably better in docs or wiki IMO
00:11:04 <zikalino82> yes, i was thinking we could use the same version into docs as well
00:11:06 <jborean93> is this for modules/roles not in Ansible?
00:11:20 <yungezz> Facts module
00:11:28 <yungezz> For facts module
00:11:40 <zikalino82> well, right now facts modules, but i am also adding stuff for other modules
00:12:10 <zikalino82> so that will be a general guideline for all azure modules
00:13:17 <jborean93> having a markdown isn't really mark of Ansible right now so either documenting it in the module docs section or in the Ansible RST docs is probably recommended
00:13:45 <nitzmahone> Wiki's probably a better place for now
00:14:10 <jborean93> oh sorry, only just saw the PR
00:14:20 <yungezz> Ok, do we have permission to edit wiki?
00:14:23 <jborean93> yea a wiki is good for that
00:14:28 <nitzmahone> Just seems like putting dev docs inline next to modules is strange
00:14:37 <nitzmahone> (just because AWS did it years ago...)
00:14:50 <nitzmahone> Community wiki for this WG
00:14:57 <nitzmahone> Several of you should
00:15:03 <zikalino82> ok, so i will close the pr, and move to community wiki for now
00:15:19 <yungezz> Thanks
00:15:19 <nitzmahone> https://github.com/ansible/community/wiki/Azure
00:15:43 <nitzmahone> (maybe public edits allowed? can't remember offhand)
00:16:01 <yungezz> We will try it firstly
00:16:23 <yungezz> If not working, then ask for help
00:16:51 <zikalino82> well, i can edit, just checked
00:17:13 <yungezz> Nice
00:17:32 <zikalino82> ok, i will move everything there.....
00:17:52 <zikalino82> then anyone can fix/add whatever necessary
00:18:34 <yungezz> Great, open source :).   Then second topic, from Kylie, she not able to join today due to meeting conflicts
00:19:37 <yungezz> Google recently checked in lots of modules, which are auto generated, what’s your opinion on it?
00:19:50 <nitzmahone> We're not generally fans of that approach
00:19:56 <zikalino82> we know :-)
00:20:00 <nitzmahone> It was very contentious whether we'd even allow it
00:20:28 <yungezz> Yes we discussed this before and understand your concerns
00:20:35 <nitzmahone> I don't recall how we arrived at "yes", was mostly community folks I think that negotiated that
00:21:45 <yungezz> Got it
00:21:47 <zikalino82> i think right now i a more in a favour of providing some tools to accelerate module development
00:22:31 <yungezz> For inner loop
00:23:45 <zikalino82> ok, so i have one more topic, a few prs
00:24:01 <zikalino82> first one: https://github.com/ansible/ansible/pull/45126
00:24:13 <zikalino82> adding os_disk_name to vm
00:24:42 <zikalino82> we had an issue reported, and now we are not sure whether this should be added or not
00:25:07 <nitzmahone> I really hate adding a lot of customization to the "auto" resources
00:25:15 <nitzmahone> If you want custom, use discrete modules
00:25:25 <nitzmahone> That'
00:25:33 <nitzmahone> At a glance that's what this is doing, right?
00:25:42 <jborean93> but is this for OS customisation in the VM and not the name of an Azure resource?
00:26:27 <yungezz> There’s module azure_rm_image
00:26:28 <nitzmahone> Oh wait, is this to attach an existing disk?
00:27:38 <zikalino82> original issue submitter wanted names bot for os disk and data disks, but data disks is easy, os disk more difficult, here's his comment
00:27:49 <zikalino82> "The datadisks are indeed not really the issue, because as you've said, I can name them with azure_rm_managed_disk. The problem lies within the OS disk; this should also have an option to name it. In the meantime I've added the options myself in azure_rm_virtualmachine to name the OS disks and Data disks. What is the best approach to do the pull re
00:27:50 <zikalino82> quest for this? First time for me. Shall I do a pull request to the Azure preview repository or to this one?"
00:28:47 <nitzmahone> What does the API do if you change that on an existing VM? Does it try to reattach the OS disk, or rename the underlying managed disk?
00:29:08 <zikalino82> i have to check this
00:29:34 <nitzmahone> That'd be kind of important to know before we add such a feature ;)
00:30:14 <nitzmahone> But in the managed disk case, I guess it makes sense for initial creation
00:30:15 <zikalino82> ok, i will check this, and also check how difficult it's to do any workaround
00:31:13 <nitzmahone> So yeah, we'd need to know what the change behavior actually is- the test that was added for this is a good example case of a test that doesn't really check what we want
00:31:53 <nitzmahone> (eg module reported "changed", but what actually happened?)
00:31:59 <zikalino82> ok, so let's pospone this....
00:32:13 <zikalino82> i have two more small prs, just adding firewall rules to mysql and postgresql
00:32:14 <zikalino82> https://github.com/ansible/ansible/pull/45077
00:32:47 <zikalino82> https://github.com/ansible/ansible/pull/45074
00:33:01 <zikalino82> pls check when you have time
00:33:22 <nitzmahone> At a glance, module UI looks fine on those to me
00:34:03 <nitzmahone> and thanks for combining tests to the main DB ones so we don't incur more instance creation time penalty ;)
00:34:22 <zikalino82> i have combined a few more too :-)
00:34:28 <nitzmahone> excellent
00:34:44 <nitzmahone> mattclay is losing hair trying to fix timeouts :)
00:34:59 <zikalino82> hehe, i can imagine :-)
00:35:37 <nitzmahone> Anything else for today?
00:35:58 <yungezz> No from my side
00:36:02 <jborean93> I'm good
00:36:07 <zikalino82> me too
00:36:12 * nitzmahone is flying to Taiwan tomorrow, will wave on the way over ;)
00:36:36 <zikalino82> have a good trip :-)
00:36:39 <yungezz> Thanks
00:36:51 <yungezz> Hope someday you could visit Shanghai
00:37:22 <nitzmahone> Tis definitely on my list :)
00:37:59 <nitzmahone> My China experience so far is limited only to Guangzhou airport :)
00:38:28 <yungezz> :)
00:39:07 <nitzmahone> OK, until next week! I may or may not be there with meetings in Taiwan
00:39:12 <nitzmahone> #endmeeting