00:00:23 <nitzmahone> #startmeeting Ansible Azure Working Group
00:00:23 <zodbot> Meeting started Thu Feb  7 00:00:23 2019 UTC.
00:00:23 <zodbot> This meeting is logged and archived in a public location.
00:00:23 <zodbot> The chair is nitzmahone. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:00:23 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:00:23 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:00:37 <jborean93> hey
00:00:39 <nitzmahone> #chair zikalino82 jborean93
00:00:39 <zodbot> Current chairs: jborean93 nitzmahone zikalino82
00:00:42 <nitzmahone> howdy
00:01:11 <zikalino82> great! i thought nobody would be here. everybody in china on holidays :-)
00:01:52 <nitzmahone> We'll usually at least see if anyone's around rather than just canceling the meeting
00:02:50 <zikalino82> yeah, i am on holidays too.... but a bit bored and have a couple of prs
00:02:55 <nitzmahone> Saw your note about a few of the updates
00:03:08 <zikalino82> and one from our contributor: https://github.com/ansible/ansible/pull/42400
00:03:35 <zikalino82> this one we discussed before, nitzmahone did you have a chance to think about these windows features?
00:03:59 <nitzmahone> Someone on the MS side was supposed to be asking around about those being the "right" way to do things vs using extensions
00:04:05 <jborean93> I think the winrm stuff was waiting on clarification on what's the proper way forward
00:04:10 <jborean93> yea
00:04:41 <zikalino82> oh, so i think @yungezz
00:05:28 <nitzmahone> Yeah, if we can get a "ruling" on that (the docs are unclear to me), might be a few naming-related changes, but don't want to ask for those unless we're going to move forward with it
00:06:23 <zikalino82> hehe, hopefully contributor won't get angry again ;-)
00:06:26 <nitzmahone> the cosmosdb account changes look ok
00:06:34 <zikalino82> ok, i have a few modules....
00:06:47 <zikalino82> first of all, i fixed your comments cosmos db in https://github.com/ansible/ansible/pull/47181
00:07:04 <zikalino82> oh, ok... that's merged, thanks! :-)
00:07:14 <nitzmahone> Yeah, just hit merge on that one. Bummer about the idempotent delete, but maybe the REST API will get better over time
00:08:05 <zikalino82> then that vmss instance module, has one property right now, so it's really simple. i want to add stuff to this one very carefully, but there will be more in the future
00:08:32 <nitzmahone> your copypasta is showing ("Assert the state of the SQL Server" again ;) )
00:08:56 <zikalino82> oh, in the test of vmss :-(
00:09:07 <nitzmahone> module docs too
00:09:24 <nitzmahone> https://github.com/ansible/ansible/pull/51461/files#diff-07cf5c59dc7d08c97f4460ce6e654abaR51
00:10:15 <zikalino82> ouch... can't see these things any more :-(
00:10:42 <zikalino82> and then i have devtest labs modules to complete the scenario: https://github.com/ansible/ansible/pull/51462
00:10:43 <nitzmahone> is "apply latest model" a concept name from the docs somewhere?
00:12:21 <nitzmahone> jborean93: what do you think, does "azure_rm_devtestlabartifactsource"  go too far with the "no underscores" thing?
00:12:39 <jborean93> it's definitely out there
00:12:57 <jborean93> I would say add `azure_rm_devtestlab_artifactsource` but not sure if we already have some devtestlab modules
00:13:02 <nitzmahone> I guess we've already set the precedence, so 🤷
00:13:12 <jborean93> I'm wondering whether we should start looking at removing the `_rm_`
00:13:39 <nitzmahone> we do, but just one from 2.8 that hasn't shipped yet, so we *could* I guess, but ...
00:13:57 <nitzmahone> well, azure_rm_devtestlab and azure_rm_devtestlabvirtualnetwork
00:14:34 <nitzmahone> *sigh* it's tough to be consistent on this stuff without turning into a_ridiculous_pile_of_snake_case
00:14:44 <zikalino82> yeah, we still have some modules with underscores
00:15:03 <jborean93> we can always make an alias and deprecate the old name sometime in the future but best to get it right now
00:15:17 <nitzmahone> Yeah... I'm leaning toward leaving as-is for now
00:15:32 <jborean93> fine with me, we always have options in the future
00:17:31 <zikalino82> i think there should be some way of aliasing module names
00:17:32 <nitzmahone> zikalino82: does devtestlab also suffer from the "async delete" problem?
00:17:46 <nitzmahone> We have a couple ways to do it already, but it's not ideal (for several reasons)
00:17:53 <zikalino82> no, it has some other problems
00:18:15 <nitzmahone> (just looking at all the commented out tests)
00:18:26 <zikalino82> but more related to tests.... it locks some subresources, but mattclay already did some changes in the ci to handle that
00:18:53 <jborean93> yea we fixed the backend to fix that issue last week
00:19:09 * jborean93 had about 200 resource groups built up by that point
00:19:32 <nitzmahone> OK, I'll give those both a quick once-over, but generally looks ok
00:19:49 <nitzmahone> zikalino82: anything else, or you gonna get back to your time off? ;)
00:20:05 <zikalino82> i think i just commented out github related test, as we don't want to have github token stored anywhere
00:20:36 <nitzmahone> ah yeah, that could be a little tricky to do securely (and I suspect GH would not appreciate our CI making throwaway accounts ;) )
00:21:22 <zikalino82> yes, so i guess it's better to disable...
00:21:25 <nitzmahone> hrm, we could probably have a static value though- just wouldn't be able to test re-fetch
00:21:48 <nitzmahone> (ie, so long as the test is read-only)
00:21:54 <zikalino82> i couldn't find that "Assert the state of the SQL Server" in vmss (fixed the doc already)
00:22:07 <nitzmahone> yeah, it was just the one this time
00:23:32 <nitzmahone> OK, anything else I should wait for on those before review?
00:24:30 <zikalino82> i think that's all pr's i have right now, i have couple more small fixes, but can wait for Catherine, she will be back on monday
00:25:14 <zikalino82> i think we should leave this github token test disabled for now....
00:25:15 <nitzmahone> OK- I'll drop a comment on the winrm VM change PR reminding her that she was going to look
00:26:34 <zikalino82> vmss doc is fixed now, just ci running
00:27:04 <nitzmahone> cool
00:27:14 <nitzmahone> OK, done for today then?
00:27:21 <zikalino82> yes, i think so :-)
00:27:36 <jborean93> I'm good, unfortunately no holiday to get back to :(
00:27:51 <nitzmahone> Cool- enjoy the rest of your time off! Everyone's back for next week, right?
00:28:02 <zikalino82> yes :-)
00:28:13 <zikalino82> thanks a lot guys! :-)
00:29:00 <nitzmahone> Til next week!
00:29:02 <nitzmahone> #endmeeting