00:00:45 <nitzmahone> #startmeeting Ansible Azure Working Group
00:00:45 <zodbot> Meeting started Thu Feb 28 00:00:45 2019 UTC.
00:00:45 <zodbot> This meeting is logged and archived in a public location.
00:00:45 <zodbot> The chair is nitzmahone. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:00:45 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:00:45 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:01:17 <nitzmahone> #chair yungezz jborean93 zikalino8265
00:01:17 <zodbot> Current chairs: jborean93 nitzmahone yungezz zikalino8265
00:02:30 <nitzmahone> Howdy all; what's up for today?
00:02:35 <yungezz> I don’t have special topic today except for prs. And thanks Matt for reviewing role definition Pr
00:02:49 <nitzmahone> We might want to discuss the servicebus PR
00:03:01 <yungezz> https://github.com/ansible/ansible/pull/53046
00:03:05 <yungezz> Ok
00:05:34 <nitzmahone> Looks like on 53046 it's assuming a single NIC
00:06:24 <yungezz> But filter by primary
00:07:46 <nitzmahone> I'll have to play with that one a little more to see if it does everything- thanks for tackling that one
00:08:17 <yungezz> Thanks
00:08:32 <nitzmahone> I see yuwei has joined
00:08:35 <yungezz> And I will add security group in another Pr
00:08:37 <yuwei> yes
00:09:06 <nitzmahone> If you saw my review for the servicebus stuff, but I agree with Zim that there's an awful lot going on there for one module
00:10:25 <yuwei> My considering is that I find most of the parameters for topic subscription are the same
00:11:22 <nitzmahone> Yeah, but it's managing things at four distinct layers, and it has a resource sub-list (sas_policies)
00:11:29 <zikalino8265> i think it's ok to have duplicates
00:12:11 <zikalino8265> if we have one module, it will become really tough to write proper documentation, which field is returned, when returned, and describe dependencies, etc.
00:12:36 <nitzmahone> Each of those things should generally be a red flag for "this should have its own module", and it basically has five of those red flags ;)
00:13:27 <nitzmahone> Small and simple modules are usually preferable to "big and hairy" modules, unless the underlying API doesn't have the resources properly split out (but this one does)
00:13:48 <yuwei> OK I will split them
00:14:22 <nitzmahone> I'm much more OK with just a single facts/info module returning everything though- not sure how others feel
00:15:16 <yuwei> they will be changed to service is
00:15:32 <nitzmahone> ?
00:15:33 <zikalino8265> to service is?
00:15:58 <yuwei> ServiceBus(namespace/queue/topic/subscription)
00:17:25 <yuwei> Changed to Servicebus(...  // sorry for the wrong sending
00:17:42 <zikalino8265> @yuwei do you mean facts?
00:17:45 <nitzmahone> sas_policies should *probably* be its own thing as well (just manages a single entry)
00:18:34 <nitzmahone> That one's more arguable, but the need to return keys/regen keys makes it more complex for list management on the parent resource
00:19:28 <yuwei> I see
00:20:02 <yuwei> @zim resource module
00:20:26 <nitzmahone> Cool, thanks for the discussion on that...
00:20:59 <nitzmahone> I'll put 53046 on my review queue- anything else exciting for today?
00:21:08 <nitzmahone> #action nitzmahone to review 53046
00:21:24 <yuwei> No from me
00:21:38 <zikalino8265> i will have additional modules for devtest labs
00:22:13 <zikalino8265> just created pr, so pls add it to your review queue :-)  https://github.com/ansible/ansible/pull/53091
00:22:46 <nitzmahone> #action nitzmahone to review https://github.com/ansible/ansible/pull/53091
00:23:17 <zikalino8265> thanks! :-)
00:23:24 <yuwei> Well these days I am wondering if there is a way to auto install right SDK when user install our module role
00:23:53 <yuwei> Is this doable?
00:23:58 <nitzmahone> auto-installing Python deps is a maze of nightmare
00:24:55 <nitzmahone> You could try to do something like a separate role entry point for SDK install that would sample the Ansible version, then go download the right requirements file from github and ship it to the pip module, but there are still numerous cases where that could fail...
00:26:03 <yuwei> I see, thanks for explaining
00:26:47 <nitzmahone> The new `collections` support should be landing in devel for 2.8 within the next week or so; I'm going to try repackaging the entire Azure subsystem in the test bits this week to make sure it does everything it needs to...
00:27:10 <yungezz> Have to drop off for another meeting. Thanks all for the Pr discussion!
00:27:39 <nitzmahone> (once that's out there, you can replace the preview role with a collection and it won't need to rely on anything shipped in the Ansible box)
00:28:16 <nitzmahone> I'll push the packaged thing up to github when I get it working so you can see what it will look like
00:28:26 <nitzmahone> (and some sample content so you can see how to use it)
00:29:01 <nitzmahone> Nothing else from me this week- anyone else?
00:30:10 <nitzmahone> Assuming not, ending in 5...
00:30:13 <nitzmahone> 4..
00:30:17 <nitzmahone> 3..
00:30:20 <nitzmahone> 2..
00:30:22 <nitzmahone> 1..
00:30:28 <nitzmahone> Thanks all- til next week!
00:30:31 <nitzmahone> #endmeeting