00:00:08 <nitzmahone> #startmeeting Ansible Azure Working Group
00:00:08 <zodbot> Meeting started Thu May 16 00:00:08 2019 UTC.
00:00:08 <zodbot> This meeting is logged and archived in a public location.
00:00:08 <zodbot> The chair is nitzmahone. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:00:08 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:00:08 <zodbot> The meeting name has been set to 'ansible_azure_working_group'
00:00:17 <zikalino826544> hello everyone :-)
00:00:19 <MyronFanQiu> Hello
00:00:20 <nitzmahone> Hey all
00:00:56 <jborean93> hey
00:01:18 <yungezz> Hello Matt and Jordan, how’s the summit?
00:01:24 <nitzmahone> #chair jborean93 zikalino826544 MyronFanQiu yungezz yuwei
00:01:24 <zodbot> Current chairs: MyronFanQiu jborean93 nitzmahone yungezz yuwei zikalino826544
00:01:32 <nitzmahone> It was good, but happy to be home
00:01:38 <yungezz> :)
00:01:41 <yuwei> hhh
00:01:43 <zikalino826544> not yet, haha
00:01:52 <nitzmahone> Oh, Zim's still in Redmond?
00:02:03 <zikalino826544> yes, leaving tomorrow
00:02:05 <jborean93> yea, was a long flight back but was nice to get over there and see people face to face
00:02:19 * nitzmahone waves 180mi north
00:02:36 <zikalino826544> yes :-)
00:02:50 * jborean93 calculates the distance between Redmond and Brisbane
00:03:34 <zikalino826544> a bit closer than boston
00:03:53 <jborean93> true :)
00:04:25 <yungezz> Looking forward to the summit summary!
00:04:38 <nitzmahone> So what's up for discussion today?
00:04:38 <yungezz> I have 2 topics today
00:04:45 <nitzmahone> Fire away!
00:04:52 <yungezz> First thanks for reviewing Pr
00:05:07 <yungezz> We have another one on lock management
00:05:42 <yungezz> https://github.com/ansible/ansible/pull/55700
00:05:52 <zikalino826544> (regarding firewall, i am just rerunning the pr, fixed comments)
00:06:04 <nitzmahone> Yeah, saw 55700 go by, will add to review queue
00:06:35 <yungezz> And policy definition https://github.com/ansible/ansible/pull/55749
00:06:48 <nitzmahone> got it
00:07:29 <yungezz> Another topic about _facts to _info since we’re adding new facts module continuously
00:07:51 <nitzmahone> Yeah, everything in-flight should be changed to _info
00:08:17 <yungezz> Parts of azure facts module do return ansible_facts
00:08:21 <zikalino826544> and we can schedule rename of old ones for later i think
00:08:39 <yungezz> For those legacy ones, can they renamed also
00:08:51 <nitzmahone> I think return value deprecation will make it in for 2.9, so we should be able to actually show deprecation warnings on the facts
00:09:00 <nitzmahone> (when they're used by someone in a play/template/etc)
00:09:03 <zikalino826544> so old version will stay as obsolete _facts
00:09:21 <zikalino826544> and we should remove ansible_facts from new _info versions
00:09:41 <yungezz> Can they been renamed? It’s confusing to have both facts and info
00:09:53 <nitzmahone> Yeah, we have lots of time to deal with that one and figure out the best way- rename + symlink is "easiest", but complicates fix backports (although _facts modules don't usually see a lot of bugfixes either)
00:10:11 <jborean93> they shouldn't be renamed if they still return ansible_facts. But they shouldn't be returning ansible_facts anyway
00:10:29 <jborean93> that would be a good candidate of creating an _info module and deprecating the _facts one altogether
00:10:45 <yungezz> So link works , both facts and info works
00:10:48 <nitzmahone> Yeah, for the ones that still return facts, we can deprecate that and add a mirrored (or curated in some cases) non-facts return
00:11:14 <nitzmahone> Yeah, and just preface the symlink with _ so the module shows as deprecated when used
00:11:16 <yungezz> Yes we already follow that practice
00:11:55 <yungezz> Btw, any news on 2.9 planning
00:12:06 <nitzmahone> Yeah, jborean93 makes a good point for the ones that actually return facts- if we just clone the module and fix the return value, we don't even have to deprecate the facts return value, just the entire module :)
00:12:32 <nitzmahone> Still in progress, talking about probably Sept/Oct release
00:12:44 <yungezz> You mean create a new info module?
00:12:49 <nitzmahone> yes
00:12:53 <zikalino826544> yes, so in this case, and i think there are not so many, we can't use link
00:13:39 <jborean93> so _facts modules that return ansible_facts == deprecate module and create new _info module
00:13:51 <zikalino826544> yes
00:13:56 <nitzmahone> Works for me
00:13:58 <jborean93> _facts module that do not return ansible_facts == symlink and deprecate to _info module
00:14:30 <yungezz> Ok
00:15:30 <nitzmahone> What else for today?
00:15:46 <yuwei> BTW, for the info module, query by resource id should be added. I always have no idea if I get an id from some where in playbook
00:15:48 <yungezz> I m fine, yuwei zikalino826544 ?
00:16:07 <zikalino826544> yes, i think that's great idea
00:16:10 <nitzmahone> yuwei: agreed- we should support that everywhere possible
00:16:15 <yuwei> Or a generic info module to do
00:16:26 <nitzmahone> That would also be a neat idea
00:16:34 <zikalino826544> we have azure_rm_resource_info :-)
00:16:59 <nitzmahone> (technically a resource lookup would be better, but we still haven't prioritized the credentials-as-inventory-hosts thing that makes that sane)
00:17:39 <nitzmahone> OK, well, if nothing else today, we can close out early...
00:17:56 <yungezz> Thanks all!
00:18:06 <nitzmahone> 'til next week!
00:18:13 <nitzmahone> #endmeeting