=============================================== #ansible-community: Ansible Community PR Review =============================================== Meeting started by gundalow at 09:01:34 UTC. The full logs are available at https://meetbot.fedoraproject.org/ansible-community/2018-12-19/ansible_community_pr_review.2018-12-19-09.01.log.html . Meeting summary --------------- * For the general community PR review days we will be ignoring anything that has a Working Group (https://docs.ansible.com/ansible/devel/community/communication.html#working-groups) as through 2019 we will have dedicated Working Group review sessions (gundalow, 09:06:20) * This is all very informal. Please do ask questions, if you are confused by something, chances are others are. We will go through PR by PR and we will use the MeetingBot to track what needs merging. This allows other people to add comments through the day (gundalow, 09:08:20) * Thank you all that are here, for our second big PR review days. Today we will be focusing on `bugfix` PRs. (gundalow, 09:09:02) * pr:bug `is:pr is:open -label:backport -label:support:core -label:support:curated -label:networking -label:new_module -label:aws -label:azure -label:docker -label:linode -label:vmware -label:windows label:bug -label:aws -label:azure -label:docker -label:linode -label:networking -label:vmware -label:windows` (gundalow, 09:09:53) * Starting with https://github.com/ansible/ansible/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+-label%3Abackport++-label%3Asupport%3Acore+-label%3Asupport%3Acurated+-label%3Anetworking+-label%3Anew_module+-label%3Aaws+-label%3Aazure+-label%3Adocker+-label%3Alinode+-label%3Avmware++-label%3Awindows++label%3Abug+-label%3Aaws+-label%3Aazure+-label%3Adocker+-label%3Alinode+-label%3Anetworking+-label%3Avmware+-label%3Awindows (gundalow, 09:10:08) * LINK: https://github.com/ansible/ansible/pull/50134 (gundalow, 09:11:40) * Use GitHub to provide feedback so it's tracked. IRC is for general discussion (gundalow, 09:16:46) * ACTION: merge and backport 50134 (gundalow, 09:20:56) * Giving details of what you've tested, or what type of review comments you've given allow an informed decision to be made (gundalow, 09:32:44) * ACTION: gundalow 50103 update BOTMETA for inventory (gundalow, 09:38:49) * ACTION: merge 50103, request backport (gundalow, 09:41:59) * ACTION: 50076 merge once it's got a changelog (gundalow, 09:45:03) * Being mindful of user experience (backwards compatibility) is an import thing in reviews (gundalow, 09:55:18) * ACTION: 50025 merge + backport once changelog added (gundalow, 10:03:24) * ACTION: merge 49952, ask for backport inc changelog (gundalow, 10:15:02) * ACTION: gundalow inventory scripts (and plugins) are not getting labels, or pinging authors (gundalow, 10:23:51) * ACTION: 49884 merge once it's got a changelog (and possibly backport) (gundalow, 10:28:42) * LINK: https://xkcd.com/1296/ (gundalow, 10:38:25) * https://github.com/theforeman/foreman-ansible-modules (akasurde, 10:43:24) * ACTION: 49731 need to look code as whole and then merge (akasurde, 10:53:28) * ACTION: 49723 requested for unit test, code LGTM (akasurde, 10:58:02) * ACTION: 49705 added a note for updating documentation fragement (akasurde, 11:08:26) * ACTION: 49665 added comments for PR author to address (akasurde, 11:22:05) * MySQL needs some maintianers (gundalow, 12:00:02) * ACTION: review and maybe merge 48597 (gundalow, 13:18:20) * ACTION: gundalow remove afternburn https://github.com/ansible/ansible/pull/48558#issuecomment-446642255 (gundalow, 13:24:51) * ACTION: merge 50134 (gundalow, 13:36:34) * ACTION: merge 48168 (gundalow, 14:06:04) * LINK: https://github.com/ansible/ansible/blob/013f69477a37a2b353a4680deaa118fa8ecd3d35/lib/ansible/modules/cloud/misc/proxmox_kvm.py#L575 (bob_cheesey, 14:12:16) * ACTION: merge 48558 (gundalow, 14:42:40) * Docs PRs (gundalow, 16:18:37) * LINK: https://github.com/ansible/ansible/pull/45396 (acozine, 17:03:55) * Thanks everybody! (gundalow, 18:55:32) Meeting ended at 18:55:34 UTC. Action Items ------------ * merge and backport 50134 * gundalow 50103 update BOTMETA for inventory * merge 50103, request backport * 50076 merge once it's got a changelog * 50025 merge + backport once changelog added * merge 49952, ask for backport inc changelog * gundalow inventory scripts (and plugins) are not getting labels, or pinging authors * 49884 merge once it's got a changelog (and possibly backport) * 49731 need to look code as whole and then merge * 49723 requested for unit test, code LGTM * 49705 added a note for updating documentation fragement * 49665 added comments for PR author to address * review and maybe merge 48597 * gundalow remove afternburn https://github.com/ansible/ansible/pull/48558#issuecomment-446642255 * merge 50134 * merge 48168 * merge 48558 Action Items, by person ----------------------- * gundalow * gundalow 50103 update BOTMETA for inventory * gundalow inventory scripts (and plugins) are not getting labels, or pinging authors * gundalow remove afternburn https://github.com/ansible/ansible/pull/48558#issuecomment-446642255 * **UNASSIGNED** * merge and backport 50134 * merge 50103, request backport * 50076 merge once it's got a changelog * 50025 merge + backport once changelog added * merge 49952, ask for backport inc changelog * 49884 merge once it's got a changelog (and possibly backport) * 49731 need to look code as whole and then merge * 49723 requested for unit test, code LGTM * 49705 added a note for updating documentation fragement * 49665 added comments for PR author to address * review and maybe merge 48597 * merge 50134 * merge 48168 * merge 48558 People Present (lines said) --------------------------- * gundalow (210) * akasurde (47) * bob_cheesey (31) * winem_ (29) * acozine (28) * felixfontein (25) * bcoca (25) * zodbot (17) * shaps (16) * resmo (10) * rbarlik (6) * fridim (5) * navalkp (4) * jhawkesworth_ (3) * davegarath (3) * terbolous (2) * robertgwilliam (2) * jtanner (2) * michaelkaye (1) * bartmon (1) * xenlo (0) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot