12:04:41 <gundalow> #startmeeting Ansible Hackathon and Open Office Hours
12:04:41 <zodbot> Meeting started Wed Mar 10 12:04:41 2021 UTC.
12:04:41 <zodbot> This meeting is logged and archived in a public location.
12:04:41 <zodbot> The chair is gundalow. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:04:41 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
12:04:41 <zodbot> The meeting name has been set to 'ansible_hackathon_and_open_office_hours'
12:05:17 <gundalow> #chair abadger1999 andersson007_ cybette dericcrago dmsimard gwmngilfen ompragash felixfontein aminvakil Tas-sos
12:05:17 <zodbot> Current chairs: Tas-sos abadger1999 aminvakil andersson007_ cybette dericcrago dmsimard felixfontein gundalow gwmngilfen ompragash
12:05:20 <gundalow> Hi all
12:05:27 <cybette> o/
12:05:44 <gundalow> So we don't have a formal agenda or anything for today, though there are lots of us around to help with anything
12:06:24 <gundalow> I know yesterday we cover a lot. There is a work in progress summary in https://hackmd.io/uZDSLOOdS1Kx0xfZVIATmQ (Feel free to add things)
12:06:51 <andersson007_> gundalow afternoon, thanks for mentioning! I’ll join a bit later after lunch
12:07:16 <gundalow> So any thoughts, questions concerns on *anything* we covered yesterday, or generally related to contributing to Collections, ansible. Development, meetups, etc
12:07:16 <gundalow> Basically anything related to the wider Ansible Community are welcome
12:07:22 <tadeboro> If there is no agenda, maybe I can kindly ask a few of you what you think about the https://github.com/ansible-community/ansible-lint/pull/1447 ?
12:07:23 <github-linkbot> https://github.com/ansible-community/ansible-lint/pull/1447 | open, created 2021-03-08T21:13:27Z by tadeboro: Undeprecate numeric rule tags [bug]
12:07:30 <gundalow> If anyone has any PRs they are working on and would like reviews please share them
12:07:34 <gundalow> tadeboro: excelleng
12:07:38 <andersson007_> gundalow afternoon, thanks for mentioning! I’ll join a bit later after lunch
12:07:44 <gundalow> andersson007_: cool
12:07:59 <cybette> I'll be "hacking" on getting videos and slides together
12:08:26 <tadeboro> I will be here, but might be distracted from time to time because I have a demo in a few hours.
12:08:41 <gundalow> tadeboro: Good luck :)
12:09:32 <basti[m]> hi! I'm rndmh3ro on github and like to passively "listen" here if that's okay :)
12:10:21 <tadeboro> cybette: During my $job time, I often "hack" around Word documents. And no matter how muh I hate it, it is hard to deny the effect those things have is often one magnitude bigger compared to some technical implementation.
12:10:54 <tadeboro> So go, cybette, go! We need those videos for posterity ;)
12:11:00 <cybette> tadeboro: truth.
12:11:02 <cybette> lol thanks
12:11:11 <cybette> basti: welcome! that's definitely ok!
12:15:41 <felixfontein> I'm only partially around
12:30:22 <zbr> hi o/
12:31:27 <zbr> regarding the PR opened by tadeboro i have some mixed feelings, mainly because "galaxy"
12:32:06 <tadeboro> This is why I am asking about it here. Maybe we can decide together what is the best way forward.
12:32:35 <zbr> tadeboro: sure, and I do appreciate that.
12:33:02 <zbr> my hope is that we can convince someone from galaxy to join our brainstorming
12:33:38 <zbr> merging you change is easy but will prevent anyone from adopting newer tags as they will not know about them.
12:33:38 <tadeboro> Maybe we can even get some response from galaxy comrades ;)
12:33:58 <zbr> we could add an option to disable deprecation warnings
12:34:27 * zbr think I could also try praying....
12:34:59 <felixfontein> zbr: I think the best approach is to delay the deprecation until later this year, to give everyone (including galaxy) time to upgrade to the current major version
12:35:36 <felixfontein> this will obviously slow down adoption, but it will improve user experience a lot
12:35:51 <felixfontein> even if galaxy upgrades ansible-lint now, I think delaying the deprecation is probably better
12:35:56 <zbr> felixfontein: If I would know that this will happen this year, I would agree.
12:36:28 <zbr> but the real status of current galaxy server is unknown, w/o any plans for this year.
12:36:40 <zbr> i cannot rely on that
12:36:48 <felixfontein> awcrosby: can you tell us when ansible-lint on galaxy will be upgraded?
12:37:54 <zbr> i should mention that I am more than happy to help addressing  problems that could prevent that, including improving the testing pipelines for the linter.
12:38:38 <zbr> but at this moment I am not aware of any ticket marked as blocker for upgrading linter on galaxy.
12:39:38 <felixfontein> in any case, galaxy-importer is already using ansible-lint 5
12:39:48 <felixfontein> (https://github.com/ansible/galaxy-importer/commit/ff20cf955a713bb94a972c331ed0f19c84601822)
12:40:02 <zbr> so the problem is only on uploading roles?
12:40:20 <felixfontein> (though it hasn't been released again since that commit)
12:42:16 <zbr> that importer is for the ng, so it does not matter.
12:45:29 <felixfontein> I don't think so: https://github.com/ansible/galaxy/blob/devel/requirements/requirements.txt#L134
12:47:44 <tadeboro> galaxy.ansible.com uses quite an  old version of importer iirc.
12:48:00 <felixfontein> I guess that can still be updated?
12:48:27 <felixfontein> in any case, keeping the deprecation in ansible-lint and not delaying it only makes the problem worse.
12:52:08 <zbr> my worry is that this is only the tip of the iceberg, and that we may encounter other issues.
12:52:34 <zbr> tadeboro: would you find ok to add an option to disable this deprecation warning?
12:53:38 <zbr> if someone can point me to a ticket on GAC where I can see there is a plan to upgrade the linter, with a checklist, I would merge tadeboro PR imediatelly.
12:54:33 <zbr> gundalow: WDYT?
12:54:50 <felixfontein> I don't think an option is a good idea, people will turn it off and then forget about this setting
13:11:23 <tadeboro> that ^
13:13:10 <zbr> felixfontein: is right, adding option to disable would not help us as we will have to pay the price later.
13:27:02 <Tas-sos> ( Sorry I will be back soon )
14:51:28 <dmsimard> greetings o/
14:51:51 <dmsimard> thanks again for everyone that participated in yesterday's event \o/
14:53:14 <felixfontein> good morning dmsimard!
15:04:48 <aminvakil> andersson007_: thanks for the explanation!
15:05:51 <cybette> #info First batch of slides uploaded and added to community wiki https://github.com/ansible/community/wiki/Contributor-Summit
15:07:02 <cybette> #info First batch of slides uploaded and added to Community wiki https://github.com/ansible/community/wiki/Contributor-Summit
15:07:29 <cybette> I also added the links in hackmd which contains more detailed notes along with the slides
15:08:52 <andersson007_> aminvakil: thank you for reviewing!:)
15:09:19 <andersson007_> felixfontein: to you too, PTAL when you have time https://github.com/ansible-collections/community.mysql/pull/112
15:12:11 * dmsimard didn't even notice hackathon/office hours were on
15:12:43 <dmsimard> #undo
15:12:43 <zodbot> Removing item from minutes: INFO by cybette at 15:07:02 : First batch of slides uploaded and added to Community wiki https://github.com/ansible/community/wiki/Contributor-Summit
15:13:05 <dmsimard> cybette: ^ I removed an extra since you added it twice
15:15:36 <cybette> dmsimard: thanks! for some reason the first one didn't show up for me
15:23:55 * samccann waves late
15:24:05 <aminvakil> can i share a PR from ansible/ansible ?
15:25:17 <bcoca> no, all PRs are MINE!!!!
15:25:23 <dmsimard> aminvakil: sure, but you can also do that anytime in #ansible-devel
15:26:00 <aminvakil> dmsimard: right, i wanted to take advantage of community gathering here today and reviewing PRs :)
15:26:31 <aminvakil> I have recently reopened a PR (https://github.com/ansible/ansible/pull/73821#issuecomment-792804431), although I think I should change to `version_added: 2.12`. But I would be thankful if you could review the whole PR and my comment to and tell me if this is an appropriate way or not.
15:26:32 <github-linkbot> https://github.com/ansible/ansible/pull/73821#issuecomment-792804431), | open, created 2021-03-08T12:53:19Z by aminvakil: Add umask option to user module [affects_2.11,ci_verified,feature,module,needs_revision,needs_triage,support:core]
15:27:40 <bcoca> yes, this wont ship for 2.11 as freeze is already passed, so 2.12 is next most probable target
15:28:06 <bcoca> fyi, still has needs_triage which means core team has not gone over it yet in their 2 weekly triage meetings
15:28:14 <bcoca> tmrow being the next one
15:28:32 <aminvakil> bcoca: thanks
15:34:20 <felixfontein> I think if you change version_added now, you'll get a sanity error
15:34:37 <felixfontein> this is due to stable-2.11 not having been forked yet, and devel still being 2.11
15:41:26 <bcoca> doesnt touch version_added, also its much older version for testing
15:41:58 <bcoca> but fine removing from copy, just need to get attributes top even passed
15:43:52 <bcoca> thnx
15:44:12 <bcoca> nvmd, mixing convos
16:15:46 <zbr> awcrosby: are you around?
16:23:15 <awcrosby> zbr: hey
16:23:56 <awcrosby> zbr: felixfontein: the `galaxy-importer` project is shared by Automation Hub and Community Galaxy, _but_ it only processes collections and not standalone roles (at least right now) … So the Community Galaxy standalone role code is indeed older.
16:25:38 <zbr> awcrosby: but we do not have a special reason for using older ansible-lint for role importing on older galaxy? am I wrong to guess that is using older version due to a safety ceiiling like a <5 ?
16:26:19 <zbr> i am trying to indentify what can we do to upgrade it.
16:27:03 <awcrosby> zbr: i don't think so, i think we can upgrade to ansible-lint to 5.x for community galaxy
16:28:37 <zbr> i want to know which path we should take, as v5 recommands users to switch from numeric rule ids to alphanumeric ones, but if they do the switch the upload to galaxy is likely fail as their newer tags used in "noqa" or skip_list would not be recognized by v4 linter.
16:29:08 <zbr> tadeboro proposed disabling the deprecation warning till we can upgrade it.
16:30:37 <awcrosby> zbr: would it help if i updated to ansible-lint 5.x and deployed to galaxy-dev.ansible.com for you to test out an import?
16:31:03 <zbr> obviously that it would help
16:31:32 <zbr> try https://pypi.org/project/ansible-lint/5.0.3rc1/
16:32:32 <awcrosby> i was thinking of updating to a non pre-release, we deploy to galaxy-dev based on our default branch
16:34:19 <zbr> in that case let me try to reach the 5.0.3
16:35:02 <awcrosby> alright, thank you, ill wait for that
16:36:44 <zbr> awcrosby: can you please take a look at these lines and let me know what you think: https://github.com/ansible-community/ansible-lint/blob/57aa3b850a0877790170efed328e4a2ff0a51219/src/ansiblelint/_prerun.py#L157-L161
16:36:59 <zbr> is about the fact that the galaxy namespace is missing from the role galaxy files...
16:37:22 <zbr> and the linter needs to know the namespace in order to emulate the installed state of the role.
16:37:43 <zbr> the current hack was to re-use author field, as most users already have correct value there (github org).
16:38:02 <zbr> but there are exceptions, like people using the author field to put real names.
16:38:52 <zbr> i observed that galaxy itself does not complain if we add extra fields, so we could recommend user to add a "namespace" field with right value, matching what we have for collections.
16:39:46 <zbr> galaxy server/importer would ignore the field, but at least we would be able to lint it correctly.
16:42:17 <awcrosby> zbr: is this something that would also apply to roles that are inside collections? or just standalone roles?
16:42:30 <zbr> that is only about standalone-roles
16:42:47 <zbr> those inside collections are not affected by this logic
16:43:13 <awcrosby> then i think recommending a `namespace` or `role_namespace`field would be fine
16:44:06 <zbr> i will make a change and recommend namespace, to match collection galaxy file.
16:45:08 <zbr> once these are done, we will release 5.0.3 and ping you to test upgrade on galaxy.
16:45:11 <zbr> thanks!
16:45:25 <awcrosby> sounds good!
16:46:53 <abadger1999> dericcrago pointed out to me yesterday that I missed the first ansible-4 alpha release last week.  I'll be making it today along with ansible-3.1.0
16:53:43 <zbr> felixfontein: tadeboro i need an eye on https://github.com/ansible-community/ansible-lint/pull/1450
16:53:44 <github-linkbot> https://github.com/ansible-community/ansible-lint/pull/1450 | open, created 2021-03-10T14:39:56Z by ssbarnea: Add optional rule that check for no-same-owner [enhancement]
16:57:44 <felixfontein> abadger1999: oh. must have missed that as well :D
17:15:49 <gundalow> felixfontein: tadeboro Did you have anything for IRC Meeting tonight? I think we said we'd cancel todays
17:22:40 <tadeboro> gundalow: I have nothing urgent and would actually appreciate an evening with no meeting ;)
17:30:48 <legreffier> i answered someone's question on irc today regarding the find module usage. (register a list of file using find, then iterate through this list, in order to delete them)
17:33:51 <legreffier> This need is fairly common, and easily covered with -delete option in a standard find (the unix command, not the ansible mode). So how do you feel about a `delete` option in find (the module) ?
17:45:09 <gundalow> abadger1999: dericcrago dmsimard ompragash andersson007_ felixfontein tadeboro No IRC meeting today
17:47:21 <dmsimard> ack
17:48:28 <jillr> gundalow: for clarity, is that the meeting that would otherwise take place in 70 minutes?
17:50:46 <gundalow> jillr: correct
17:54:32 <jillr> ack, thanks
18:11:34 <felixfontein> gundalow: we have stuff like Python requirements (though that isn't updated I think, so it has to wait for next week anyway), and whether community.general should get new content - but that discussion isn't urgent at all
19:07:19 <felixfontein> legreffier: you probably should better ask that in #ansible-devel, since that module is part of ansible-core
19:12:33 <legreffier> felixfontein: thanks for the advice I often fail to find my way across those
19:16:46 <Tas-sos> I was wondering if it would be a good idea (or if they already exist) to have some pull requests/issues/task/ for newcomers..
19:18:11 <gundalow> #endmeeting