16:02:10 #startmeeting Documentation Working Group aka DaWGs 16:02:10 Meeting started Tue Jan 26 16:02:10 2021 UTC. 16:02:10 This meeting is logged and archived in a public location. 16:02:10 The chair is samccann. Information about MeetBot at http://wiki.debian.org/MeetBot. 16:02:10 Useful Commands: #action #agreed #halp #info #idea #link #topic. 16:02:10 The meeting name has been set to 'documentation_working_group_aka_dawgs' 16:02:15 #chair acozine 16:02:15 Current chairs: acozine samccann 16:02:26 #topic opening chatter 16:02:36 * samccann hands baton to acozine 16:02:53 #chair baptistemm gwmngilfen lmodemal dmsimard felixfontein abadger1999 16:02:53 Current chairs: abadger1999 acozine baptistemm dmsimard felixfontein gwmngilfen lmodemal samccann 16:02:53 o/ 16:02:53 * dericcrago waves 16:03:02 #chair dericcrago 16:03:02 Current chairs: abadger1999 acozine baptistemm dericcrago dmsimard felixfontein gwmngilfen lmodemal samccann 16:03:08 hey folks! good to see everyone 16:03:18 * acozine reads backscroll a bit 16:03:38 * lmodemal getting the kids some lunch. brb :) 16:03:48 baptistemm: you okay with being furniture today? 16:04:14 if it gets too intrusive, feel free to unchair yourself 16:05:19 I'm multi-tasking, trying to finalize the issue about the /docs/ folder in collections 16:05:39 samccann: you want to give an update on the core docs work? 16:06:20 sure 16:06:31 #topic docsite split work 16:06:31 #topic Docsite Split Update 16:06:35 HAHA woopsie 16:06:37 heh 16:06:39 go for it! 16:07:11 ok so with abadger1999 and acozine help, I'm inching toward having a docsite split working via makefile fun and some sphinx initiatives 16:07:47 #info WIP PR for docsite split is https://github.com/ansible/ansible/pull/73362 - still a lot to go on it 16:08:33 The gist of it all is - it's the same set of files, but excluding scenario guides, network guides and the individual porting/maintenance pages from the relevant docs (core vs Ansible the package) 16:08:56 #info we also have an internal build that can publish 'make coredocs' once we have all this working 16:09:04 acozine did that part :-) 16:09:19 (as in I couldn't explain what her magic was, but it works) 16:10:09 So the next steps - clean up that WIP PR. The stumbling block right now is it uses a separate index page for Ansible the Package and that won't work (it's not index.html). But acozine came up with a way to use conditionals so I'm trying that next 16:11:12 And now for the Deep Thoughts - I 'think' once this is working in devel, it all has to be backported to stable-2.10, because we need to be able to publish Ansible 3.0.0 with stable-2.10 user guides etc. BUT the question becomes - will we ALSO need to be able to publish Ansible 2.10 from stable-2.10? 16:11:24 (as in stable-2.10 has to be able to publish THREE docsites? 16:11:40 the core docs are still on the testing site as http://docs.testing.ansible.com/ansible-core/2.11/, but the only difference right now is the URL 16:11:42 * samccann pauses for that all to sink in 16:12:09 hmm, I guess so 16:12:12 well, the `stable-2.10` branch will need to publish both 2.10 and 3.0 16:12:29 ansible-2.10, ansible-base-2.10, ansible-3 16:12:33 does it also need to publish a separate ansible-base 2.10 docset? 16:12:58 hmmm... like in "we didn't do it before, so let's not do it now"? 16:13:01 Well to start, I think if we can keep stable-2.10 able to republish what's already out there (plus bugfixes) that's good 16:13:01 or could we start the separate docsite with ansible-core 2.11? 16:13:22 maybe starting it with ansible-core 2.11 is easier - it gives more time :) 16:13:32 it will definitely be easier 16:13:35 something I'm unsure of - how does antsibull decide whether to pull in the 2.10 collections list or the 3.x collections list? 16:13:45 acozine: no probs 16:13:50 will it leave any users unable to find docs they need? 16:14:30 I'm +1 for keeping Ansible 2.10 docs as they are today.. at least for now. So the user uses the version switcher to go from 2.9 - 3. 16:14:54 and coredocs are published separately as devel as soon as we get that working 16:14:55 it would be nice to avoid the whole `ansible-base` to `ansible-core` thing if we can 16:15:02 amen to that 16:17:00 if we don't have to publish separate docs for ansible-base 2.10, then we don't have to backport samccann's changes 16:17:12 abadger1999: how does `anstibull` decide whether to publish 2.10 collectoins vs 3.0 collections if both are being published from stable-2.10? 16:17:15 we only need a way for the stable-2.10 branch to publish 2.10 and 3.0 16:17:32 we do need to backport my changes, how else would we publish 3.0 from stable 2.10? 16:17:50 IIRC, we tell antsibull what to do... the logic for selecting is in the ansible/ansible repo (hacking/build-ansible.py) 16:17:56 But I could be misremembering 16:17:58 ugh 16:18:19 so something in hacking/build-ansible.py has to distinguish between 2.10 and 3.0 in the build request? 16:18:42 17 from ansible.release import __version__ as ansible_base__version__ 16:19:08 Yeah, that line is from docs_build.py (under hacking) 16:20:31 sorry can't find docs_build.py ? can you add a link? 16:20:46 ./hacking/build_library/build_ansible/command_plugins/docs_build.py 16:21:04 thanks! 16:21:08 So what happens is... (1) git clone ansible (2) source hacking/en-setup (3) run build-ansible.py which uses docs_build to build the docs (4) docs_build imports ansible.release.__version__ from the ansible checkout and gets the version (5) docs_build executes antsibull-docs with that version 16:21:27 I guess it needs to be passed the Ansible version(s) 16:21:48 #info this line controls what collection version gets included in the docs build -https://github.com/ansible/ansible/blob/devel/hacking/build_library/build_ansible/command_plugins/docs_build.py#L17 16:21:53 (5) is actually... it finds the deps file for that version of ansible in the ansible-build-data repo and passes that to antsibull-docs. 16:22:21 abadger1999: in step 4, how do we "get the version"? 16:22:38 is it currently using `ansible --version`? 16:22:57 #info (1) git clone ansible (2) source hacking/en-setup (3) run build-ansible.py which uses docs_build to build the docs (4) docs_build imports ansible.release.__version__ from the ansible checkout and gets the version (5) docs_build executes antsibull-docs with that version 16:23:03 https://github.com/ansible/ansible/blob/devel/hacking/build_library/build_ansible/command_plugins/docs_build.py#L75-L76 definitely needs some update for ansible 3 16:23:14 acozine: python import of ansible.release.__version__ which comes from the checkout of ansible (because of doing `source hacking/env-setup.py` earlier) 16:23:15 acozine: it's essentially `ansible --version`, it uses some ansible internals to get that version more directly 16:24:25 do we need to inject the higher version numbers somehow, then? 3.0, 4.0, and so on? 16:24:25 Yeah, it looks like that's going to always pull the 2.10 info. 16:24:31 okay so in general, we need some stable-2.10 'magic coding' to have the ability to create Ansible 3 package anyway, yes? 16:26:38 Yeah, looks like we're going to need to do some work there......... I think the antsibull-docs code might be able to get the version of ansible-base that it needs to satisfy the version in the ansible-build-data deps file. 16:27:29 so... an action item for/....? (waits for volunteer from the audience) 16:28:17 So one option would be to drive everything from the command line to antsibull-docs instead of this wrapper in ansible/ansible. I think that would work well in jenkins, for instance. But the wrapper in ansible/ansible is how we currently develop docs so that would mean jenkins and edveloping docs has the potential to diverge :-( 16:28:42 samccann: Question: What would you like the workflow to be like? 16:28:49 what is the difference betwen jenkins and 'developing docs' ? 16:29:16 as in in my mind, jenkins IS developing/publishing docs.. so I'm missing a piece 16:29:35 Probably starts with I checkout the branch of ansible/ansible that I want to build docs for, right? Then there has to be some way to select "Iwant coredocs" "I want ansible-2.10 docs" "I want ansible-3 docs"? 16:29:59 yeah that part I'm working on (though 2.10 ins a new wrinkle) 16:30:51 samccann: What do you see that selection looking like? 16:31:18 well right now I was leaning toward 'make coredocs' and 'make webdocs' 16:31:27 * samccann has to figure out the correct way to format on irc 16:31:32 `make webdocs ANSIBLE=2.10`;; `make webdocs ANSIBLE=3` ;; `make coredocs` ? 16:31:44 yeah that might work 16:32:02 Yeah... but there's two versions of webdocs, so we have to account for that too. 16:32:15 * acozine channels cybette . . . we're at the half-hour mark 16:32:21 hhahaha!! 16:32:25 Heh 16:32:37 #info we may need something like `make webdocs ANSIBLE=2.10`;; `make webdocs ANSIBLE=3` ;; `make coredocs` 16:32:54 If you let me know what you want to type at the command line to select between the three choices, I can design a way to make that work. 16:33:13 I just don't know if the above is the way you'd want it or something else 16:33:45 acozine ;) 16:33:46 off the top of my head it looks like a good way to go. 16:34:17 (`make ansible2docs` `make ansible3docs` `make ansiblecoredocs` ;; `make docs VER=ansible2` `make docs VER=ansible3` `make docs VER=core` ;; etc) 16:34:17 I think I'd like to FORCE people to use ANSIBLE=xx for make webdocs so that they have to consciously decide what version they are talking about 16:34:55 nah I like the prior one better. make coredocs is simple and I can't see that ever needing a 'version' selection like Ansible the package needs 16:34:59 cybette: heh, I didn't mean to ping you 16:35:06 `make webdocs ANSIBLE=[core|2.10|3]` 16:35:18 16:35:20 I like that better as well 16:35:29 i dislike that particular one because what happens when core becomes 3? I think it could be confusing 16:35:44 hmm 16:35:57 well, core will continue to draw its version from `ansible --version` 16:36:42 yes but a user new to this will wonder - do a choose core or 3 as my ANSIBLE version in make webdocs? 16:36:54 but separating the `make coredocs` and `make webdocs` commands does feel cleaner 16:37:18 i've been leaning toward having core as clean as possible, in the inevitable future where we yank things out of ansible/ansible 16:37:22 #action abadger1999 to figure out how to implement `make webdocs ANSIBLE=2.10`;; `make webdocs ANSIBLE=3` ;; `make coredocs` and report back later this week 16:37:51 acozine: no worries! Can't offer my services right now though, having dinner... 16:37:52 abadger1999: I may be able to figure that part out 16:37:55 maybe the variable could be `PACKAGE`? 16:38:06 as in `make webdocs PACKAGE=3.0`? 16:38:13 what I can't touch is how to get ansible the package in stable-2.10 to figure out whether to build 2.10 or 3 16:39:07 it gets the version to build explicitly passed 16:39:17 ok we are 40 min in on this... should we move to another topic and abadger and I can thumbwrestle on who does what next 16:39:25 heh 16:39:27 sounds good 16:40:04 samccann: Yeah, that's why we need to add a variable to the `make` command line 16:40:28 ok let's brainstorm a bit later this afternoon 16:40:41 #topic documenting use of `C(. . . )` 16:40:46 https://github.com/ansible/ansible/pull/73312 16:41:09 (Note: I have non-work stuff that will take up my afternoon... we can either work separately or brainstorm tomorrow) 16:41:15 for history: https://github.com/ansible-collections/ansible.utils/pull/32#discussion_r560490351 16:41:33 abadger1999: 16:41:57 i'm +1 for using C(..) for code 16:41:59 I think code fragments should always be formatted in `C(...)`, for several reasons: 1) it is a common convention, 2) it translates to , i.e. semantic markup, which also helps screen readers 16:42:21 +1 16:42:21 agreed 16:42:57 felixfontein: can you add that bit about the screen readers to the PR description. That's an important point we don't want to forget about 16:43:12 I would have thought the way it was rendered would tell people it was a known standard but I guess not. 16:43:17 samccann: to the PR's content, or the PR's description? 16:43:17 this is the least controversial and the easiest to implement part of the discussion about semantic markup 16:43:27 (also "C" stands for "C"ode ;-) 16:43:29 just the description, not the actual docs change 16:44:19 samccann: I updated it 16:44:21 abadger1999: we'll always have newbies who just don't know or haven't thought of it 16:44:48 true. so it's better to document it. 16:45:44 shall we vote? 16:45:50 any other comments/discussion? 16:46:00 #chair 16:46:00 Current chairs: abadger1999 acozine baptistemm dericcrago dmsimard felixfontein gwmngilfen lmodemal samccann 16:46:26 +1 16:46:32 vote: +1 to merge https://github.com/ansible/ansible/pull/73312/files 16:46:34 +1 16:46:52 comments still welcome if you have them! 16:47:05 +1 16:47:34 +1 16:48:14 that's 5 in favor, no votes against, out of 9 chairs . . . 16:48:16 going once 16:48:23 going twice 16:48:53 merged 16:48:55 thanks felixfontein 16:48:59 thanks everyone :) 16:49:05 I'll create a backport for stable-2.10 16:49:19 #topic previous action items 16:50:23 dmsimard: did you open a backport PR to add FQCN to the glossary in 2.10? 16:51:41 I'll report on my own action item - I'm editing an issue for our discussion of publishing documentation from the `/docs/` folder in collections - the issue will be in https://github.com/ansible-community/antsibull/ 16:51:55 btw, there are a couple of stable-2.10 docs backports: https://github.com/ansible/ansible/pull/73222 https://github.com/ansible/ansible/pull/73280 https://github.com/ansible/ansible/pull/73374 (ok the last one is from now ;) ) 16:52:37 felixfontein: thanks, let me make sure we're okay to merge backports . . . I got a little hasty not long ago and had to revert a couple . . . 16:53:28 speaking of which, I may need to revive a couple of backports once things are open again. 16:53:40 acozine: I think as long as they are docs only, it should be ok 16:53:42 one of which I think needs to be discussed with core 16:54:07 yeah, we can have a miniature backportapalooza this afternoon 16:55:20 #action acozine to clear the docs backports queue 16:55:39 oops, we have five minutes left . . . 16:55:48 I can't go over today 16:55:51 quick open floor 16:55:59 #topic open floor 16:56:08 survey can wait til next week, i'm not done with it yet anyway 16:56:14 all questions, comments, suggestions, requests for help are welcome 16:56:33 when does Ansible 3 go to beta? 16:56:52 gwmngilfen: sounds good, I'll make sure it's on the agenda 16:58:16 I have a topic: https://github.com/ansible-community/antsibull/pull/238 16:58:22 * abadger1999 looks on ompragash 16:58:28 * abadger1999 looks on roadmap 16:59:20 samccann: beginning of february 16:59:29 so . . . next week 16:59:30 2-2 https://docs.ansible.com/ansible/devel/roadmap/COLLECTIONS_3_0.html 16:59:55 which is next week... is it still on track for Feb 2? 17:00:10 I ask because my goal was to have a beta docsite available 17:00:21 may or may not be possible, but ... a goal. 17:00:22 felixfontein: antsibull PR 238 is a big change 17:00:35 well worth discussing in detail 17:00:41 abadger1999: is ompragash doing the release? should I be in sync w/ him? 17:01:02 acozine: it is, but necessary for Ansible 3.0.0 17:01:08 because then a lot of stuff will move 17:01:15 samccann: Sprry... I started replying to you and then saw a message notification from him and types his name instead of finishing the message to you 17:01:41 felixfontein: would merging it mean no more redirects? 17:02:05 acozine: redirects between stable-2.9 and the new versions are still necessary 17:02:20 mmm, okay 17:02:21 but new redirects are probably no longer necessary 17:02:21 hah ok phew... (and sorry to our Indian peer who now has an unnecessary ping awaiting for him) 17:02:52 acozine, samccann : What do you think of the output of 238? 17:03:20 I can disable all the stubs for ansible.builtin for now, if that makes everyone feel better :) 17:03:37 I can review the code but I saw that felix had some questions about whether the output was how we want to do it or not. 17:05:07 I'm confused 17:05:44 in the 'after' output here: https://ansible.fontein.de/collections/community/crypto/index.html#plugins-in-community-crypto the `_facts` module is not listed . . . 17:05:45 I guess the main question is whether we want to generate stub files for ansible.builtin - I guess we don't want that, at least for the beginning. maybe later. 17:05:58 am I looking at the right thing? 17:06:27 acozine: you are. I'm not sure whether it should be listed or not; it's a deprecated redirect, so not showing it is fine IMO 17:06:28 i'm also confused, but by a different part. so maybe a slow walkthrough would help 17:06:34 on the other hand, it's not removed, so we could stlil show it 17:06:38 but acozine - did you have a hardstop now? 17:06:43 yeah, I need to go 17:06:52 do you folks want to carry on with the meeting? 17:06:58 ok let's set a 'time' where at least the three of us can discuss? 17:07:01 Yeah, I think ansible.builtin might be a special case.... And we might even want to take a snapshot (as in, don't generate any stubs for things that moved in 2.10. But do generate stubs for any future moves) 17:07:01 or shall we revive the Thursday Special for this week? 17:07:36 well let's start with when is felixfontein available around a similar time as this in the next few days? 17:08:04 I think 10:30 AM ET is probably the earliest that both acozine and I are around. 17:08:08 if "as this" is when the meeting started, I have time :) if it's now, it's a bit suboptimal :) 17:08:33 Thursday at the time this meeting started 17:08:36 ok 11am ET tomorrow? 17:08:42 um, tomorrow is Weds 17:08:45 I'll probably be out 17:08:49 ah ok 17:08:55 11am ET Thursday then? 17:09:10 is that 16:00 UTC? 17:09:17 (i.e. 17:00 CET) 17:09:21 is that when this meeeting started? 17:09:23 what time is it now? 17:09:29 UTC I mean 17:09:54 should be 17:00 UTC 17:09:57 17:09 :) 17:10:17 yes, so 16:00 UTC on Thursday is my proposal 17:10:18 so yes, 16:00 UTC Thursday 17:10:22 +1 17:10:42 sounds good! 17:10:51 I'll be available and ready by then :) 17:10:59 (I'm right now alternating between kitchen and laptop ;) ) 17:11:12 #info we will have a supplemental meeting Thursday at 11am ET /16:00 UTC to discuss https://github.com/ansible-community/antsibull/pull/238 17:11:19 heh, go enjoy your dinner felixfontein 17:11:20 there. acozine shoo... I'll close this out 17:11:24 thanks 17:11:28 thanks! 17:11:31 anyone else have anything before we end the official meeting? 17:12:25 ok silence is golden as they say... 17:12:29 #endmeeting