15:02:59 #startmeeting Ansible Core Meeting 15:02:59 Meeting started Thu May 4 15:02:59 2017 UTC. The chair is bcoca. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:02:59 Useful Commands: #action #agreed #halp #info #idea #link #topic. 15:02:59 The meeting name has been set to 'ansible_core_meeting' 15:03:08 ohai 15:04:05 rolp 15:04:48 * bcoca waves 15:04:55 #chair jtanner nitzmahone abadger1999 15:04:55 Current chairs: abadger1999 bcoca jtanner nitzmahone 15:05:07 o/ 15:05:18 passing on 'shipit' workflow as it requires tagging of each plugin type, which has not been done/scheduled 15:06:00 abadger1999: wildcards on lookup? author of PR made some comments, invited them to this meeting but i'm still unlcear if we have chosen a path forward 15:06:53 Hmm... Link to the issue? 15:07:05 * mattclay waves 15:07:14 We had decided that we were going to error on wildcards in the path portion I think. 15:07:29 I haven'[t read his responses since then. 15:07:33 abadger1999: a, ok, https://github.com/ansible/ansible/pull/19297 15:08:03 #topic https://github.com/ansible/ansible/pull/19297 wildcard in path portion of fileglob lookup 15:09:00 abadger1999: so slight modification to my implementation? 15:09:10 #info alternative solution: https://github.com/ansible/ansible/pull/23265 15:10:13 #action: bcoca to update alternate to give error instead of 'first found' 15:10:30 #action bcoca to update alternate to give error instead of 'first found' 15:10:30 bcoca: Probably yeah... I believe we said... relative paths with globbing in the path are ambiguous so it should error. globbing in absolute paths is fine. 15:11:12 he, its written already in ticket ... did not read to end, totally forgot 15:11:23 proposals, anything new? 15:11:28 #topic proposals 15:12:02 I think thaumos took this on and since he's at summit no progress for htis week. 15:12:52 moving on then 15:12:59 #topic module option validateion expansion 15:13:05 do we add ipv4/etc to basic 15:13:13 ^ didnt we vote on this, was mostly split 15:13:28 ah ... need to learn2scroll 15:13:36 no oposition if outside basic 15:13:54 anything new on this? 15:14:10 I think that was where we left it 15:14:24 so mostly i vote we dump it on privateip's lap 15:14:33 I think that was also where we left it. ;) 15:14:39 :-) 15:14:44 unanimous! 15:14:51 ok, so that is all i see in ticket 15:14:55 #topic open floor 15:14:57 yep, I think we can take it off the agenda. 15:15:02 mattclay: Did you see this? https://github.com/ansible/community/issues/159#issuecomment-291569609 15:15:27 Hi I did my homework and updated PR 20333 15:17:00 * mattclay looks 15:17:09 lgtm, any fedora/rhel leaning people want to review? 15:17:21 Yep. That's on my personal TODO list now. 15:19:33 mattclay: cool thanks. 15:19:40 albertom: I'll review that. 15:20:23 #action abadger1999 to review https://github.com/ansible/ansible/pull/20333 15:21:21 u thanks 15:21:23 ill update asap 15:24:45 Anyone else have any items to discuss? 15:25:06 misc reviewed #23686 (postgresql_user module) and i updated the PR, new reviews are welcome 15:26:18 Pilou: erroring on python3. 15:26:58 i am not able to reproduce this error and mattclay added ci_verified label 15:27:47 should i 'touch/rebase' the PR in order to trigger another pass ? 15:28:15 ci_verified means that the error stands 15:28:18 I believe ci_verified means that the ci test failure is a valid failure. 15:28:20 not that it passes 15:29:01 oh, i was not aware, my bad 15:29:14 Pilou: Have you tried running the tests locally using python 3? 15:29:21 Pilou: Lines like this look like likely Py3 culprits: hashed_password = 'md5{0}'.format(md5(to_bytes(password) + to_bytes(user)).hexdigest()) 15:30:00 Pilou: not all py3 are the same 15:30:11 Hmm... but looks like it should work. 15:30:17 * abadger1999 takes a close look at the traceback 15:30:44 mattclay: yes, in a xenial lxc container without python2 at all 15:32:12 Perhaps it's due to a different version of psycopg2? What version do you have installed? 15:33:34 The error seems to be coming from a function not modified in that PR, but unsure how it may impact that function. Line 269 in user_add 15:34:28 mattclay: 2.6.1 (according to http://packages.ubuntu.com). I will check the version used in the CI and then comment the PR 15:35:29 #action mattclay and abadger1999 to follow up 15:35:33 anything else? 15:38:54 ok, ending meeting in 5 if nothing else comes up 15:42:33 #endmeeting