15:01:15 <bcoca> #startmeeting ansible core public irc meeting 15:01:15 <zodbot> Meeting started Thu May 14 15:01:15 2020 UTC. 15:01:15 <zodbot> This meeting is logged and archived in a public location. 15:01:15 <zodbot> The chair is bcoca. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:15 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic. 15:01:15 <zodbot> The meeting name has been set to 'ansible_core_public_irc_meeting' 15:01:28 <bcoca> #topic https://github.com/ansible/ansible/pull/69087 15:02:03 <bcoca> looking to see if we shoudl add this to 'base' .. since vaulting/unvaulting is pretty 'core function' 15:02:16 * bcoca plans a vault lookup afterwards if this goes well 15:03:11 <bcoca> no comments? 15:03:16 <bcoca> thoughts, votes? 15:04:05 <bcoca> going to assume everyone agrees then ... 15:04:29 <Shrews> i don't see why not 15:04:45 <bcoca> main reason, we really want to add as little as possible to base 15:05:08 <bcoca> keep it lean, move most stuff to collecitons, but things like this are imho on the fence of 'should be basic' 15:05:22 <bcoca> why i brought up here to get more thoughts/opinions 15:05:42 <Shrews> what collection would it move to, if we were to consider that option? 15:06:06 <bcoca> i imagine c.general .. since it is the dumping ground 15:07:01 <Shrews> i guess the question is do we want to maintain it or not. i don't see us monitoring c.gen too much, tbh 15:07:20 <bcoca> if it goes to c.g we DONT maintain it 15:07:58 <Shrews> right 15:09:42 <bcoca> well, that makes it +200/0 ... so will merge 15:09:52 <sdoran> This may be a dumb question, but how is this substantially more useful than using vaulted vars in a vars file that gets automatically decrypted? 15:10:11 <sdoran> And does this actually decrypt the value? 15:10:27 <bcoca> sdoran: for vaulted files that are not vars, but you want to include the content in a template 15:10:57 <bcoca> sdoran: see test 15:11:53 <bcoca> not really case, but simple test that 'it works' https://github.com/ansible/ansible/issues/69084 <= this ticket finally got me to do it 15:12:07 <sdoran> Hmmm. Will it handle multiple vars in a single vaulted file? 15:12:07 <bcoca> but there are many other 'use cases' in previous tickets, mostly asking for vault/unvault filters 15:12:17 <sdoran> Just trying to think through all the enhancements folks will ask for. 15:12:19 <bcoca> sdoran: no, specifically it does not do vars 15:12:34 <bcoca> if they want 'vars' they can always |from_json/|from_yaml 15:12:43 <bcoca> or just use include_vars 15:12:49 <sdoran> So you can pull in vaulted vars outside the normal play vars. 15:12:53 <bcoca> this is mainlyu for 'non vars content' 15:13:08 <bcoca> sdoran: that is what include_vars does ... 15:16:14 <bcoca> sdoran: anything else? 15:16:33 <sdoran> I guess it's fine to add. 15:16:46 <sdoran> Use case in that ticket makes sense. 15:17:11 <sdoran> Be prepared for the tsunami of enhancement requests. :) 15:17:45 <Shrews> autoassign bcoca 15:17:47 <Shrews> :) 15:18:04 * bcoca can shut most down by showing examples 15:18:15 <bcoca> #topic https://github.com/bcoca/collection/issues/3 15:18:23 <bcoca> new home for 'cannonical layout of collection' 15:18:45 <bcoca> bcoca/ is not really the best place to have it, shoudl it go under ansible/ ansible-collections? 15:19:35 <sdoran> Do we provide sample repos for projects and roles? Just wondering what makes collections different. 15:19:38 <sdoran> More tedious to setup? 15:20:16 <bcoca> lot bigger, we provide example for role tree in docs .. but worth expanding this? 15:20:32 <bcoca> shoud it be 'layout' repo and have collection and role in there? 15:20:32 <gundalow> For somethings maybe easier to show an example, thank docs 15:21:02 <gundalow> I'd thought we have a repo with example GitHub action 15:21:09 <bcoca> gundalow: was mostly users requesting, i had it initially just for 'development' to sync on one thing, was not intended for users to consume 15:21:14 <gundalow> https://github.com/ansible-collections/collection_template/ is sort of this 15:21:37 <geerlingguy> @bcoca it could do vars maybe if the vaulted file is yaml, and you use | from yaml, right? 15:21:44 <bcoca> that is more 'colleciton repo' vs collection itself 15:21:52 <bcoca> @geerlingguy soo .include_vars ... 15:22:24 <geerlingguy> true, but some people get their brain stuck in a `lookup` mindset and might do it that way, I'm just saying that it would be possible (however insane) 15:22:49 <bcoca> i'll add note to docs, it should really be used only for the 'missing case' which is to allow using in templatse vaulted content that is not vars 15:23:27 <bcoca> gundalow: this is more about h;aving a 'structure reference', fine with kiling the repo, but the 'spec' needs to live somewhere 15:23:57 <sdoran> So I think it'd be good to move that repo to `ansible-collections/example_collection` and fill it out with some more content. 15:24:05 <geerlingguy> bcoca: FYI https://github.com/ansible/ansible/pull/69087#discussion_r425219504 — there was a typo in it. Should I file a PR :D 15:24:33 <bcoca> u can do so too! 15:24:52 <Shrews> if anywhere, ansible-collections, but if it's in ansible, something in docs seems more appropriate than a sample repo 15:25:36 <bcoca> that was my first impulse, just didnt look very good when i tried to do the same as with roles .. probalby need an image better than 'ascii art' 15:26:11 <sdoran> Given how much stuff can be in collections, I do think an example repo would be more useful than the output of `tree` in a docs page. 15:26:33 <sdoran> Just so long as we caveat it with "This is an example, not a template". 15:26:46 <bcoca> i would even argue that a 'role' version woudl have been very helpful also 15:26:58 <bcoca> sdoran: template is already in 'init' action in a-g 15:27:04 <sdoran> Exactly. 15:27:11 <bcoca> that shoudl be 'first thing in readme' 15:27:40 <bcoca> maybe shoudl move this to docs meeting? 15:29:05 <sdoran> Probably good to run by the docs team because maybe it should be something the docs team maintains since it would be a "living example". 15:29:29 <sdoran> But I think it makes the most sense to move it to `ansible-collections/example_collection` 15:30:44 <Shrews> somehow adding 'a-g collections init' output tree to docs dynamically would help keep it in sync... but wishlist maybe 15:31:06 <bcoca> k, then pushing that to their agenda 15:31:10 <bcoca> #topic open floor 15:31:14 <gundalow> gh/anisble-collections/example.SOMETHING 15:36:26 <bcoca> k, if nothing new, ending meeting, have your time back! 15:36:29 <bcoca> #endmeeting