15:05:43 #startmeeting core public irc meeting 15:05:43 Meeting started Thu May 13 15:05:43 2021 UTC. 15:05:43 This meeting is logged and archived in a public location. 15:05:43 The chair is bcoca. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:05:43 Useful Commands: #action #agreed #halp #info #idea #link #topic. 15:05:43 The meeting name has been set to 'core_public_irc_meeting' 15:06:07 o/ 15:06:13 \o 15:06:36 #topic https://github.com/ansible/ansible/issues/74558 15:07:34 in 'preview' discussion, most of core seemed to be of the mind 'this should not be a std core test' 15:08:01 o/ 15:08:29 that if we wanted this restriction, it should be in runtime code 15:09:05 * gundalow waves 15:09:28 It should be a configurable option in one way or another. 15:09:44 Core allows all the things, collection authors can choose to restrict that further. 15:09:49 otherwise, folks would want backport of new plugin types 15:09:49 * gundalow waves 15:10:20 mattclay felixfontein: FYI we are talking about https://github.com/ansible/ansible/issues/74558 ansible-test: Error if non-standard dirs exist under plugins/ 15:11:04 its a bit early for matt, PDT 15:11:19 ah, yup, hadn't looked at the clock 15:12:23 bcoca: could you please expand on `Also, if we are doing a 'extraneous dir check' i would extend this to verifying the full collection schema and 'warn' about those directories, just not error.` 15:13:30 yes, your check only affects 'plugins' subdir, if we are going to verify 'proper collection' i would verify ALL dirs for 'extraneous' .. but still not make it an error, just a warning 15:14:24 ah so https://docs.ansible.com/ansible/latest/dev_guide/developing_collections.html#collection-structure 15:14:24 though + `scripts` 15:14:45 I think `scripts` is where we put oldskool inventory scripts 15:15:05 still 'meaningless' to ansbile itself 15:15:23 nod 15:16:21 AFAIK this requirement (extra dirs under plugins) was because some collections made a new subdir that wasn't currently used by Ansible, and we were concerned that those dirs might conflict with a future thing in Ansible 15:17:31 well, not that worried about that .. also ended up with 2 "standards" 15:20:16 im tempted to punty this to a linting tool 15:20:30 OK, maybe we throw this on the backlog for a while, till there are more thoughts around the collection-only testing 15:20:33 bcoca: bingo :) 15:20:41 +1 15:21:30 If we have time, dericcrago and I would be interested in talking about about https://github.com/ansible-collections/community.general/issues/176 15:21:59 * dericcrago waves 15:22:32 comment added on 74558 15:25:39 #topic open floor 15:26:08 #topic https://github.com/ansible-collections/community.general/issues/176 15:26:11 :( 15:26:22 woops, wrong link 15:26:44 https://github.com/ansible/ansible/issues/74684 15:26:57 i was going to punt to galaxy team 15:27:12 Does Core have any thoughts/ 15:27:38 or any gotchas? 15:28:49 well, i would say that they serve diff purposes, core one is 'general' (just uses layout) while your template is for community collections (has licenses, code of conduct) 15:29:52 That's a fair comment 15:30:02 off the top of my head I was thinking you could give it either a --bare or --opinionated to get one of the other 15:30:41 also, mulitple temlpates, --template community_collection 15:31:06 the design was always 'overridable' 15:31:49 dericcrago: so maybe do a table in #74684 showing the existing files (in both collection_template and ansible-core) and list which template they could apply to 15:32:16 add 'this is how you init this type of collection' with a-g init .. 15:32:22 to readme 15:33:37 heh, TIL about GH repo templates 15:33:58 ^ me too 15:34:11 Sorry for being late to the parts, but I think we decided last time that someone (me) will write the docs about this and call it a day. The extra check should go somewhere else. 15:34:13 is `--template` already available? 15:34:27 gh templates have improved A LOT 15:34:57 --role-skeleton .. not sure equiv for collections 15:35:18 --collection-skeleton 15:35:37 Shrews: shertel I think GH Collection Templates are ~ year old, 15:35:46 My plan is to document the "these dorectories are safe to use" once I start teacing our internal teams some collection development next week. 15:37:19 tadeboro: cool, is that something that could end up on https://docs.ansible.com/ansible/latest/dev_guide/developing_collections.html#collection-structure 15:37:44 gundalow: This is where I wanted to put it, yes. 15:37:45 dericcrago: Any other questions or thoughts you want to share at this point? 15:37:49 tadeboro: thanks :) 15:38:03 ok, with `--collection-skeleton` is there a specific directory we can use so that these skeletons would be considered 'builtin'? 15:38:48 yes, easy to add logic that w/o fullpath/unfound relative to look into 'data dir' which is where we keep em 15:38:55 https://github.com/ansible-community/community-topics/issues/15 contains a discussin topic related to the topic of linting. 15:39:11 also wil lprobably rewrite to --skeleton as common option 15:40:17 ok, I'll start poking around at it, thanks! 15:41:49 Thank all 15:41:52 Nothing else from me 15:43:12 k, if nothing else ending in 3mins 15:44:55 * gundalow -> afk 15:47:05 #endmeeting