16:00:01 #startmeeting Network Working Group 16:00:01 Meeting started Wed Jul 25 16:00:01 2018 UTC. 16:00:01 This meeting is logged and archived in a public location. 16:00:01 The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot. 16:00:01 Useful Commands: #action #agreed #halp #info #idea #link #topic. 16:00:01 The meeting name has been set to 'network_working_group' 16:00:10 #chair ganeshrn gundalow privateip rcarrillocruz trishnag 16:00:10 Current chairs: Qalthos ganeshrn gundalow privateip rcarrillocruz trishnag 16:00:53 #link https://github.com/ansible/community/labels/network agenda as always 16:01:12 #topic Team Updates 16:01:40 #info This week we've been working on the following: 16:01:45 #info * nios and other networking bugs and nios new module integration tests. 16:01:51 #info * nxos cliconf plugin refactor PR #43203 16:01:56 #info * nxos_facts refactor work 16:02:03 #info * nxos get_capabilities regex fix. 16:02:08 #info * nxos_logging bugs and adding new features - use-vrf & source-interface. 16:02:16 #info * merged setting command timeout per task feature, Added PR #43078 to send timeout error message in output 16:02:22 #info * Adjustments to httpapi connection plugin to better support incoming httpapi plugins 16:03:40 #topic Lenovo port to persistence pt. 2 16:04:43 I don't see you here, but I want to mention, it looks good and will likely get merged soon, bother me here if I get distracted and don't get that done 16:05:09 #action Qalthos merge PR #43194 16:05:20 #topic Open Floor 16:06:40 If anyone has anything else to bring up, feel free 16:06:54 I have one PR 16:07:10 #chair Anil_ 16:07:10 Current chairs: Anil_ Qalthos ganeshrn gundalow privateip rcarrillocruz trishnag 16:07:28 Haha, I was too quick for you 16:07:41 #topic Lenovo port to persistence pt. 2 16:07:54 #link https://github.com/ansible/ansible/pull/43194 16:08:02 (remembered to link it this time) 16:08:16 Anil_: I assume this is what you were referring to? 16:08:19 some one please review 16:08:48 This is in similiar lines that you have reviewed previously 16:08:54 42500 16:09:15 It looks good, I had one question about why you have comments in your EXAMPLES, but other than that, it looks good 16:10:06 That examples didnot worked when I ran end to end test using real switch. Because that configuration doesnot apply to L2 port 16:10:14 I mentioned before you joined that my plan was to merge it after we're done here 16:11:33 I thought, it always better to present what all i could finish by wednesday as PR. As if like its a scrum iteration of 1 week 16:11:52 But you aren't running directly from the EXAMPLES in the module right? I mean they're just examples 16:12:18 true. But I have a set up in my lab which run these examples 16:12:42 and I cannot cheat customer, so I verify them all by running 16:13:18 If the module doesn't support whatever it is, I would remove it untril it does, and if it does support it, I don't see why you would need to comment anything 16:13:38 sure. I will remove the commented examples 16:14:00 u add it as a review comment 16:14:10 I did indeed 16:14:25 oh thanks for that 16:14:51 Anil_: Anything else you want to bring up? 16:15:20 Nothing, so thankful to you for reviewing my code 16:15:27 Anil_: Sure 16:15:36 #topic Open Floor 16:16:03 And Ganesh has been trying on introducing timeout configuration for each command, what happend to that ? 16:16:34 That is merged, let me look up the PR 16:17:12 I think I may need it when i started working on image upload , config upload , back up etc 16:17:38 #link https://github.com/ansible/ansible/pull/42847 should tell you all about how to use per-task timeouts 16:18:03 #action somebody make sure that is documented 16:18:32 Thanks 16:19:12 acozine: I will probably follow up on that, try to help me not drop that 16:20:03 (or whomever, I just picked on you because I can see you're in here) 16:20:23 Anything form anyone else? 16:40:11 Right, thanks everyone for coming by 16:40:15 #endmeeting