15:59:02 #startmeeting Ansible Network Working Group 15:59:02 Meeting started Wed Mar 20 15:59:02 2019 UTC. 15:59:02 This meeting is logged and archived in a public location. 15:59:02 The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:59:02 Useful Commands: #action #agreed #halp #info #idea #link #topic. 15:59:02 The meeting name has been set to 'ansible_network_working_group' 15:59:39 #chair ganeshrn ikhan privateip trishnag pabelanger 15:59:39 Current chairs: Qalthos ganeshrn ikhan pabelanger privateip trishnag 16:00:20 #topic Core Updates 16:00:36 No updates of note from team, core freeze has passed. 16:00:47 #info Community freeze is in eight (8!) days (2019-03-28) 16:01:09 #info if your feature isn't already in a PR, it is unlikely to make it in to 2.8 16:02:15 #link https://github.com/ansible/community/labels/network is where the agenda for this meeting can always be found 16:03:01 #topic EXOS updates/exos_vlan module 16:03:51 UjwalKomarla: I've made a comment on the PR, but this really should be two PRs, as the exos_vlan module doesn't seem to have much to do with the other changes 16:05:19 Additionally, exos_vlan should be using the existing restconf httpapi plugin, rather than creating a second RESTCONF implementation 16:05:50 Qalthos: When I started working on the 'httpapi' plugin, I wasn't aware of the work with regard to RESTCONF. 16:06:32 The way, I have implemented 'httpapi' plugin is that, the modules can use either the restconf or jsonrpc interface on an EXOS device. 16:07:41 UjwalKomarla: Do any modules support both? The PR is a little unclear on that 16:09:20 exos_vlan module when it does a 'gather_facts' uses 'jsonrpc'. 16:09:42 Whereas, for configuring the VLAN, it uses restconf. 16:12:20 The way I have written 'httpapi' plugin, will allow a mix of tasks with module using jsonrpc, and modules which use restconf with the same inventory file information. 16:16:32 https://gist.github.com/ujwalkomarla/ccd8d6d577ed601b67a5e3cd1e0efe26 16:16:34 Alright, that seems to explain a few problems I've seen here. I would still like to see this PR split apart, and then we can have a more targeted conversation about how you're using httpapi 16:18:34 It's not ideal, but that gist should still be workable with two different httpapi plugins. Hopefully we can make that more seamless in 2.9 16:19:25 Sounds good. 16:20:21 For the PR split, would you like a set with 'httpapi' changes and related changes to old modules. And another with just the 'exos_vlan' module? 16:20:29 #action UjwalKomarla split exos_vlan from ansible/ansible#53762 into a new PR 16:20:36 That's it exactly 16:21:09 Will do. 16:21:20 Alright, then, moving on 16:22:01 #topic new Sophos XG module 16:22:48 I don't see anyone that looks like the author of this here 16:23:49 And they've acknowledged my comments on the PR, so unless someone wants to mention something quick, I'll move on 16:27:50 #topic Open Floor 16:28:21 Anyone else have anything they want to bring up? 16:42:59 Alright, have a good week, everyone! 16:43:04 #endmeeting