15:59:36 <Qalthos> #startmeeting Ansible Network Working Group
15:59:36 <zodbot> Meeting started Wed Aug  7 15:59:36 2019 UTC.
15:59:36 <zodbot> This meeting is logged and archived in a public location.
15:59:36 <zodbot> The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:59:36 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
15:59:36 <zodbot> The meeting name has been set to 'ansible_network_working_group'
16:00:12 <Qalthos> #chair ganeshrn ikhan nilashishc privateip trishnag pabelanger dmellado
16:00:12 <zodbot> Current chairs: Qalthos dmellado ganeshrn ikhan nilashishc pabelanger privateip trishnag
16:00:22 <Qalthos> #topic Core Updates
16:00:26 <pabelanger> o/
16:02:01 <Qalthos> #info AnsibleFest is still Sept. 24-26 in Atlana, GA
16:02:11 <Qalthos> #link https://www.ansible.com/ansiblefest for details
16:03:32 <Qalthos> #info Feature freeze for Ansible 2.9 is also quickly approaching, at 2019-08-29
16:03:49 <Qalthos> #link https://docs.ansible.com/ansible/latest/roadmap/ROADMAP_2_9.html for up-to-date info on that
16:05:33 <Qalthos> #link https://github.com/ansible/community/labels/network is where the agenda for this meeting can always be found
16:06:03 <Qalthos> I think that's it from us, so let's get into it
16:06:26 <Qalthos> #topic Configurable terminal plugins #60086
16:08:04 <Qalthos> This is something ganeshrn has put together to solve a number of problems with initial device setup
16:09:06 <Qalthos> #info If you maintain a platform that has a terminal plugin, you are affected. Take a look at ansible/ansible#60086 and make sure everything looks right.
16:10:15 <Qalthos> There shouldn't be any issues, but as with any change of this size, we can't keep an eye on everything.
16:11:09 <Qalthos> I don't think ganeshrn is available to add anything more, so I'm going to move on.
16:11:45 <Qalthos> #topic Meraki bugfix #59395
16:12:34 <mrproper> #59395 was submitted as a PR last week and I'm happy with it. I'd like to get it into devel so I can backport as well. The submitter hasn't submitted a changelog fragment so I'm looking for advice on how I should best move this forward.
16:14:08 <Qalthos> mrproper: You are listed as a maintainer for meraki, right?
16:14:16 <mrproper> I should be. Yes.
16:17:46 <Qalthos> mrproper: My suggestion would be to submit a review as 'request changes' detailing what you want, which should cause the bot to start bugging the submitter to resove it.
16:17:47 <Qalthos> If that doesn't work for people without commit access, as a maintainer you should be able to use one of https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md#commands to create the same outcome
16:18:30 <mrproper> Excellent.
16:21:28 <mrproper> My next topic is about PR #55251 (https://github.com/ansible/ansible/pull/55251). This is the base PR for my unit tests against the Meraki module utility. It's failing CI and I need to look into that a little more. But I'd like to get this merged as I have a feature for 2.9 which depends on this.
16:21:47 <Qalthos> mrproper: After that, give it a shipit and it should merge quickly
16:21:53 <mrproper> Thanks.
16:22:39 <Qalthos> #topic Meraki unit tests #55251
16:23:47 <mrproper> The PR is failing CI because the import isn't working in Python 2.7 and probably 2.6.
16:24:13 <Qalthos> pabelanger: Do you know anything about this?
16:24:33 <pabelanger> no, first I am hearing of it. do you have a log?
16:24:45 <Qalthos> https://app.shippable.com/github/ansible/ansible/runs/136026/5/tests
16:24:53 <pabelanger> looking
16:25:13 <pabelanger> make this is fall out of recent ansible-test changes?
16:25:26 <pabelanger> we should ask mattclay to look
16:25:56 <Qalthos> He's been reviewing the PR so far
16:26:01 <pabelanger> did python 2.6 ship with mock?
16:26:13 <pabelanger> or do we need python-mock installed vi pip
16:27:10 <mrproper> If mock is implemented different in 2.x, let me know and I'll look into existing examples of how to use it. But I didn't see anything obviously different.
16:27:53 <pabelanger> yah, I think mock is not in python 2.6
16:28:01 <pabelanger> so we need to switch or pip install it
16:28:20 <Qalthos> I honestly don't know. I just `ansible-test <suite> --requirements` and don't really pay attention to what it installs
16:29:04 <pabelanger> yah, lets check with core and see
16:29:13 <pabelanger> been so long since I did 2.6 things
16:29:20 <Qalthos> And while I see some more changes have come out while I was on PTO, I haven't dug into what they were yet
16:31:49 <mrproper> Are one of you two going to talk to core about it? If so, let me know and I can make required changes.
16:36:22 <Qalthos> mrproper: My guess is you need to change `from unittest import mock` to `from units.compat import mock`
16:38:53 <Qalthos> If that isn't the issue, I can get mattclay to give it another look
16:40:47 <mrproper> I'll give it a try tonight.
16:40:50 <mrproper> Thank you.
16:47:17 <Qalthos> #topic Open Floor
16:47:35 <Qalthos> Anyone else want to discuss anything in the last few minutes?
16:51:10 <Qalthos> Alright, then, have a good week everyone
16:51:14 <Qalthos> #endmeeting