16:00:50 <Qalthos> #startmeeting Ansible Network Working Group
16:00:50 <zodbot> Meeting started Wed Sep  1 16:00:50 2021 UTC.
16:00:50 <zodbot> This meeting is logged and archived in a public location.
16:00:50 <zodbot> The chair is Qalthos. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:50 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:00:50 <zodbot> The meeting name has been set to 'ansible_network_working_group'
16:01:12 <Qalthos> #topic Agenda https://github.com/ansible/community/issues/542
16:01:32 <Qalthos> #link https://github.com/ansible/community/labels/network is where the latest agenda can always be found
16:01:44 <Qalthos> #topic Core Updates
16:01:59 <Qalthos> #chair nilashishc
16:01:59 <zodbot> Current chairs: Qalthos nilashishc
16:02:06 <Qalthos> #chair justjais[m]
16:02:06 <zodbot> Current chairs: Qalthos justjais[m] nilashishc
16:04:34 <Qalthos> #info The August releases of supported collections are now out
16:07:23 <Qalthos> #info If I'm reading this right, these releases should also be a part of the latest Ansible 4.5.0 release
16:09:17 <Qalthos> #info September's release will be largely concerned with adding a ntp resource module for platform collections
16:09:28 <Qalthos> Speaking of September
16:09:43 <Qalthos> #info AnsibleFest is coming up at the end of the month
16:10:03 <Qalthos> #link https://www.ansible.com/ansiblefest to register and learn more
16:10:34 <Qalthos> #info It's online, it's free, and I hope to see you there
16:11:21 <wayt> qalthos will that be for all platforms or a subset of the platforms? (ntp)
16:11:56 <wayt> qalthos any comments on the pr i sent to your fork (to update your pr) about docs using real vs documentation prefixes. i still have more fix-up to do as well on that (cisco.asa)
16:13:56 <Qalthos> wayt: it will be for all platforms we directly support for which it makes sense to do so, so eos, ios{,xr}, nxos, junos, vyos
16:14:29 <wayt> cool thanks!
16:16:05 <Qalthos> If you sent it to my fork, I haven't seen it, and probably just broke it this morning by rebasing, sorry. If you want to work with justjais[m] directly to get this fixed, I can cede my PR to your version, I was just trying to get eyes in front of it
16:17:07 <Qalthos> #info Contributor Summit is taking place before and after Fest, so the 28th of September and the 1st of October respectively
16:17:55 <Qalthos> #info The event on the 28th is focused more on onboarding newcomers and getting people more affective at making PRs
16:18:41 <Qalthos> #info The event on the 1st is a traditional Contributor Summit covering the future direction of Ansible
16:19:41 <Qalthos> #link https://hackmd.io/@ansible-community/contrib-summit-202109 to see what's on the schedule and add your own ideas
16:20:23 <Qalthos> I think that's everything I wanted to get through
16:20:33 <Qalthos> #topic Open Floor
16:21:19 <nilashishc> Hey all! I just wanted to quickly add something. The RMEngineBase classes (ResourceModule & NetworkTemplate) have been moved to the `module_utils/network/common/rm_base` directory. These are still backwards compatible but will be removed in a release after 2023-01-01.
16:21:20 <nilashishc> If you are developing Resource Modules that leverage this, please import the classes from the new location.
16:21:20 <nilashishc> https://github.com/ansible-collections/ansible.netcommon/tree/main/plugins/module_utils/network/common/rm_base
16:22:29 <Qalthos> nilashishc: Thanks for the update
16:22:39 <Qalthos> (let me see if I can do this right)
16:22:41 <Qalthos> #undo
16:22:41 <zodbot> Removing item from minutes: <MeetBot.items.Link object at 0x7f631259c4e0>
16:22:43 <Qalthos> #undo
16:22:43 <zodbot> Removing item from minutes: <MeetBot.items.Topic object at 0x7f631262c358>
16:23:00 <sc68cal> dumb question, but is there an e-mail outlining the plans for that? since I have been digging into the arista.eos collection where they use the network resource modules
16:23:02 <Qalthos> #info The RMEngineBase classes (ResourceModule & NetworkTemplate) have been moved to the `module_utils/network/common/rm_base` directory. These are still backwards compatible but will be removed in a release after 2023-01-01.
16:23:23 <Qalthos> #info If you are developing Resource Modules that leverage this, please import the classes from the new location.
16:23:25 <sc68cal> what is going to replace the resource modules, after 2023
16:23:47 <nilashishc> sc68cal the resource modules aren't being replaced.
16:24:21 <sc68cal> Do you mean to say that the old paths for importing those classes will be removed?
16:24:27 <nilashishc> The new resource modules inherit from a set of classes (ResourceModule & NetworkTemplate) which have been moved to a different location.
16:25:27 <sc68cal> ok thanks for the clarification
16:26:49 <Qalthos> #link https://github.com/ansible-collections/ansible.netcommon/tree/main/plugins/module_utils/network/common/rm_base is the new location to import from
16:27:01 <Qalthos> nilashishc: anything else you want in the minutes?
16:27:37 <nilashishc> #info The `cli_rm_builder` has also been updated to import these classes from the new location while scaffolding.
16:28:00 <nilashishc> Qalthos That's pretty much it from my side.
16:28:04 <Qalthos> Cool
16:28:06 <Qalthos> #topic Open Floor
16:28:11 <sc68cal> Qalthos: do you have any suggestions for how to handle https://github.com/ansible-collections/arista.eos/pull/264#issuecomment-910378248 ? I'm hesitant to just spam "neighbor foo 0 mypassword" in every switch config fixture in the arista.eos repo
16:29:59 <wayt> qalthos thanks i'll take care of pushing the cisco.asa doc's pr forward on getting the ip's updated across the board
16:35:46 <Qalthos> sc68cal: I'm assuming you've had a look around the existing tests for the module. You don't need to add your parameter to every test, but adding a unit test that makes sure that the configuration is generated properly is a good start
16:36:14 <sc68cal> re unit testing, that makes sense, it was more around the integration tree
16:41:21 <Qalthos> The integration tests shouldn't be too much harder, as the output of a resource module is almost always a superset of the input
16:42:24 <Qalthos> Assuming everything is working properly, adding a parameter to the input of any of the integration tests (other than deleted) should be sufficient
16:43:24 <Qalthos> If you add it and the test fails, then there's almost certainly some issue with either the command or the fact parsing for that argument
16:43:46 <Qalthos> I hope that makes sense?
16:45:56 <Qalthos> If you need more specific help, GomathiselviS should be able to assist you in the PR
16:46:38 <Qalthos> Anything else that anyone wants to bring up this week?
16:46:43 <sc68cal> thanks Qalthos
16:50:36 <Qalthos> Thanks everyone for coming by today!
16:50:41 <Qalthos> #endmeeting