16:01:31 <akasurde> #startmeeting Ansible VMware Working Group Meeting
16:01:31 <zodbot> Meeting started Mon Mar  5 16:01:31 2018 UTC.  The chair is akasurde. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:31 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:01:31 <zodbot> The meeting name has been set to 'ansible_vmware_working_group_meeting'
16:01:37 <akasurde> Hello Everyone
16:03:48 <dericcrago> hi akasurde
16:03:56 <akasurde> dericcrago, hi
16:04:01 <akasurde> #chair dericcrago
16:04:01 <zodbot> Current chairs: akasurde dericcrago
16:05:43 <akasurde> dericcrago, Would you like discuss anything ?
16:07:07 <dericcrago> I could talk about vm floppy progress
16:07:25 <dericcrago> I think https://github.com/ansible/ansible/pull/35618 kinda stalled out
16:08:33 <kaneda-f_> Hi
16:10:06 <dericcrago> I've also almost got a PR ready for floppy support in vmware_guest, but I think I'm finding a bug in vcsim
16:11:01 <dericcrago> does anyone know if running the same play twice *should* result in "No Change" in vcsim?
16:11:28 <dericcrago> in my test environment it's no change like you would expect, in vcsim it's changed
16:14:23 <akasurde> #chair kaneda-f_
16:14:23 <zodbot> Current chairs: akasurde dericcrago kaneda-f_
16:14:27 <akasurde> kaneda-f_, hi
16:15:19 <akasurde> Generally if you run play twice it should return "No change"
16:15:42 <akasurde> I am not sure, what do you want to know in case of vcsim + playbook ?
16:18:05 <dericcrago> well, I'm trying to add my integration tests for the floppy support on vmware_guest
16:18:32 <dericcrago> and I thought it would be good to add a "doesn't change" test
16:19:01 <dericcrago> although, looking through some of the other integration test files, I'm not sure we've got a doesn't change test
16:35:13 <akasurde> dericcrago, OK
16:40:05 <akasurde> dericcrago, you can submit PR and people can comment on it.
16:41:11 <dericcrago> should I take the "no change" tests out?
16:42:46 <akasurde> dericcrago, I would recommend to keep it
16:43:01 <akasurde> does it happening due to floopy change or something else ?
16:43:50 <dericcrago> that's a good question, I wasn't using it outside of the context of floppy
16:43:51 <dericcrago> one sec
16:47:52 <dericcrago> ok
16:48:06 <dericcrago> it would fail for cdrom too
16:48:30 <dericcrago> if you're checking for "cdrom_vm.changed == false"
16:52:03 <dericcrago> https://paste.fedoraproject.org/paste/9NNPyAWP~YbttOg2~mKsog
16:52:08 <akasurde> I guess because both floppy and cdrom are attached IDE controller
16:52:09 <dericcrago> there's an example
16:53:15 <dericcrago> if you run it cdrom: type: none twice in a row, in your real environment I beleive you'll see "no change" the second time, in vcsim however, it shows changed both times
16:53:31 <akasurde> OK
16:53:43 <akasurde> need to check vcsim side then
16:54:24 <akasurde> If you feel it is bug then raise it we will track it and discuss it over there
16:55:58 <dericcrago> there definitely seems like something going on
16:56:17 <dericcrago> real env, no change, vcsim, change
16:58:06 <akasurde> dericcrago, if it working on real env then we can comment out testcase and saying reason that vcsim does not handle this
16:58:21 <dericcrago> ah, I like that idea
16:58:23 <akasurde> because if it is working in real env that should matter
16:58:37 <dericcrago> good thinking akasurde, I agree
16:59:03 <akasurde> We can always file a bug against vcsim and track it here - https://github.com/ansible/community/wiki/VMware%3A-testing-efforts#unresolved-issues
16:59:06 <akasurde> #info https://github.com/ansible/community/wiki/VMware%3A-testing-efforts#unresolved-issues
17:00:14 <dericcrago> ok, I'll wrap up my PR then and then look at creating a simple example for potentially creating a bug in vcsim
17:00:35 <dericcrago> thanks for the help akasurde and sorry to take up the whole meeting
17:01:15 <akasurde> no problem
17:01:37 <akasurde> dericcrago, sure thanks for help
17:05:10 <akasurde> We are over the time for this meeting.
17:05:23 <akasurde> I will close meeting if we don't have anything else to discuss
17:07:16 <akasurde> #endmeeting