16:00:08 <akasurde> #startmeeting Ansible VMware Working Group Meeting
16:00:08 <zodbot> Meeting started Mon Apr  2 16:00:08 2018 UTC.  The chair is akasurde. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:08 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:00:08 <zodbot> The meeting name has been set to 'ansible_vmware_working_group_meeting'
16:00:14 <akasurde> Hello Everyone
16:01:11 <dericcrago> hi
16:02:28 <akasurde> #chair dericcrago
16:02:28 <zodbot> Current chairs: akasurde dericcrago
16:02:34 <akasurde> dericcrago, hi
16:03:40 <akasurde> dericcrago, we will wait for other people to join
16:03:55 <dericcrago> ok
16:07:33 <akasurde> dericcrago, There are bunch of new modules are laying around in PR list due to lack of reviews
16:07:41 <akasurde> #info https://github.com/ansible/community/wiki/VMware%3A-progress-tracker#new-module-development---link
16:11:33 <dericcrago> do we want to assign specific PRs / people to review? what are the general guidelines for the review process?
16:11:58 <akasurde> There is no guidelines as such for review
16:12:04 <akasurde> people randomly review PRs
16:13:23 <akasurde> pdellaert, tchernomax has done a fantastic job of reviewing lot of my PRs. Thanks to their valuable reviews we are here
16:14:17 <akasurde> We need to increase community interaction around VMware modules
16:19:24 <dericcrago> sure, I think something that would help me is maybe a "guide" or something around reviewing. what are the expectations of a review?
16:20:03 <dericcrago> is the reviewer, just looking at the code, pulling the PR down locally and running / testing it?
16:21:17 <dericcrago> maybe this is already spelled out somewhere or just generally assumed based on past workflows, but for someone new coming in, it might be good to have something that we could point to, "here's how to help"
16:21:45 <akasurde> Make sense
16:22:06 <akasurde> Maybe we should checkout how other SIG are doing the review process
16:22:29 <akasurde> #action Check other SIG for review procedure
16:23:17 <akasurde> #action akasurde Document expectations from review procedure
16:31:25 <dericcrago> akasurde - let me know when you're ready for feedback on the expectations, I can use them as a baseline, try to do some reviews, and see what happens
16:32:25 <akasurde> dericcrago, sure
16:39:06 <akasurde> dericcrago, do you want to discuss anything else ?
16:40:16 <dericcrago> 35618 & 37318 both need a second look
16:40:42 <akasurde> Sure I will do it in this week
16:41:08 <dericcrago> they're not super important, but they're my two PRs for floppy support
16:41:38 <akasurde> Agree.
16:42:03 <dericcrago> what else is there to discuss?
16:46:23 <akasurde> Nothing from my side
16:46:55 <dericcrago> I guess you could say 37318 is kind of important, it's on the list for vsphere_guest deprecation
16:48:40 <akasurde> vsphere_guest is deprecated but it will around for next 4 releases i.e. 2.9 release
16:49:47 <akasurde> I will do testing and review this week and let you know
16:49:59 <dericcrago> right, 37318 is to add floppy support to vmware_guest which is something vsphere_guest had
16:50:20 <dericcrago> 35618 is just adding floppy reconfiguration to vsphere_guest
16:51:17 <akasurde> Cool
16:56:33 <akasurde> If we don't have anything else to discuss, we can close this meeting for now
16:56:39 <akasurde> #endmeeting