16:02:21 <akasurde> #startmeeting Ansible VMware Working Group Meeting
16:02:21 <zodbot> Meeting started Mon Feb 18 16:02:21 2019 UTC.
16:02:21 <zodbot> This meeting is logged and archived in a public location.
16:02:21 <zodbot> The chair is akasurde. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:02:21 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:02:21 <zodbot> The meeting name has been set to 'ansible_vmware_working_group_meeting'
16:02:28 <akasurde> Hello everyone
16:02:49 <xenlo> Hey
16:02:52 <alongchamps> hi
16:03:15 <akasurde> #chair xenlo
16:03:15 <zodbot> Current chairs: akasurde xenlo
16:03:18 <akasurde> #chair alongchamps
16:03:18 <zodbot> Current chairs: akasurde alongchamps xenlo
16:03:32 <akasurde> alongchamps, I saw some weird rebase in your PR
16:03:42 <akasurde> do you need any help ?
16:04:43 <alongchamps> yeah I was trying to rebase it with the libertymutual/ansible fork, I found the article on docs.ansible.com for doing it properly so I need to follow that, https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
16:05:00 <alongchamps> for now I reverted it but I have a shippable test running now on PR 52125
16:05:28 <alongchamps> it's been running for 10 minutes though, which is a lot longer than normal for my one test
16:05:35 <akasurde> yes
16:05:45 <akasurde> because it messed with lot of files
16:05:58 <akasurde> Files changed 1,391
16:06:28 <alongchamps> oh is that because I changed it back on my repo? since I hope I didn't impact the ansible/ansible/devel branch (I don't have permissions on that)
16:06:29 <akasurde> 10k added and 97K removed lines
16:07:02 <akasurde> ansible/ansible/devel is protected and you don't have access
16:07:28 <alongchamps> good, last thing I need for a Monday is to screw something up there :)
16:08:16 <akasurde> yeah, should I fix things for you ?
16:08:39 <alongchamps> sure
16:08:40 <akasurde> I would like to get your PR merged
16:08:44 <akasurde> thanks
16:08:44 <alongchamps> me too!
16:15:52 <adarobin> I'd like some help with PR 49800.  I'm happy to write some tests but I
16:16:04 <adarobin> 've never written any tests for Ansible so I'm not sure where to start
16:16:21 <alongchamps> akasurde: any luck / how is it looking?
16:17:29 <akasurde> adarobin, Hi
16:17:33 <akasurde> #chair adarobin
16:17:33 <zodbot> Current chairs: adarobin akasurde alongchamps xenlo
16:17:40 <akasurde> alongchamps, working ...
16:17:53 <akasurde> adarobin, I checking PR
16:17:55 <alongchamps> thanks
16:17:57 <akasurde> *am
16:19:11 <akasurde> alongchamps, are you ok me creating new PR and closing this one ?
16:19:54 <alongchamps> sure, want me to make a new PR from the libertymutual/ansible repo?
16:19:59 <akasurde> nope
16:20:09 <akasurde> https://github.com/ansible/ansible/pull/52503
16:20:14 <alongchamps> ok
16:20:29 <akasurde> adarobin, I am looking into your PR now
16:22:11 <akasurde> adarobin, Can help me to understand what is difference between vm.summary.customValue and vm.summary.customValue ?
16:22:18 <akasurde> sorry vm.config.extraConfig*
16:23:01 <adarobin> customValue contains annotations for virtual machines
16:23:23 <adarobin> extraConfig contains config options added to the vmx file
16:25:53 <adarobin> vmware_guest_custom_attributes exists to edit vm.summary.customValue already
16:25:56 * akasurde wondering how it was working till this time
16:26:18 <adarobin> it works as it is now, just isn't idempotent
16:26:31 <akasurde> OK
16:26:31 <adarobin> it will always report changed
16:26:36 <akasurde> ah
16:26:48 <adarobin> additionally, there were a few snags in regards to checking for values that should be removed
16:26:59 <akasurde> yup
16:27:03 <adarobin> as you remove a key by setting it's value to ""
16:28:05 <adarobin> I'm trying to implement the CIS-CAT benchmark for ESXi 6.5 virtual machines and this would help greatly in that process :-)
16:28:57 <akasurde> ok
16:29:12 <akasurde> This is wiki page for VMware + Ansible - https://github.com/ansible/community/wiki/VMware
16:29:40 <akasurde> adarobin, VMware tests run on govcsim
16:29:58 <akasurde> you can install and configure govcsim using - https://github.com/ansible/community/wiki/VMware%3A-govcsim
16:31:36 <akasurde> once you have setup you can treat govcsim as a vCenter server and write test something similar as - https://github.com/ansible/ansible/blob/devel/test/integration/targets/vmware_about_facts/tasks/main.yml
16:32:25 <akasurde> since this is related to Vmware_guest - you may want to take reference for this https://github.com/ansible/ansible/blob/devel/test/integration/targets/vmware_guest/tasks/check_mode.yml
16:33:23 <adarobin> So I would be adding a test under https://github.com/ansible/ansible/tree/devel/test/integration/targets/vmware_guest/tasks then?
16:34:02 <akasurde> yup
16:34:38 <akasurde> add an entry in https://github.com/ansible/ansible/blob/devel/test/integration/targets/vmware_guest/tasks/main.yml and write a new file with custom value change
16:35:16 <akasurde> alongchamps, Thanks for the PR
16:35:46 <alongchamps> sure thing! I'm going to try to fix our pull of ansible/devel so it's in sync on libertymutual/ansible/devel
16:36:22 <alongchamps> and after lunch, work on 51240 for vmware_host_firewall_manager for IP addresses
16:37:23 <akasurde> alongchamps, cool
16:38:02 <alongchamps> so QQ on the rebase, git pull --rebase upstream devel will copy down the changes from ansible/ into libertymutual/ as far as I can tell, right
16:38:09 <alongchamps> that's what I want to do so they stay in sync
16:38:24 <alongchamps> our current pull is from 2 weeks ago, so there have been a lot of commits since then
16:38:41 <akasurde> alongchamps, yes
16:38:54 * alongchamps presses enter
16:39:17 <akasurde> command is correct but not sure how you ended in messing with libertymutual/devel
16:39:53 <akasurde> adarobin write a testcase and ping me once you are done
16:40:20 <alongchamps> so via github.com in the browser, I tried to do the rebase then I reverted that so I'm sure it's at least a little out of whack
16:46:14 <alongchamps> I think I'll deal with that after lunch - I'll be back in an hour or so
16:48:17 <akasurde> cool
17:00:17 <akasurde> If there is nothing on agenda then we can end the meeting for today
17:05:37 <akasurde> #endmeeting