16:02:24 <akasurde> #startmeeting Ansible VMware Working Group Meeting
16:02:24 <zodbot> Meeting started Mon Mar 25 16:02:24 2019 UTC.
16:02:24 <zodbot> This meeting is logged and archived in a public location.
16:02:24 <zodbot> The chair is akasurde. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:02:24 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:02:24 <zodbot> The meeting name has been set to 'ansible_vmware_working_group_meeting'
16:02:36 <akasurde> Hello Everyone
16:04:27 <Goneri> hey!
16:04:36 <akasurde> #chair Goneri
16:04:36 <zodbot> Current chairs: Goneri akasurde
16:04:42 <akasurde> Goneri, Hello
16:05:14 <jillr> o/
16:06:41 <akasurde> #chair jillr
16:06:41 <zodbot> Current chairs: Goneri akasurde jillr
16:08:25 <akasurde> Goneri, jillr We generally discuss issues and PRs in this meeting.
16:10:05 <jillr> it appears we have no PRs to review then, if this is still accurate?  https://github.com/ansible/community/issues/417
16:11:12 <akasurde> those are on demand from user/ authos
16:11:20 <akasurde> authors*
16:12:57 <akasurde> https://github.com/ansible/ansible/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+label%3Avmware
16:13:20 <jillr> shall we just start at the top of the list then?
16:13:37 <akasurde> yes sure
16:14:37 <jillr> #topic https://github.com/ansible/ansible/pull/54304
16:17:30 <jillr> looks reasonable enough to me
16:18:15 <akasurde> jillr, this is related to -https://github.com/vmware/vsphere-automation-sdk-python/issues/136
16:18:20 <jillr> yep, saw that
16:18:37 <akasurde> There is issue with VMware documentation which I referred
16:18:56 <jillr> silly question for the newbie - what is the actual merge criteria.  2x +1?  1x +1?  is there auto-merging?
16:19:02 <akasurde> and due to lack for integration test never got caught
16:19:19 <akasurde> Generally 2 x +1
16:19:30 <jillr> cool, ta
16:20:13 <akasurde> jillr, Thanks for review
16:20:34 <jillr> np
16:20:54 <jillr> Goneri: any thoughts on that PR?
16:21:16 <jillr> I dont want us to rush ahead if you've still reviewing
16:21:30 <akasurde> jillr, I merged it :)
16:21:35 <jillr> ah well  :)
16:21:45 <jillr> #topic https://github.com/ansible/ansible/pull/54170
16:22:58 <akasurde> changes logically looks good to me. But I need to test before commenting
16:23:21 <jillr> from a code perspective I agree but yeah, I'm not entirely sure the implications
16:23:48 <akasurde> jillr, Goneri this is kind of PRs we would like to go through CI environment testing
16:23:55 <jillr> totally
16:24:19 <jillr> akasurde: what are we doing now?  would you just stand up a local instance and test manually?
16:24:33 <akasurde> this is related to VMware guest customization and we don't have way to do that in govcsim
16:24:42 <akasurde> yes
16:24:48 <jillr> ack
16:25:07 <akasurde> next PR
16:25:22 <jillr> #topic https://github.com/ansible/ansible/pull/54123
16:27:30 <akasurde> Another example of customization
16:27:56 <jillr> I agree with kobayashi the proposed fix is overly complicated
16:28:55 <jillr> akasurde: FAOD, do you mean like environment-specific customization, or something else?
16:29:39 <jillr> oh, or like guest customizations that govcsim doesnt test?
16:29:56 <akasurde> yes guest customization
16:30:00 <jillr> ic
16:30:15 <akasurde> add your comments in PR
16:32:25 * jillr tries not to grumble that gh doesnt work exactly like gerrit and flails at the ui  ;)
16:32:39 <jillr> #topic https://github.com/ansible/ansible/pull/53976
16:34:31 <jillr> lgtn
16:34:36 <jillr> *lgtm
16:35:07 <jillr> akasurde: so with 2 reviews, will this automerge?
16:37:14 <akasurde> yes
16:37:35 <jillr> #topic https://github.com/ansible/ansible/pull/53632
16:39:40 <akasurde> Code LGTM
16:39:54 <akasurde> I need to test this before we can merge/
16:40:06 <akasurde> #action akasurde test #53632
16:40:24 <jillr> thx, I'll let that to you then, I'm still wrapping my head around it
16:40:59 <akasurde> if you have vcenter 6.7 then you can reproduce the issue and check the fix as well
16:40:59 <jillr> #topic https://github.com/ansible/ansible/pull/53523
16:41:05 <jillr> ah cool
16:45:01 * akasurde looking
16:46:58 <jillr> code seems reasonable, and the requestor reports it working, so I suppose that wfm
16:48:26 <akasurde> yes, I am waiting for jeking3 to comment again
16:48:49 <jillr> do we want to put this on hold for them?
16:49:38 <jillr> ah just saw your comment, ok
16:49:52 <jillr> #topic https://github.com/ansible/ansible/pull/53321
16:52:09 <akasurde> jillr, for this PR, I would like to request PR author to create a new module
16:52:46 <akasurde> little background here, vmware_guest is heavily loaded with features and it is very difficult to manage this module now,
16:53:23 <akasurde> so we decided in (IRC meetings) to stabilize existing features and moving all new features to modules
16:53:33 <jillr> that makes sense
16:54:01 <akasurde> for example, vmware_guest_vnc, vmware_guest_disk, and new vmware_guest_network
16:54:20 <akasurde> this way we can manage individual features efficiently
16:54:53 <akasurde> I will comment accordingly
16:55:33 <jillr> ok thanks
16:57:28 <akasurde> jillr, I have another meeting so we will close this meeting for now.
16:57:50 <jillr> akasurde: sounds good, thanks o/
16:58:01 <akasurde> thanks jillr Goneri
16:58:04 <akasurde> #endmeeting