15:59:23 #startmeeting VMware Working Group meeting 15:59:23 Meeting started Mon Dec 9 15:59:23 2019 UTC. 15:59:23 This meeting is logged and archived in a public location. 15:59:23 The chair is Goneri. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:59:23 Useful Commands: #action #agreed #halp #info #idea #link #topic. 15:59:23 The meeting name has been set to 'vmware_working_group_meeting' 15:59:36 #chair jtyr 15:59:36 Current chairs: Goneri jtyr 16:02:39 #chair akasurde 16:02:57 * akasurde bot didn't like my command 16:04:17 #chair akasurde 16:04:17 Current chairs: Goneri akasurde jtyr 16:04:19 :-) 16:04:32 #topic https://github.com/ansible/community/issues/423#issuecomment-560460206 16:05:11 #topic https://github.com/ansible/ansible/pull/63741 16:05:26 first one is Don't search for VMDK if filename is defined #63741 16:05:31 I am OK merging 16:05:45 that was fast :-) 16:06:39 Merged, thank you jtyr for the PR! 16:06:50 #topic https://github.com/ansible/ansible/pull/63740 16:06:53 next 16:07:21 Adding filename and destroy options to vmware_guest_disk #63740 16:08:40 I was not really convinced by the 'destroy' key name 16:08:47 same here 16:09:07 I would prefer something like 'detach' 16:10:35 also, can this be parted by two PRS ? 16:10:49 easy to revert ;) 16:10:53 yes, agreed. 16:11:33 jtyr, does this work for you? 16:12:18 what's PRS? 16:12:43 pull requests == PRS 16:12:54 otherwise 'detach' key is not capturing what that option is doing. 16:12:54 sorry for short form 16:13:05 jtyr, oh sorry, yes it's Github standard jargon 16:13:31 PRs would be better to use... 16:13:48 I thought that PRS is some VMware functionality ... ;o) 16:13:53 jtyr, 'destroy' sounds like (to me) we will clean up the file on the filesystem. 16:14:15 this is exactly what it does ... 16:14:20 Goneri, yes 16:14:25 it is destroying the File 16:14:26 :palmface: 16:14:34 I understood the opposite 16:14:46 it does what it says ... 16:14:49 ok, so then, please ignore all the things I said during the last 5 minutes 16:15:40 then, the PR needs a more formal review, but I'm fine with the idea. 16:17:02 jtyr, are you ok with create a separate PR for each change ? or those changes are interlinked ? 16:17:15 pardon me, if I am missing something here 16:17:53 they are interlinked ... 16:18:03 you need filename to remove the file ... 16:21:11 "The first option (destroy) allows to remove a disk without deleting the VMDK file." 16:21:19 I'm actually still confused by the sentence 16:21:44 it removes the disk from the VM, but the disk remains in datastore? 16:23:25 destroy=yes ... remove disk from the datastore; destroy=no ... keep in in the datastore 16:24:55 thanks for the clarification 16:25:03 can we continue to the next PR? 16:25:55 I'm trying to test the last PR with hot add options enabled ... 16:26:21 #topic https://github.com/ansible/ansible/pull/65429 16:28:47 jtyr, is there anything to clarify on this PR? 16:29:01 I'm getting: "msg": "Invalid virtual machine configuration.", "op": "reconfig" 16:29:15 CPU and MEM hot adding enabled ... when VM is powered on ... 16:29:34 trying to increase memory only ... 16:30:17 changing CPU works 16:30:58 sounds like a but to me, this should work seamlessly. 16:31:13 yeah ... it should ... ;o) 16:32:58 so should I change the text from: "...the VM must be powered off and the..." to: "...the VM must be powered off unless hot adding features are enabled and the..." 16:34:57 or even better: "...the VM must be powered off unless the hot-add support are enabled and the..." 16:35:31 yes, it sounds way better to me 16:35:46 OK, changing now ... 16:35:55 :-) 16:37:36 anything else to cover? 16:38:18 #topic https://github.com/ansible/ansible/pull/65663 16:38:56 change pushed for PR #65429 16:39:46 so what about the #63740 16:40:06 do you want to discuss it next week again? ;o) 16:41:17 akasurde, I've just approved your PR 16:41:30 Goneri, thank 16:41:32 Goneri, thanks 16:41:33 jtyr, for https://github.com/ansible/ansible/pull/63740, I need to test the PR and do a proper review 16:41:49 jtyr, this is not something I want to do during a meeting, since it takes a bit of time. 16:42:19 jtyr, but I've assigned the PR to myself and I will take a look 16:43:13 I just that we are discussing it already 3 weeks ... ;o) 16:44:31 it will be done before xmas :-) 16:44:34 hi pbidkar 16:44:49 Hi Goneri 16:44:51 #topic CI 16:45:10 I've enabled a new CI job last friday 16:46:02 https://groups.google.com/forum/#!searchin/ansible-devel/vmware%7Csort:date/ansible-devel/-c88lDtZ3vI/-O4XD5b9AgAJ 16:46:17 this post explains all the details of the new job 16:46:41 basically, we now test some of the modules against a REAL vmware environment, Vs govcsim. 16:46:57 this will help us to spot regression/problem before we merge PR. 16:47:19 and the next step is to integrate an additional job to cover the remaining modules :-) 16:48:09 Can I close the meeting, or do with have anything else to cover? 16:48:38 I'm waiting for the CI to finish for PR #65429 16:48:44 so you can merge it ;oP 16:49:05 #endmeeting