20:00:17 <jborean93> #startmeeting Ansible Windows Working Group
20:00:17 <zodbot> Meeting started Tue Apr 17 20:00:17 2018 UTC.  The chair is jborean93. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:00:17 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
20:00:17 <zodbot> The meeting name has been set to 'ansible_windows_working_group'
20:00:26 <jborean93> #chair jhawkesworth_
20:00:26 <zodbot> Current chairs: jborean93 jhawkesworth_
20:00:28 <nitzmahone> o/
20:00:30 <jhawkesworth_> hey
20:00:38 <jborean93> #chair nitzmahone
20:00:38 <zodbot> Current chairs: jborean93 jhawkesworth_ nitzmahone
20:01:02 <jborean93> hey all
20:01:14 <jborean93> give it a few more minutes to see if anything else turns up
20:01:22 <jhawkesworth_> cool
20:03:43 <jborean93> looks like it is just us today
20:03:47 <jborean93> #topic open floor
20:03:57 <jborean93> Ansible 2.5.1 is just round the corner which is great
20:04:04 <jborean93> Anything anyone wants to share or ask?
20:04:05 <nitzmahone> Yep, should be tomorrow
20:04:13 <nitzmahone> Nothing from me
20:04:42 <jhawkesworth_> cool.  I gave up trying to get my fix for \r line endings in custom modules in to 2.5.1 - merge conflicts
20:05:01 <jhawkesworth_> can live without it
20:05:02 <jborean93> Do you still have the old PR link handy?
20:05:14 <jhawkesworth_> should do, hang on
20:05:19 <jborean93> I will probably hold off until 2.5.1 is out but would be good to get in after
20:05:23 <jborean93> I can take a stab at it
20:06:02 <jhawkesworth_> its this one.  https://github.com/ansible/ansible/pull/37291
20:06:24 <jborean93> thanks, will try it out after nitzmahone releases 2.5.1
20:06:28 <jhawkesworth_> the code smells were ported from bash to python aroudn the same time
20:06:41 <jhawkesworth_> thank you
20:06:47 <jborean93> it may just need a manual PR to 2.5 but will see how it goes
20:07:26 <jhawkesworth_> its probably doable but I don't use git much, ran out of confidence that I was doing the right thing
20:08:38 <jborean93> that's ok, cherry-picking isn't really fun. Especially when you have conflicts, I usually bang my head against the wall a few times myself
20:10:06 <jhawkesworth_> I haven't had much time to tackle ansible windows bugs/prs recently as I've been trying to tech review a book that walks through building a share point farm using packer, ansible, vagrant, serverspec.
20:10:29 * jborean93 shudders at the mention of sharepoint
20:11:05 <jborean93> cool, if that's it we might bring it to a close
20:11:18 <nitzmahone> Heh, I think the author of that book mentioned that to me at a conference or meeting somewhere
20:11:24 <nitzmahone> I'm good to go
20:11:37 <jhawkesworth_> yeah gregdek put me in touch with the guy
20:11:56 <jhawkesworth_> yep, I'll let you get on, don't want to hold up 2.5.1 with chat
20:12:51 <nitzmahone> Doesn't seem to slow anyone else down ;)
20:13:06 <jborean93> sounds good, thanks for your time
20:13:10 <jborean93> #end meeting
20:13:14 <jborean93> #endmeeting