20:00:58 <nitzmahone> #startmeeting Ansible Windows Working Group
20:00:58 <zodbot> Meeting started Tue Feb 12 20:00:58 2019 UTC.
20:00:58 <zodbot> This meeting is logged and archived in a public location.
20:00:58 <zodbot> The chair is nitzmahone. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:00:58 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
20:00:58 <zodbot> The meeting name has been set to 'ansible_windows_working_group'
20:01:10 <it-praktyk[m]> hi
20:01:18 <jhawkesworth_> hey
20:01:26 <caco> @nitzmahone: ill ask after the meeting. have thoughts on what you just said
20:01:47 <nitzmahone> #chair it-praktyk[m] jhawkesworth_
20:01:47 <zodbot> Current chairs: it-praktyk[m] jhawkesworth_ nitzmahone
20:02:08 <nitzmahone> you guys and your special-characters-included nicks make me crazy ;)
20:02:28 <nitzmahone> #info agenda: https://github.com/ansible/community/issues/420
20:02:44 <jhawkesworth_> irccloud 'gave' me the _ and I'm too lazy to get rid of it
20:03:20 <nitzmahone> I think Jordan's out this morning, so I guess let's just get started
20:03:38 <it-praktyk[m]> it's a power efficiency not laziness ;)
20:03:58 <jhawkesworth> there, gone
20:04:15 <jhawkesworth> laziness is a programmer virtue
20:04:16 * nitzmahone won't really start complaining until non-printing chars and high unicode chars start showing up ;)
20:04:19 <jhawkesworth> anyway
20:04:36 <jhawkesworth> are we starting here: https://github.com/ansible/community/issues/420#issuecomment-462125577 ?
20:04:45 <nitzmahone> #topic * https://github.com/ansible/ansible/pull/50033
20:04:50 <nitzmahone> (backup arg on modules)
20:05:46 <jhawkesworth> ok
20:05:53 * jhawkesworth catching up
20:06:06 <jborean93> Hey I will be in and out, just on my mobile for now
20:06:08 <nitzmahone> I'm +1 for merge at this point; it's passing tests and I think all the current feedback has been incorporated
20:06:20 <nitzmahone> #chair jborean93 jhawkesworth
20:06:20 <zodbot> Current chairs: it-praktyk[m] jborean93 jhawkesworth jhawkesworth_ nitzmahone
20:06:31 <nitzmahone> Anybody else have objections?
20:06:52 <chopraaa> +1
20:07:03 <jhawkesworth> no objections.
20:07:15 <jborean93> the only objection I still have is the win_copy behaviour around backup
20:07:24 <jborean93> I believe dag said he was going to investigate
20:08:00 <nitzmahone> jborean93: this? https://github.com/ansible/ansible/pull/50033/commits/15ee38f447658d57c6f9ca9412e8f0b4808bde21
20:08:42 <jhawkesworth> unless I've missed something win_copy got fixed
20:08:57 <jborean93> yep, there was an outstanding question around how that works with the 3 different win_copy modes, control -> remote (single file), control -> remote (multi file), remote -> remote (any)
20:09:05 <jhawkesworth> ah yeah I see it now
20:09:16 <jborean93> I believe it works for everything except the middle one and dag was going to see how copy operated
20:09:34 <jhawkesworth> i only tried single file
20:10:16 <nitzmahone> I looked at multi-file a bit ago and it looked like it would do the right thing, but I didn't actually try it
20:10:23 <jborean93> for the testing side I can follow up on making it a bit more efficient and fix the localisation requirements, dag's done enough
20:10:26 <nitzmahone> (as I had a similar question)
20:10:40 <nitzmahone> OK- I'll make that note on the PR
20:10:49 <jborean93> AFAIK multi file just "explodes" from the zip and doesn't use the methods he's current;y changed
20:11:53 * jborean93 back at my desk
20:12:09 <nitzmahone> https://github.com/ansible/ansible/pull/49701
20:13:10 <jborean93> we went through that and said it can't be looked at until pywinrm has been updated
20:13:23 <nitzmahone> yeah, was gonna say that doesn't look quite right
20:13:23 <jborean93> same with     * [25532](https://github.com/ansible/ansible/issues/25532)
20:14:00 <jborean93> and at that point pywinrm was thought to be mostly dead in the water feature wise
20:14:12 <nitzmahone> https://github.com/ansible/ansible/pull/45870
20:14:46 <jborean93> just needs validation, I think jhawkesworth was going to test it out
20:14:58 * jborean93 looks he has already :)
20:14:58 <nitzmahone> he did everything but hyper-v
20:15:30 <jborean93> yea I can try and test out a hyper-v host today or tomorrow
20:15:52 <jhawkesworth> I have hyper-v installed but so far not managed to get any vms running in it
20:16:11 <jborean93> you can use Vagrant to set one up easily
20:17:27 <jhawkesworth> not sure if this is still the case but it used to be you could either run hyper-V or virtualbox virtualisation but not both on the same box.
20:17:41 <nitzmahone> I don't think we're going to do the upstream releases necessary for https://github.com/ansible/ansible/issues/25532 right now
20:17:55 <jborean93> yea that's the same as the read_timeout PR
20:18:14 <jborean93> psrp has it included though so there's some avenue to set that
20:18:19 <jhawkesworth> that's fair enough
20:18:23 <nitzmahone> https://github.com/ansible/ansible/pull/50759
20:19:01 <it-praktyk[m]> it's related to the point that to agenda that I asked
20:19:12 <jborean93> I not a big fan of updating dependencies in the background but it seemed like we did that in the test so  it's not a change
20:19:16 <it-praktyk[m]> updating PackageManagement and PowerShellGet
20:19:33 <jborean93> really a question as to whether we do it or get the user to, it doesn't seem that bad though so I'm ok with the PR
20:19:43 <it-praktyk[m]> What do you think about adding an additional switch
20:20:00 <it-praktyk[m]> updating that dependencies is necessary
20:20:21 <jborean93> I think that's probably a bit too much, considering the simplicity of updating the dep right now I'm ok with it, it's just not ideal
20:20:35 <jborean93> but MS would have no needed an updated dep in an ideal world
20:20:58 <it-praktyk[m]> World is not ideal
20:21:03 <nitzmahone> I think we can implement a tinfoil-hat mode in the future if people request it, but I'm OK with it as-is
20:21:36 <jborean93> yea, +1 to me. A user cna always update before if this step fails at least we try and make it easier for users
20:22:11 <nitzmahone> OK, merging
20:22:24 <it-praktyk[m]> thx
20:22:34 <jhawkesworth> nice
20:23:17 <nitzmahone> https://github.com/ansible/ansible/pull/50808
20:23:32 <nitzmahone> hrm, are those our S3 buckets?
20:23:42 <jborean93> yep I uploaded them
20:23:45 <it-praktyk[m]> yes
20:24:04 <nitzmahone> +1 for this then as well
20:24:12 <jhawkesworth> seems to have conflicts now
20:24:24 <jhawkesworth> perhaps due to merge just done
20:24:43 <nitzmahone> yeah, probably- if you want to fix those it-praktyk[m] we can get it merged
20:24:52 <it-praktyk[m]> I'll update that
20:24:58 <jhawkesworth> I'm in favour of having this
20:25:23 <it-praktyk[m]> I'll do that :)
20:25:30 <nitzmahone> thanks!
20:25:45 <nitzmahone> #topic: win_format idempotency
20:26:07 <nitzmahone> chopraaa?
20:26:20 <chopraaa> hey
20:26:22 <jborean93> did we talk about this last week and forgot to update the agenda?
20:26:36 <chopraaa> yeah we talked about this - plus i didnt really get around to it
20:26:39 <chopraaa> busy week
20:26:55 <jborean93> no worries, did you get what you wanted from last week or is there more you want to talk about?
20:27:04 <chopraaa> yep
20:27:46 <chopraaa> decided to format where it was detected to be safe - otherwise require a force param
20:28:02 <nitzmahone> ok, cool
20:28:04 <nitzmahone> #topic https://github.com/ansible/ansible/pull/51986
20:28:10 <chopraaa> safe as in unformatted partitions
20:28:32 <jborean93> I'm ok with supporting checksums, not sure if we want to follow the same module options as get_url
20:28:43 <jborean93> never liked the algo:hash format but that's just me
20:29:20 <nitzmahone> you'd rather discrete subdict or ?
20:29:59 <jborean93> either that or 2 options like we do with win_stat
20:30:10 <jborean93> but now that would be going against what get_url does
20:30:26 <jborean93> Apart from that I haven't actually gone to review the code
20:30:35 <nitzmahone> wow, big changes
20:30:37 <jborean93> so I want the feature but I haven't really looked at it too much
20:30:42 <jborean93> yea that's a bit worrying
20:31:52 <nitzmahone> k, not gonna code review this live- anyone else have an opinion on the checksum UI support for win_get_url?
20:32:25 <jhawkesworth> nice to have.  I suspect path of least resistance is to keep ui same as get_url for now...
20:32:36 <jborean93> my vote is `checksum_algorithm` and `checksum` as 2 options but I'm not married to it
20:32:44 <jhawkesworth> ... although I prefer the stat/win_stat way, that could be different
20:33:27 <jhawkesworth> i guess it wasn't there before, might as well have `checksum_algorithm` and `checksum`
20:33:37 <jhawkesworth> which just leaves get_url as outlier
20:33:56 <nitzmahone> +1 to discrete args- if anyone complains loudly we can add support for the algo:sum to checksum later
20:33:57 <jhawkesworth> could be retrofitted there and deprecated over time
20:34:13 <jborean93> yep, I just hate splitting values and then validating
20:34:28 <jhawkesworth> makes ugly module code for sure!
20:34:28 <jborean93> if we have discrete args we can build the checks in the module arg spec for cleaner documentation
20:35:19 <jhawkesworth> yep, worth asking for as part of this PR then I think
20:35:36 <nitzmahone> OK, will comment as such, though it also feels like the impl is overwrought at first glance
20:37:46 <nitzmahone> is this a similar thing to the Nuget provider update  https://github.com/ansible/ansible/pull/50621#discussion_r249645345 ?
20:38:18 <it-praktyk[m]> that exactly the same case
20:40:52 <nitzmahone> so on that specific question, same answer I guess- default to updating what's necessary and implement a "paranoid" switch later that skips the updates and fails instead if people want it
20:41:20 <nitzmahone> #topic open floor
20:41:23 <it-praktyk[m]> I'm OK with that
20:41:46 <it-praktyk[m]> NuGet was previously updated - since the initial version of the win_psmodule
20:42:36 <nitzmahone> Anything else burning for today?
20:43:10 <jhawkesworth> not from me
20:43:21 <it-praktyk[m]> https://github.com/ansible/ansible/pull/50808 - rebased, will be ready for merge after CI tests
20:44:35 <nitzmahone> cool, should auto-merge after tests pass
20:45:00 <nitzmahone> OK, if nothing else, closing in 5..
20:45:03 <nitzmahone> 4..
20:45:06 <nitzmahone> 3..
20:45:09 <nitzmahone> 2..
20:45:10 <nitzmahone> 1..
20:45:13 <jhawkesworth> let nitzmahone get his lunch
20:45:15 <nitzmahone> Thanks all- until next week!
20:45:23 <jhawkesworth> thanks
20:45:25 <it-praktyk[m]> thx
20:45:31 <nitzmahone> jhawkesworth: ;)
20:45:33 <nitzmahone> #endmeeting