20:02:05 <nitzmahone> #startmeeting Ansible Windows Working Group
20:02:05 <zodbot> Meeting started Tue Jun  4 20:02:05 2019 UTC.
20:02:05 <zodbot> This meeting is logged and archived in a public location.
20:02:05 <zodbot> The chair is nitzmahone. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:02:05 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
20:02:05 <zodbot> The meeting name has been set to 'ansible_windows_working_group'
20:02:08 <blah__> hello, I linked my PR in the meeting ticket so that it can be discussed :)
20:02:18 <nitzmahone> #chair jhawkesworth jborean93
20:02:18 <zodbot> Current chairs: jborean93 jhawkesworth nitzmahone
20:02:26 <jborean93> hey
20:02:36 <jhawkesworth> heya
20:03:12 <blah__> https://github.com/ansible/ansible/pull/56445
20:03:16 <blah__> the PR in question :)
20:03:56 <blah__> jhawkesworth: I see that you did some reviewing already (just noticed now)
20:04:10 <jhawkesworth> yeah, just a minor documentation thing
20:04:48 <jhawkesworth> i'm still trying to work out how I feel about the implementation.  Just wish there was a decent powershell way to modify it.
20:04:59 <blah__> me too...
20:05:07 <jhawkesworth> tbh we use a service manager so it isn't something I'd use myself.
20:05:22 <blah__> I tried looking at implementing the Win32 API, but couldn't wrap my head around it (also didn't have enough time for that)
20:05:52 <jhawkesworth> best link I found about it is this one: https://stackoverflow.com/questions/53009043/how-to-change-windows-service-recovery-option-using-c-sharp
20:06:00 <blah__> I added this feature because we use it to provision services on VMs in my company
20:06:04 <jhawkesworth> but can't say I've got my head round it fully either
20:07:11 <jborean93> I'm hoping to have a look at this at some point but I've been backlogged with a few other things so it may be a week or 2 before I get to it sorry
20:07:32 <clcaldwell> It might be useful to take a look to see how services are managed in the DSC resources to see if they are doing it the same way (reg keys) or if they have a better solution in place
20:07:33 <blah__> I mean, if, ultimately, no one is satisfied enough, I can withdraw the PR, no problem
20:07:44 <nitzmahone> Same, trying to dig out from some other stuff
20:08:14 <blah__> no problem guys, I figured as much, that's why I joined this meeting to touch base :)
20:08:17 <jborean93> it's good functionality to have, I might eventually convert over to the Win32 API but alas time is the devil here
20:08:24 <nitzmahone> I guess the real question is if we want this as an interim experimental option that we could replace with a PInvoke impl later (if necessary)
20:09:09 <jhawkesworth> my worry is that its particularly fragile as it depends on sc.exe not changing and also the registry stuff (which also needs hex conversion).
20:09:55 <jhawkesworth> as long as it doesn't bust existing functionality I could live with it - I think the parameters interface is ok now
20:10:24 <nitzmahone> Yeah, at a glance the UI looks fine now (once updated to use `choices` anyway)
20:10:27 <jborean93> if the tests pass I'm probably fine with it. It shows while it's not documented it is somewhat stable-ish and can tie us over. But would need to research a bit more before officially saying that
20:10:46 <blah__> I'd argue that it has been working like this for a while (on the Windows side), so I'm not sure that's something that'd change soon, that also moght be why it was never implemented in Powershell directly by them
20:10:51 <jhawkesworth> win_service is something I really want to be bullet proof though as I can imagine it gets a lot of use
20:11:14 <nitzmahone> We shouldn't do any sc.exe messing around in the module itself, but would be good in the tests if we had a little for validating basic functionality
20:11:30 * jborean93 just like inet proxy settings, everyone goes through the registry but that has weird side effects across versions
20:11:38 <blah__> I tested as much as I could, and I created the test so that they're relevant to the functionality itself
20:12:42 <blah__> clcaldwell: https://docs.microsoft.com/en-us/powershell/dsc/reference/resources/windows/serviceresource Are you refering to this?
20:12:51 <nitzmahone> Since the UI's pretty dialed-in and the impl is pretty self-contained, I'm leaning toward let's polish it up, and if we have a lot of demand/issues, upgrade to a PInvoke impl later
20:13:20 <nitzmahone> (that should've been *polish it up and merge)
20:14:21 <clcaldwell> @Blah_ Yes, almost all of the DSC resources are in Github. Not sure if the have any recovery options in their resources, though
20:14:36 <nitzmahone> Yeah, I didn't see any
20:14:55 <nitzmahone> Anybody object strongly to that approach?
20:15:10 <jhawkesworth> No objection from me.
20:15:43 <jborean93> all good from me
20:15:48 <nitzmahone> OK- so blah__ - sounds like we'll keep working toward a merge. I'll try to give your latest changes a once-over and see if there's anything else we need... Thanks for that!
20:16:06 <nitzmahone> (it'll probably be later this week or next though- lots happening right now)
20:16:07 <jhawkesworth> yeah thanks for your work on it
20:16:44 <jhawkesworth> should we let jborean93 and nitzmahone get back to it then?  Or does anyone else have anything they want to raise?
20:16:56 <blah__> clcaldwell: This is a bit lacking though: https://github.com/PowerShell/PSDscResources/blob/3791600924213f9b410ab41cd7582aad93310949/DscResources/ServiceSet/ServiceSet.schema.psm1
20:17:22 <nitzmahone> Nothing from me- 2.8.1 probably coming this week
20:17:31 * jborean93 party
20:17:39 <blah__> thank you for your time guys :)
20:17:40 <nitzmahone> 2.9 release/freeze schedules are getting dialed in, should probably be public next week
20:17:41 <jhawkesworth> great
20:17:50 <jhawkesworth> good to know
20:18:03 <blah__> I'll update the .py file following the suggestions and I'll wait for your feedback sometime this month
20:18:19 <nitzmahone> Sounds good!
20:18:29 <nitzmahone> OK, if nothing else, we'll wrap up in 5..
20:18:34 <nitzmahone> 4..
20:18:38 <nitzmahone> 3..
20:18:38 <jhawkesworth> nothing from me
20:18:41 <nitzmahone> 2..
20:18:45 <nitzmahone> 1..
20:18:56 <nitzmahone> 'til next week- thanks all!
20:18:59 <nitzmahone> #endmeeting