20:00:03 <jborean93> #startmeeting Ansible Windows Working Group
20:00:03 <zodbot> Meeting started Tue Jul  9 20:00:03 2019 UTC.
20:00:03 <zodbot> This meeting is logged and archived in a public location.
20:00:03 <zodbot> The chair is jborean93. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:00:03 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
20:00:03 <zodbot> The meeting name has been set to 'ansible_windows_working_group'
20:00:09 <jborean93> o/
20:00:46 <jhawkesworth> hey
20:01:08 <jborean93> hey
20:01:14 <jborean93> #chair jhawkesworth
20:01:14 <zodbot> Current chairs: jborean93 jhawkesworth
20:01:27 <jborean93> Matt's in the middle of something so it's just me today
20:01:32 <jborean93> thanks for the web util review as well
20:02:09 <jhawkesworth> you're welcome.  I was just trying to catch up.  Nice piece of work.
20:02:10 <jborean93> give it a few more minutes to see if anything else will join
20:02:23 <jhawkesworth> sure
20:03:39 <jhawkesworth> I will try to test the webutil PR later in the week using my azure standup playbooks.
20:03:51 <jhawkesworth> I don't use win_uri so it will be rather one-sided
20:04:21 <jborean93> that's ok, I tried to test things out myself but considering it's now the same code, what works for win_get_url should also work for win_uri
20:04:35 <jborean93> My only concern with the PR is if the interface is too complicated right now
20:05:03 <jborean93> I was trying to make something flexible which just handles the setup side and that's what I ended up with
20:05:24 <jhawkesworth> I haven't fully got my head round the script block stuff yet, but its not a totally alien pattern
20:06:07 <jborean93> We can always add a helper Get-File or something that does the generic download to path cmdlet if we like
20:06:16 <jhawkesworth> its a bit unfortunate that the module params are split between the util and the modules themselves but better than copy pasting them (I can't think of a better way)
20:06:17 <jborean93> win_get_url and win_uri just do different things with the overall request
20:06:33 <jborean93> that's mostly so modules can still use it and explicitly pass in the params themselves
20:06:59 <jborean93> or ar eyou talking about the actual param definition for Ansible.Basic?
20:07:42 <jborean93> looks like it is just us so not really worth going through the agenda. Is there anything you would like to talk about regardless?
20:08:03 <jhawkesworth> just that there are now two places  you have to look to see the module parameter definitions.  Its not a big issue
20:08:14 <jborean93> ah I see what you mean
20:08:43 <jborean93> the fact that we now have validation for modules using the newer wrapper should make that less of an issue. The online docs, or `ansible-doc` should always be correct
20:09:24 <jhawkesworth> yeah, there's less need to poke around the module code these days now anyway.
20:10:18 <jhawkesworth> I don't think I have anything specific to talk about this week, just came to see if I can help out with whatever folks want reviewed
20:10:46 <jborean93> cool, I'm sure there are lots of PRs ready :) They seem to be popping up like crazy
20:11:17 <jhawkesworth> yeah my inbox is 99% github notifications
20:12:55 * jhawkesworth looks at agenda anyway
20:15:03 <jhawkesworth> I think I'd want a different module to tackle https://github.com/ansible/ansible/issues/49828 - verify_connection or something.
20:15:22 <jborean93> either that or a specific state
20:15:43 <jhawkesworth> it doesn't strike me as that useful _just_ to check you can connect though
20:16:21 <jborean93> wait_for_connection was purely designed to wait until the connection is available in an Ansible sense. I can see the use case here but the majority of the times I've used this was around things like waiting for it to join the domain and I'm connecting with domain creds
20:16:25 <jhawkesworth> so no real advantage to have something specific over just running win_shell
20:16:52 <jborean93> also it's hard to differentiate between bad creds and other issues as a 401 can mean a lot of things when it comes to WinRM but that's not a big issue
20:16:55 <jhawkesworth> yeah I use to it wait for vmware and azure to finish making vms
20:20:06 <jborean93> cool, if there is nothing else, I'll give us back our 40 minutes to do other fun things :)
20:20:19 <jhawkesworth> yep, I'll let you get on.
20:20:40 <jborean93> awesome, have a good one
20:20:44 <jborean93> #endmeeting