19:59:59 <nitzmahone> #startmeeting Ansible Windows Working Group
19:59:59 <zodbot> Meeting started Tue Jul  5 19:59:59 2022 UTC.
19:59:59 <zodbot> This meeting is logged and archived in a public location.
19:59:59 <zodbot> The chair is nitzmahone. Information about MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions.
19:59:59 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
19:59:59 <zodbot> The meeting name has been set to 'ansible_windows_working_group'
20:00:03 <nitzmahone> doh
20:00:04 <briantist> yo
20:00:08 <nitzmahone> #chair jborean93
20:00:08 <zodbot> Current chairs: jborean93 nitzmahone
20:00:17 <nitzmahone> yay for no ill-timed netsplits this week :D
20:00:25 <nitzmahone> #info agenda https://github.com/ansible/community/issues/644
20:00:34 <nitzmahone> #topic https://github.com/ansible-collections/community.windows/issues/394
20:00:53 <nitzmahone> (migrating windows module dev docs)
20:01:18 <jborean93> I did see that and have been quite slack at responding
20:01:25 <nitzmahone> briantist: anything we need to talk about for this one? Also wondering if ansible.windows makes more sense- not sure what the upstream/downstream docs implications are (if any)
20:01:59 <briantist> that's what I was suggesting yeah, that the module development guide, if it's to be removed from core, probably makes more sense in `ansible.windows`
20:02:20 <briantist> I don't think the docs folks will care which one it is, but that seems better to me
20:02:56 <briantist> and in either case, I'm happy to actually put the guide in place if that's helpful
20:03:02 <jborean93> a.w definitely sounds better
20:03:08 <nitzmahone> I'll chat with samcann about that to see if there's a preference
20:03:36 <nitzmahone> I know there are $things happening with downstream docs, but dunno if it makes any difference to those things where the community docs live
20:03:39 <briantist> sure, we can also discuss in the next DaWGs
20:04:38 <nitzmahone> Oh, I guess she's on PTO all week, so maybe next week
20:04:44 <briantist> jborean93: any objection to merging https://github.com/ansible-collections/community.windows/pull/391 ?
20:05:01 <jborean93> no, will do so
20:05:07 * jborean93 didn't realise nitz approved it
20:05:19 * nitzmahone is sneaky like that
20:06:05 <briantist> ok thanks! https://github.com/ansible-collections/community.windows/pull/392 is the follow up, we could give the stuff from 391 a week or so before pulling the trigger on that I suppose?
20:06:19 <jborean93> definitely need to do another pass through on the collections, will look at 392 when I do get to that
20:06:53 <briantist> I'll also put up a clone of #391 & #392 on `a.w` at some point so they're ready to go if all is going well
20:08:48 <briantist> in other news I opened https://github.com/ansible-collections/community.windows/pull/411 yesterday, but it's in early stages.. I'm glad I started with the tests on this one.. because I can't get the scenario that's expected to fail to actually fail... so I need to look a little closer at what's going on
20:09:18 <nitzmahone> *sigh* why does MS feel the need to assert clickthru licenses like this at runtime
20:09:38 * nitzmahone glares at the `ACCEPT_EULA=1` envvar for SQL Server containers...
20:09:49 <jborean93> PSGet strikes again really
20:10:51 <briantist> it's interesting that no one raised this  for so long, goes to show how few modules require acceptance
20:11:20 <briantist> the one in the issue is by HP, I don't think I've ever encountered an actual MS module that requires it
20:11:31 <jborean93> I've never actually encountered one that does before
20:11:55 <nitzmahone> Just the fact that they built the capability into the underlying ecosystem...
20:11:57 <briantist> me neither, never even knew about this until I stumbled across that issue
20:12:19 <nitzmahone> half-tempted to just make it default to `True`, but I'm sure that would upset someone :D
20:12:41 <briantist> that doesn't surprise me much, given that it seems to be surfacing a feature of nuget rather than a first-class thing
20:13:06 <briantist> haha I do think an option makes more sense, it shouldn't be hard to implement at all,
20:13:39 <briantist> but I  haven't started that part I was only modifying the test modules to have one with the setting enabled, and then trying to get the integration tests to fail on it but they... don't
20:13:59 <briantist> I ran out of time though, it'll probably become obvious when I dig a little
20:15:10 <jborean93> I personally thought you fixed this in the past as well
20:15:26 <briantist> nope, never seen this stuff before
20:15:59 <jborean93> maybe it was another PR I'm thinking off from someone else that did pass the standard
20:16:34 <briantist> could be.. I did a lot of work on the various PSGet modules but not this particular thing
20:17:44 <briantist> the main thig I'm hoping is that this work doesn't have different behavior in the old windows/PS versions.... we'll see
20:18:22 <briantist> I know there's some mention of PSGet 2.0 or some such thing, I just hope it's compatible and doesn't require gnarly conditonals or whatever
20:18:33 <jborean93> PSGet 3.0 uses a new set of cmdlets
20:18:39 <jborean93> like `Install-PSResource` or something
20:18:50 <briantist> yeah.. I haven't even looked at that in over a year
20:18:55 <jborean93> there's a shim to have it exposed with the old ones which could affect it though
20:19:11 <jborean93> It's been in beta for probably the past 2-3 years I think
20:19:49 <nitzmahone> oof, yeah, b1 was March 2020
20:19:56 <briantist> these are the versions that matter for licensing:
20:19:57 <briantist> > If format version of client is older than 2.0, operation fails and asks the user to update the client.
20:19:57 <briantist> > If module was published with format version older than 2.0, requireLicenseAcceptance flag is ignored.
20:20:01 <briantist> https://docs.microsoft.com/en-us/powershell/scripting/gallery/concepts/module-license-acceptance?view=powershell-5.1
20:20:11 <jborean93> on the plus side it removes the whole nuget bootstrapping
20:20:34 <jborean93> I didn't even know there was format versioning
20:20:36 <briantist> it's a little unclear what they mean by format version
20:20:57 <jborean93> yea
20:20:58 <briantist> right... so I'll douse that bridge once I inadvertently light it on fire
20:20:59 <nitzmahone> Isn't that the nuget manifest version?
20:22:00 <briantist> I assume so.. but I haven't yet been able to test that out. The integration tests are templating a nuspec file instead of having powershell build it, comments mention because of issues in older PS versions or something
20:22:02 <jborean93> potentially but it's not something you as a pwsh module author really control AFAIK
20:22:13 <briantist> (I think jborean93 wrote the setup for this?)
20:22:17 <jborean93> I did
20:22:34 <jborean93> I remember it being very finnicky
20:23:14 <briantist> yeah, I'll work through it once I have a little time again
20:25:12 <nitzmahone> Anything else to kick around for today?
20:25:22 <briantist> nothing else from me
20:25:24 <jborean93> I'm all good
20:25:46 <nitzmahone> Cool, wrapping it up for this week then- til next week. Thanks all!
20:25:49 <nitzmahone> #endmeeting