20:00:00 <jborean93> #startmeeting Ansible Windows Working Group
20:00:00 <zodbot> Meeting started Tue Jul 19 20:00:00 2022 UTC.
20:00:00 <zodbot> This meeting is logged and archived in a public location.
20:00:00 <zodbot> The chair is jborean93. Information about MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions.
20:00:00 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
20:00:00 <zodbot> The meeting name has been set to 'ansible_windows_working_group'
20:00:05 <nitzmahone> noice
20:00:08 <briantist> yo
20:00:16 <jborean93> #chair nitzmahone
20:00:16 <zodbot> Current chairs: jborean93 nitzmahone
20:00:25 <jborean93> #info agenda https://github.com/ansible/community/issues/644
20:01:08 <jborean93> looks like the docs team will be keeping the windows guides in ansible/ansible for now
20:01:32 <briantist> yup, finalized that today in the DaWGs meeting
20:01:40 <jborean93> thanks for that
20:01:42 <jborean93> #topic https://github.com/ansible/community/issues/644#issuecomment-1180351561 - ansible.windows docs generalisation
20:02:19 <jborean93> I can't remember, did we have concerns about the PR side of things having commit access to the docs branch or was that resolved?
20:02:49 <briantist> we removed that from PRs in `c.w` (and in this PR for `a.w` too since it's the same thing)
20:03:24 <briantist> so we don't get published docs individually for PRs, but the push workflows do publish a site (so when PRs are merged, tags are pushed, etc.)
20:04:33 <jborean93> just looking at https://github.com/ansible-collections/ansible.windows/pull/388/files#diff-3fce96e4c9f6a9e13204b677a8bdefb92e6f93c6378d8d6c78b36dbc5d132f2aR6-R7, it seems like it is running at least something with prs
20:05:03 <jborean93> is it just a build to make sure it doesn't break
20:05:31 <briantist> it is! it still does the builds, it still compares a diff, and adds the built docs as a build artifact (so they could be downloaded and checked in your browser locally), and then it posts a comment to the PR with all that info
20:06:29 <briantist> the only thing it's missing is publishing the gh-pages site individual to the PR (which needed to commit to the gh-pages branch to publish)
20:06:30 <nitzmahone> (and PR target uses the base branch and workflows, not the ones from the proposed PR)
20:06:58 <briantist> ^ yes that, so a PR author cannot modify the workflow that runs within their PR
20:07:15 <jborean93> awesome
20:07:42 <briantist> but we do need GH pages enabled before merging that PR in `a.w`, I think nitzmahone enabled it in `c.w` when we first discussed it
20:08:07 <briantist> instructions to do that are linked in the PR too, but it's this link: https://github.com/ansible-community/github-docs-build/wiki/Getting-started-with-GitHub-Pages#setting-up-github-pages-for-the-first-time
20:08:25 <jborean93> let me check the c.w settings
20:08:26 <nitzmahone> (I did)
20:10:33 <jborean93> I'll go through that page as the gh-pages branch isn't present and enable it after the meeting
20:10:44 <briantist> cool, sounds good
20:12:13 <jborean93> #topic Open Floor
20:12:20 <jborean93> Anything else we wanted to talk about?
20:12:52 <briantist> I got nothing else at the moment
20:13:18 <nitzmahone> nothing here
20:13:26 <jborean93> cool, will let us get back on with our days
20:13:33 <jborean93> #endmeeting