17:00:19 #startmeeting F20-blocker-review 17:00:19 Meeting started Wed Dec 11 17:00:19 2013 UTC. The chair is kparal. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:00:19 Useful Commands: #action #agreed #halp #info #idea #link #topic. 17:00:19 #meetingname F20-blocker-review 17:00:19 #topic Roll Call 17:00:19 The meeting name has been set to 'f20-blocker-review' 17:00:23 hello there 17:00:28 who's available? 17:00:38 #chair roshi adamw pschindl 17:00:38 Current chairs: adamw kparal pschindl roshi 17:00:53 * pschindl is here 17:00:54 ahoyhoy 17:00:56 * roshi is here 17:00:59 * mkrizek is here 17:01:03 * greenlion_ is here 17:01:07 * Viking-Ice here 17:01:14 roshi volunteered to do secretary work 17:01:27 that I did 17:01:30 * nirik is here 17:02:22 note: I'll move the order of some anaconda bugs because dlehman can stay for only 30 minutes 17:03:18 ok, lets go 17:03:21 * jreznik is semihere 17:03:25 #topic Introduction 17:03:25 Why are we here? 17:03:25 #info Our purpose in this meeting is to review proposed blocker and nice-to-have bugs and decide whether to accept them, and to monitor the progress of fixing existing accepted blocker and nice-to-have bugs. 17:03:25 #info We'll be following the process outlined at: 17:03:25 #link https://fedoraproject.org/wiki/QA:SOP_Blocker_Bug_Meeting 17:03:27 #info The bugs up for review today are available at: 17:03:29 #link http://qa.fedoraproject.org/blockerbugs/current 17:03:33 #info The criteria for release blocking bugs can be found at: 17:03:35 #link https://fedoraproject.org/wiki/Fedora_20_Alpha_Release_Criteria 17:03:37 #link https://fedoraproject.org/wiki/Fedora_20_Beta_Release_Criteria 17:03:39 #link https://fedoraproject.org/wiki/Fedora_20_Final_Release_Criteria 17:03:41 today we have 17:03:43 #info 10 Proposed Blockers 17:03:45 #info 8 Accepted Blockers 17:03:47 #info 2 Proposed Freeze Exceptions 17:03:49 #info 12 Accepted Freeze Exceptions 17:03:51 let's start with 17:03:53 ============================================================ 17:03:55 Proposed Blockers 17:03:57 ============================================================ 17:03:59 #topic (1008732) LUKSError: luks device not configured 17:04:03 #link https://bugzilla.redhat.com/show_bug.cgi?id=1008732 17:04:05 #info Proposed Blocker, anaconda, NEW 17:04:19 #Team 17:04:19 17:04:19 8 new Anaconda bugs proposed as release blocker 17:04:30 read from c34 17:04:52 rejected blocker once, but greenlion found way to reproduce reliably 17:04:58 even from c37 17:05:22 +1 17:06:09 * nirik reads up 17:06:14 it is not likely for people to trigger this often. but it's not even totally unlikely 17:06:49 so, what's the criteria violation here? 17:06:50 i'm +1 FE 17:06:55 also c29 mentions a "normal" use case 17:07:02 deferring to anaconda team on whether to fix 17:07:09 I guess almost any refresh action with luks partition will trigger it 17:07:21 adamw: fails to remove a partition, probably 17:07:27 I dont think its normal for people to encrypt then decide not to encrypt 17:07:34 dlehman: what do you think about this? 17:07:34 or what to encrypt in custom 17:07:39 * nirik thinks this is pretty fringe 17:07:44 but i want to know more about what's happening in case this extends to other use cases 17:07:52 doesn't feel like a blocker to me. FE seems reasonable. 17:08:03 -1/+1 for me 17:08:13 the 'refresh disks' button did feel like a big 'Cause Problems' button when we first put it in, to me, but meh 17:08:27 -1 / +1 17:08:30 me2 17:08:31 I have to say I used nautilus to open LUKS to do some stuff and then reinstall in the past 17:08:33 adamw, yeah confusing point 17:08:41 (that would be c29 use case) 17:09:16 -1, FE would depend whether we're slipping or not 17:09:41 "The installer must be able to create and install to any workable partition layout using any file system and/or container format combination offered in a default installer configuration." [2] 17:09:48 not a clear criteria violation, given our release cycle and the size of anaconda we can't really block every release on every complex crasher we find 17:09:50 was the criteria cited last time 17:09:59 at the least it could be made a common bugs - since the workaround is to have your mind made up when you start, right? 17:10:04 adamw, I hardly call this complex 17:10:09 roshi: definitely common bugs, yes 17:10:27 or just reboot and try again 17:10:29 this is not a default installer configuration 17:10:41 if anaconda does not hard crash I think it would be fine but.. 17:10:55 cmurf, what do you mean not default install 17:11:03 it's unfortunate the crash occurs during installation, not before 17:11:12 cmurf, if you can do it then one can argue it's default 17:11:22 the cited criteria says "in a default installer configuration" 17:11:47 I thought "default" was just clicking "Next" and filling out user info 17:11:49 manual partitioning isn't the default 17:11:57 cmurf, and refrences https://fedoraproject.org/wiki/Fedora_20_Final_Release_Criteria#Disk_layouts 17:12:09 we have also " Correctly interpret, and modify as described below, any disk with a valid ms-dos or gpt disk label and partition table containing ext4 partitions, LVM and/or btrfs volumes, and/or software RAID arrays at RAID levels 0, 1 and 5 containing ext4 partitions " 17:12:25 * adamw still -1 17:12:39 Viking-Ice: that's ridiculous. if the criterion is "if you can do it" don't call it "default" 17:12:42 cmurf: 'default installer configuration' just means the filesystem/container options it gives you when you boot normally 17:13:03 cmurf, it's the criteria that was agreed upon last time 17:13:03 the point of that wording is to not cover something that's hidden behind an experimental option, like btrfs used to be 17:13:17 i wouldn't say the 'default installer configuration' bit is relevant here at all. 17:13:57 dlehman, I said one can argue 17:14:01 pretend it says "The installer must be able to create and install to any workable partition layout using any file system and/or container format combination offered". is it able to? yes it is. does it crash if you do it a particular roundabout way? yes. do we consider that sufficient to violate the criterion? ehh. i don't, -1. 17:14:09 how about we just vote and move on instead of arguing? ;) 17:14:11 adamw, in what case this bug should be hit to be a blocker in your vision? 17:14:41 I see 3x -1 and 1x +1 17:14:46 greenlion: without using the 'refresh disks' button. or if it happened to anyone who ever hit that button, maybe, not just people with an existing encrypted LVM layout. 17:15:00 or data loss which i don't think is the case 17:15:13 cmurf: it alters the layout before crashing 17:15:23 greenlion: and to be honest, i think slavish adherence to the partitioning criteria is a mistake - even though i'm the criteria guy - because they suck. we've tried writing them three times and they've sucked every time. next time someone else should draft it. 17:15:24 adamw, I'm pretty sure users expect to be able to use the refresh button since it's available for them to click on 17:15:24 really? 17:15:28 ok hold on 17:15:40 Viking-Ice: people expect a lot of things. =) 17:15:46 okay, is anyone changing their minds, or can we move on? 17:15:49 my recollection is that it crashed figuring out what to do, and no actions were being taken yet 17:15:49 cmurf: yes, it crashes at the beginning of installing, so probably it already wiped some partitions 17:15:50 we've been on this bug for 10 minutes 17:15:50 adamw, if users can they do ;) 17:15:59 proposed #agreed 1008732 - RejectedBlocker - This is a fringe use case that might not hit many users. We will add it to CommonBugs and warn users they should not change the state of partitions (unlock them) before starting the installer, or do the same use the Rescan button. 17:16:00 kparal: are we sure? 17:16:03 ack 17:16:07 cmurf: of course not 17:16:08 kparal: it wouldn't be wiping any you cared about keeping, though. 17:16:08 * jreznik is here 17:16:10 kparal: do we want to +1 FE? 17:16:13 ack 17:16:14 ack 17:16:25 * jreznik is re-reading 17:16:41 proposed #agreed 1008732 - RejectedBlocker AcceptedFreezeException - This is a fringe use case that might not hit many users. We will add it to CommonBugs and warn users they should not change the state of partitions (unlock them) before starting the installer, or do the same use the Rescan button. Timely patch will be considered. 17:16:48 ack 17:16:51 ack 17:16:54 ack 17:17:01 ack, sure, if 'timely' means 'if we slip'. 17:17:04 ack 17:17:06 :P 17:17:11 #agreed 1008732 - RejectedBlocker AcceptedFreezeException - This is a fringe use case that might not hit many users. We will add it to CommonBugs and warn users they should not change the state of partitions (unlock them) before starting the installer, or do the same use the Rescan button. Timely patch will be considered. 17:17:12 nothing FE can be 'timely' if we're going for a hero run today. 17:17:24 hero run 17:17:27 #topic (1040352) Cannot change a standard partition's size, then return it to the original size 17:17:28 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040352 17:17:28 #info Proposed Blocker, anaconda, NEW 17:17:28 adamw: right, but it could be if we don't 17:17:32 yeah. 17:18:10 this one is workaroundable if you hit Reset All button and lose all your changes 17:18:22 otherwise you can't reset the standard partition size value back to original 17:18:30 kinda gross, but it is a workaround... 17:18:38 setting /boot size has been flaky for a while 17:18:40 or just, you know, be okay with it being 1MB different in size or something 17:18:51 cmurf: doesn't matter where the partition's going to be mounted, i don't think 17:19:04 adamw: I think the assumption from the user is that the partition won't get touched if they set the size back 17:19:04 the bug of this kind we took as a blocker was a *crasher* 17:19:11 it does all sorts of strange things, i have another bug on this on btrfs where changing 500MB /boot to btrfs caused the whole btrfs volume to snap to 2GB 17:19:12 kparal, and we suggest to not click refresh in other cases... 17:19:23 greenlion: rescan, not refresh 17:19:31 as, yes, rescan 17:19:42 and the /boot for uefi seems to be broken as well 17:19:43 so yeah, this sucks, does it block the release of fedora? meh. -1. 17:19:47 Viking-Ice: ? 17:19:48 cmurf: that's specific to btrfs 17:19:51 -1/+1 from me too. 17:19:54 sorry I'm late guys 17:19:59 yeah, we took it as blocker because it was crashers, if not anymore, then -1 17:20:00 cmurf: and /boot on btrfs is no longer allowed, so... 17:20:06 adamw, what do you mean uefi 17:20:23 Viking-Ice: yeah, i was asking for details on the uefi thing 17:20:26 yes the uefi partitioning layout for /boot is wrong it works but it's wrong 17:20:34 how do you mean 'wrong'? 17:20:37 wrong? 17:20:45 eh, sidetrack, unless it's a release blocker 17:20:46 users might be tossing partition sizes few times until they get sizes they want to 17:21:17 -1 17:21:19 partitions seem to be OK since I let the installer do the work 17:21:20 adamw, http://www.freedesktop.org/wiki/Specifications/BootLoaderSpec/ 17:21:26 FWIW I have a trivial patch that fixes this immediate problem. I cannot guarantee it will not cause some other regression. 17:21:33 +1 FE 17:21:38 proposed #agreed 1040352 - RejectedBlocker AcceptedFreezeException - This is inconvenient, but can be easily worked around by hitting Reset All. A patch will be considered. 17:21:38 -1FE -1 blocker 17:21:42 no more regressions please 17:21:43 Viking-Ice: we make no attempt to adhere to that spec 17:21:48 okay, if you go to custom, decide you want to resize something, then change your mind, you're a bit stuck unless you start over. at this point i'm kinda -1 on all these 'if you start out doing it wrong then do it different' bugs, it feels like there are so many of them possible that it's futile to keep slipping a week to throw in emergency patches for one or two 17:22:02 which might be breaking other cases, for all the time we have to test 17:22:02 FE=fragility encourager 17:22:07 adamw: +1 17:22:20 kparal: ack 17:22:31 ack 17:22:36 -1 blocker/+1 FE 17:22:38 adamw, rush pushing things out the door 17:22:38 ack 17:22:42 i found breakage caused by two of the hero patches from yesterday (unless i tested wrong), so we may be at jlaska's point of no return with these things 17:22:56 ack 17:23:02 #agreed 1040352 - RejectedBlocker AcceptedFreezeException - This is inconvenient, but can be easily worked around by hitting Reset All. A patch will be considered. 17:23:02 ack 17:23:02 this is the problem with making these sorts of bugs non-blocking at beta, is that by the time we get to final we want to be more conservative to avoid regressions and slip. 17:23:16 roshi: please also add common bugs to all of this 17:23:23 kparal +1 17:23:25 #topic (1040413) Cannot change a logical volume's size twice, then return it to the original size 17:23:25 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040413 17:23:25 #info Proposed Blocker, anaconda, NEW 17:23:29 cmurf, we should not be dealing with installer bugs after beta 17:23:40 yep 17:23:42 this is the same, but for lvm, and it breaks only after you resize twice 17:23:55 cmurf, but if you do block beta on these bugs wouldn't you still waiting for it?.. 17:23:59 agreed, but we need to be able to slow the rate of development of the installer to make that possible. 17:24:04 so, obviously -1 as it's more involved than the last. 17:24:06 so it's even less important than the previous one... 17:24:09 -1 17:24:09 -1 17:24:12 -1 17:24:20 FE votes the same? 17:24:21 well, -1/+1 from me... 17:24:24 there's another trivial patch for this one 17:24:28 ok 17:24:30 -1/+1 17:24:31 -1 FE for this one 17:24:32 proposed #agreed 1040413 - RejectedBlocker AcceptedFreezeException - This is inconvenient, but can be easily worked around by hitting Reset All. A patch will be considered. 17:24:34 ah 17:24:37 ack, since i'm ouitvoted 17:24:43 ack 17:24:46 i'm still -1 FE 17:24:48 ack 17:24:49 ack 17:24:51 ack 17:24:55 should we redo FE vote? 17:25:07 yes 17:25:14 let's vote again on FE 17:25:20 FE? 17:25:24 if the point is to push out the release regardless what's the point of this meeting? 17:25:38 I'm +1 FE since we already added +1 FE to the previous once 17:25:43 make sense 17:25:45 0 17:25:52 -1/-1 (I think this is not worth _any_ chance of a regression or delay.) 17:25:56 richard_ FE=fragility encouragement (a.k.a. freeze exception) 17:25:59 -1 FE 17:25:59 +1 FE 17:26:03 this is more edge case than that previous one 17:26:06 -1 FE 17:26:22 okay, changing to -1 17:26:22 +1 FE 17:26:25 funny numbers, always results in zero sum :) 17:26:32 ah! thanks cmurf! 17:27:02 -1 FE 17:27:05 leave it undecided and move on? blocker status is the key 17:27:06 it seems we can't agree, so I skip the vote, it was not nominated (how clever of me) 17:27:19 proposed #agreed 1040413 - RejectedBlocker - This is inconvenient, but can be easily worked around by hitting Reset All. 17:27:26 * nirik shrugs. we can revisit I guess later if needed. 17:27:27 i'm counting FE fails 17:27:28 ack 17:27:28 ack 17:27:31 ack 17:27:34 ack 17:27:37 ack 17:27:39 #agreed 1040413 - RejectedBlocker - This is inconvenient, but can be easily worked around by hitting Reset All. 17:27:40 ack, will add CommonBugs tag 17:27:52 roshi: thanks 17:27:53 #topic (1040422) Standard partitions can't be enlarged 17:27:53 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040422 17:27:53 #info Proposed Blocker, anaconda, NEW 17:28:06 -1 doesn't seem to be a bug in first place 17:28:11 I would welcome some more testing to this one, I reported it today 17:28:22 um. i think this is user error 17:28:23 dlehman: is that intentional behavior or a bug? 17:28:32 * nirik reads up 17:28:33 adamw: it can be UI error, not user error 17:28:37 I'd need to see evidence that there is available free space immediately following the partition you're trying to enlarge. 17:28:41 if you do a normal layout, your disk will have /boot , then the partition for the LV, then the free space 17:28:48 you can't enlarge /boot into the free space 17:28:49 in default configuration /boot is first partition - no free space to enlarge 17:28:58 right 17:29:06 +1 17:29:06 okay, we don't show the lozenge diagram of the disk any more so this isn't particularly clear, but we can't run around changing the UI at this point 17:29:07 the UI fails to inform the user properly if the resize can't be attempted. I see "Free space: 1.5GB" 17:29:14 so what are you proposing? 17:29:15 this looks like a very valid usecase 17:29:17 yeah, I don't thing we want to move possible multi TB partitions 17:29:18 we delay the release until... 17:29:22 that's UI problem... 17:29:28 adamw, wtf adan 17:29:33 we can completely redesign the custom part UI to indicate the physical location of partitions? 17:29:37 Viking-Ice: what's the practical fix? 17:29:49 if that's the attitude then call of this meeting now 17:29:54 Viking-Ice: seriously 17:29:59 if we accept this as a blocker, what's the next step? 17:30:00 I don't propose to redesign the UI, I just don't know whether this is a bug or not 17:30:07 The UI's behavior is to attempt to achieve the requested size and come as close as possible. If the max possible size for sda1 is 500MB then that's all there is to work with. 17:30:10 and that seem we don't have "user must not be puzzled" criteria... 17:30:12 I found it today with the rest of the issues, so I reported it 17:30:18 error dialog saying 'cannot resize because it's not contigious'? 17:30:35 yeah, wth? we cannot be beholden to every possible user delusion or misconception. 17:30:37 it's definitely a problem, that's what I say 17:30:38 that sounds like the best we could do without a ui rewrite 17:30:52 UI rewrite? again? 17:30:59 dlehman: well, i'd say this is a case of the UI not being correctly designed to match reality, but that's not something we can fix post-beta as a blocker emergency 17:31:17 (the UI is designed as if all 'free space' were equal, this is still not true) 17:31:31 or the logic needs to put a bigger /boot somewhere else where there is enough space 17:31:32 anyhow, I'm -1 blocker. 17:31:38 +1 17:31:41 blocker 17:31:41 but in either case i'm -1/-1 17:31:42 i think we only considered the design in the context of creating new partitions, not enlarging existing 17:31:46 expected user behaviour 17:32:09 is to be able to enlarge as well as shring 17:32:12 mean shrink 17:32:18 -1, it's a problem but there is no plausible change to a post-beta OS we could make to make this significantly better. we really ought to have spotted it earlier, though. 17:32:24 it is unpleasant but we'd block for weeks on this to get a ui to show the user what's going on 17:32:29 we talked about some more graphical (literally) UIs for custom, but it would have taken another year or two 17:32:47 cmurf, we can just as well block now as well after the bloody release 17:32:54 in next cycle 17:33:09 Viking-Ice: ok so it's not weeks it's months to years 17:33:22 ergo, the answer is no 17:33:31 the notion of blocking because the user has no understanding of disk partitions and we haven't drawn them a damned picture is asinine 17:33:39 haha 17:34:02 dlehman: the purpose of the new UI is that user doesn't have to understand partitioning, no? 17:34:09 dlehman, if you give an end user the possibility to shrink you must realize he might want to expand as well 17:34:18 he even can't, with no graphic representation 17:34:22 kparal: yes, but they still cannot have a pony. 17:34:23 and in many sane cases, they can 17:34:23 this is the road of graphical installers, the expectations will get higher because they make installing OS's seem easy and magical 17:34:25 proposed #agreed 1040422 - RejectedBlocker - This is probably a UI issue failing to inform the user properly what can and what cannot be achieved. It's not possible to redesign UI to fix this in a short time. If this really affects real cases where there is enough contiguous space for resize, please propose again. 17:34:32 ack 17:34:35 ack 17:34:38 ack 17:34:40 ack 17:34:42 ack 17:34:45 #agreed 1040422 - RejectedBlocker - This is probably a UI issue failing to inform the user properly what can and what cannot be achieved. It's not possible to redesign UI to fix this in a short time. If this really affects real cases where there is enough contiguous space for resize, please propose again. 17:34:55 #topic (1040438) LV partitions can't be enlarged 17:34:55 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040438 17:34:55 #info Proposed Blocker, anaconda, NEW 17:34:58 and the same for LVM 17:35:05 -1 same 17:35:08 (the same disk layout, btw) 17:35:09 someone talk about a gnome installer appearing sooner rather then later which is going to be fun for us ;) 17:35:20 * adamw looks at yak farm prices 17:35:26 can't enlarge anything at all, even when I have "free space" 17:35:29 We only support enlarging LVs if there is free space in the VG. We do not do a cascading resize of pv then vg then lv 17:35:42 adamw: hey yak poo burns you know? so you can sell yak logs! 17:35:53 oh man, the gnome installer would be a dream to QA. it probably can only install one layout to a disk of exactly 500GB. if you don't have one you have to go out and buy one. i'm sold 17:35:56 shgurg 17:36:09 adamw, yeah sounds like less buggy ;) 17:36:14 and more userfriendly 17:36:15 new PV could be made on free space... 17:36:17 adamw: yep, not supported, not intended, just one button "install" 17:36:26 jreznik, +1 17:36:31 -1/-1 17:36:34 greenlion: it could, but we've never had time to make it work. 17:36:40 -1 blocker 17:36:51 proposed #agreed 1040438 - RejectedBlocker - This is probably a UI issue failing to inform the user properly what can and what cannot be achieved. Anaconda doesn't support LV resize when there is no free space in the VG. Will be added to CommonBugs. 17:36:54 this feels kinda like the last one, it's an inherent limitation of the design, not a bug we can find a reasonable fix for at this point 17:36:55 dlehman, yes, and users probably not want it to 17:36:55 ack 17:36:56 -1 17:37:00 ack 17:37:02 ack 17:37:05 ack 17:37:08 ack 17:37:22 #agreed 1040438 - RejectedBlocker - This is probably a UI issue failing to inform the user properly what can and what cannot be achieved. Anaconda doesn't support LV resize when there is no free space in the VG. Will be added to CommonBugs. 17:37:35 #topic (1040445) resize attempts ignored for LVs already scheduled for reformat 17:37:35 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040445 17:37:35 #info Proposed Blocker, anaconda, NEW 17:37:50 the same right 17:37:56 * nirik reads 17:37:57 no 17:37:59 no 17:38:12 this is about behaviour changing after you assign a mount point to an existing partition 17:38:17 the resize stuff just mysteriously stops working 17:38:18 when you mount some partition, you can't even downsize it 17:38:28 does it work again if you un-assign the mountpoint? 17:38:30 if so we can document it 17:38:37 oh sorry still on the old bug 17:38:38 adamw: I haven't tried that 17:38:44 but I can in a minute 17:39:03 this is very valid for custom as it seems 17:39:05 though at this point when i say 'document' i mean 'tell people "look, if you want to resize stuff, probably best just do it before you start"' 17:39:17 (outside of anaconda) 17:39:23 still, we did specifically limit the 'resize' criterion to be quite specific 17:39:26 adamw, maybe tell users "don't use custom partitioning" right away?.. 17:39:29 BTW, I'll note there is a thesis topic available for Anaconda storage layout visualization - but no one has applied for it just yet (a few asked, but no one applied in the end) 17:40:14 anyone who does apply should probably be sent for a psychiatric evaluation immediately 17:40:21 We had some really nice ideas during design of current/new UI, but it would have required a ton of custom GTK widgets. 17:40:21 adamw: mount point can't be unassigned. that might be yet another bug 17:40:32 great just fracking great 17:40:36 did anyone test this thing? 17:40:43 i mean, i know i spent the last six months drinking, anyone else? 17:40:50 who ever unassignes mount points? 17:40:50 kparal: if you don't select mount point at all can you resize then? 17:40:53 I assume everyone still want's to push to release 17:41:00 nirik: yes 17:41:04 nirik: yeah, it works fine till you set a mount point 17:41:05 downsize at least 17:41:08 * nirik is still trying to determine the scope of this bug. 17:41:14 * greenlion thinks he saw something like this 17:41:32 cant we just document only default install path works this release cycle anything outside that and it sucks to be you ;) 17:41:37 but Reset All comes to the rescue 17:41:37 it's difficult imagining much contribution to an installer specific custom partitioner rather than a general purpose utility 17:41:47 Viking-Ice: the thing is, a lot of these bugs probably exist in 19 too 17:41:48 so, you could reboot and resize the next go I guess... 17:41:54 the workaround is to Reset All 17:42:09 adamw, so you are saying they should exist in 21 and 22 as well? 17:42:15 -1/-1 17:42:16 which is a great workaround so long as you don't have an existing encrypted LVM...:P 17:42:19 valid workaround 17:42:21 -1 17:42:27 kparal, or reboot and start from scratch... 17:42:29 adamw: those bugs come full circle, don't they? 17:42:37 but yeah, -1, various ways to avoid this and we don't want to block very hard on resizing anyway 17:42:37 lol 17:42:47 -1 17:43:10 Viking-Ice: I think we really should start tracking rejected blockers and potential edge spots better... as it's coming over and over :( 17:43:11 -1/+1 17:43:12 -1 17:43:16 FE votes? 17:43:20 let's just cancel f20. in f21 we will disable custom storage configuration. problem(s) solved. 17:43:27 -1/+1 17:43:37 dlehman: you said I can't have my pony 17:43:43 haha 17:43:51 that's _my_ pony 17:43:54 dlehman: i actually support that 17:43:57 dlehman: we could start making 'Fedora(tm) hardware' that has a known specific config and comes pre-installed. ;) 17:44:11 heh 17:44:14 hey the big boys get away with it 17:44:16 nirik: even that's not as easy as it sounds :) 17:44:29 "you shall install only this way or that way, that is all" 17:44:30 I'm sure. 17:44:32 dlehman: hell, we can match the 'market leader' if we put in a button that runs gparted! 17:44:43 I just hope the dvd dies in F21 17:44:47 I see 2x +1 FE and 1x -1 FE 17:44:48 that's my pony 17:44:56 -1 FE 17:45:06 -everything 17:45:13 * adamw holds up big sign with NO painted on it 17:45:14 adamw: so negative. ;) 17:45:15 that seems to be the theme 17:45:16 that's -3 FE 17:45:17 -1 17:45:22 FE 17:45:26 now -4 FE 17:45:35 proposed #agreed 1040445 - RejectedBlocker RejectedFreezeException - This is inconvenient, but can be worked around using the Reset All button, or resized in advance before assigning a mount point. Will be added to CommonBugs. 17:45:35 -1 FE 17:45:44 kparal: did you file a bug about scheduling a resize of an lv, then marking it for reformat, then setting it back to its original size causing a crash? 17:45:47 ack 17:45:50 ack 17:45:55 ack 17:45:55 dlehman: I could not reproduce that 17:45:58 kparal: yeah, we thought that was actually the worst of the ones you hit 17:46:03 oh, if it's not reproducible that's good... 17:46:17 wait, if you can't resize after marking for format, how did you ever hit that? 17:46:19 I actually hit it once, but couldn't again 17:46:19 I hit it yesterday. 17:46:25 ack 17:46:28 #agreed 1040445 - RejectedBlocker RejectedFreezeException - This is inconvenient, but can be worked around using the Reset All button, or resized in advance before assigning a mount point. Will be added to CommonBugs. 17:46:37 adamw: i had one of those from monday i can't reproduce so i marked it closed/insufificient data. no point spending time on it. 17:46:38 adamw: I may have had other fixes in place. 17:47:32 this is the crash I received: https://bugzilla.redhat.com/show_bug.cgi?id=1039503 17:47:40 if anyone else have seen it, we can propose it 17:47:44 but I can't reproduce it 17:47:57 i've actually been hitting very few crashes 17:48:02 almost none 17:48:11 ship it. 17:48:13 =) 17:48:15 exactly 17:48:16 lol 17:48:19 if cmurf can't crash it.. 17:48:19 alright, let's move 17:48:29 #topic (1039491) "ValueError: new size same as old size" if you set a volume to 'Shrink' but do not change its size, in Reclaim Space 17:48:29 #link https://bugzilla.redhat.com/show_bug.cgi?id=1039491 17:48:29 #info Proposed Blocker, anaconda, POST 17:48:41 no kidding 17:48:46 okay, this one's a crasher, and it's not as complex as a lot of the others 17:48:53 so i'm more open to turning the sign around 17:49:00 c18 is descriptive I think 17:49:01 pre-beta it was like a bug magnetism course 17:49:02 (it has 'reluctant yes' written on it in very small letters) 17:49:26 +1 17:49:28 adamw: actually this one is safer than the previous ones, because this one crashes before starting the installation 17:49:46 eh, i don't place as much emphasis on that distinction as you do 17:49:50 and it crashes doing something almost no one would do 17:49:57 the previous bugs wiped your partitions first 17:49:58 no one sane anyhow. 17:49:59 which is choose to shrink but then not move the slider 17:50:11 it's like - ok you deserve the crash 17:50:21 users should never find them in situation where they exiting partitions get wipe and then the installer crashes 17:50:23 how intrusive is the fix? 17:50:32 that's v. similar to the 'resize, then change back to the original value' bugs in 'user intent' i guess 17:50:34 no partitions get wiped with this bug 17:50:40 Viking-Ice: that's my thinking 17:50:50 except in this case they changed their minds faster, or just forgot to actually shrink anything 17:50:51 * Viking-Ice brings fourth introsometer 17:50:54 some people see installer gui 2 times a year and they want to click some buttons and explore it... 17:51:05 greenlion: absolutely 17:51:24 there is a consideration related to the fix here 17:51:36 greenlion, users having to do installation 2 a year is a bug in itself ;) 17:51:37 oh, no, that was a different one, never mind me 17:51:40 it's only testers who know what is "safe path" is in it... 17:52:04 for the fix, how difficult is it to do a "if the slider isn't moved, ignore the fact the shrink button was clicked at all" 17:52:28 I guess I am a weak -1/+1... it seems like a thing most people won't do, and if they do, they can just re-run and not do that next time... sure it would be good to fix... 17:52:40 cmurf, the fix is like that as I see from patch 17:52:40 mkolman: do you know some technical details here? how intrusive is the patch? 17:52:51 there's a patch on the list. It's pretty simple. 17:52:52 -1/+1 17:52:58 kparal: looked quite simple 17:53:01 +1 17:53:25 -1 blocker / +1 Fragility Express 17:53:48 i can be -1. i have no problem with no. :P 17:53:48 I'd normally give +1 here, but since we rejected much more serious ones (in my view) just a short time ago, I can go -1/+1 quite fine 17:53:52 cmurf: that's basically what it does - if the size is the same, it skips the resize action 17:54:01 brilliaint 17:54:10 adamw: your standards left you again, I see 17:54:13 cmurf: i was thinking of a different bug with that comment - there's another shrink bug for which the 'fix' introduces other issues 17:54:13 except i'm having spelling problems apparently 17:54:19 we're probably going to hit that soon 17:54:20 kparal: yup. 17:54:28 17:54:32 i will give that a southpark F minus 17:54:36 it's push the release regardless 17:54:40 time 17:54:51 no! ship it! 17:55:03 right 17:55:10 * cmurf produces unicorns one after another 17:55:12 proposed #agreed 1039491 - RejectedBlocker AcceptedFreezeException - This is inconvenient, but quite unlikely to hit. It also doesn't present any user data loss. A patch will be considered. 17:55:21 ack 17:55:22 ack 17:55:25 ack 17:55:30 ack 17:55:32 ack 17:55:33 ack 17:55:33 #agreed 1039491 - RejectedBlocker AcceptedFreezeException - This is inconvenient, but quite unlikely to hit. It also doesn't present any user data loss. A patch will be considered. 17:55:54 Viking-Ice: for me it's 'we either ship more or less what we have, or slip for at least three weeks to take a kind of random bunch of small patches which might make more things worse than better' 17:55:56 #topic (1040012) SizeNotPositiveError: spec= param must be >=0 17:55:57 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040012 17:55:57 #info Proposed Blocker, anaconda, POST 17:56:13 adamw: exactlyl 17:56:15 we seem to be in a deny mood today 17:56:22 * cmurf for sure is 17:56:33 Viking-Ice: i mean, there's _so much_ to storage, and at this point we're kind of running around blind inside it, knocking on bits and finding problems - we don't know what all else there is in there, and it's kinda late to be finding out 17:56:35 I'm +1 here 17:56:40 +1 blocker 17:56:43 +1 17:56:45 if you create certain partition sizes, anaconda crashes 17:56:52 like 500MB instead of 500MiB 17:56:57 wait another one of these 17:57:13 this time it is not alignment issue from what I heard 17:57:21 kparal: according to Disks, it actually creates a disk of size 500,000,256 bytes. no idea how significant it is, but there iti s. 17:57:35 anyhow, this one is a genuine case you can hit, so closer to +1 17:57:36 oh and it is a regression 17:57:40 floats are evil. vpodzime has a patch for this. 17:57:41 c19 17:57:41 but it's also the one where the fix brings its own issue 17:57:50 what's the issue? 17:57:52 yeah, vpodzime said gnome-disks is weird. but the size is valid 17:58:00 well, it didn't happen in f19... 17:58:01 cmurf: c#20 17:58:06 bcl, why not measure partition in bytes? 17:58:10 and we don't know which tools and which partition sized might be affected 17:58:11 how much actually do we want to support out of anaconda created disks layouts? 17:58:15 oh god 17:58:31 so then there's a fix for *that*, but it's quite a large one: just quit caring about fractions of MB at all 17:58:33 adamw: that was before the last updates img/fix tho right? 17:58:39 round everything off to single MB 17:58:42 *sigh* 17:58:51 * nirik grumbles. 17:58:52 which is great, but is kind of a big change for late 17:58:58 note the comment on the patch 17:59:00 yes i suggested single MB and no fractions a year ago 17:59:13 adamw: that's basically what the fix from vpodzime does 17:59:14 but also late for f20 so i'd say no thanks to that 17:59:21 https://lists.fedorahosted.org/pipermail/anaconda-patches/2013-December/007768.html 17:59:27 and it for sure rounds it to greater value which makes it oversize... 17:59:34 "These two patches should fix two bugs, one F20 blocker and one proposed F20 17:59:35 blocker. I've asked QA to give those patches a lot of testing because I 17:59:35 understand especially PATCH 1/2 may cause some unexpected issues." 17:59:42 well it seems that the fix is easy, but produces a bigger bug than the original 17:59:42 greenlion: I'm watching a patch to track all sizes in bytes collect dust while I attend the all-year-long fedora flailfest 17:59:52 greenlion: right, that's the kind of thing i'm worried we'd run into 18:00:00 so, we have three choices: 18:00:01 1) reject 18:00:16 2) take the fix for the initial issue and live with the crasher I found (which you won't hit unless you do something a bit odd) 18:00:17 hm, they are using int() so it rounds to lower actually 18:00:24 3) take both fixes, cross fingerts 18:00:52 ughh 18:00:57 4) fix gnome-disks post release? meh, probibly not 18:00:58 ick, ick, triple ick 18:01:02 bcl: dlehman: wdyt? i'm kinda thinking 2). 18:01:18 adamw: your crash appears during installation? 18:01:20 2 sounds reasonable I think 18:01:29 nirik: you could plausibly create a disk like this with just about any utility. fdisk can do it. 18:01:38 yeah, I suppose so. ;( 18:01:39 adamw, what is your crasher? 18:01:42 kparal: yeah 18:01:55 greenlion: see comment #20 18:02:11 and c21 18:02:24 * greenlion is already a bit lost in all those anaconda bugs 18:02:25 you have to have an affected disk, then choose to shrink it, and then actually drag the slider upwards very slightly. 18:02:28 adamw: I defer to vpodzime. Anything that kills off floats is a plus in my book. 18:02:36 even if there is fallout. 18:02:47 bcl: i like it in principle, but if vpodzime is worried that it might break stuff, i'm kinda thinking f21... 18:03:20 if it's hard to hit then yes. 18:03:29 just a note, vpodzime's updates.img was tested today by several of our people on several bugs, found no problems 18:03:38 of course that doesn't mean much 18:03:39 that's the simple fix 18:03:40 ? 18:03:50 because as you can see, we do a sloppy job as a QA :) 18:04:09 we poke things with a stick and see if they meow 18:04:12 cmurf: I think that's the proper fix, 3) 18:04:27 oh boy 18:04:28 it sounds like it from vpodzime's messages, i haven't looked inside it yet 18:04:43 well, shall we vote on blocker status and then discuss which fix to take later? 18:04:43 * nirik is in favor of 2... 18:04:58 mkolman: the updates.img from vpodzime contains both fixes, right? 18:05:02 but if 3 is looking ok, we could try it I guess 18:05:04 did we vote already 18:05:08 Viking-Ice: a bit 18:05:09 i'm reluctant +1 on the blocker, it's a bit too likely to be hit to just throw it out 18:05:16 * greenlion is for taking both fixes 18:05:22 * jreznik is more in reject mood looking on what we rejected already 18:05:24 Viking-Ice: you did 18:05:24 kparal: yeah, I think so 18:05:30 +1 on the simple fix 18:05:39 kparal, and you as well as greenlion 18:05:43 0 on the bigger one to fix the simple fix's crasher 18:05:44 I guess a weak +1 18:05:45 jreznik: it is significantly easier to hit than the ones we've rejected 18:06:09 jreznik: it doesn't require you to go into custom or change your mind about anything, you hit it on a perfectly normal action - try and resize a partition - if that partition happens to be a 'weird' size. and it's a crasher. 18:06:24 what version are we voting for? 2) or 3) ? 18:06:29 we're voting on whether the bug is a blocker 18:06:35 which fix to take isn't strictly a part of that 18:06:40 oh 18:06:41 right. 18:06:41 ok 18:06:45 proposed #agreed 1040012 - AcceptedBlocker - Violates the criterion "Any installer mechanism for resizing storage volumes must correctly attempt the requested operation.". In this case anaconda crashes for certain partition sizes. 18:06:54 ack 18:06:56 reluctant ack 18:06:57 ack 18:06:57 ack 18:06:57 ack 18:07:02 adamw: counts as well 18:07:04 #agreed 1040012 - AcceptedBlocker - Violates the criterion "Any installer mechanism for resizing storage volumes must correctly attempt the requested operation.". In this case anaconda crashes for certain partition sizes. 18:07:27 #topic (1025072) libstdc++/58800 (the bug, not the fix) just got backported to Fedora 19 and 20 18:07:27 #link https://bugzilla.redhat.com/show_bug.cgi?id=1025072 18:07:27 #info Proposed Blocker, gcc, NEW 18:07:38 hold up 18:07:39 well wait 18:07:47 can we look at the one unaddressed anaconda accepted blocker while we have anaconda folks? 18:07:48 if we still do? 18:07:53 so it's a blocker which means the simple fix must happen 18:07:53 he bug, not the fix lol 18:07:54 sure 18:08:03 #undo 18:08:03 Removing item from minutes: 18:08:06 #undo 18:08:06 Removing item from minutes: 18:08:08 and then the bigger fix for c20 is at best an FE 18:08:08 #undo 18:08:09 Removing item from minutes: 18:08:22 adamw: bug number? 18:08:27 1039292 18:08:42 #topic (1039292) Assigning partition to disk with not enough free space causes custom partition interface to become unusable 18:08:42 #link https://bugzilla.redhat.com/show_bug.cgi?id=1039292 18:08:42 #info Accepted Blocker, anaconda, NEW 18:09:03 please note this is already accepted 18:09:04 I just tested a fix for this one. I think I can honestly say it has zero risk. 18:09:20 adamw, this one already is accepted blocker 18:09:45 Viking-Ice: yes, but dlehman must leave soon 18:09:59 oh ok 18:10:17 dlehman, it doesn't fix #c8 there? 18:10:19 #info dlehman has a fix for this one, with 'zero risk' 18:10:35 yeah, just wanted to do an out-of-order acceptedblocker review while anaconda devs were here 18:10:40 to check on the status of it 18:10:44 'zero risk' should be added to the list of forbidden words, I think 18:10:44 we have a fix for it? awesome 18:10:55 kparal: did you see mjg59's twitter yesterday? 'five word tech horrors' 18:10:59 back to yak farm shopping 18:11:01 not yet 18:11:02 i contributed 'it probably can't break anything' 18:11:08 greenlion: unrelated. they end up being luks-$UUID anyway. 18:11:24 oh, twitter. I don't have it 18:11:29 so if we have a fix for this, then i think that's all that needs to be said, right? 18:11:34 hurray 18:11:38 just need to put it into the hero anaconda build that'll show up today 18:11:39 dlehman, new ones are shown like 'luks-vdaN'... 18:11:42 then find out it explodes and slip again 18:11:46 yep. 18:12:05 let's continue with the proposed blockers 18:12:12 greenlion: right, because the order of operations varies from autopart to custom. 18:12:34 can we? 18:12:45 sure, i think so 18:12:45 yes 18:12:47 #topic (1025072) libstdc++/58800 (the bug, not the fix) just got backported to Fedora 19 and 20 18:12:47 #link https://bugzilla.redhat.com/show_bug.cgi?id=1025072 18:12:47 #info Proposed Blocker, gcc, NEW 18:13:05 c11+ is new 18:13:25 yeah. 18:14:03 so, libreoffice is on default media 18:14:05 -1/-1, fix in updates. 18:14:24 given c#14 and c#15 and the general absence of shit exploding all over the place, yeah, -1 18:14:27 -1 18:14:32 -1/-1 18:14:36 -1/-1 18:14:36 if LO on the lives was crashing all the time that'd be one thing, but it doesn't seem to be 18:15:03 -1 18:15:03 impact with fan averted 18:15:28 proposed #agreed 1025072 - RejectedBlocker - No critical packages are affected. The affected packages don't seem to be crashing frequently. Will be fixed in updates. 18:15:32 ack 18:15:38 ack 18:15:38 ack 18:15:56 ack 18:16:01 aack 18:16:06 #agreed 1025072 - RejectedBlocker - No critical packages are affected. The affected packages don't seem to be crashing frequently. Will be fixed in updates. 18:16:11 #topic (1021749) Review Request: php-symfony - PHP framework for web projects 18:16:11 #link https://bugzilla.redhat.com/show_bug.cgi?id=1021749 18:16:11 #info Proposed Blocker, Package Review, ON_QA 18:16:29 +1 FE I dont understand this one was proposed as a blockerf 18:16:30 does anyone know the timeline here? 18:16:40 Viking-Ice: if it would cause broken deps on the DVD that'd be autoblocker 18:16:48 but i'm not sure what all of php is on the dvd 18:16:55 can somebody summarize? 18:17:05 kparal: a package that various php packages depend on was retired during freeze 18:17:16 it's supposed to be replaced by this one, but this one can't go stable with the freeze in place 18:17:24 it's a fuckup that's what it is late fuckup 18:17:31 I guess due to things being stuck in review 18:17:33 Hi 18:17:39 RemiFedora: can you sum up for folks? 18:17:47 Viking-Ice: it's basically because of the holes in the freeze 18:17:53 for symfnony ? 18:17:55 Viking-Ice: you shouldn't be able to retire stuff in freeze without some kind of manual override 18:17:57 RemiFedora: yeah, thanks 18:18:17 php-symfony-* obsoletes php-symfony2-* packages 18:18:27 adamw, orphaning retiring etc should be done before alpha 18:18:47 php-symfony2-* habe benn retired and php-symfony-* are not yet in stable 18:18:53 but yeah broken process 18:19:22 RemiFedora: does it break any important packages on DVD? 18:19:24 broken process, probably, but now we have broken deps, and we should fix tis 18:19:25 RemiFedora: do we have a list of what deps are broken? 18:19:31 kparal: it's not just 'important', it's 'any' 18:19:36 if it breaks any, we need the bug as a blocker 18:19:37 right, any packages 18:19:39 if it doesn't, it can be FE 18:19:40 Mostly PHPUnit, which is used by tons of packahe on %check 18:20:05 but that could be fixed as a 0 day update, no? 18:20:14 http://fpaste.org/60889/38678601/ 18:20:15 what about yanking the things that need the deps? 18:20:27 is that one thing or a pile of things? 18:20:30 there's no real harm to taking this is if it doesn't hit the deliverables 18:20:38 so i'm +1 FE anyway, but blocker status depends on whether it hits the dvd 18:20:39 it should not 18:20:47 http://fpaste.org/60889/38678601/ is php* on the DVD 18:20:49 I don't see PHPUnit on DVD 18:21:29 is that a case sensitive ls? 18:21:33 wouldn't we know the broken deps already with TC5? 18:21:42 package name is php-phpunit-PHPUnit 18:21:42 cmurf: just 'ls php*' 18:21:54 kparal: i wasn't sure of the timeline 18:21:55 isn't the thing being looked for PHPUnit? 18:21:59 do we have a date for the retirement? 18:22:26 cmurf: see remi: "php-phpunit-PHPUnit' 18:22:46 yeah i don't see it in either case 18:22:48 the problem was reported on 12-06 18:23:02 I receive broken dep mail on 12-06 18:23:05 TC5 is from 12-05 18:23:38 yeah, it was after rc5 18:23:40 tc5 18:23:40 * ignatenkobrain is here 18:23:46 hi all 18:23:56 forget about bb review today 18:25:31 bb? 18:25:35 it was dec 4th actually. 18:25:37 oh, blocker bug 18:25:46 so in this case we probably need this (if it's on dvd), right? 18:25:59 just means we can't say TC5 proves it's okay 18:26:06 jreznik: we don't know whether some of the affected packages are on DVD 18:26:08 right. 18:26:15 let's just call it FE, pull it into RC1, and move the hell on 18:26:22 right 18:26:23 ^^ +1 18:26:26 +1 18:26:27 +1 18:26:28 we can run repoclosure on current repos and compare the php packages list 18:26:30 let's see, if we want some process hackery 18:26:41 * nirik runs one 18:26:51 agree that the bug's a blocker if any of the packages are on the DVD, FE if not, and we'll figure things out on BZ if need be 18:27:16 sounds gooder 18:27:17 +1 18:27:22 proposed #agreed 1021749 - RejectedBlocker AcceptedFreezeException - This causes some broken dependencies and can be fixed with a new package. It seems no affected packages are available on DVD. If there are, please re-propose as a blocker. 18:27:27 wfm 18:27:30 ack 18:27:37 ack 18:27:48 we have daily repoclosures, btw. http://fpaste.org/60891/67864571/ is the list from 1211. 18:27:53 so maybe write it in the proposal, it could be auto blocked than 18:27:58 right, nack 18:28:03 make it acceptedfe, blocker status undetermined 18:28:24 it can be made an auto-blocker without further discussion if we determine it'd affect dvd compose 18:28:34 proposed #agreed 1021749 - AcceptedFreezeException - This causes some broken dependencies and can be fixed with a new package. It seems no affected packages are available on DVD. If there are, this can be automatically accepted as a blocker. 18:28:41 ack 18:28:56 ack 18:28:56 propose #agreed 1021749 - AcceptedFreezeException - this is at least FE. blocker status depends on whether it affects any package on the DVD; we will determine and update status after the meeting 18:29:00 ...or ack to kparal's 18:29:01 either way 18:29:02 ack 18:29:12 ack 18:29:19 ack (any) 18:29:20 ack 18:29:23 #agreed 1021749 - AcceptedFreezeException - this is at least FE. blocker status depends on whether it affects any package on the DVD; we will determine and update status after the meeting 18:29:42 http://paste.fedoraproject.org/60892/13867865/ 18:29:43 that's all of proposed blockers 18:29:45 (repoclosure) 18:29:51 wow 18:30:04 5 minute break for pansies? 18:30:41 .fire cmurf 18:30:44 adamw fires cmurf 18:30:44 * cmurf goes to get a cáfe 18:30:45 cmurf: feel free to have a break, no sweat :) we'll go to the 1 proposed FE 18:30:56 lol 18:30:57 ============================================================ 18:30:57 Proposed Freeze Exceptions 18:30:57 ============================================================ 18:30:58 oh i can live for one 18:31:07 #topic (1040536) cloud kickstart: switch order of console kernel command line params to make log show up in openstack. 18:31:07 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040536 18:31:07 #info Proposed Freeze Exceptions, spin-kickstarts, NEW 18:31:20 +1 FE 18:31:34 +1 18:31:39 sure, +1 18:31:45 +1 18:31:48 +1 FE 18:31:49 +1 18:31:51 +1 18:31:52 is this a retroactive one? :) 18:32:06 +1 18:32:21 adamw: no? 18:32:32 it was applied on master, but not f20 branch that I saw. 18:32:41 ah, ok 18:32:46 thought someone mentioned it had gone to f20 18:32:55 +1 FE 18:32:55 proposed #agreed 1040536 - AcceptedFreezeException - This improves situation for cloud deployments and presents no risk to other products. 18:32:58 so we'd need to apply it and do a new s-k quickly to go in rc1 18:32:58 * nirik looks to make sure. 18:33:01 ack 18:33:04 ack 18:33:04 ack 18:33:04 I think Matthew has a few more changes since the last group. 18:33:19 #agreed 1040536 - AcceptedFreezeException - This improves situation for cloud deployments and presents no risk to other products. 18:33:25 nope, don't see it on f20 18:33:28 ok 18:33:44 can someone volunteer to look after getting it committed and a new s-k built? 18:33:48 ready for accepted blockers or fainting already? 18:34:11 kparal: sure! =) 18:34:26 kparal: all time ready !~ 18:34:29 let's ping mattdm 18:34:31 is there any ab we need to worry about? 18:34:31 I can do the new build after Matthew cherry-picks the changes into the f20 branch. 18:34:39 fuck it, i can do that now 18:34:41 brunowolff: thanks 18:34:48 does it include the live key import commit? 18:34:54 we had another fe on that one right? 18:35:00 Viking-Ice: i think i'm on top of them all, but in the interests of raptor proofing / sanity checking let's go through any anyone wants to discuss 18:35:00 adamw: so you'll do it or should I ping him? 18:35:01 no 18:35:11 nirik: the only other proposed FE was the php stuff 18:35:16 mean no with nirik fe 18:35:19 the key thing's already accepted fge 18:35:20 The live key import might have been the changes he did a couple of days ago. 18:35:21 fe 18:35:24 kparal: it was accepted before. 18:35:52 I have a question about accepted blocker 1038969 18:36:07 .fire greenlion 18:36:07 adamw fires greenlion 18:36:07 After that change I asked him to get a bug entered for changes while in freeze and he seems to be playing nice now that he knows. 18:36:12 I think the security team would like to propose php 5.5.7 for F20... but probably not yet done... and probably to late. 18:36:15 greenlion: will come to that. do you need to discuss it ASAP? 18:36:39 adamw needs coffee 18:36:51 kparal, nope, could be on usual schedule 18:36:53 or maybe a scone with honey 18:36:59 firing people left and right 18:37:04 pushed the cloud kickstart thing 18:37:05 seems we're ready for the truly awesome and interesting part 18:37:08 ============================================================ 18:37:09 Accepted Blockers 18:37:09 ============================================================ 18:37:14 if we want to fix the GPG key import let's do that now before s-k gets built 18:37:23 nirik: can you push either your fix or kalev's? 18:37:36 * kparal waiting until this is sorted out 18:37:50 * Viking-Ice goes out for a "fresh air" 18:38:00 nirik: you'll also want to fix matt's GPG import commit for the cloud kickstart as he copied the broken version 18:38:33 adamw: I don't feel strongly about which fix to use... 18:38:47 you prefer the wildcard? 18:40:17 nirik: that was my instinct, but i have no idea why anyone trusts me 18:40:21 toss a goddamn coin 18:40:38 or you can make whichever change you want since you are in there already for this last one? ;) 18:40:58 Let me know when you are ready for s-k to be rebuilt. Matt already started committing his changes and should be ready very soon. 18:42:32 brunowolff: i already committed the one we just signed off on. 18:42:44 let's discuss this in -releng and move on here 18:42:49 ok 18:42:49 ok 18:42:53 #topic (1038847) SizeNotPositiveError: spec= param must be >=0 - "1" as size of encrypted partition 18:42:53 #link https://bugzilla.redhat.com/show_bug.cgi?id=1038847 18:42:53 #info Accepted Blocker, anaconda, POST 18:43:02 OK. I forgot that the author stays the same when cherry-picking. 18:43:41 I still need to wait for the GPG import fix you were just discussing? 18:44:00 so i think vpodzime's test image has an improved version of dlehman's fix 18:44:11 brunowolff: yes, can you join #fedora-releng so we can sync up there 18:44:15 brunowolff: yeah, lets figure that out in releng 18:44:32 i really ought to just look at what's in the updates.img. 18:45:30 is that the same updates.img as for the partition sizes bug? 18:45:36 * kparal checking 18:45:44 i think he threw all his fixes together in one image, yeah 18:45:49 i believe what the updates.img contains is https://lists.fedorahosted.org/pipermail/anaconda-patches/2013-December/007766.html 18:46:26 greenlion's bug :D 18:46:38 he too much tested anaconda 18:46:40 ignatenkobrain, anaconda's bug, not mine! :) 18:47:08 it's the same one 18:47:08 so feedback from jan looks good 18:47:19 i'll verify here too before we go for the big build 18:47:25 Spherical anaconda in vacuum 18:47:30 =) 18:47:31 but this is tricky, if we require only the simple fix for 1040012, then we need to verify again 18:47:38 with a different updates.img 18:47:45 the two shouldn't be related 18:47:51 (five word tech horrors) 18:48:09 right 18:48:42 i want to see a blog on this five word tech horror biz 18:48:44 OK, confirmed, the patch i linked is definitely what's in http://vpodzime.fedorapeople.org/f20_blockers_updates.img 18:48:51 #info seems to be fixed, it would be great to have more verification. the updates.img is the same as for 1040012, therefore containing contentious fixes 18:48:55 so that's what we're looking at including, and initial testing is good. not sure what else to say 18:49:23 move on? 18:49:26 yep 18:49:27 right 18:49:28 if people could run installs with http://vpodzime.fedorapeople.org/f20_blockers_updates.img against all kinds of disks (esp. different sized disks and partitions) and check 'reclaim space' it'd be helpful 18:49:46 #info if people could run installs with http://vpodzime.fedorapeople.org/f20_blockers_updates.img against all kinds of disks (esp. different sized disks and partitions) and check 'reclaim space' it'd be helpful 18:49:56 #topic (1039292) Assigning partition to disk with not enough free space causes custom partition interface to become unusable 18:49:56 #link https://bugzilla.redhat.com/show_bug.cgi?id=1039292 18:49:56 #info Accepted Blocker, anaconda, NEW 18:50:29 oh, we already did this one 18:50:29 we looked at this one already 18:50:43 #topic (1024223) fedup 19->20 failed with DVD iso upgrade 18:50:43 #link https://bugzilla.redhat.com/show_bug.cgi?id=1024223 18:50:43 #info Accepted Blocker, fedup-dracut, ASSIGNED 18:51:04 kparal: new proposed FE after this one, https://bugzilla.redhat.com/show_bug.cgi?id=1020112 18:51:17 so i've reproduced this and tested the fixes and it looks good 18:51:21 further confirmation welcome 18:51:31 adamw: should we do it right now or after accepted blockers section? 18:51:35 requires us to pull the newer fedup-dracut into rc1 and build the upgrade.img with it, then a fix to f19's fedup 18:51:39 lol " 18:51:39 Would be nice if f20 ppc images could boot." 18:51:41 kparal: after this bug 18:51:48 +1 FE 18:52:15 #info seems to be fixed, we need a new fedup for F19 and pull newer fedup-dracut to RC1 18:52:47 @@ now a new proposed FE @@ 18:53:08 #topic (1020112) Fedora 20 alpha DVD is not recognized as bootable disk on Apple G5 18:53:11 #link https://bugzilla.redhat.com/show_bug.cgi?id=1020112 18:53:25 do it now 18:53:29 +1 FE 18:53:32 +1 FE, bcl says the fix only affects ppc paths inside lorax so should be safe and there's an obvious benefit 18:53:32 looking on what bcl wrote in anaconda, +1 FE 18:53:36 +1 18:53:39 +1 FE 18:53:44 does the fix only affect ppc path? 18:53:44 yep. 18:53:44 okay 18:53:44 just the lorax template and ppc mapping file. 18:53:48 +1 FE 18:54:03 * nirik thought apple ppc hw was specifically disclaimed 18:54:41 nirik: that was back when ppc was primary arch, i think 18:55:01 don't think so... back then it was supported. 18:55:06 too long for me to read 18:55:21 proposed #agreed 1020112 - AcceptedFreezeException - This improves situation for Apple G5 18:55:27 ack 18:55:27 ack 18:55:28 ack 18:55:44 doesn't really say, but ok, sure. 18:55:47 ack 18:56:10 #agreed 1020112 - AcceptedFreezeException - This improves situation for Apple G5 18:56:39 back to accepted blockers 18:56:41 #topic (1000893) Desktop Live is oversized (larger than 1 GB) 18:56:41 #link https://bugzilla.redhat.com/show_bug.cgi?id=1000893 18:56:41 #info Accepted Blocker, LiveCD, MODIFIED 18:57:36 seems it *should* be good but you know, s-word 18:57:39 i did a test build with all blocker/fe fixes as of yesterday plus the smaller LO build, it got back under size 18:57:52 so yeah, all we can really do is fire RC1 with the LO update and cross all digits 18:58:09 why do we care slight bigger image size if we don't slight different units in anaconda? :) 18:58:15 ah the glorification of should 18:58:17 lol 18:58:20 =) 18:58:29 greenlion: because we're very, very bad at what we do 18:58:35 never lose sight of this 18:58:45 #info adamw did a test build, we should be under limit 18:58:52 only hardcore only dual-dvd size :D 18:59:03 #topic (1026860) lvm2: services specified with SYSTEMD_WANTS are not started for some LVM volumes 18:59:03 #link https://bugzilla.redhat.com/show_bug.cgi?id=1026860 18:59:03 #info Accepted Blocker, lvm2, MODIFIED 18:59:12 kill that releng dvd that's what I say 18:59:21 so I spent some time today with Peter on this one... 18:59:49 this relates to the one they have to have synced update right 18:59:53 jreznik: a summary please? 19:00:08 uh oh this is starting off really good, like a serious come to jesus talk is about to happen 19:00:46 haha we're going to get a massive summary or really bad news with a pause this long! 19:00:54 cmurf, self biography for christmas 19:00:57 so there are two possibilites I'd say - go against lennart's wish and pick that fix in systemd - a bit more tested or we have a new lvm2 build 19:01:03 sorry, i was just doing something else 19:01:10 jreznik: i don't think it's against lennart's wishes 19:01:17 but we're kinda reading tea leaves 19:01:20 I want to pull in that double fix ont he dvd 19:01:23 mean the 19:01:36 the way i was reading it is that lennart's happy to go with the workaround for release, then replace it with the 'proper fix' on update 19:01:38 as opposed to push it via updated 19:01:45 i would do that 19:01:49 adamw: even that lvm build is still not proper fix 19:01:54 is the new lvm2 build tested? 19:02:05 at this late point i'd hate to go with the 'proper fix' and find it busts something...but of course there are risks to changing the approach post-release too 19:02:07 i'm finding lvm2 this release is just really really testy 19:02:07 but peter don't want to risk proper fix now 19:02:26 cmurf, you rather want to push unested update to a GA release? 19:02:35 no i don't 19:02:46 what we have is tested even if it has some problems 19:02:56 and yes, he's a bit worried about that proper fix as an update but less than for release 19:03:10 an untested new build of lvm2 (?) is not a good idea even if it fixes things, it's unknown what it breaks 19:03:22 and like i said lvm has been finicky this whole release cycle 19:03:29 cmurf, and what do you think happens when we push it via update 19:03:47 Viking-Ice: at least in that case you can roll back to the release versions... 19:03:48 it's better we test now and include at install time then push the update after GA release 19:03:48 marvin the martian blows up earth? 19:03:54 and it gets to go through bodhi 19:04:00 at least we can revert, and it's not on ISOs 19:04:03 #info there is an older systemd fix (which was reverted later) and a newer lvm build. the current approach is probably to use systemd fix in a release and push lvm build to updates 19:04:13 Viking-Ice: we don't have proper fix now, so... 19:04:30 no proper fix, not enough time to test, go-no/go is tomorrow, etc 19:04:30 i would be in favour of sticking with the systemd workaround for final at this point, we have enough moving parts to try and sign off on release tomorrow 19:04:43 jreznik, so what what we release like that, what are we canonical ? 19:04:55 this goose is squirming and squawking to lay her golden egg 19:05:17 adamw: I'm ok with that, we have both options in case of anything got busted more 19:05:33 copper egg maybe 19:05:55 should we move on? 19:06:00 why 19:06:03 yes 19:06:09 Viking-Ice: what is there to add? 19:06:17 pull in the right fix 19:06:23 there isn't one yet 19:06:38 Viking-Ice: iiuic that is just a temporary fix anyway 19:06:58 Fixed In Version|systemd-208-9.fc20 |lvm2-2.02.103-4.fc20 19:07:02 actually it should be easy to get right one, just it's touching more places and devs are not ok with it 19:07:06 that's not the proper fix? 19:07:09 Viking-Ice: no 19:07:16 not the proper-proper one :) 19:07:18 * adamw would be happier with clear information from the devs 19:07:30 but in the absence of that, taking the path of changing less stuff seems appropriate 19:07:35 adamw: what's clear for you? I can look into my memory 19:07:52 jreznik: clear call as to whether they think it's safer to take the systemd workaround or the current lvm2 'fix' 19:07:53 it sounds like a revert for systemd and then not updating lvm2 for release, and then both get updated after release 19:08:03 cmurf: no, there's no reversion 19:08:24 sorry not revert, i meant the minor temp fix 19:08:25 adamw: for this, I really don't have answer, sorry :( 19:08:36 jreznik: all i got when i asked was 'they should be equivalent', which doesn't help a lot 19:08:54 equally broken I guess ;) 19:08:56 take the path of least resistance 19:08:56 that's my understanding 19:09:23 right, in the absence of a particularly convincing reason to change course, i guess we'll just put systemd 208-9 in RC1. 19:09:35 * kparal nods and moves on 19:09:35 if that blows up on us, viking-ice can say he told me so =) 19:09:45 i've been running it without issues for almost a week 19:09:50 208-9 that is 19:09:53 mostly worried about murphy fucking up the connected update 19:09:57 after GA 19:10:00 actually it might need karma 19:10:14 it's already pushed stable 19:10:22 it's been a while since tc5, lots of stuff went stable since 19:10:23 oh nevermind then 19:10:25 #topic (1038969) DeviceCreateError: ('lvcreate failed for fedora/swap: running lvm lvcreate -L 819m -n swap fedora failed', 'fedora-swap') 19:10:25 #link https://bugzilla.redhat.com/show_bug.cgi?id=1038969 19:10:25 #info Accepted Blocker, python-blivet, POST 19:10:32 i kept holding out for rc1 to do a new build, and it never quite happened... 19:10:33 oh ick this one 19:10:37 there are all kinds ways where f update/upgrade go wrong 19:10:41 here I have a question... 19:10:58 looks like it's fixed? 19:11:06 c16 19:11:07 right 19:11:12 #info seems to be fixed, more verification would be handy 19:11:13 in fix they also change semantics of how 'encrypted' checkbox does works 19:11:16 mean 17 19:11:30 i.e. disallowing it on already encrypted container 19:11:34 greenlion: that was actually a separate patch, but it looks sane to me. 19:11:44 greenlion: I actually filed an RFE for it a few weeks back 19:11:53 i don't mind that getting trojanned in, as it seems to only reduce the risk of borkiness. 19:12:03 what could possibly go wrong 19:12:14 so it a separate feature and does it need FE? 19:12:27 this is the point where we turn a blind eye. 19:12:33 adamw: you memorized the whole set of forbidden QA phrases, right? 19:12:40 container vs container 19:12:41 kparal: they're pinned to my monitor 19:13:01 adamw, like ... upgrading from previous fedora release where that was possible 19:13:16 that's a regression 19:13:20 greenlion: shouldn't be relevant, they only patched *anaconda* behaviour 19:13:21 or managing/resizing partitions from previous installation 19:13:48 oh, i see. still don't think it's going to make that any worse, but who the hell knows 19:13:50 ok, reinstalling on top of previous installation... 19:14:03 and opening luks :) 19:14:03 i've got to talk to bcl after this meeting and try to straighten out what exactly we're putting in the next anaconda build 19:14:08 upgrading encrypted = fedup 19:14:10 that's already scheduled 19:14:11 it might have unintended consequences if you reinstall encrypted VG with encrypted LV 19:14:21 but hey, it never worked properly anyway :) 19:14:24 let's face it, chances are high that's already broken 19:14:25 ...yeah :) 19:14:36 feel free to go test it, if you like. 19:14:38 encrypted LV on encrypted PV should be disallowed 19:14:41 oh well 19:14:47 talk about a huge performance hit on non AES-NI hardware 19:14:47 cmurf: that's what the patch we're discussing effectively does 19:15:00 cmurf: the question is whether the change might make anaconda worse at handling *existing cases* of it 19:15:06 and i'm currently attempting to care 19:15:10 haah 19:15:11 ECAREFAIL 19:15:15 ok 19:15:17 #topic (1035536) Final spin-kickstarts build required for Fedora 20 GA 19:15:17 #link https://bugzilla.redhat.com/show_bug.cgi?id=1035536 19:15:17 #info Accepted Blocker, spin-kickstarts, MODIFIED 19:15:19 yeah 19:15:37 okay, we're on this one. we pushed the two desired s-k FE changes and bruno's building a new s-k. 19:15:37 brunowolff is on it. ;) 19:15:51 #info the new build needs karma 19:16:04 oh, there will be a new one then? 19:16:07 yes 19:16:08 #undo 19:16:08 Removing item from minutes: 19:16:19 #info there will be a new build soon and it will need testing and karma 19:16:23 if we have everything right, RC1 will build from ce61f186bb2c5b6ba998c59434fac64a4b3dcb81 19:16:42 the way to karma this would be simply to satisfy yourself the spin-kickstarts package matches that git commit from f20 branch of s-k git 19:16:56 i have once caught a case where the build was done wrong, so, you know, do actually check it. 19:17:18 (i usually install the s-k package, check out s-k git at the appropriate commit, and run some diffs.) 19:18:23 do you want to discuss some specific accepted FEs? 19:18:41 that's all the blockers? 19:18:43 yes 19:19:00 has anyone tested https://admin.fedoraproject.org/updates/FEDORA-2013-23185 ? 19:19:08 the bug for it is accepted FE, but 0 karma scares me a bit 19:19:20 other than that it's all anaconda stuff 19:19:23 ============================================================ 19:19:23 Accepted Freeze Exceptions 19:19:23 ============================================================ 19:19:34 Add a comment >> 19:19:34 Bodhi Version: 0.9.7.4 -- Server: app01 19:19:34 Copyright © 2007-2011 Red Hat, Inc. and others. 19:19:34 Licensed under the GNU General Public License v2 or later. 19:19:35 The Fedora Project is maintained and driven by the community and sponsored by Red Hat. 19:19:35 This is a community maintained site. Red Hat is not responsible for content. 19:19:37 [ Legal, Trademark Guidelines, Source Code ] 19:19:40 that kinda narrows it down 19:19:42 #info https://admin.fedoraproject.org/updates/FEDORA-2013-23185 needs testing 19:19:47 frack copy paste fail 19:19:57 as in, within the next hour or two... 19:20:11 I don't have bluetooth to test with 19:20:14 * roshi has nothing with bt 19:20:41 * jreznik is looking 19:21:04 heh, I could try to connect two laptops. is it supported? :) 19:21:19 oh hai, found another resize crasher 19:21:23 this shit really just doesn't work... 19:21:31 adamw: reproducible? 19:21:32 kparal: you could at least pair them, i think 19:21:45 I'm going to try it, give me a sec 19:21:46 kparal: dunno, it's the weird-500MB-partition test with the latest updates.img, try and resize it to smallest possible size 19:21:58 adamw, disable resize at all?) 19:21:58 :/ 19:22:09 adamw, right let's ship with completely failed resizing in the installer 19:22:15 which adds way to much to / 19:22:21 of people hd 19:22:24 sizes 19:22:44 Viking-Ice: we've done it for two releases, why stop now?! 19:22:46 no, disable Manual Partitioning, then ship 19:22:54 cmurf: this one's in Reclaim Space 19:23:06 oops 19:23:16 and the resize plot thickens 19:23:30 well i'm increasingly opposed to resize 19:23:46 anaconda says it can shrink things it doesn't know can be shrunk 19:23:48 yes yes we all know that let's just kill anaconda 19:23:56 no more bugs and endless time for QA ;) 19:23:56 if it's an unrecognized format, it assumes it can shrink it 19:23:58 which seems bad 19:24:17 seems like bluez is still crashing... 19:24:18 everyone hates resize, everyone hates us more if we drop it 19:24:19 it should only offer resize UI when the resize can be assured data will be retained 19:24:34 that's basically impossible 19:24:45 we can't guarantee the output of whatever tool we call to do the resize 19:24:48 anyhow 19:24:48 bluez singing the blues 19:25:10 heh, no - bad bluez 19:25:21 that's not what i mean, i mean even offering the ui in the installer when it has no idea what it's looking at 19:25:36 some bug in an underlying tool is a different matter 19:26:10 adamw: I reproduced your crash 19:26:21 * adamw talking to anaconda bout it 19:26:27 #topic Open Floor 19:26:33 cmurf: sure 19:26:51 Viking-Ice: hey, this 'fuck anaconda' approach sure is liberating, isn't it :) 19:26:53 cmurf, anaconda used to show end users if they had two hard disk the wwid of the disk not master or slave so people had 50%/50% chances of wiping their backup drive if the drive was of same manufactorer or model 19:27:02 not ok 19:27:04 that's anaconda ui design for you 19:27:05 yeah, we've sucked for years 19:27:21 and the old dialog about 'hey, we don't understand what's on this disk, would you like us to delete it?' worded as confusingly as possible 19:27:27 that was mizmo's favourite 19:27:35 e.g. i have a bug, not blocker because there's no data loss, where the UI shows that encrypted Apple Core Storage partitions are resizable 19:27:43 well we need to do something about the anaconda it's development cycle is not panning out for us 19:27:46 and it's because the underlying format isn't known 19:28:01 unknown format = no format = resizable 19:28:10 not good logic IMO 19:28:37 I think we should just keep will drunk and move to the next level with fedup no more installing ;) 19:28:39 only recognized formats should have UI for resize. if it's not recognized, then the user must be required to delete and recreate only, not resize 19:29:05 Viking-Ice: good idea 19:29:21 * cmurf buys first round 19:29:44 cmurf, you need to go in the woods for that proper moonshine 19:29:50 cant get it in a bar 19:30:02 so, anything else to discuss? 19:30:13 are we done with the lists? 19:30:17 it seems that adamw tries to forget about 1040650 19:30:21 yes, we're done 19:30:34 he's chatting to anaconda team i think still 19:30:42 yes 19:30:46 off meeting chatting 19:30:48 no no 19:31:03 so lets just get a summary from that for the record then we're done 19:31:09 let's just pretend it never happened 19:31:12 let's have it on record 19:31:16 so that we can fire him later 19:31:28 i think he needs sugar 19:31:30 I DENY EVERYTHING 19:31:31 fire-ing him is letting him off easy 19:31:42 triage transifex for 5 cycles 19:31:47 now that's proper punishment 19:31:47 can you prove i haven't been hacked by the NSA? 19:31:57 penetrated by the nsa no 19:31:57 adamw: yes 19:32:05 can't prove that you aren't them either 19:32:17 cmurf: go ahead! 19:32:19 ok guys, thanks for coming 19:32:36 cmurf: pay no attention to the drones circling above your home. 19:32:38 * kparal detonates this meeting in a minute 19:32:42 are we still forgetting about that bug 19:32:51 Viking-Ice: well, i'm not proposing it as anything. 19:33:15 why not 19:33:21 adamw: i'm just being goofy, obviously we have all been hacked because to do what they say their mandate is, they have to know everything in order to prevent nothing. something like that. 19:33:22 so could we get around blockers by just not proposing them? 19:33:32 * roshi thinks maybe we could use that in the future :P 19:33:35 apparently so 19:33:54 Well I'm proposing it as a blocker then 19:33:55 roshi: that's my policy after beta ;-) 19:34:13 lol 19:34:20 we should probably discuss that 19:34:30 sigh. fine. 19:34:43 so with bluedevil, it no longer crashes but I'm unable to pair 19:34:51 #topic 1040650 - ValueError: invalid target size request 19:34:58 #link https://bugzilla.redhat.com/show_bug.cgi?id=1040650 19:35:20 so if i'm still clinging to my quality hat, i guess it's kinda hard to -1 this 19:35:26 right 19:35:26 it seems we can no longer shrink to minimal size with the patch 19:35:32 it's a resize request. anaconda doesn't try it properly. 19:35:38 kparal: no, it's broken without the patch too. 19:35:55 adamw: just for this 'weird' partition or for any? 19:35:58 if we fix it on top of the patch, it actually ought to be safer than without the patch 19:36:03 kparal: not sure about the non-patch case 19:36:11 I think with this patch it will crash on any 19:36:17 the patch case will be broken almost always, i think, because it rounds the min size down 19:36:20 shrunk to minimal size 19:36:27 yes 19:36:28 but we may be able to fix it 19:36:40 which is the worse behavior, with or without the patch? 19:36:41 yes, if we at least +1 FE it 19:36:43 shouldn't we default to roundin gup? 19:36:53 "Proposing as a final blocker, per beta criterion: ""Custom partitioning: Reject or disallow invalid disk and volume configurations without crashing.", with resize issues acceptable as Final blocker." 19:36:57 that would ensure you never try to over-allocate 19:37:06 it violates that blocking criteria right 19:37:10 looks like +1 blocker for 1040650 19:37:21 make sense to me 19:37:28 +1 blocker 19:37:30 gray area 19:37:36 is it actualy invalid? 19:37:43 adamw: why did you go and test more... silly person! :) 19:37:45 cmurf, what's gray about it violating the criteria 19:37:46 or is the installer UI fussy? 19:37:51 cmurf: it shrinks to smaller size than supported 19:38:02 it rounds down the size 19:38:04 and then crashes 19:38:05 so the UI is allowing an invalid size 19:38:11 then the installer crashes 19:38:19 ugly. 19:38:27 do i have that correct? 19:38:27 size should always round up 19:38:39 so, it should let you resize to 1MB? 19:38:52 roshi, then you will have something oversize... 19:39:02 nirik: to whatever the filesystem supports 19:39:04 roshi: maybe on shrink it should, but not catagorically because we've had bugs where it rounds up LV's and then they're too big for the space left in a VG and we get a crash 19:39:05 there are always some metadata 19:39:24 resize2fs can actually tell you that 19:39:32 if it rounds up, then it would throw an error saying there wasn't enough space, right? 19:39:34 oh 19:39:50 the file system guys are all a bit skeptical of resizing too you know 19:39:52 resize should be like bounded to fs min/max size 19:39:54 * roshi was thinking all perfect-world and whatnot 19:39:55 min size should always round up. max size should always round down. that should be fairly safe. 19:39:55 in reality anyone doing this would just re-run and not be so silly? or is there some valid case for 'super small partition' ? 19:40:16 kparal dlehman: that's a good policy 19:40:26 nirik: but he won't know the cause 19:40:56 it's not like the error message is super descriptive 19:40:56 nirik: no and i think one could argue less than 500MB might be a bad idea to the point it's a bug in resize2fs 19:40:59 or any resizer 19:41:05 I suppose, unless they report the crash and look at the bug. 19:41:11 * greenlion wonders why anaconda reuses gparted or gnome-disks code for doing such things... 19:41:17 not reuses* 19:41:29 greenlion: it uses pyparted which uses parted which is what gparted uses 19:41:35 hence gparted 19:41:40 graphical parted 19:42:02 i don't know what gnome-disks is using off hand 19:42:03 are we mostly +1? 19:42:08 but console parted does not allow resize currently, or does it? 19:42:15 well, I'm definitely +1FE... blocker, not sure... it seems an odd case again... not something most people would do, or if they did they would rerun and not do that again. 19:42:20 kparal, I would think so it's odd to be -1 on this one 19:42:23 +1 FE 19:42:35 ficures 19:42:48 * jreznik is with nirik 19:42:58 the crash occurs during installation 19:43:07 so some partitions may already be wiped 19:43:17 just saying 19:43:19 seriously guys if that's the attitude with blocker bug we should just stop doing these meetings 19:43:20 it's very obviously violating the criteria so it ought to be a blocker based on the criteria text HOWEVER 19:43:32 but they were going to be anyhow, since they were, you know, planning to install? 19:43:33 if the plan is to push the release out the door no matter what 19:43:42 I'm +1 19:43:44 Viking-Ice: at a certain point yes 19:43:55 short of explosions 19:43:58 that is not my "plan". I am just discussing each bug as I feel. Feel free to disagree with me. 19:44:05 adamw: do we still have you? 19:44:14 sorry, was chatting with someone else 19:44:33 this is still bug 1040650? 19:44:34 we need some votes 19:44:37 cmurf: yes 19:44:39 it's scrolled way up off the screen 19:45:05 i find it hard to be -1 on this unless anaconda tell us it's structurally impossible to fix reasonably 19:45:11 strictly speaking we ought to be +1 blocker on the merits, but realistically +1 FE is more practical because this is sort of an edge case to click shrink and then slide it all the way down to minimum 19:45:16 esp when minimum is what, 15MB? 19:45:18 that's just nuts 19:45:23 19:45:29 +1 19:45:32 actually, doesn't this affect 50% full partitions? 19:45:42 20GB partitions, 10GB occupied 19:45:45 oh shiitake 19:45:49 yes 19:45:51 shrink to minimum, i.e. to 10GB 19:45:59 ok 19:46:00 and it will crash 19:46:03 wel then that's a +1 blocker 19:46:08 thank you! 19:46:12 since it's going to be a half megabyte under the limit 19:46:15 that wasn't clear from the bug to me at least 19:46:21 me neither 19:46:28 I'm just assuming 19:46:30 i thought we were talking about ridiculously small shrinks 19:46:33 it's rounding down, always 19:46:36 got it 19:46:41 but it seems logical 19:46:45 it would be good to know that for sure. 19:46:46 :) 19:46:47 yes 19:46:51 yeah, i don't think the size of the disk being resized or the minimum size itself actually matters, the rounding's the issue 19:46:56 but if thats the case I would be +1 19:47:02 exactly knowing matters 19:47:12 should I test? I can do it in 3 minutes 19:47:16 resizing to absolute minimum seems like it's unusual as it means you can't put anything more on the resize partition (in which case why are you keeping it?), but i'm sure someone has a plausible reason for it 19:47:18 yes sir that would be great 19:47:19 kparal: yeah, might be nice 19:47:23 sure. 19:47:25 remember to use the updates image 19:47:39 and "weird" partition size 19:47:41 adamw: yeah i think it practically makes teh resized volume useless or nearly so 19:47:41 * nirik turns on the elevator music. 19:47:47 muzak! 19:48:16 adamw, I dont think it's unusual you look at what the installer says is the minimum rezisie option and resize to that 19:48:40 i don't know about that 19:48:46 Viking-Ice: but then what do you do with that volume? it's only really useful if you want to keep it around for reference but never ever put any more data on it 19:48:51 but then i'm skeptical of resizes 19:48:51 which i guess happens, but isn't terribly common 19:48:56 still, i'm still +1 at this point 19:49:05 that's +4 -3 19:49:08 for blocker 19:49:19 i'm +1 contingent on any minimum amount set causing a crash 19:49:39 so let's accept it then as a blocker and move on 19:49:48 we have nothing else 19:49:52 or rather #end-meeting 19:49:53 * greenlion still +1 for blocker 19:49:55 waiting for kparal 19:50:11 to do what exactly 19:50:26 he's checking it affects other scenarios 19:50:28 if it doesn't crash on minimum when minimum is ~1GB 19:50:33 there are some contingent votes 19:50:40 in the reclaim dialog, the minimum displayed is 359.7MB, but I can drag the slider only to 360MB 19:50:45 only 2 by my account 19:50:45 if it only crashes on ridiciulously small minimums, pff i'll be -1/+1 19:50:53 let's try a few different cases 19:50:58 and resizing worked well 19:51:03 so no crash? 19:51:09 not this time 19:51:17 ok so we have an x factor here 19:51:23 want to vote conditional blocker if it can be reproduced for minimums < 1GB? 19:51:30 and here we go again... 19:51:31 good idea 19:51:41 except > 19:51:43 not < 19:52:00 if crash greater than 1GB, then block 19:52:02 +1 FE if it is less than 1GB +1 Blocker if greater? 19:52:08 right 19:52:10 details cmurf, details 19:52:16 and i'm open to the amount 19:52:22 500MB might be reasonable ?? 19:52:25 I think that's a reasonable compromise 19:52:27 but not less than that 19:52:27 I'm +1 blocker regardless 19:52:38 * greenlion is with Viking-Ice 19:52:52 I don't think that partition sizes matter. I think it matters whether this happens with not-just-empty partitions, resized to minimum 19:52:56 we had +4 vs +3 earlier 19:53:00 I lean +1 on it 19:53:08 mean +4 vs -3 earlier 19:53:19 * roshi was just trying to come to some sort of actionable compromise 19:53:44 kparal, what's your vote 19:53:54 +1 19:54:03 i think there are enough votes for blocking then no matter what 19:54:04 there we have it 19:54:12 time for accept and end 19:54:15 yep 19:54:16 yep 19:54:37 a sec 19:55:00 just realize there's almost no chance of this getting fixed by go/no-go 19:55:04 * Viking-Ice goes dancing with nirik elevator music 19:55:11 yeah 19:55:18 but what can you do? 19:55:21 right 19:55:27 tried once again, it worked again. with non-empty partitions it seems to work OK 19:55:30 wel the blocker board has to be cleared to get an RC right? 19:55:33 but we can't be sure 19:55:36 yeh 19:55:40 cmurf: yep 19:55:42 it does cmurf 19:55:50 so, it's only on empty partitions? 19:55:52 i really think the conditional blocker should be considered but… 19:56:09 the votes are already in 19:56:11 i know 19:56:17 i like to argue i'm contrary 19:56:26 * nirik wonders why everyone is in such a hurry. :( 19:56:32 cmurf: accepted blockers have to be addressed 19:56:52 shit happens with anaconda is more then everything else apparently 19:57:03 adamw: and we need an RC before go/no-go 19:57:08 yes 19:57:10 proposed #agreed 1040650 - AcceptedBlocker - We're worried that this happens not only for empty partitions, but also for somewhat filled parttions shrunk to minimal size, which violates "Custom partitioning: Reject or disallow invalid disk and volume configurations without crashing." If the developers are certain this is not true, the status can be re-evaluated. 19:57:13 ack 19:57:16 how much lee way on RC testing do we have for a go? 19:57:19 ack 19:57:19 Viking-Ice: couldn't have read that 19:57:21 ack 19:57:28 ok, ack 19:57:29 kparal: can you play with it some more while i try and pull together a patch set? 19:57:35 kparal, what do you mean ? 19:57:35 adamw: sure 19:57:43 Viking-Ice: you were too fast 19:57:43 ack 19:57:46 proposed #agreed 1040650 - AcceptedBlocker - We're worried that this happens not only for empty partitions, but also for somewhat filled parttions shrunk to minimal size, which violates "Custom partitioning: Reject or disallow invalid disk and volume configurations without crashing." If the developers are certain this is not true, the status can be re-evaluated. 19:57:46 ack 19:57:47 cmurf: lee way in what sense? 19:57:53 cmurf: we need to get as much done as possible esp. in the installer matrix, rc1 is quite different from tc5 19:57:56 ack 19:57:58 #agreed 1040650 - AcceptedBlocker - We're worried that this happens not only for empty partitions, but also for somewhat filled parttions shrunk to minimal size, which violates "Custom partitioning: Reject or disallow invalid disk and volume configurations without crashing." If the developers are certain this is not true, the status can be re-evaluated. 19:58:00 kparal, or your latency to slow 19:58:05 kparal: he read "acceptedblocker" only haha 19:58:11 I know 19:58:15 :) 19:58:42 nirk adamw: i understand i mean go/no-go is tomorrow about midday so at what time must an RC appear by for a go to happen? 19:58:52 jreznik: for my reference, do we have any chance to do a one-day slip for final or is it 'tomorrow's meeting or bust'? 19:58:52 probably need to remove 1021749 from blocker tracker? 19:59:05 cmurf: asap. i'm going to try and get one built asap. 19:59:09 adamw: that's my question 19:59:24 do we have a one day slip possibility 19:59:30 greenlion: it's intentionally in undetermined state. 19:59:36 ah, ok 19:59:48 adamw: in case we would be in somehow shipable state, I'd be ok with repeated Fri Go/No-Go 19:59:56 and I expect nirik and dgilmore would be too 19:59:58 I received AVC on install, that's a blocker :) 20:00:14 that's autoblocker 20:00:21 someone please tape kparal to the wall 20:00:26 both of you 20:00:28 so yeah i have a bunch of avc messages also on every install i idn't realize that was blocking 20:00:31 oh 20:00:31 kparal: you're not suppose to touch installer! 20:00:42 but the installs succeed so... 20:00:45 if this is in the DVD and you don't get a popup noptification we're fine 20:00:46 so bust? see you in Jan? :) 20:00:55 it's only things that produce a visible notification we care about 20:01:00 got it 20:01:16 kparal, test it on live! 20:01:21 TAPE TAPE TAPE 20:01:27 adamw, I guess that depends on what exactly triggers the avc 20:01:32 stick a finger in it! 20:01:43 Viking-Ice: anaconda isn't remotely selinux safe, we've known that for years 20:01:50 that's why selinux is set permissive while anaconda's running 20:02:02 it was on live 20:02:07 selinux is just on live 20:02:12 adamw, oh I just knew anaconda isn't remotely safe for anything 20:02:15 kparal: did you actually get an AVC popup? 20:02:15 lol 20:02:18 adamw: yes 20:02:22 sigh. doing what? 20:02:29 nothing, finishing installation 20:02:33 mmmm selinux must be on DVD also in order to set the labels correctly during install 20:02:40 https://bugzilla.redhat.com/show_bug.cgi?id=1040444 20:02:44 what a lovely bug number 20:02:48 cosmic ray 20:02:51 transient 20:02:56 I've seen sexier numbers 20:02:57 just look away son 20:03:11 seem I'm not the only one 20:03:25 might be the updates.img used 20:03:43 jsedlak also used it today, even though I don't know whether for that installation 20:04:00 kparal, did you change hostname in network config during that? 20:04:05 greenlion: no 20:04:11 is it reproducible? 20:04:15 it's the "after installation" phase 20:04:25 hmm 20:04:31 adamw, 2 have hit it so far so I would say yes 20:04:39 * adamw tests 20:04:55 huh, but only today? 20:04:59 but why it happened today? maybe it's really connected to updates.img 20:05:00 2 is not a scientific sample 20:05:03 the 'possible duplicate' is from f19 last month 20:05:42 don't create a user during the installation, I didn't do that 20:05:53 maybe it is related 20:06:02 just when anaconda waits for it 20:06:04 i will try this with the updates img and live and try to break it 20:06:09 i emit cosmic rays 20:06:30 we're over time limit today, but I guess this time it is allowed 20:06:33 but first i have to get a hair cut 20:06:40 * jreznik has to run now, moving IRC to the phone 20:06:44 i'll report on #fedora-qa 20:06:47 * greenlion guesses it depends on moon phase 20:08:56 well, shit, i see it too. what the freaking fuck. 20:09:07 adamw: have you used the updates.img? 20:09:09 yeah 20:09:11 trying without 20:09:18 I didn't and I don't see it 20:09:18 it def does not happen without 20:09:26 so it's the updates.img 20:09:30 so 3 have seen it 20:09:39 awooga dan walsh 20:09:42 it might not happen when the patches are included 20:09:50 maybe this always happens if you use any updates.img 20:09:51 or undo the patch 20:10:01 it's calling hostname 20:10:02 kparal oh crap don't say that out loud! 20:11:40 or type it in silence! 20:12:13 which updates.img are you using? 20:12:27 http://vpodzime.fedorapeople.org/f20_blockers_updates.img 20:12:45 i've used quite a few updates images and they weren't causing avc denials 20:12:53 oh, 'happens when you use an updates.img' sounds plausible, since it affects network stuff.. 20:13:01 but i don't think i've used an updates.img since systemd 208-8 came out 20:13:21 kparal: you could try running an install with one of the smaller updates.img's i built last night and posted in various bugs? 20:13:43 adamw: can you give me a link? 20:13:50 kparal: default install triggers this? 20:13:59 cmurf: Live default 20:14:13 so it's an blocker let's accept it and move on 20:14:23 kparal: /var/www/html/extras/updates-1040012.img maybe 20:14:31 Viking-Ice: not if it only happens if you use an updates.img 20:14:37 bit hard to be sure about that, though 20:14:48 Let Dan take care of it 20:15:24 so accept it conditionally - if it happens without updates.img -> blocker? 20:15:24 we can un-blocking it's ones in a full moon when very one sock and a boot on your left foot kind of thing 20:16:01 conditional accept sounds ok to me 20:16:04 we could close out this meeting I guess and vote in bug as more info shows up... or wait. 20:16:20 well 20:16:26 actually, can we punt, for procedural reasons? 20:16:36 yes 20:16:36 the best way to check if it happens without an updates.img or not is just to build RC1 and see 20:16:44 but if it's accepted as a blocker, technically, i can't do that 20:16:51 true 20:16:59 so it works best to leave it proposed and set it accepted if we build RC1 and it turns out to affect it 20:17:04 well we need to file it as an blocker and punt 20:17:14 yeah, propose as a blocker and punt seems the best approach 20:17:15 ( so we keep it on the radar ) 20:17:19 yep 20:17:37 actually maybe i can do a smoke test live with the new anaconda when it's built and we check with that 20:17:37 adamw: that is not a link. can't google that file 20:17:45 kparal: oh haha, forgot to edit 20:17:55 adamw: yeah that's faster to just do a smoke test live 20:17:55 http://www.happyassassin.net/extras/updates-1040012.img 20:18:17 * jreznik thinks everyone here would have a nice yaks farm soon :) 20:18:27 i found two 20:18:41 this release cycle has been sunshine and rainbows compared to F18 20:19:03 true 20:19:11 almost to post-install 20:19:45 Viking-Ice: after F19 it looks like F18 again, we just forgot real F18 20:19:57 Viking-Ice: hah, triaging transifex is sunshine and rainbows compared to f18 20:20:21 adamw: testing 20:20:50 sooo are we getting closer to end-meeting or does someone else have something up his sleeve 20:20:54 confirming kparal's results so far, happens with the updates.img, not with tc5 and no updates.img 20:21:10 which updates.img 20:21:12 any? 20:21:14 just punt it :) 20:21:27 or just vpodzime's? 20:21:32 avc are autoblockers and if the root cause is found... 20:21:49 Viking-Ice, avc with updates.img is not, I guess 20:22:00 cmurf: so far i only tried vpodzime's, kparal is trying another 20:22:22 Dan probably has fixed this since we have started discussing he has 6th sense about these things 20:22:33 greenlion, network install/updated install 20:22:42 Viking-Ice: it's an autoblocker if it always happens, i'm fine wiht -1 if it only happens when using an updates.img on live. 20:22:43 are affected right 20:22:47 well it also implicates systemd and are we not going to have 208-9 in RC1? 20:22:52 "Notifications that only happen on unusual configurations are excluded" 20:22:54 and if it will be confirmed on RC1 it could be auto-blocked on its own without meeting, I think 20:22:58 yeah, rc1 would be 208-9 20:23:03 greenlion: indeed 20:23:06 adamw, what are the usecases for updates.img on live 20:23:07 roll a smoke 20:23:26 Viking-Ice: same as updates.img anywhere, but since this is a 'polish criterion' as long as the install still works it doesn't seem like an issue 20:23:27 and how common are they ( do we think ) 20:23:46 not that common, you only use updates.img if you need to get something fixed, and at that point we probably already lost from a 'polish' perspective 20:23:53 kik 20:23:54 lol 20:23:55 with vpodzime's udpates.img i get the avc notification as well on live 20:23:57 (since you found a bug and had to be directed to an updates.img , most likely) 20:23:59 without it i don't 20:24:05 it occurs when the initramfs is being generated 20:24:19 cmurf: the thing we're testing now is if some *other* updates.img causes it, to try and determine whether it's the changes in the updates.img causing it, or just the fact of using one 20:24:20 probably extracting update.img messes up with selinux labels? 20:24:40 adamw: i know, i'm just behind 20:24:51 so we are back at punt? 20:25:10 it is not an autoblocker but propose as blocker to track and then punt 20:25:24 need to see if another updates.img causes it 20:25:32 every time we go in circles a kitten dies and someones beer goes flat 20:25:38 * greenlion is with cmurf 20:25:40 and I hate drinking flat beer 20:25:52 cmurf, try empty? 20:26:01 what is the native language that phrase is said in? 20:26:02 just #info what we agreed already and let's go 20:26:09 right 20:26:22 kthxkbai 20:27:30 adamw: no avc with your updates.img 20:27:37 which is kinda bad news 20:27:43 I guess 20:28:15 kde 'heisenbug' was 'fixed', right? 20:28:29 must hang on for #info and #end-meeting 20:28:36 lol 20:28:36 kde bug, yeah 20:28:43 kparal: oh dear, yeah, that is bad news 20:28:54 so what of the changes in that updates.img could possibly be causing this? it seems odd 20:29:07 punt and figure otu 20:29:10 so, #ndmeeting and discuss in #fedora-qa? 20:29:11 think all flat beer 20:29:13 sure 20:29:16 #endmeeting