15:31:54 #startmeeting RELENG (2014-09-29) 15:31:54 Meeting started Mon Sep 29 15:31:54 2014 UTC. The chair is dgilmore. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:31:54 Useful Commands: #action #agreed #halp #info #idea #link #topic. 15:32:00 #meetingname releng 15:32:00 The meeting name has been set to 'releng' 15:32:00 #chair dgilmore nirik tyll sharkcz bochecha masta pbrobinson 15:32:00 Current chairs: bochecha dgilmore masta nirik pbrobinson sharkcz tyll 15:32:02 #topic init process 15:32:08 hola all who is here 15:32:11 * nirik is here 15:32:11 hi everyone 15:32:14 * sharkcz is here 15:32:16 * pbrobinson is 15:34:43 hi 15:35:05 lets get moving 15:35:17 #topic #5931 [Proposal] Move new branch and unretire requests to pkgdb2 15:35:22 https://fedorahosted.org/rel-eng/ticket/5931 15:35:35 #info nothing new from pingou 15:35:36 pingu said in #fedora-releng that there was nothing new 15:35:55 #topic #5967 Enable source repo generation 15:36:00 I have still failed here 15:36:24 #action dgilmore still needs to ask for more info 15:37:04 #topic #4071 Block pushes to origin/ in gitolite ACLs 15:37:09 https://fedorahosted.org/rel-eng/ticket/4071 15:37:14 bochecha: has a patch here I think... 15:37:20 he does 15:37:21 yeah 15:37:25 its in the ticket 15:37:50 both for installing the hook in new repos, and the check to run on older repos so they also get the hook 15:38:05 #info patches in the ticket need review 15:38:09 it looks okay to me 15:38:21 can someone merge it then, so we test in in staging? 15:38:41 sure 15:38:53 #action dgilmore to apply patch 15:39:38 I'll note that distgit staging starts diverging from production, as production is still in puppet 15:40:11 do we want to move distgit production to ansible before F21 at all, or should we postpone that until F22? 15:40:38 I thought we would move to gitolite3 and distgit at once? 15:40:44 or is that not the plan? 15:40:48 * bochecha is just worried that we need to push a change to production, but we can't because staging is too different 15:40:58 dgilmore, we already moved to gitolite3 :) 15:41:00 in staging 15:41:04 bochecha: right 15:41:08 staging is in ansible, on rhel7, with gitolite3 15:41:14 right. 15:41:15 so staging is already a lot different to prod 15:41:16 lots of changes 15:41:25 yeah 15:41:29 I was thinking we would do that after f21 15:41:35 since it could be a lot of changes/bugs. 15:41:45 nirik: seems like the right time to do it 15:41:54 and if we need to send a change to prod, then we might not be able to test it in staging? 15:41:57 January sometime 15:42:01 I don't know that this change is urgent enough to want to push to prod before then 15:42:10 bochecha: we already can't test in staging 15:42:20 bochecha: yep... but in the past our stg instacnce was not very testable anyhow. 15:42:25 ah, ok 15:42:58 well, no worries then :) 15:43:41 I do not think this is urgent enough to need to go into prod straight away 15:44:18 #info move to production after f21 with lot of changes 15:44:25 #undo 15:44:25 Removing item from minutes: INFO by tyll at 15:44:18 : move to production after f21 with lot of changes 15:44:27 #info move to production after f21 with lots of changes 15:44:32 dgilmore, that wasn't what I meant, I was just worried about testability of something else that might be urgent ;) 15:44:50 we can always spin up another puppet based stg instance if needed. 15:44:57 would be a pain, but can do it. :) 15:44:59 but if we didn't really test in staging in the past, then the current situation doesn't make things worse :) 15:45:06 bochecha: sure but we can not test today as its way too different already 15:45:33 bochecha: right, just some firefighting if things go bad :( 15:45:52 dgilmore, right, I was speaking more generally, not this change in specifics (I probably shouldn't have conflated the two in the same #topic, then) 15:45:53 or setup a puppet based stg if we think its really needed 15:46:01 bochecha: indeed 15:46:09 okay lets move on 15:46:15 #topic #5878 noarch packages corrupted on import on ppc.koji.fp.o 15:46:21 https://fedorahosted.org/rel-eng/ticket/5878 15:46:27 so this has nothing to do with us 15:46:31 its a bug in koji 15:46:46 koji-shadow needs to verify the rpms it imports 15:47:18 move to koji-shadow bug? 15:47:22 (is that even packaged?) 15:47:28 nirik: its part of koji 15:47:29 #info bug in koji 15:47:38 it is, part of koji-utils 15:47:49 k 15:49:44 feel free to add me as a cc to that bug pls 15:50:20 #topic #5959 Enable keep-alive connections for koji (primary and secondaries) 15:50:27 https://fedorahosted.org/rel-eng/ticket/5959 15:50:39 I thought we agreed to enable everywhere lastw eek 15:50:50 seems we just forgot to update the ticket 15:50:56 and make sure its enabled everywhere 15:51:22 #info updating ticket was forgotten, it should be enabled everywhere 15:51:32 #topic #5963 Orphaned vulnerable packages in EPEL 15:51:35 https://fedorahosted.org/rel-eng/ticket/5963 15:51:46 there is still tooling missing 15:52:09 unless there is a volunteer now, I guess we can skip it 15:52:27 #action volunteer needed for toolingh 15:52:31 #undo 15:52:31 Removing item from minutes: ACTION by dgilmore at 15:52:27 : volunteer needed for toolingh 15:52:34 #action volunteer needed for tooling 15:52:52 #topic #6000 automate creation of excludelist for koji-shadow 15:52:58 https://fedorahosted.org/rel-eng/ticket/6000 15:53:24 I added the lists being built nightly. I need to debug why its not quite working right 15:53:53 where should the output land? 15:54:09 nightly branched and rawhide log files 15:54:15 ok 15:54:19 http://kojipkgs.fedoraproject.org/mash/branched-20140929/logs/excludearch-arm.log 15:54:21 #info scripts were adjusted, but need debugging 15:54:22 for instance 15:54:39 its only doing the first letter and not all of them 15:55:49 sharkcz: http://kojipkgs.fedoraproject.org/mash/branched-20140929/logs/excludearch-s390.log 15:55:54 is the s390 one 15:56:10 I think I see it - --path /mnt/koji/mash/branched-$DATE/$BRANCHED$EXPANDARCH/source/SRPMS/*/ 15:56:24 they are in the format of excludearch-.log 15:56:32 it takes only the first dir here 15:56:46 sharkcz: we have to use a wildcard 15:57:37 ./srpm-exlcuded-arch.py -a "ppc64,ppc64le" --path /mnt/koji/mash/rawhide/source/SRPMS/\*/ 15:57:45 but it gets expanded when ./srpm-exlcuded-arch.py is called 15:57:52 last time i manually ran it i had to escape the * 15:57:52 not inside it 15:58:04 easily fixed 15:58:15 yep 15:58:34 #action dgilmore to fix up the calls 15:58:59 sharkcz: so from tomorrow we should have them created nightly 15:59:58 perfect :-) 16:01:11 #topic #5886 need method for distributing urgent fixes... urgently 16:01:17 https://fedorahosted.org/rel-eng/ticket/5886 16:01:30 so we had a need for this last week again with bash 16:01:44 twice 16:03:00 I do not think that we need to have a testing repo for these updates 16:03:39 I was wondering, will we create one for Rawhide as well? Then it can be used for testing 16:03:42 in the examples we have had people grabbing from koji and testing has been sufficient 16:03:54 we could have a rawhide one 16:04:11 the person who adds the builds to the repo can call for testing before they are added 16:04:13 though there would never be any rawhide bodhi integration 16:04:40 nevertheless, it is a lot easier for testers to test if everything is just in a testing repo 16:04:58 it also makes sure that everyone is testing the same set of updates and not accidently some other koji build 16:05:45 I also want to not have any of this rely on fedmsg 16:05:59 just because fedmsg has no reliabiliy guarantee 16:06:14 so, this would start for f21? or a fedora-release update for older releases to enable it/ 16:06:33 nirik: we could do both 16:06:41 f21 ships by default with it 16:06:42 perhaps we look at doing it for rawhide/f21 now and once it's all setup do the older 16:06:45 #info do not rely on fedmsg 16:06:49 but we backport to f20 16:07:34 fedmsg is not really necessary 16:07:40 and we need to write up exactly how it works/policy 16:07:47 a wiki page perhaps 16:08:04 it definitely needs documenting 16:08:20 likely we should come up witha policy and take it to FESCo for ratification 16:08:22 ie, update MUST be a security update, MUST be submitted to bodhi as normal?, file releng ticket, etc 16:08:26 yep 16:08:41 anly security updates 16:08:50 they have to be of a critical priority 16:09:00 i would say remotely exploitable only 16:09:17 if we just require a real update too we can have that go as normal and only clean out the crit one once the real update is stable 16:09:18 we will want a releng ticket to track it 16:09:20 (for a bit) 16:09:34 nirik: yeah, clean up after a week 16:09:42 should the security team be involved in defining whether this is the real critical fix? 16:09:47 it will give heaps of time for it to go stable via normal channels 16:09:59 btw. it might be more difficult than it is outlined in the ticket because of multilib, so I guess that createrepo is not enough anymore 16:10:06 sharkcz: we could require the request comes from SRT 16:10:11 tyll: good point. 16:10:19 * nirik wishes we could just drop multilib. ;( 16:10:28 probably also have a criteria that the update can not depend on other updated packages, only the one being fixed? 16:10:37 we only have multilib on s390 and x86_64 now 16:10:59 bochecha: no, if it requires another package we will have to push both 16:11:33 Bodhi updates shoul already contain all dependent builds in one update 16:11:42 bochecha: say heartbleed fix needed a fix in another library it was using we would want both 16:11:45 and to get it out 16:11:56 dgilmore, right, if both need to be fixed, sure 16:12:06 but having it contained to a single update is okay 16:12:21 I can whip up a wiki page. 16:12:34 bochecha: if the other packages fixes are optional that is a different problem 16:12:34 and we can draft on it for a week and see what we can come up with? 16:12:42 #info multilib needs to be taken care of 16:12:44 what I meant is if we build a bash update against a version of a lib newer than what's in the repository, then we'd have to push both bash and that lib, even though the lib isn't necessary for the critical security fix 16:12:47 nirik: sure that would be awesome 16:12:53 #action nirik create a wiki page 16:13:04 we will need to make an asjustment to mm I think 16:13:06 and in that case, I would think we'd want to only push bash, so we'd need a build that doesn't require that new lib, only stuff currently in the repos 16:13:18 fedora-repos change is simple 16:13:54 #info mirrormanager needs changes 16:14:28 bochecha: would be a case by case thing I think 16:15:52 lets get the wiki page up, comment and adjust and discuss in next weeks meeting before taking to FESCo for ratification 16:16:24 #topic https://fedorahosted.org/rel-eng/ticket/5775 16:16:27 https://fedorahosted.org/rel-eng/ticket/5775 16:16:38 https://fedoraproject.org/wiki/Urgent_updates_policy is the draft I put up. Please edit/add. 16:16:50 afaik this is what oddshocks's upload service does 16:18:20 there is really nothing here for us to discuss 16:18:21 so, close? asign to oddshocks ? :) 16:18:50 well i think we should leav it open. we need to properly get the upload service deployed 16:19:00 we need to make sure we do it 16:19:06 I guess assign to oddshocks 16:19:07 #info this is what oddshocks's upload service does 16:20:19 #topic #5819 Need tags deleted in python-heatclient repo 16:20:22 https://fedorahosted.org/rel-eng/ticket/5819 16:20:28 this needs closed as wontfix 16:20:32 or invalid 16:20:37 its not something we do 16:21:28 why do we not delete tags? 16:21:46 we do not delete anything from git 16:22:05 or what is the problem when the tags are there, there is no harm AFAICT 16:22:16 there is no harm in the tags 16:22:23 there is also no harmin deleting them 16:22:31 I think you can actaully doa build from a tag 16:22:45 I'm pretty sure this is possible, yes 16:22:50 so we would need to make sure that a build wasnt done 16:23:12 oh, like building from git://pkgs.fedoraproject.org/module#TAG instead of #HASH ? 16:23:13 it doesnt cause any harm to have the tags 16:23:19 bochecha: yeah, 16:23:28 I think this should be a self-service where packagers can delete their own tags and stuff, but have a git hook that rejects the push if a build was done out of that tag / whatever 16:23:36 koji clones teh repo can checks out what was passed 16:23:38 fedpkg alays uses the commit hash, so I didn't know it was doable to build from a tag 16:23:41 as long as all tagged commites are still referenced by a branch, nothing is lost 16:23:42 so the hash or tag 16:23:49 if that's the case, then yeah, deleting them is much harder 16:24:10 we use the hash in fedpkg as it is immutable 16:24:10 tyll, if the build sourceurl contains the tag but not the commit hash, how do you know which commit was referenced by the tag? 16:24:29 bochecha: you don't which is why we use the hash 16:24:49 dgilmore, I know, I was replying to tyll's « nothing is lost » 16:25:30 bochecha: does koji allow to build from a tag? 16:25:39 tyll, that's what we were just saying :) 16:25:48 tyll: yes 16:25:50 tyll, I learned it a few sentences above, just like you :) 16:26:09 I'm pretty sure koji allows building out of everything, can even say tell it to build HEAD and it just goes and builds it 16:26:11 it scrolled to fast here, I have only a small screen 16:26:15 too fast* 16:27:29 I see more reasons to keep the tags than remove them 16:27:49 +1 16:27:59 yeah, if we can build from tags, then we shouldn't remove them 16:28:04 nevertheless, this means we also should make sure in koji that it does not allow to build from HEAD 16:28:11 tyll: we should 16:28:25 ideally make it only build from hash. ;) 16:28:32 I know some people regularly do scratch builds from HEAD 16:28:56 #info koji should be changed to create non-scratch builds only from full commit hashes 16:29:02 the plugin we need to check the branch is valid should probably also check that its a hash and not a tag or HEAD 16:29:08 ideally it should build from a hash that's reachable from one of the fxx branches and verify that the build target matches with the fxx branch in git 16:29:19 kalev: correct 16:29:23 :) 16:29:26 :) 16:29:31 kalev: this is an open ticket in trac :-) 16:29:49 its a open ticket, it will need updating with this extra info 16:30:30 https://fedorahosted.org/rel-eng/ticket/5843 16:30:41 https://fedorahosted.org/koji/ticket/281 16:31:15 tyll: the last two tickets are rawhide signing and moving the blocking service. do we have any updates there? or should we quickly cover secondary arches? 16:31:32 #info tags cannot be removed, because they might have been used to build something 16:31:40 there is an update to the blocking service 16:31:48 okay 16:32:04 anything else here? 16:32:27 #action dgilmore to close the ticket as wontfix with and explanation as to why 16:32:28 not from me 16:32:35 #topic #5914 Move fedmsg based blocking service to Fedora Infrastructure 16:32:41 https://fedorahosted.org/rel-eng/ticket/5914 16:32:53 the floor is yours tyll 16:33:01 So I noticed that koji and pkgdb is a lot faster to use from autosign than frommy local system 16:33:35 e.g. checking whether all currently retired packages are blocked takes only a couple of seconds for all relevant branches 16:34:07 therefore I guess using fedmsg does not make sense unless we need to block packages fast after they are retired 16:34:19 cool. 16:34:20 but afaik blocking them within one day is usually enough 16:34:43 tyll: :) well ideally they get blocked the day they are retired 16:34:49 therefore it could just be a cron job (which we needeed anyhow) 16:34:58 * nirik nods. cron job sounds good. 16:35:03 but perhaps we can run the blocking script at the start of buildbranched and buildrawhide 16:35:27 we would still need to deal with epel 16:35:36 could do that. Would also mean perhaps we could add that info to the report. 16:35:45 nirik: yeah 16:35:45 (well, I guess it already is in repodiff) 16:35:49 the script can just run always for all branches 16:36:02 * nirik doesn't care much 16:36:09 if there is nothing to do, it is done really fast 16:36:15 tyll: can we put the script in the releng git repo 16:36:23 then we could have buildrawhide run it 16:36:41 yes, I am planning to do this 16:36:44 and buildbranched to catch last minute straglers 16:37:00 but we also need to deploy a cert for it on the affected systems 16:37:07 we will need to make sure the masher user can blokc packages 16:37:13 tyll: therer already is one 16:37:15 there 16:37:31 tyll: as koji needs to work to create the lives and cloud images 16:37:50 ok, is it still releng04 the script would run on? 16:38:48 tyll: no 16:39:15 there is two compose boxes, one for rawhide and one for branched 16:39:31 compose-{rawhide|branched}.phx2.fedoraproject.oorg 16:39:33 org even 16:39:59 I see 16:40:14 * nirik goes to get more coffee. I have an item for open floor tho. 16:40:32 * kalev has an item too. 16:40:33 * sharkcz has one open floor too 16:40:36 :-) 16:40:42 nirik: no problem I have some generaly secondary arch stuff to cover before going into arch specifics 16:40:52 * bochecha also has an item for open floor 16:40:53 So how/who deploys it? I am not sure whether I have sudo permissions there 16:41:25 #action till to get teh script in to the releng git repo and wire up buildbranched and buildrawhide to run it 16:41:54 #action dgilmore to make sure the masher user can block the packages and that till wires thinsg up correctly 16:42:07 tyll: it just needs added to teh releng git repo 16:42:15 we need to tag the repo 16:42:22 then it will get run automatically 16:42:23 one idea about buildbranched/buildrawhide - what about making them like wrappers calling individual functions form other scripts? they start to get complicated 16:42:28 no need fot sudo 16:42:29 for 16:42:34 s/form/from/ 16:42:41 ok 16:42:54 sharkcz: good task fro rewriting to a unified set of scripts 16:43:26 sharkcz: I do wan to make the nightly composes be full ocmposes 16:43:32 composes 16:43:52 so the scipts for nightly and TC/RC composes would be the same 16:44:01 It would be nice to have a releng python module that contains all the common code, I usually need the same methods in several scripts 16:44:24 tyll: there is a lot of things we could do better 16:44:33 it is something we could look at doing 16:44:53 python-fedorareleng ! :) 16:45:10 python3-fedorareleng ! :) 16:45:26 kalev: python3 is not even started yet 16:45:35 it is something we need to look at 16:45:36 kalev: for this we need python3 koji and yum or dnf 16:46:20 anything else here? 16:46:36 not from me 16:46:43 #topic Secondary Architectures updates 16:46:56 so as a general secondary arch update 16:47:24 I am going to be transitioning secondary arch leadership over to pbrobinson 16:47:45 cool. 16:47:51 he is going to lead making sure that secondary arches follow policy and all use the same procedures 16:48:27 I still have a long term goal of unifying secondary arches and primary and making the whole secondary arch process transparent 16:48:38 and so I wont be not doing secondary arch work 16:48:55 I won't be trying to do it all 16:49:20 sounds good. ;) 16:49:31 ack :-) 16:49:42 I'd also over time like to pull the secondary arch stuff into infrastructure so it's all setup the same way, gets updates the same way, etc, etc, 16:50:01 nirik: yep, fas groups for shell access 16:50:09 and sudo etc controleed through ansible 16:50:48 pulling secondary arch infra into primary infra is somewhere we should go 16:51:02 I know that the s390 builders will be hard to do 16:51:35 nirik: yes, I want to do that too so I'm extremely happy to work with you on that :) 16:51:51 but s390 should be able to share at least something 16:51:54 cool. :) 16:52:17 nirik dgilmore: ultimately I don't see any reason from an infra PoV to be any different from mainline 16:52:18 they should be able to run fas and pull from ansible git 16:52:24 yeah. 16:52:25 and some time we might move to KVM :-) 16:52:34 the bits in ansible-private will be hard 16:52:51 sharkcz: I can work with you on that.... we'll leave it until the end ;-) 16:53:09 sharkcz: that owuld be lovely 16:53:45 anything else generic secondary arch related? 16:54:02 #topic Secondary Architectures update - ppc 16:54:13 the 2nd TC went out earlier 16:54:13 pbrobinson: sharkcz: how are things? 16:54:41 and we are testing them, and it looks good 16:54:41 excellent 16:54:42 I'm awaiting reports on that. Need to look at the signing side of things so we're ready to move to RC -> Alpha 16:55:48 #info ppc Alpha TC2 out and being tested, hopefully RC soon 16:56:00 #topic Secondary Architectures update - s390 16:56:07 sharkcz: how goes s390? 16:56:39 I'm going to do first compose this week, builds looks good, eclipse will need a rebootstrap as it wasn't built for a long time 16:57:50 :( okay 16:58:35 not sure if I have access to f21 key, so I'll check and let you know 16:58:49 sharkcz: pretty sure you do, if not we will fix it 17:00:03 sharkcz: you have key access 17:00:08 just double checked 17:00:13 ok, thx for info 17:00:28 #topic Secondary Architectures update - arm 17:00:41 pbrobinson: how goes the arm world? 17:02:42 guess we lost pbrobinson 17:02:50 * pbrobinson is herre 17:02:56 I know he was working to get a TC done 17:03:13 so I'm working on the TC, didn't do much over the weekend, working on it now 17:03:17 hoping to get something out today 17:03:30 builds are going great with very few missing 17:03:42 over all aarch64 is looking pretty decent 17:05:01 although some changes for the compose host WRT ACLs would make things much easier. eg arm.koji isn't resolvable and not accessible on the public IP so I have to hack around using internal addresses. Is nirik the best person to assist with that? 17:05:49 hum, I thought it did have a public ip... 17:06:03 can work with after meeting to sort that out. 17:06:15 pbrobinson: yeah, ansible uses /etc/host entries to make things work 17:06:53 OK, I can't telnet to the public http(s) IP but can the 10.x addr. 17:07:19 similar I can't mount the /mnt/koji nfs mount 17:07:55 but I suspect the later needs a storage change request of some type to update the ACL because I can see the nfs server 17:08:23 where are you trying to do those things? some other compose machine? 17:08:32 pbrobinson: nirik can change the exports file on the netapp 17:08:41 yep. :) 17:08:45 nirik: let's take if offlinee 17:08:45 nirik: one of the aarch64 boxes in phx2 17:08:52 ah ha. ok. 17:08:59 or post meeting 17:09:03 yeah, can update... see me in #fedora-releng post meeting. ;) 17:09:11 or anytime 17:09:24 cool 17:10:34 pbrobinson: anything else? 17:11:36 #topic Open Floor 17:11:39 guessing no 17:11:44 nirik: you had something 17:11:44 I had one item 17:12:02 https://lists.fedoraproject.org/pipermail/releng-cron/2014-September/002672.html and https://lists.fedoraproject.org/pipermail/releng-cron/2014-September/002673.html 17:12:06 can someone fix these cron jobs? 17:12:14 they are using dwa's old cert that is expired. 17:12:28 I don't know if they are doing something important, but they should be fixed or removed. 17:12:30 masta set those up to go to the list 17:12:43 they are going to the list. 17:12:44 they are just busted. 17:12:46 we should evaluate what they are as they are not part of teh standard processes 17:12:50 looks like they're using dwa's cert 17:13:10 yep. They need fixing. 17:13:11 I can look at them and work with people to learn the proper process and migrate them to it 17:13:16 the sync-tagged-primary is run from a central location 17:13:24 #info cron jobs fail because of dwa's expired koji certificate 17:13:28 the ppc specific one should not be needed 17:13:40 same with sync-override 17:13:48 both of those cronjobs should be removed 17:13:52 dgilmore: I'll review the difference between them and kill them as appropriate 17:13:55 #action pbrobinson takes care to fix them 17:14:04 great. :) 17:14:10 * nirik doesn't like looking at tracebacks. 17:15:01 * dgilmore notes secondary arches shouldnt go inventing processes just for themselves 17:15:15 anyhow, that was it. :) 17:15:24 I want to propose to remove the epel component from trac as we do not really use it (afaik it was used earlier when there was a distinction between Fedora and EPEL releng) 17:15:28 dgilmore: it's historical.... it won't be like that moving forward! 17:15:32 if you think you need to do something do it with all secondary arches in mind and get it part of the standard processes 17:15:40 pbrobinson: right :) 17:15:46 just pointing it out 17:15:52 dgilmore: you can get off your high horse now ;-) 17:16:03 I have to go very soon, so I'll throw it out there, I sent two mash patches to the rel-eng list today, https://lists.fedoraproject.org/pipermail/rel-eng/2014-September/018424.html and https://lists.fedoraproject.org/pipermail/rel-eng/2014-September/018425.html 17:16:08 tyll: ive updated the epel component to go to teh fedora-releng list 17:16:11 tyll: ok with me now that there is an epel trac... but are there any tickets open in it? 17:16:22 second one is something Remi asked for, the first one is just something I found while testing for it 17:16:31 the epel trac is not for releng tasks 17:16:42 its for epel management 17:16:47 the epel task can just go into the koji component 17:16:54 the relen epel tasks 17:16:57 releng* 17:17:09 epel was setup like it is in releng trac because JEsse wanted nothing to do with epel 17:17:57 I do plan to shutdown the epel-releng list 17:18:09 this sounds also good 17:18:45 mine item - there are 20+ builds found by check-latest-build.py in f21 where the latest NVR isn't the highest NVR, tyll already fixed one because a ticket was opened, I'll create a new ticket for the rest 17:19:25 sharkcz: thats due to bodhi bugs 17:19:48 not all, some are "intentional" in ghc* IIRC 17:20:15 sharkcz: not sure what you are talking about 17:20:41 so can we remove the trac componend? Will someone do it? I cannot do it afaik. 17:20:48 trac epel component 17:20:54 packages must never go backwards nvr wise 17:21:14 some of the problematic builds are in ghc* packages, and they are intentional becuase they reverted some commits after mass rebuild or something like that, you will see from the full list 17:21:30 sharkcz: so if ghc packages went out at a higher nvr at some point and they taged older builds in they violated policy and need to go about fixing it the right way 17:21:56 I just recall some discussion on the devel list (not sure) 17:22:02 sharkcz: that sounds like they did the wrong thing and get to deal with it the right way 17:22:04 I understand your point 17:23:05 or can someone run the check-latest-build.py script on a releng host? it would be faster than on mine wkst 17:23:42 sure 17:23:45 I really have to go, so I'll take feedback on my mash patches on the list :) 17:23:47 as I said I'll open a ticket, so it's not forgotten 17:23:49 we need to clean things up 17:23:58 bochecha: thanks 17:24:51 I had an item too, can I go? 17:25:18 kalev: sure 17:25:28 ok, some quick background first 17:25:37 at flock, we had a meeting where dgilmore and pbrobinson and hughsie and I discussed how to move on with appstream data generation in koji 17:25:47 and came up with an action plan with a bunch of items 17:25:59 one thing we wanted to do was to move things around so that instead of http://alt.fedoraproject.org/pub/alt/screenshots/f21/failed.html , we'd get the warnings / errors at package build time in koji instead 17:26:14 to move forward with this, I've been looking into how to make desktop file and appdata file validation automatic during koji builds 17:26:26 kalev: yes, you were going to add the functionality to the desktop files package thing 17:26:54 what I wanted to discuss here today was how to do it -- the most straightforward way would be to add desktop-file-utils and the appdata validation tools to the minimal koji buildroot and run validation from redhat-rpm-config for everything that gets built in koji 17:27:06 bochecha did some quick tests to see how much new deps these two would drag in to the minimal builroot 17:27:11 kalev: thats not how to do it 17:27:15 bochecha: do you still have the fpaste links from earlier at hand or did you leave already? 17:27:39 kalev: people already have to add a BuildRequires to validate the .desktop file 17:27:39 kalev: does it need to be run for 16k source packages as opposed to just desktop apps? 17:28:12 kalev: there is zero reason for adding the extra packages to every buildroot 17:28:34 or running on every build as opposed to just desktop apps 17:28:43 ok, that's a good enough answer, that's exactly what I wanted to know: if it would make sense to add it to the minimal buildroot 17:29:14 well, it wouldn't _run_ on every build if it sees that there are no files, but the additional deps in every buildroot could be a problem, agreed 17:29:38 kalev: but if you're running it in desktop-file-utils it would have the deps as part of that package anyway 17:29:51 yes 17:29:52 http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files 17:30:13 the plan was to have desktop-file-validate do the appdata validation 17:30:36 packages that ship it should already be doing the validation 17:31:00 mhm, but a bunch have probably forgotten to add the validation and it might be nice to make this automatic 17:31:20 and not have it fail the build for F-21 and only warn but for F-22+ to fail the build 17:31:30 yep, definitely 17:31:33 kalev: having a way to check broken packages is very useful 17:32:02 kalev: but every time we add something to the minimal buildroot we extend teh build time 17:32:17 kalev: if you have a list of packages that have app data I can grep the entire source tree check out and see if any don't have desktop-file-utils as a dep 17:32:59 pbrobinson: that should actually be even easier, should be able to just get the filelists from the metadata and cross-check that 17:33:17 anyway, I have my answer now, thanks -- I won't pursue adding it to the minimal buildroot any more 17:34:31 I guess I'll hook it up so that redhat-rpm-config runs the checks when the appropriate package(s) are installed 17:34:57 and then make sure to cross-check as pbrobinson suggested to make sure everything has the needed build deps to actually run this 17:35:09 thanks, nothing more from me 17:35:12 yeah, there's a guideline requiring it. 17:35:27 so would be good to fix any broken packages 17:35:28 kalev: you probably should also go via packaging committee with such change 17:35:59 kalev: such a change will require packaging guideline changes 17:36:23 https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files 17:36:34 there already is a guideline 17:36:34 kalev: that's part of why we said you should do it the way we said 17:36:52 * sharkcz needs to leave now 17:37:42 right, thanks, I'll make sure the guidelines get updated as well 17:37:47 desktop-file-install or desktop-file-validate have to be run according to the guidelines 17:37:59 we should make both validate the appdata 17:38:17 they are supposed to already be run 17:38:25 I want to make this automatic so that BR: desktop-file-utils takes care of the validation 17:38:28 there should be no need for guideline changes 17:38:42 copy-pasting validation lines to each and every spec is just crazy, and a lot of packages forget those out 17:38:45 kalev: I do not think that is the right things to do 17:38:51 so the guidelines are just going to get simpler 17:39:44 kalev: i think things would get overly complex in redhat-rpm-config trying to do it automatically 17:40:10 nah, it's not hard at all, just a few additional lines 17:40:11 quite often desktop-file-install is used to change or set some variables 17:40:21 I've already posted a patch and got tentative buy in from the redhat-rpm-config maintainers 17:40:47 kalev: where is the patch? 17:41:00 devel list I think it was? 17:41:14 dgilmore: https://lists.fedoraproject.org/pipermail/devel/2014-September/202711.html 17:42:49 kalev: okay, that's not dealing with installing the .desktop file at all 17:43:03 you made it sound like you were trying to automate that 17:43:05 right, just validation 17:43:12 that was not clear 17:43:18 oh now, I just want to make sure that every desktop file that is installed also gets validated automatically 17:43:23 oh no * 17:44:02 the patch will need some revision 17:44:13 but automatically validating is fine 17:44:13 yes, or more like complete rewrite :) 17:44:51 cool, glad that you agree :) 17:45:11 next rpm version should also make a lot of other stuff easier, like killing most of the copy-pasted scriptlets 17:45:14 Hi all, I saw "eclipse" mentioned here! For getting eclipse built on the platform where it doesn't build, the instructions here should apply: https://bugzilla.redhat.com/show_bug.cgi?id=1141225 17:45:14 I would rather not add the extra deps to every buildroot 17:45:42 mbooth: it was mentioned for s390 sharkcz is on it afaik 17:46:23 anything else for openflor? 17:46:25 floor 17:46:26 dgilmore: Okay great. I'd be happy to help if there are deeper problems with it :-) 17:47:02 if not ill wrap up we are over an hour over 17:48:20 #endmeeting