16:00:44 #startmeeting fpc 16:00:44 Meeting started Thu Jun 18 16:00:44 2015 UTC. The chair is geppetto. Information about MeetBot at http://wiki.debian.org/MeetBot. 16:00:44 Useful Commands: #action #agreed #halp #info #idea #link #topic. 16:00:44 #meetingname fpc 16:00:44 #topic Roll Call 16:00:44 The meeting name has been set to 'fpc' 16:01:01 Good morning, I'm here to discuss Ticket #541 - Package Naming Guidelines Clarification 16:02:01 Hi all 16:02:16 Hi all 16:02:34 #chair tomspur 16:02:34 Current chairs: geppetto tomspur 16:02:36 #chair mbooth 16:02:36 Current chairs: geppetto mbooth tomspur 16:02:45 Howdy. 16:05:31 #chair tibbs 16:05:31 Current chairs: geppetto mbooth tibbs tomspur 16:05:44 * racor is here (currently distracted on the phone) 16:05:52 #chair racor 16:05:52 Current chairs: geppetto mbooth racor tibbs tomspur 16:08:30 * Corey84 hangs out in back row 16:10:14 racor: sorry for the ping 16:10:38 Looks like nobody else is here, and we have 5 so … 16:10:43 #topic Schedule 16:10:49 https://lists.fedoraproject.org/pipermail/packaging/2015-June/010705.html 16:11:16 #topic #541 Package Naming Guidelines - Clarification Required 16:11:16 .fpc 541 16:11:17 https://fedorahosted.org/fpc/ticket/541 16:11:19 geppetto: #541 (Package Naming Guidelines - Clarification Required) – fpc - https://fedorahosted.org/fpc/ticket/541 16:11:42 gbcox: you are up :) 16:12:07 Although I'm not sure we have to do anything here 16:12:13 I still don't see what clarification is required. 16:12:16 Thanks... I really don't have more to add than what I've already put into the ticket. I think the guidelines are clear 16:12:26 racor was the one who had the issue... 16:12:46 Guidelines say lower case is preferred. 16:13:22 I do think it would be wise to tighten up the exceptions 16:14:02 I'd like to work on the NamingGuidelines page at some point anyway, to split out the Versioning stuff to a different page. 16:14:07 Here was my last comment in the ticket regarding that... 16:14:09 The Naming Guidelines are not changing the identity of the project, nor the method upstream chooses to name their project. It only relates to how that package is identified within Fedora for packaging purposes. If you go to the project website, you can view how upstream wants to represent their project - mixed case, special characters, etc. It's helpful to know though, if you want to install My-FavORIte_PacKage that in Fedora, 16:14:11 you can simply use: dnf install my-favorite-package from the command line. I believe there is major value to that. Allowing upstream to dictate the package naming convention is just confusing and chaotic. You then don't have one uniform standard, you have thousands. 16:15:34 agree, seems like a non-issue 16:15:47 Can we push this down a little bit and I'll write a quick proposal? 16:15:52 sure 16:15:55 If I can get the wiki to do anything. 16:16:16 #topic #542 Forbid "python -OO" for Python < 3.5 16:16:16 .fpc 542 16:16:16 https://fedorahosted.org/fpc/ticket/542 16:16:17 geppetto: #542 (Forbid "python -OO" for Python < 3.5) – fpc - https://fedorahosted.org/fpc/ticket/542 16:16:34 I'm kind of lost as to what the deal is here. 16:17:00 "something the package does causes problems. please fix." "the guidelines don't say I have to fix it." 16:17:11 That's basically my understanding. 16:17:26 Same here 16:17:54 * geppetto shrugs 16:17:55 I think if the python folks say, "don't use -OO" you shouldn't use -OO, but I don't think this belongs into the guidelines 16:18:11 Nevertheless, if it confuses people, one sentence won't hurt. 16:18:18 Maybe on some kind of "bugs we don't backport" or whatever 16:18:43 tibbs|w: Did you see toshios diff? ;) 16:19:31 wow, that's big 16:19:48 Well, I did, but I think we should try to limit the length of the python guidelines to at most the length of your favorite Tolstoy novel. 16:20:14 ha 16:20:27 Plus, I believe that rationale never belongs directly on a guideline page. 16:20:50 Yeah, I don't think the character needs that much back story 16:20:52 Can we just remove the rationale section 16:21:20 Just "don't use -OO until python-3.5" ought to suffice 16:21:33 Yeh, I'd be happy to remove the version qualifier too 16:21:57 at least until someone has a better usecase than Ales decided it was fun a few months ago. 16:22:06 For my elucidation, what does -O0 actualy do? 16:22:24 Removes docstrings as well as asserts 16:23:36 In theory this could make the .pyo files quite a bit smaller, if you have lots of API docs. 16:23:55 In practice … I doubt it's measurable. 16:24:19 Does that really matter? I guess for DNF it might be (since it's always on the system), but someone should be able to at least provide some stats. 16:24:20 Well, the disk space is probably measurable … but still stupidly small 16:24:30 But I doubt the difference in load time is measurable. 16:24:50 And how does py3.5 help here? 16:25:06 It seems that since it writes out separate files, it would actually increase the disk usage. 16:25:07 AIUI 3.5 it kind of works somehow? 16:25:36 before 3.5 python will get confused if there are different optimisation levels used within the same program … AIUI 16:25:39 py3.5 ostensibly generates two different bytecode outputs so you can have both -O and -OO on disk 16:26:00 Instead of .pyo files only 16:26:30 (AIUI from reading toshio's text) 16:28:38 So if I add "don't use -OO on python versions less than 3.5" to Packaging:Python, where would it go? 16:29:05 I think we should just have: 16:29:19 === Python Optimization Level === 16:29:19 * Fedora packages running with Python '''MUST NOT''' use python -OO in shebang lines (python -O is fine) or set the environment variable PYTHONOPTIMIZE to 2 or greater. 16:29:19 * Similarly, any .pyo shipped in a Fedora package for python '''MUST NOT''' have been byte compiled using optimization level 2 or higher. 16:29:49 Where toshio put it … so around line 143 of the python docs. 16:30:05 +1 16:30:13 +1 16:30:19 +1 16:30:29 +1 16:31:37 racor: vote? 16:35:22 back from the phone ... what is the topic? 16:35:28 We really need to have a meeting where we get more than the minimum 5. 16:35:41 racor: Voting on the text just before the +1's 16:36:07 my vote: 0 16:37:21 Well OK then. Maybe we can get more votes in the ticket or something. 16:37:40 I kind of figured this was a just do it thing since it's obvious that the behavior is broken. 16:38:16 indeed 16:38:28 #action Forbid "python -OO" for all versions of Python, no need for rationale in policy (+1:4, 0:1, -1:0) 16:38:37 #action Need more votes 16:39:18 Ok, so we have 539, 540 and 541 we can talk about. 16:39:59 540 seems kind of trivial, and I'm not sure we really need to do anything … but maybe putting some small number of lines somewhere will make the GCC people happ 16:40:00 happy 16:40:03 and #281 16:40:10 has that changed? 16:40:26 ahh, yes, sorry 16:40:32 #topic #281 New Python Macros for Easier Packaging 16:40:32 .fpc 281 16:40:32 https://fedorahosted.org/fpc/ticket/281 16:40:33 * tomspur tested the macros and posted a diff 16:40:34 geppetto: #281 (New Python Macros for Easier Packaging) – fpc - https://fedorahosted.org/fpc/ticket/281 16:41:19 those look awesome, to me 16:41:21 * tomspur talked with mstuchli and it is fine to add those to the python package and built it on all branches 16:41:31 +1 16:41:40 Please define "all branches". 16:41:55 I only talked about Fedora with him... 16:42:06 Can ask about rhel again... 16:42:26 I would assume no, but it may be possible for EPEL folks to just have a macros package. 16:42:48 I don't work with python < 3.3 any more so that cuts RHEL right out. 16:43:46 I am +1 to that latest diff 16:44:30 +1 to that diff, though some of that is already in the guidelines now. 16:44:37 racor: vote? 16:44:55 I can figure it out when I write this up, assuming it passes. 16:45:03 tibbs|w: where would you put those macros? redhat-rpm-macros? 16:45:03 FYI, epel does have a macros package. :) 16:45:26 nirik: Ah, cool. I have been agitating for that for years but I didn't realize it actually happened. 16:45:28 epel-rpm-macros 16:45:49 tomspur: In the python package if that's possible. 16:45:53 it has these python3 macros in it already. Not sure if it's in the srpmbuild root yet, but if not it will be soon 16:46:15 But either location is fine. Just seems to make sense to me to keep them together somehow. 16:46:27 * tomspur nods 16:46:33 nirik: Does that package get sucked in automatically? 16:46:45 yeah, we are planning to add it to the srpm buildroot. 16:46:48 Because we might be able to encapsulate other EPEL differences in there now. 16:46:49 (for epel) 16:46:55 sure, sounds good. 16:47:26 happy to add co-maintainers of FPC folks too if you want to just add things as needed. 16:48:28 that would be great 16:48:43 #action New Python Macros for Easier Packaging, py2_build/py2_install/etc. (+1:4, 0:0, -1:0) 16:48:53 my vote on https://fedorahosted.org/fpc/ticket/281; 0 16:48:59 #undo 16:48:59 Removing item from minutes: ACTION by geppetto at 16:48:43 : New Python Macros for Easier Packaging, py2_build/py2_install/etc. (+1:4, 0:0, -1:0) 16:49:05 #action New Python Macros for Easier Packaging, py2_build/py2_install/etc. (+1:4, 0:1, -1:0) 16:49:12 #action Need more votes 16:49:41 Ok, so back to 539, 540 and 541. 16:49:57 tibbs: You done a draft for 541 yet? 16:50:10 Typing now. 16:50:53 Ok, we might as well wait on it … as 539/540 don't have much to actually do 16:50:59 #topic #541 Package Naming Guidelines - Clarification Required 16:50:59 .fpc 541 16:50:59 https://fedorahosted.org/fpc/ticket/541 16:51:01 geppetto: #541 (Package Naming Guidelines - Clarification Required) – fpc - https://fedorahosted.org/fpc/ticket/541 16:51:05 FWIW: I will abstain from voting on any of these current python packaging issues, because I don't feel knowlegable to vote and feel these changes are not productive. 16:51:33 geppetto: I just commented on the ticket 16:52:08 https://fedoraproject.org/w/index.php?title=PackagingDrafts%2FLowerCase&diff=416012&oldid=416011 16:53:03 I just struck "generally", moved the statement about case/dashes to the beginning, and added a sentence about asking upstream. 16:53:34 But, ugh, my editor re-wrapped things. Dang it. 16:53:53 Looks fine, to m 16:54:01 +1 16:54:41 +1 16:55:02 +1 16:55:53 -1 this proposal is totally converse to what had been rule in Fedora for 10 yes. This proposal is idiotic. 16:56:14 s/yes/years/ 16:56:18 racor: Just blindly using the tarball name won't work on all occasions as some upstreams wildly use Coke or coke together. Do you have a concrete example why this proposal is idiotic? 16:56:31 racor: It was a rule to always use upstream naming even when it's stupid? 16:57:07 * tomspur would also prefer lowercase names, but it makes also sense to use upper ones sometimes. So the diff above seems fine 16:57:15 geppetto: I was rule to use the tarball name - period. This had avoided endless and unpleasant rules and package conflicts. 16:57:20 But maybe I'm missing some concrete reason for not using it 16:57:45 That was never the rule. 16:58:22 If there is a naming clash of two upstreams you have a problem. No matter if one is upper and the other is lower. That confuses people anyway. 16:58:35 +1 16:59:00 Yeh, it was never the rule that you had to follow the tarball name. And it was always encouraged to use lowercase, and add a provides for the capitalized version. Just that the encouragement has been more forceful with expereience of people not doing it and how that isn't good for anyone 16:59:20 But … shrugs. 16:59:26 The preference for using lowercase was already voted on and decided by FPC in Ticket #336 16:59:26 #action Package Naming Guidelines - Clarification (+1:4, 0:0, -1:1) 16:59:34 #action Need more votes 16:59:42 gbcox: Of course it was. 16:59:43 #topic Open Floor 17:00:08 This just cleans up the language to be a bit less confusing, but sometimes people don't want things to be less confusing. 17:00:34 So do we want to talk about 540? 17:00:34 yes, agreed... so is my package of all lowercase ready to go now? 17:00:42 I'm not sure we need to do anything 17:00:48 or is it still being blocked by FPC 17:00:51 tibbs|w: No it causes additional churn and bugs. 17:00:54 Not blocked by FPC. 17:00:59 Blocked by your reviewer. 17:01:07 my reviewer didn't block it 17:01:10 racor did 17:01:14 Uh? 17:01:18 my reviewer agrees with me 17:01:19 What are you going to BR: libx or libX11 17:01:25 Then have your reviewer just click the box and go on with life. 17:01:31 ok, will do 17:01:36 thanks 17:01:40 racor: whatever the package is called 17:01:55 racor: The guideline says should, not must. This isn't rocket science, you know. 17:02:05 gbcox: tibbs just overruled ... I'm this FPC has derailed. 17:02:13 And our guidelines are not retroactive. 17:02:34 racor: There's nothing to overrule … the packager is complying with the poliucy, and the reviewer agrees 17:02:45 racor: Blame me or curse me if you like; I can take it. If you don't like the existing rules, feel free to submit a draft to change them. 17:02:53 But this rule has been in effect for a long time. 17:03:13 tibbs|w: https://fedoraproject.org/w/index.php?title=Packaging:NamingGuidelines&oldid=66607 17:03:20 And we had nothing but problems with random case before that 17:03:40 Way way way too many "I tried yum install mysql" and nothing happened 17:03:50 gbcox: Sorry you had to see this. 17:04:19 no problems... I expected it 17:05:06 I would actually be super happy to force packages to always Provides: a lower-cased name if they choose to use mixed case. 17:05:07 racor: There is still a "should" in it. So if not matching the tarball, it is not a problem too 17:05:34 tibbs: yeh, I'd +1 that 17:05:52 https://fedoraproject.org/w/index.php?title=Packaging:NamingGuidelines&oldid=400814 17:05:56 I'll make a separate proposal. Let me wrap that draft up in another ticket. 17:06:07 I'd even be happy to +1 a "you should provide an exact upstream capitalization, if possible" 17:06:20 * tomspur is unsure about the provides 17:06:31 tomspur: Why what could go wrong? 17:06:49 sorry folks, I am not in a mood to continue this discussion and therefore prefer to quit this meeting now. 17:06:52 I would encourage people to do so, but writing it into the guidelines seems to more or less force them 17:07:03 He took his ball and went home. 17:07:07 :) 17:07:09 tomspur: I'm happy with a SHOULD instead of a MUST 17:07:23 tomspur: Just that some of them might not think of it without a nudge 17:07:27 tomspur: it might be desirable to... it gives end users a consistent way to find packages. 17:07:34 geppetto: If racor reviews it, the should turns into a must 17:07:57 That's a separate thing 17:08:02 One I've hit recently 17:08:09 And I'm not sure how to solve it 17:08:39 As an outside observer, I don't see any value add to Fedora for having mixed case in package names or doing what upstream desires 17:08:46 But when you are getting a package reviewed all common sense goes out the window, and you are kind of forced to just do whatever the reviewer wants 17:09:00 yeah 17:09:09 why give upstream the power of veto over fedora packaging guidelines 17:09:26 I don't think we ever have. 17:09:43 But working with upstream in a productive fashion is one of the tenets of Fedora. 17:09:46 there is clear value to standardize on lowercase... what is the value add for mixed? 17:09:47 In general we try to be nice to what upstream wants 17:09:53 So that they don't hate us 17:10:03 Like the apache-httpd rename 17:10:20 And just recently, mscore -> musescore. 17:10:28 LOL... true, but in 99.999% I think they could care less... they're just happy someone is taking the time to package their program 17:10:57 yeh, I would certainly expect almost all upstreams to understand using all lowercase 17:10:57 Of course. 17:11:08 Which is why this whole thing is so absurd. 17:11:11 and you're not changing their package identity, just how it is represented internally in fedora 17:11:27 To step in to someone else's review to complain about the case of one letter seems beyond the pale. 17:11:35 And only the most insane to disagree if we add the provides 17:12:01 I don't get the drama surrounding this 17:12:06 But I wouldn't guarantee there are no insane OSS people out there ;) 17:12:31 gbcox: It's just an interpersonal thing. Every project acquires some people who are just harder to handle. 17:12:44 Unfortunately one of them happened to notice your review. 17:12:49 ROFL 17:13:18 It sucks because this kind of thing turns off so many potential contributors. 17:13:29 But it's not really our place to fix that. 17:13:36 Yeah, my concern is that is happening quite a bit, and people roll over when threatening with having to take an issue to FPC 17:13:53 I really, really want to do package reviews differently in any case. 17:13:55 That isn't right 17:14:03 We are at 1.25 hours, so my time is up for today 17:14:09 Like always having the spec in some collaborative editing platform. 17:14:12 mbooth: I think we are done anyway 17:14:16 And yeah, I think we're done. 17:14:21 Cool :-) 17:14:21 Thanks folks! 17:14:55 Yeh, the two big things I think are that reviews are way too strict when they happen, and they only happen once 17:14:57 tibbs|w: In which sense? Isn't git collaborative? ;) 17:15:33 tomspur: I guess he means more like proven packagers just editing minor stuff in specs 17:15:43 Ah ok 17:15:45 except on a much bigger scale 17:15:47 No, I mean pre-import. 17:15:57 People work on a spec together. 17:16:10 Whip it into shape. 17:16:23 yeh, but that requires us taking the spec into something we own before we've "approved it" 17:16:35 Just the spec; that's not a big deal. 17:16:46 And I don't mean git, I mean something like etherpad or gobby. 17:16:51 * geppetto nods 17:17:19 I'm certainly not against that as a best practice 17:17:29 Oh, sure, it wouldn't work for every case. 17:18:04 * tomspur always wanted to write some checks to see which packages comply with the guidelines and which ones don't. e.g. introducing the %py_install macros 17:18:16 * geppetto nods 17:18:48 The only way I've seen that done is someone having a lot of disk space, checking out all the packages and doing greps/etc. 17:19:11 tomspur: More rpmlint checks 17:19:19 Would be a good start 17:19:23 There are complete tarballs of the git repos you can get. 17:19:32 At least there used to be. 17:19:51 there still is. :) or is again 17:19:55 mbooth: yes, maybe. I thought more about on some automatic fixes. 17:20:10 nirik: Is it possible to use/grep on fedorapeople? :) 17:20:58 I don't understand the question... you can use grep there yes, but it doesn't have all git pkgs repos there at all. 17:22:08 nirik: yeah, that was the question. If it is mounted there read-only so one can grep or so 17:22:34 tomspur: We have a RPM spec file editor for eclipse: https://wiki.eclipse.org/Linux_Tools_Project/SpecfileEditor/User_Guide 17:22:35 no easy way to do that. they are not in the same datacenters 17:23:05 tomspur: I want to add "quickfixes" and "save actions" to it that make files more guideline compliant 17:23:33 Long term TODO list item :-) 17:23:42 I just use vim. It tells me a big pile of things that are wrong with specs. 17:23:49 :) 17:24:03 Well, vim with syntastic, which calls rpmlint. 17:24:08 Is that in beepy mode or non-beepy mode? 17:24:30 I have vim and emacs and kate open right now. 17:24:34 ha 17:24:37 mbooth: Sounds good for people who like using eclipse :) 17:24:44 Working on javascript and python and perl. 17:25:05 tomspur: It's hard work to get java people to package software ;-) 17:25:15 You said "java". 17:25:58 Does that mean I lose points? 17:26:01 :D 17:27:44 * tomspur didn't know about syntastic+rpmlint. Will try it out later on 17:28:22 Can give you my .vimrc stuff if you like. 17:28:44 Anyway, we should probably end the meeting as I have another (real-life) meeting soon. 17:28:59 Do you have to configure a lot of stuff? 17:29:08 Not really. 17:29:48 Install syntastic using whatever method you use to install vim things (I use Plug) and it kind of happens automatically. 17:29:59 Ahh, I know I have automatic highlighting with vim … but I don't get rpmlint messages 17:30:22 Ahh, I _love_ having to use non-native package managers ;) 17:30:36 Doesn't work right out of the box over here 17:30:43 tibbs|w: .vimrc would be great :) 17:31:06 there's actually nothing in vimrc about rpmlint; it just happened. 17:31:13 * geppetto nods 17:31:23 Maybe it is interfering with some other plugins of mine... :/ 17:31:42 One annoying thing is that it actually checks the Source: urls by default, which slows startup. But you can disable that. 17:31:44 Anyway … I shall end the meeting in a min., unless someone brings something up real soon 17:32:10 Might be worth having a page somewhere about tools you can use to help with specfile creation/maintenance 17:32:21 With a spec file open, :SyntasticCheckers says http://fpaste.org/233670/43464872/ 17:33:10 interesting 17:33:31 vimrc is at http://paste.fedoraproject.org/233671/34648788 but I have local ftplugins as well. 17:33:42 Not one for spec files, though. 17:34:17 thanks! 17:35:30 #endmeeting