17:00:27 #startmeeting fpc 17:00:27 Meeting started Thu Nov 15 17:00:27 2018 UTC. 17:00:27 This meeting is logged and archived in a public location. 17:00:27 The chair is geppetto. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:00:27 Useful Commands: #action #agreed #halp #info #idea #link #topic. 17:00:27 The meeting name has been set to 'fpc' 17:00:27 #meetingname fpc 17:00:27 The meeting name has been set to 'fpc' 17:00:27 #topic Roll Call 17:00:36 .hello2 17:00:37 ignatenkobrain: ignatenkobrain 'Igor Gnatenko' 17:00:51 #chair ignatenkobrain 17:00:51 Current chairs: geppetto ignatenkobrain 17:01:13 hi 17:01:20 #chair redi 17:01:20 Current chairs: geppetto ignatenkobrain redi 17:01:23 Hey. 17:01:32 #chair tibbs 17:01:32 Current chairs: geppetto ignatenkobrain redi tibbs 17:01:32 hi guys 17:01:32 Sorry, busy morning for me. 17:01:35 #chair decathorpe 17:01:35 Current chairs: decathorpe geppetto ignatenkobrain redi tibbs 17:01:43 * decathorpe online on phone only 17:01:52 hi 17:01:59 #chair mhroncok 17:01:59 Current chairs: decathorpe geppetto ignatenkobrain mhroncok redi tibbs 17:05:17 #topic Schedule 17:05:26 https://lists.fedoraproject.org/archives/list/packaging@lists.fedoraproject.org/message/YFLCBJS74CBQJXQQONDXNRHEVUHBZ6VP/ 17:05:38 #topic #806 Procedure should be updated for Pull Requests 17:05:38 .fpc 806 17:05:39 geppetto: Issue #806: Guideline Change Procedure should be updated for Pull Requests - packaging-committee - Pagure.io - https://pagure.io/packaging-committee/issue/806 17:06:31 should we dicsuss the issue vs PR thing? 17:06:53 I think that it always depends on the nature of the problem 17:07:04 I was about to say I don't see a benefit to separating them, but tibbs's point about discussion vs concrete changes makes sense too 17:07:21 Some things are trivial and we'll just merge them. 17:07:25 I think if we need some conversation without any specific proposal I would use issues, but discussing some specific proposal makes sense in PR IMO 17:07:26 Some things require discussion. 17:07:26 e.g. if something is just cosmetic change, fesco approved change, etc. it can go as PR only 17:07:42 yeah it's pointless having an issue which is empty, and just points to a pull req 17:07:45 but if peeople actually request a chenage of púolicy, they should open an issue IMHO 17:07:49 Sadly pagure, like github, separates PRs and tickets in ways that shouldn't really be separate. 17:08:14 If all else fails, one of us can just open an issue but it's one more thing that could be missed. 17:08:51 We can tag PRs like we can tag tickets, so I guess looking at those could also be made part of the agenda generation process. 17:09:17 I tagged one PR for meeting today actually 17:09:22 Yeh, I feel like PRs should be used when we know (or mostly know) what the change should be and need to do it. Anything less than that should be hashed out in an issue first 17:09:48 Yeh, another problem is that only issues come up on the report. 17:09:59 You have to make another report. 17:10:06 another problem is that PR is closed when it's merged 17:10:06 I still don't get why they are shown separately. 17:10:20 And yes, merging auto-closes which is annoying as well. 17:10:33 we usually kept the issue open until announced 17:10:34 So things miss the announcement phase. 17:10:43 and that happens after the wiki change (or commit) is made 17:10:44 tibbs: You know of a way to tagPRs? 17:10:45 we can disable this 17:10:47 So definitely we need an issue for any change that will be announced. 17:10:55 You can tag PRs exactly like tickets. 17:11:10 Hmm, ok 17:11:19 Because they are tickets, but not shown in the same place for reasons. 17:11:37 another option which we could go might be to tag commit so basically what was after latest tagged commit -- was not announced 17:11:42 when we announce, we push new tag 17:11:58 That's.... overcomplicating things. 17:12:25 ignatenkobrain: let not 17:12:31 I mean, sure, I don't object to tagging things but it would just result in yet another place we'd have to look for things to announce. 17:13:02 actually if you write in commit message "Relates", "References", then issue is not getting closed 17:13:10 but if you write "Fixes", "Closes", then it does 17:13:31 The issue doesn't close, but the PR does close. 17:13:53 which imho makes sense if it's merged 17:14:05 yes but that a reson we need an extra issue 17:14:09 yeah agreed 17:14:20 It's just one more thing we need to worry about. 17:14:36 conclusion: whatever needs announcement needs an issue 17:14:38 right? 17:14:41 For me the biggest issue is that there won't necessarily be one PR per change. 17:15:08 mhroncok: Yes, certainly everything that will need an announcement needs an issue. 17:15:17 I would say that everything which needs committee discussion needs an issue. 17:15:29 how is it better than having tags? tag message can be exactly announcement? 17:15:41 The worst thing that would happen is someone opens an issue they don't need to open. 17:16:25 ignatenkobrain: I know you love this process but it's just more complexity that's not needed right now. 17:16:45 I'm fine with either way 17:16:46 Plus, you know, in an issue we could discuss something like the announcement message if we need to. 17:17:07 that's important 17:17:26 github actually recently made feature to propose a tag as pull request so that you can discuss it there ;) 17:17:39 And getting lost in pushing revisions to tags and fast forwards and more git nonsense is just not where I want to be. 17:17:51 but let's not rathole on this, I think conclusion is that if we need announcement or decision, we need an issue 17:18:10 I know some people love git and its random bizarre features but endless git reset --hard invocations is not how I want to spend my life. 17:18:18 OT: I search wehere would I update the issue templates but fail to find it 17:18:38 They are in the ticket repo. 17:18:55 Click "clone" and you should see how to clone "Issues". 17:19:01 ssh://git@pagure.io/tickets/packaging-committee.git 17:19:16 tibbs: thanks 17:19:27 I'll update the draft part to have a link to PR instead 17:19:38 Under there should be a "templates" directory. 17:20:18 I'm also unclear on what we should do with a PR that can't now be merged. 17:20:32 It seems really poor form to keep asking people to rebase. 17:20:48 And I personally don't even know how to rebase. 17:21:24 I think it's pretty standard practice to ask people to rebase 17:21:41 if PR can't be merged because of conflicts it's only author knows best how to resolve conflicts 17:21:49 tibbs: how would you do it with wiki 17:21:49 you take their chanegs 17:21:49 and apply them 17:21:49 so you take their commit 17:21:49 and apply it 17:21:50 tibbs: if it's too much git nonsense, just ping me with a PR link and I'll do that 17:22:10 Well, sure, I can just apply their changes manually. 17:22:16 or like mhroncok says 17:22:18 you just apply the commit manually 17:22:25 cherry-pick 17:22:36 ignatenkobrain: But what you say is right for code but wrong for packaging guidelines or most documentation. 17:22:41 or you git pull origin refs/pull//head 17:22:51 They aren't best placed to resolve conflicts, we are. 17:22:58 PR is really the wrong workflow here. 17:23:14 why? 17:23:19 you mean we don't just keep editing the guidelines until they compile? ;) 17:23:31 Exactly because we're not dealing with code. 17:23:47 This is a situation where git is the hammer, and we're pretending the guidelines are a nail. 17:24:21 redi: that's what I do :) 17:24:23 Maybe pagure is the hammer instead of git. 17:24:44 I'm not sure it'll be much different/worse with docs. than code. 17:24:50 After all, there are plenty of other completely valid git workflows besides the PR model. It's just the only one we're offered because github popularized it. 17:25:15 The difference here is that the usual case was always for me to do some level of rewriting for every single guidelines change applied. 17:25:38 we use github for the C++ standard, that's documentation. 1500 pages of it. it works ok 17:25:50 I really don't expect everyone to have complete mastery of the terrible English grammar before submitting guideline changes. 17:25:51 Pr model works for the docs just fine 17:26:09 tibbs: that's fine, if you want to rewrite, you have basically 2 main options 17:26:27 tibbs: 1) you look at their diff/tezt and you write (copypaste) your own 17:26:37 I mean, I just gave you quite reasonable examples of why it _doesn't_ work fine, and you ignore them and say it does. 17:26:40 tibbs: 2) you apply their commit adn put an extra commit of yours on top of it 17:26:56 Obviously folks love git so much they don't care, but that doesn't change the reality. 17:27:20 tibbs: I donẗ see any example why is this any worse than a link to wiki page and a wiki diff 17:27:27 it has all the features of such + more 17:27:52 It has most of the features of such plus more. 17:28:10 I'm not arguing that it doesn't have advantages. You just conveniently ignore the disadvantages. 17:28:12 That's fine. 17:28:26 whta fature it doesn't have? 17:28:32 the disadvantage I see is in how we convert the docs to html 17:28:42 i.e. in the wiki, you just click preview and it works 17:29:00 now you need container with random stuff to build it 17:29:09 and that's bad, but it not a git disadvantage 17:29:20 Well, and wait a day before your changes are live, but that's not what I'm talking about either. 17:29:35 It means I have to merge and then pull and then edit and then commit and push. 17:29:43 tibbs: now you don't 17:29:50 you can pull, edit and push 17:29:59 And the PR closes automatically? 17:30:14 put Merges in commit msg 17:30:26 tibbs: no idea, a wiki draft page also doesn't delete itself automatically 17:30:36 but as ignatenkobrain says 17:30:43 (not sure if it works in Pagure) 17:30:45 Merges: #123 17:30:52 this will close PR as merged 17:31:24 ignatenkobrain++ 17:31:25 pingou: Karma for ignatenkobrain changed to 2 (for the current release cycle): https://badges.fedoraproject.org/tags/cookie/any 17:31:43 It's both more work and less work depending on the situation. 17:31:57 I certainly love it for quick fixes. I don't like it nearly as much for big changes. 17:32:00 TBH the main disadvantage of the PR workflow is that one needs to get used to it and learn the git stuff 17:32:14 anyway, I think we have more important stuff to discuss 17:32:16 but i guess that is true for any change 17:32:18 geppetto: don't we? 17:32:57 You folks who live in git all day have internalized all of the absolutely bizarre bits about it. I can just barely manage a merge with conflicts. 17:33:09 I mean … tibbs does most of the editing/pushing … so if people can give him pointers to how to work with git easie, I think it's worth a few minutes 17:33:11 tibbs: and I take that 17:33:19 tibbs: that's fine. 17:33:34 Anyway, we don't have to do this now. 17:33:43 tibbs: but really to do this kind of work you don't need to know "all the bizzare stuff" 17:33:46 And I can certainly get any human who understands git to assist. 17:33:56 Ok 17:34:04 tibbs: just ask anytime if you are struggling with git and we will help 17:34:13 tibbs: also ping me any time with a specific how to question 17:34:20 ignatenkobrain++ 17:34:20 mhroncok: Karma for ignatenkobrain changed to 3 (for the current release cycle): https://badges.fedoraproject.org/tags/cookie/any 17:34:32 We really should move on, though. 17:34:39 yes 17:34:44 #topic https://pagure.io/packaging-committee/pull-request/821 17:34:49 Talking of PRs :) 17:35:03 ignatenkobrain: Want to talk about it? 17:35:05 ;) 17:35:19 basically we need to do something with this PR 17:35:32 because author is asking for action and we do not do anything 17:35:48 Is there a good way to see more context in the diff view? 17:36:23 tibbs: not trough pagure - you can see the diff you see or the entire new file 17:36:41 tibbs: I guess not with pagure, but there is no more context, it's complete rewrite of file 17:37:14 It's slightly tough to see that from what pagure provides. 17:37:31 Obviously there are a lot of deletes but it's not clear if there's more that's not deleted. 17:37:54 for that, I'd use the compelte file view 17:38:15 Yes, but then you have to switch back and forth between the master and branch views. 17:38:28 To see what it looked like before and what it looks like after. 17:38:47 It's merely a mild annoyance. 17:39:09 a side by side entire file view wqould indeed be nice (cc pingou) 17:39:28 Very much yes. I'm sure it's already a feature request. 17:39:29 mhroncok: exists for commit not for pr atm 17:39:29 (and here we are again talking about git and pagure) 17:40:05 As for the draft... I'm quote fine with it though those are some looooong lines. 17:40:11 (so if there is only one commit in the PR I can should you the side by side) 17:40:30 s/should/show/ 17:40:37 pingou: there is 17:40:46 Semantic line breaks would certainly be great but I can add them as part of the writeup. 17:40:48 pingou: and even if I click the commit, I have no idea how to show that 17:41:03 mhroncok: link? 17:41:07 https://pagure.io/fork/nmav/packaging-committee/c/5532e4aaae14c5785435b7c2ff9b2da37cbe1b87 17:41:21 and https://pagure.io/packaging-committee/pull-request/821#commit_list 17:41:40 tibbs: so do we vote on the content change? 17:41:49 I think so. 17:41:50 mhroncok: https://pagure.io/fork/nmav/packaging-committee/c/5532e4aaae14c5785435b7c2ff9b2da37cbe1b87?splitview=True 17:42:08 (yes it's a little bit of a hidden feature for now, until we can make it work better) 17:42:23 I am so happy I have 21:9 monitors. 17:42:47 long-line-- 17:42:48 pingou++ 17:42:48 mhroncok: Karma for pingou changed to 5 (for the current release cycle): https://badges.fedoraproject.org/tags/cookie/any 17:42:57 mkonecny: all ryanlerch :) 17:43:19 +1 BTW 17:44:01 sure +1 17:45:25 +1 17:45:38 (to the draft, that is) 17:46:21 I would remove Guidelines from links and also add "SSL" into the page title 17:46:26 and use sembr 17:46:34 but apart from that I am voting +1 17:47:09 I haven't read the draft, and I'm only on my phone. if you need my vote, I'll vote on the ticket when I'm at my PC - is that alright? 17:47:21 Certainly that's fine. 17:47:44 ignatenkobrain: What "Guidelines" would you remove? I'm not seeing it. 17:47:58 Oh, you mean in the navbar. 17:48:09 yep 17:48:29 Yes, those I would ceratinly take out. nav.adoc is why it doesn't merge anyway. 17:50:20 And I would obviously add some line breaks. 17:50:41 +4, 0, -0 ? 17:50:41 I've started writing asciidoc stuff here at work so I'm much more familiar with it now. 17:50:53 I think it's fair to say people can add line breaks without more voting ;) 17:51:02 mhroncok: I think so 17:51:13 at this smestr we went form wiki to asciidoc based materials by chance so I get more and more familiar with it as well 17:51:24 *semester 17:52:03 # info 821 is +4, 0, 0, decathorpe tio vote in the ticket 17:52:13 #info 821 is +4, 0, 0, decathorpe to vote in the ticket 17:52:15 #chair 17:52:15 Current chairs: decathorpe geppetto ignatenkobrain mhroncok redi tibbs 17:52:30 mhroncok: redi can vote too 17:52:34 * mhroncok doesn't remember the line 17:52:43 oh, sorry redi 17:53:37 #info PR/821 is +4, 0, 0, decathorpe/redi can vote in the ticket 17:53:52 maybe the bot died ?:-o 17:54:00 #topic Open Floor 17:54:04 I guess not 17:54:35 Oh, I don't think it responds to #info commands, just does them 17:54:40 oh 17:54:54 Anyway … anything to discuss in the last few minutes? 17:54:58 I would like to ask you to look at other PRs, one is from nim and one from mhroncok 17:55:05 I meant not now but when you will have time 17:55:05 ;) 17:55:14 ignatenkobrain++ 17:55:14 nim: Karma for ignatenkobrain changed to 4 (for the current release cycle): https://badges.fedoraproject.org/tags/cookie/any 17:55:20 Well, an update on the tilde versioning thing. 17:55:35 oh yeah, tilde! 17:55:37 ~~~~~~~ 17:55:49 I put in more work but I still have another draft to write. 17:55:55 https://fedoraproject.org/wiki/User:Tibbs/TildeVersioning has explanation and notes. 17:56:02 tibbs > tibbs~tibbs 17:56:11 Just two important cases to consider. 17:56:21 One draft pretty much done unless I screwed it up. 17:56:26 Another draft still to write. 17:56:48 Basically everything I do uncovers some difficult case. 17:57:31 I have listed two cases which are not at all uncommon and tried to simply not worry about everything else. 17:57:59 Since people were complaining that I was throwing completely contrived cases up as something that a policy has to handle. 17:58:15 (Somehow releasing version "0.1" is contrived by some metrics, but...) 18:00:04 Double tildes, oh 18:00:12 It was just a comment that it works. 18:00:18 Actually using it doesn't help. 18:00:28 ¯\_(ツ)_/¯ 18:00:56 * geppetto nods 18:01:05 * ignatenkobrain nods too 18:01:06 Note that there are two primary issues here: I'm trained as a mathematician and I have been doing this long enough to see all of these weird versioning cases. 18:01:35 Allow tilde. Keep post-release snapshot information in Release:. Keep prerelease snapshot information in Version. 18:01:41 this seems most reasonable 18:01:51 Yes, that is the first draft. 18:03:58 I can see that tilde is one of pair of "operators" you need to properly implement snapshots. But we don't have its counterpart and I doubt we would ever get it. (I haven't asked.) 18:04:29 let's ask maybe? 18:04:30 We can live with it by continuing to cram stuff into Release: when necessary. 18:04:35 actually one day I proposed caret 18:04:45 1.2^2018 < 1.2.1 18:04:59 Yes, that's the analog of what a complete implementation would need. 18:05:02 but I wasn't pushing very hard for it so it didn't made upstream 18:05:08 In the notes I called it '?'. 18:05:12 if you feel it's needed, I have branch with test cases 18:05:36 §&[]{}!~@%... 18:05:37 Well it's needed for a scheme which keeps Release: pristine in all cases. 18:05:52 It's not needed in general, but then neither was tilde. 18:05:54 caret was only thin which wasn't looking that awful 18:06:03 and we discussed it with ffesti for long 18:06:23 then I will ask RPM upstream again about caret 18:06:48 https://github.com/rpm-software-management/rpm/pull/88 18:06:51 Yes, caret is perfectly fine. It would take the place of the '+' in some of random exposition that exists in the ticket. 18:06:52 Sep 10 2016 ;) 18:06:56 we can do draf1 one and maybe one day add caret or another whatnot 18:07:01 but let's not block i on that 18:07:03 Obviously '+' isn't something we could use. 18:07:05 > OK, looks like Fedora is going for a policy that works with the current version compare. If version and release strings are chosen with some care (which they have to be anyway) I do not really see an immediate need for this. Closing for now. 18:07:27 Interesting. 18:07:31 I implemented the code and also put test-cases 18:07:33 Please comment on that PR 18:07:44 I don't think we were "going for" anything in particular. 18:08:04 if it's matter of getting this to simplify things, I'm ready to work on it in upstream 18:08:23 but the patch exists and it's not very hard to get it into upstream 18:08:27 Well, sure but as usual the problem is EPEL. 18:08:30 it just needs rationale from Fedora 18:08:36 EPEL is always the problem 18:08:40 tibbs: ffesti backported tilde to RHEL6 at some point 18:08:41 That said, tilde was backported. 18:08:53 if we make it work and used in Fedora, we can ask him to backport caret 18:08:55 it was backported specifically so that Fedora could start using tilde. 18:09:14 I recall a statement to that effect, and that our refusal to take up tilde meant that the work was wasted. 18:09:24 But again, this is not really needed. 18:09:33 but it would be nice 18:09:33 It would just make things simpler. 18:09:43 and a nice explanation why might help us get it 18:09:57 then please, put your opinion in that PR to upstream RPM 18:09:58 and I will revamp it 18:10:11 I will proceed to fine tune the existing draft and implement the second one. And if this caret thing happens then we can be prepared for it. 18:10:38 to caret to happen I need your words to be heard by RPM folks ;) 18:10:43 not the other way around 18:10:54 I'm typing. 18:11:02 cool =) 18:11:07 In that PR. So I'll add as much info as I can. 18:11:28 tibbs: thanks 18:11:44 tibbs++ 18:11:44 ignatenkobrain: Karma for tibbs changed to 5 (for the current release cycle): https://badges.fedoraproject.org/tags/cookie/any 18:11:55 If I had that, the guidelines would be much simpler. 18:12:24 Another question related to tilde 18:12:31 and we would ahve both: tilde + simpler guidelines 18:13:30 What do people think of this sequence: (1.2~beta1-1, 1.2~20180101.abcde-1, 1.2~3.beta2-1 ???, 1.2~4.20180102.fghij-1, 1.2-1) 18:13:49 Or basically even ignore the first element there. 18:14:25 data, beta, date, beta 18:14:27 Basically if you're doing prerelease snapshots and upstream never tags a beta or anything, you just have 1.2~date.whatever, 1.2~nextdate.whatever. It looks nice. 18:14:32 well, double tildes? :D 18:14:46 But if they tag a beta, then you have to have 1.2~3.beta (for at least the next 982 years). 18:15:05 It just seems hard to describe why you have to put a 3 there. 18:15:23 But in the case where you never package a beta, it looks quite nice. 18:15:40 tbh what I would do is 18:15:41 Alternately, if we drop the date then there's never any confusion because you always have to have a digit. 18:15:42 wait, the thing after tilde sort lexicographically? 18:15:51 mhroncok: Yes. 18:15:52 1.2~beta1+20180101.abcde 18:16:02 mhroncok: And evem multiple tildes. 18:16:03 or directly go to 1.2~beta2~20180101.abcde 18:16:13 ignatenkobrain: That's the post-prerelease thing, which is even harder to explain. 18:16:16 because you are NOT swapping beta to git snapshot 18:16:29 you are basically getting commit on top of beta 18:16:36 or before next beta 18:16:39 ignatenkobrain: And you can't know that the next prerelease will be called beta2 unless upstream has told you so. 18:16:45 it's not something that you take random commit and insert after beta release 18:16:47 why should just allow anyhting in there and bump epoch with every rebuild :D 18:16:56 then you use ~beta1+20180101 18:17:04 because you don't know what next release will be 18:17:13 but you know that you are basing it on beta1 + some commits 18:17:53 I have intentionally tried to avoid post-prerelease and pre-prerelease snapshots. 18:18:09 Because actually describing those seems more confusing than useful. 18:18:30 Now, if we used the git describe method, it would sort of fall out. 18:18:46 tbh, I would go with git describe method 18:18:49 That's what Suse does and it makes sense if you understand what git describe does. 18:19:30 Of course, it's dependent on git. 18:20:01 And it requires that upstream actually tags their prereleases, and uses the same naming for the tag as what they actually call the release. 18:20:17 Which seems too much to assume. 18:20:22 Anyway, we're way over here. 18:20:33 * geppetto nods 18:20:53 The problem is that so many of these things weren't really all tied together and could be considered separately. 18:21:00 Anyway … we are 20 minutes over … should we end now or need to talk about tilda more? 18:21:00 * geppetto nods 18:21:05 But by introducing tilde they all some in together. 18:21:08 tibbs, it's much too much to assume I confirm 18:21:11 I will keep writing drafts. 18:21:36 Every scheme that someone wants or suggests seems to work great with one set of upstreams. 18:21:55 And just fails badly with the poorly behaved ones. 18:22:08 But there are so many of the latter category. 18:22:15 :( 18:22:18 tibbs, you want something everyone will accept you need git upstream to implement it 18:22:32 tibbs, good luck with that 18:22:33 Anyway … 18:22:34 #endmeeting