16:00:56 #startmeeting Fedora Packaging Committee 16:00:56 Meeting started Wed Aug 18 16:00:56 2010 UTC. The chair is spot. Information about MeetBot at http://wiki.debian.org/MeetBot. 16:00:56 Useful Commands: #action #agreed #halp #info #idea #link #topic. 16:01:13 #topic Roll call 16:01:59 racor, rdieter, abadger1999, SmootherFrOgZ, Rathann|work, tibbs|h : ping 16:02:04 * Rathann|work present 16:02:17 spot: Here 16:04:05 well, we can wait a few minutes 16:04:31 here 16:06:37 Yep. 16:06:52 okay, thats 5. 16:06:52 No speakers on this computer, unfortunately. 16:07:11 #action Quorum achieved (5) 16:07:23 Okay, I'm going to work through the trac items first 16:07:41 #topic https://fedorahosted.org/fpc/ticket/5 - /usr/share/gtk-doc directory ownership issue 16:08:07 i actually did a draft on this one based on some discussion with the rpm folks and the desktop folks 16:08:13 https://fedoraproject.org/wiki/PackagingDrafts/Revised_File_and_Directory_Ownership 16:09:48 Trying to figure out what changed. 16:10:07 in practical terms on the gtk-doc directory issue, it means that packages can own /usr/share/gtk-doc/ without needing to Requires: gtk-doc 16:10:09 I see a couple of bullet points at the top 16:10:26 here 16:11:09 tibbs|h: i rewrote the "directory ownership" rules to try to simplify and clarify them 16:11:27 tibbs|h: some of the examples were slightly altered/reworded as a result 16:11:38 The second example is completely different. 16:12:32 the draft looks fine to me, except that I don't like the idea of requiring apps dropping files in /usr/share/gtk-doc/ to own that directory as well 16:13:17 Rathann|work: or they can Requires: gtk-doc 16:13:33 Or it could just be stuck in filesystem. 16:13:36 yes they can, but in reality they don't require gtk-doc to function 16:13:36 Rathann|work: or did you have something else in mind? 16:13:47 Rathann|work: the concern is that the rpm folks wanted to ensure that there was never a situation where packages in a dep chain had files in an unowned directory 16:13:51 The last two examples are really the same. 16:14:04 yeah I understand, so even if I don't like it, I'm not opposed 16:14:09 fwiw, I like the draft, 16:14:19 abadger1999: yes, but the perl example came up enough that it has been worth keeping 16:14:20 abadger1999: I was just about to say the same thing 16:14:30 gtk-doc is a devel package, so forcing packages to own it would be wrong. 16:14:44 racor: this doesn't force packages to own it, it actually does the opposite 16:14:52 spot: Oh I'm sorry the second to last and third to last. 16:15:11 yes, the bash-completion and gtk-doc examples look similar 16:15:19 ah. 16:15:23 that is a good point. 16:15:30 spot: Yeah, badly put on my part. Requires:gtk-docs would be wrong 16:15:31 i could probably simply drop the bash-completion item 16:15:42 racor: agreed 16:16:04 or, i could merge it into the above section 16:16:11 two examples in that space may not be a bad thing 16:16:43 * spot is going to merge it, one sec 16:18:26 okay, reload 16:18:39 those items have been merged, and the "filesystem" exception is now highlighted there 16:19:51 If anyone has additional comments, please speak up, otherwise, lets vote. 16:20:40 Add an {{admon/note|Keeping devel packages out of the dep chain|In the specific case of gtk-doc, we would an end-user application (evolution) requiring a devel package (gtk-doc). To keep the minimal install size low, we don't want such deps to occur so it is preferable to multiply own the directory}} 16:20:52 Good change? 16:21:01 theres a grammar burp in there 16:21:31 "we would an end-user" 16:21:47 ... would not want ... ? 16:21:47 we would have an end user 16:22:03 would not want is better 16:22:15 we don't want an end-user 16:22:18 abadger1999: well, its not necessarily wrong, but the point is that gtk-doc isn't in evolutions "natural dependency chain" 16:22:52 natural dep chain is mentioned at the beginning 16:23:39 "In the specific case of gtk-doc, we would not want an end-user application (evolution) artificially requiring a devel package (gtk-doc). To keep the minimal install size low, we don't want such deps to occur so it is preferable to multiply own the directory." 16:24:07 Ah -- I was responding to racor's comment. 16:24:17 the rationale is fine, but isn't that a little redundant? 16:24:19 [09:14:30] gtk-doc is a devel package, so forcing packages to own it would be wrong. 16:24:25 [09:15:30] spot: Yeah, badly put on my part. Requires:gtk-docs would be wrong 16:24:27 Rathann|work: yes, it is redundant. 16:24:39 but i don't mind adding it to make things clear. 16:24:45 sure 16:24:49 If we're not going to judge it as strictly wrong, no need for the change. 16:25:19 okay, then lets leave the change out. 16:25:25 any other comments before we vote? 16:25:37 abadger1999: we do think it's wrong, but the "why" is already covered by the "natural dependency chain" requirement 16:25:49 I do wish it was shorter, but I don't see how to make it do without removing examples. 16:26:12 tibbs|h: if you can think of a revision to condense it, we can revisit it in the future 16:27:04 +1 to the draft 16:27:08 Got another complaint that the guidelines are too long this morning. Not much to be done, honestly. 16:27:11 +1 from me 16:27:14 +1 16:27:25 +1 from me as well 16:27:30 Yeah -- for the guidelines too long, I think the only solution is to better organize them. 16:27:43 abadger1999: i think you're right. 16:28:00 the highlighted "Note on directories" at the top seems to mostly duplicate highlighted "An exception" down below 16:28:16 +1 16:28:30 kalev: this is intentional, someone wanted to make sure it was clear in both places. 16:28:44 Relating to this draft, I do think that at some point this committee or someone might consider finding directories which are significantly multiply-owned and move them into one of the filesystem packages. 16:28:49 * spot would have to dig in his logs to look up who 16:29:04 spot: It's also i nthe bullet points at the top. 16:29:14 # any directories owned by the filesystem, man, or other explicitly created -filesystem packages 16:29:18 tibbs|h: i have enough landmines to step on at the moment. :) 16:29:27 abadger1999: do you think i should drop the note from the top? 16:29:34 I suppose that the {{admon}} at the top could be dropped. 16:29:40 yeah. 16:29:47 okay, im fine with that 16:29:56 if it would change your vote to drop that note at the top, speak up. :) 16:30:14 Hey, one less warning block is a good thing. 16:30:24 agreed 16:30:30 +1 :-) 16:30:33 okay. its dropped, and with +5, it passes. 16:30:44 rdieter: if you would like to vote for the record, go ahead. :) 16:30:54 ok, +1 (sorry, fetched coffee) 16:31:38 #action spot's draft approved (with minor revisions made in flight) 16:31:58 #topic https://fedorahosted.org/fpc/ticket/6 Recoll bundling exception 16:32:08 spot: Hold one 16:32:27 abadger1999: mmkay. whats up? 16:32:47 spot: We also need to decide whether we make people change this, let provenpackagers change it, let maintainers have totally free reign. 16:32:52 For the specific gtk-doc case. 16:33:13 abadger1999: i know it is trendy to say this, but i think that's fesco's call 16:33:28 Because someone did this: https://bugzilla.redhat.com/show_bug.cgi?id=604169 16:33:37 spot: Well -- nirik opened the fpc ticket. 16:33:52 and we've clarified the guidelines as to how it should be handled 16:34:24 So I think they want some input from us. I'd say, old usage is gransdfathered but provenpackagers are welcome to update the packages. 16:34:30 I would expect we would want maintainers to fix it... if someone here can update the ticket to point to the new guideline? 16:34:43 nirik: i threw the new guideline in the fpc ticket 16:35:12 i would be inclined to say that maintainers should fix it, but i'm not going to lose any sleep if they don't. 16:35:25 so, abadger1999's suggestion works for me. 16:35:35 * nirik nods. 16:35:51 Cool. Okay, we can go on to recoll. 16:35:54 i would also note that this is something that provenpackagers should be fixing in rawhide/master, not in pushed updates. 16:36:10 (since that inevitably gets asked) 16:36:27 okay, on to recoll. 16:36:38 abadger1999: i'm not entirely sure why this is on the FPC trac, can you explain? 16:36:39 Note that recoll is touching the same area as this ticket: https://fedorahosted.org/fpc/ticket/8 16:37:08 spot: We need to add the exception to hte guidelines -- I would really realy like to add why an exception was granted at the same time. 16:37:28 abadger1999: aha, okay 16:37:29 spot: If you look at the changes I made to do ticket #8, you'll see what I'd like to do for recoll. 16:38:07 Basically in the Exception section, add potential reasons people could be granted an exception. 16:38:10 gotcha. 16:38:28 And then list the reasons that each specific case was granted one. 16:38:53 okay, so lemme try to figure out why i supported the exception for recoll 16:40:20 ... and i dont have notes on it. 16:40:34 nirik: is there a fesco ticket that might refresh my memory? 16:40:50 I generally support the addition of the 'Exceptions' section to the bundled library guidelines, but damn, it's a whole additional screenfull added to the guidelines. 16:41:16 https://fedorahosted.org/fesco/ticket/431 16:41:17 tibbs|h: we could split it off into its own page. 16:41:27 Sure, some of it could go out of line. 16:41:41 I just don't know if that makes things better or worse for the packagers. 16:41:45 spot: I think there was, can try and dig it up 16:41:54 At least in a single long document you can search. 16:42:00 okay, i have it. 16:42:29 https://bugzilla.redhat.com/show_bug.cgi?id=612719 16:42:34 Note: the whole No bundled libraries section is on a separate page already. 16:42:41 Oh, true 16:42:47 Then never mind, I guess. 16:43:08 I understand the single long document can be searched idea too though -- that's how I find things in the FHS. 16:43:18 my reasoning here was that in cases where A) the upstream is defunct/dead _AND_ B) there are application specific changes to the bundled code 16:44:11 spot: If upstream is defunct, why not push for the present package revitalizing that code base/project? 16:44:23 of course, this conflicts with the text in copylibs 16:44:28 16:45:08 I seem to be lagging quite a bit; please excuse me if I don't respond quickly. 16:45:12 well, okay, and C) the project using the forked bundled libs is not willing or able to revitalize the dead upstream 16:45:19 which is a crappy copout, really. 16:45:53 Well, they have chosen to continue maintenance of the code. 16:46:06 The only real difference is whether it's in a separate tarball or not. 16:46:26 tibbs|h: is it useful to others inside of that package? 16:46:39 I've no idea. 16:46:43 tibbs|h: Okay... but if that's really the case, then we probably should have a unac subpackage with a library in it that other packages consume. 16:46:45 will anyone think "i bet there is a newer unac library in the recoll package i could use" 16:46:53 I mean, all code is potentially useful to others. 16:47:44 So, I think the binc bundled code in recoll falls under the "copylibs" exception in the draft text 16:47:58 * spot is looking at http://lists.fedoraproject.org/pipermail/devel/2010-July/139015.html 16:48:53 hmm. 16:49:18 it would appear so 16:49:20 yeah -- so binc looks like -- there was an application, binc. recoll copied code out of binc. 16:49:44 I can see that falling under "copylib"... maybe I should clarify the wording to include snippets of code from other applications. 16:50:21 what about something like "bundled code has been forked and customized in a way such that it is only useful for the application using it" and "upstream is defunct/dead" and "authors of code fork are unable or unwilling to restart upstream" 16:50:37 i know thats a thick chain of conditionals 16:50:39 * abadger1999 wonders if that would help with a python bundling issue he's seen as well..... there it's strange because anything in site-packages is importable whether or not it's what upstream intends. 16:51:02 I do not like "authors of code fork are unable or unwilling to restart upstream" 16:51:11 i don't like it either 16:51:26 but if it is the practical reality, will we not permit it in Fedora? 16:51:38 I could see the forked and customized clause but not sure how we'd apply that well... 16:51:45 I mean here's a counter example to recoll: 16:51:46 note that the rule is all three being true 16:51:50 rsync bundling zlib 16:51:51 not "one of them being true" 16:51:56 True... 16:52:01 So that wouldn't apply to rsync. 16:52:04 yes. 16:52:52 alright ... so forked and customized seems the most reasonable of these but.... how do we evaluate that? 16:53:21 Case by case. 16:53:27 i think tibbs|h is right. 16:53:38 Honestly I don't think we want this stuff to get in easily. 16:53:41 I mean -- rsync felt like what it did with zlib was something that only it wanted to do but we now have another package that bundles zlib b/c it needs to be compatible with rsync. 16:53:53 looking at the diff between upstream and the bundled source might also make the changes more apparent 16:53:57 And we should certainly consider the exposure it brings to us and our users. 16:54:08 e.g. for libjingle in chromium, it is 20000 LOC. 16:54:24 But honestly we have to understand that we don't have the ability to control what upstreams do. 16:56:11 true. But we do have the option of not allowing the software in the distro because it would make the baby sys admin cry :-) 16:56:32 abadger1999: on the recoll case, i believe my grounds were A) (unac) "bundled code has been forked and customized in a way such that it is only useful for the application using it" and "upstream is defunct/dead" and "authors of code fork are unable or unwilling to restart upstream" and B) (binc) copylibs 16:56:36 And again we have to consider how this serves our purpose as a distro. 16:56:59 as long as nothing else in the distro uses unac, I think it's acceptable 16:57:22 Rathann|work: which i think is true. 16:57:33 * spot wouldn't mind adding that as another restriction 16:58:13 "bundled code has been forked and customized in a way such that it is only useful for the application using it" and "upstream is defunct/dead" and "authors of code fork are unable or unwilling to restart upstream" and "bundled_code (pre-fork) is not otherwise used in Fedora" 16:58:26 Okay, here's a question, shold we setup some way of tracking bundled libs? 16:58:35 abadger1999: yeah, we probably should. 16:58:43 abadger1999: maybe in the pkgdb? 16:59:11 spot: Could be. Or a wiki page. 16:59:13 * spot doesn't want to try to overload rpm provides for this 16:59:14 The farther you put it from the packager, the less chance it will actually be updated. 16:59:22 tibbs|h: a valid point 16:59:24 I suppose we'll want to query it which means pkgdb is better. 16:59:35 But yeah; tibbs|h's point... 16:59:45 but at the very least, exceptions could be processed in pkgdb at the same time they're approved 16:59:59 We can query rpm tags and it's right there in the spec file so the packager has ready access... 17:00:22 * Rathann|work is also in favour of the rpm provides 17:00:27 abadger1999: we'd need to standardize it somehow 17:00:46 * spot notes that we are now at the 1 hour mark 17:01:07 abadger1999: do you have enough from me to amend the draft for recoll? 17:01:08 i.e. Provides: bundled_upstream_name = the_version_it_was_based_of 17:01:10 Like bundled(zlib-1.1.4) 17:01:25 ah, right, abadger1999's idea is better 17:01:38 abadger1999: that seems sane enough 17:01:40 but let's modify it 17:01:50 Provides: bundled(zlib) = 1.1.4 17:01:58 spot: Well, I personally don't like adding adding defunct or upstream is lazy as arguments for bundling. 17:02:16 I do like adding the code has been forked customized to only be useful in this instance. 17:02:24 okay 17:02:25 I just worry about evaluating that statement. 17:02:56 so, what i propose is that you add recoll and the justification that you're comfortable with 17:02:57 Sound good if I revise the draft to include just that one additional condition for next time? 17:03:02 17:03:07 The bottom line is that any package can be granted an exception to any guideline. 17:03:08 Sounds like a plan. 17:03:13 along with the text about how to indicate bundled bits 17:03:25 and we'll review it next time 17:03:58 any other comments on bundling before we move on? 17:04:18 #topic https://fedorahosted.org/fpc/ticket/7 - D Packaging Guidelines 17:04:32 https://fedoraproject.org/wiki/D%2Bpackaging%2Bguideline%2Bdraft 17:05:00 Can someone expand those macros for me?} 17:05:16 What's _d_libdir in practise, or is that not relevant to the discussion? 17:06:12 I objected to _d_includedir being /usr/include/d, but I think I was overridden by FESCo. 17:06:26 also I don't like this: 17:06:29 Because GNU strip can't extract debug symbols from static lib achieves. 17:06:40 http://pkgs.fedoraproject.org/gitweb/?p=ldc.git;a=blob;f=macros.ldc;h=60132c618d129a78470798b76cd994173807bb0a;hb=HEAD 17:06:51 this should at least be accompanied by a link to upstream bug report 17:07:03 tibbs|h: I think we can say that /usr/include/d is wrong if we think it goes someplace else. 17:07:39 Rathann|work: the fact that debuginfo doesn't work on static libs is an open bug 17:07:47 ok 17:07:50 * spot has it written down somewhere 17:07:57 My concern is that at this point the guideline merely codifies existing practice. 17:08:20 tibbs|h: yeah, but so does most (all) of the lang specific guidelines 17:08:37 Only if the cart goes before the horse. 17:08:46 Do the guidelines first, then review the packages against them. 17:08:51 well, the cart is before the horse now. 17:08:56 Which is fail. 17:09:03 I don't understand the point of the makefile example 17:09:07 But that's partially because we haven't been able to meet. 17:09:09 yep. should we not act as a result? 17:09:23 My point is that there's not much we can do. 17:09:35 except codify existing practices in this case. 17:09:45 Might as well spellcheck the document and approve it. 17:09:51 We can tell people they're wrong and must change.... 17:10:01 abadger1999: we can. 17:10:09 That's always a danger when you review packages before hte guidelines are reviewed. 17:10:14 i don't think there are hundreds of D packages in fedora at the moment 17:10:20 The template shouldn't have BuildRoot. 17:10:28 tibbs|h: thats easily cleaned up 17:10:33 it shouldn't have %clean either 17:10:36 Probably shouldn't have %clean, either. 17:10:42 But F12 does still need %clean. 17:10:58 well, it is not harmful to leave it then. 17:11:21 I'm ok with it, curious though why %_d_libdir isn't used in the .spec example though 17:11:30 rdieter: so am i. 17:11:53 probabaly just an omission/typo 17:12:19 rdieter: not sure about that 17:12:26 %files has %{_libdir}/%{name}/ 17:12:38 which is not %{_libdir}/d 17:12:45 (%_d_libdir) 17:12:50 I think I agree with tibbs that hte expansions of the filesystem related macros should be listed. 17:13:03 They are actually there in the macros section. 17:13:07 they are 17:13:09 :) 17:13:31 i think the draft needs to be cleaned up a bit, for grammar and style 17:13:32 It's just that the English there is really tough to parse. 17:13:40 agreed 17:13:41 (also, the makefile section seems unnecessary) 17:14:09 Yeah, what is the point of the block after Libraries? 17:14:11 ah.... /me wonders how he'd reformat this to be easier to read 17:14:24 i could probably take a shot at cleaning this up 17:14:32 and we could revisit it next time. 17:14:39 * rdieter nominates spot for sainthood 17:14:50 gotta be easier than working on chromium. ;) 17:14:59 ha 17:15:19 #action spot will cleanup D draft for next time 17:15:37 okay, so that is all of the trac tickets i am aware of 17:15:45 are there other items for discussion today? 17:15:55 #topic Open Floor 17:15:57 BTW, there are categories for pages needing updates with a release is branched, comes out or goes EPL. 17:16:00 EOL. 17:16:51 nice 17:16:52 Add Category:Update_on_f12_EOL and we can do things like remove %clean from all of the templates. 17:16:56 spot: supercypher wanted the python naming guidelines revisited/clarified but I think I'm against it and he wrote his draft in a bz ticket. 17:17:17 tibbs|h: That's good to know. Thanks! 17:17:33 Not that anything's using them at this point. 17:18:02 .bug 623425 17:18:04 rdieter: Bug 623425 Review Request: python-pyside - Python bindings for Qt4 - https://bugzilla.redhat.com/show_bug.cgi?id=623425 17:18:23 ^^ it's in there if anyone is morbidly curious. 17:18:32 I've never seen that our python naming stuff is unclear. 17:18:53 I dislike the "py" exception, but the rule isn't confusing. 17:19:32 mainly, I think he disliked not using CamelCase and being consistent with other distros. 17:19:59 in this case anyway 17:20:31 I do wish we had lower-cased everything back in the beginning, but far too late now. 17:21:06 well, if someone wants to seriously rework the python naming guidelines, they can open a ticket. 17:21:17 agreed (if conflicts occur only due to case differences, we're in a world of hurt anyway) 17:21:24 BTW, did we get votes from the absent member? 17:21:41 We already have a rule about conflicts due to case differences. 17:21:43 tibbs|h: we did, but he abstained on everything, except for a possible +1 on #7 17:21:50 which never got to a vote. 17:22:54 Okay, last call for topics. If you have nothing, please indicate that you're ready for the meeting to close. 17:23:20 Nothing more from me. 17:23:48 Nor I. 17:23:55 Nothing here. 17:24:49 * abadger1999 had something but forgot it. 17:24:49 nothing 17:24:54 So next time is fine. 17:25:17 okay, then i propose that we meet again next week 17:25:39 same time and day as today (Wednesday, Aug 25, 2010, 1600 UTC) 17:25:39 Oh I remember 17:25:43 sounds good 17:25:51 I'll just mention so we remember 17:26:18 fine by me 17:26:36 Does FPC want to dispense with explicit fesco review and just have them note problems when they see them/people complain on the list. 17:26:51 abadger1999: can you open a trac ticket for that one and we'll discuss it next week? 17:26:54 * abadger1999 can do either tuesday or wednesday just fine. 17:26:58 Yep will do. 17:27:05 spot: Do we like trac then? 17:27:23 I can start documenting it on the how to make an FPC draft page. 17:27:29 abadger1999: eh, i think it is better than the wiki method of yore. 17:27:40 Cool. baby steps :-) 17:28:09 okay, thanks everyone 17:28:11 #endmeeting