#meeting-1:fedoraproject.org log

<@james:fedora.im>

16:00:02

!startmeeting fpc

<@james:fedora.im>

16:00:03

!topic Roll Call

<@meetbot:fedora.im>

16:00:03

Meeting started at 2024-10-10 16:00:02 UTC

<@meetbot:fedora.im>

16:00:04

The Meeting name is 'fpc'

<@limb:fedora.im>

16:00:11

!hi

<@zodbot:fedora.im>

16:00:12

Gwyn Ciesla (limb) - she / her / hers

<@james:fedora.im>

16:00:52

!hi

<@zodbot:fedora.im>

16:00:54

James Antill (james)

<@tibbs:fedora.im>

16:03:17

Hey.

<@tibbs:fedora.im>

16:03:44

I was all ready and then neochat crashed.

<@james:fedora.im>

16:04:20

I still use the webchat ... which has issues, but it doesn't crash.

<@carlwgeorge:matrix.org>

16:05:44

!hi

<@zodbot:fedora.im>

16:05:47

Carl George (carlwgeorge) - he / him / his

<@james:fedora.im>

16:10:09

!topic FPC PR#1207 https://pagure.io/packaging-committee/pull-request/1207

<@james:fedora.im>

16:11:16

This seems ... simple but yet not, somehow

<@tibbs:fedora.im>

16:11:48

I haven't gained any additional understanding of the issue in the intervening years.

<@james:fedora.im>

16:12:07

Not sure if we should just close it and shrug, say something like "feel free to talk to everyone and open a new PR if everyone (or enough people) agrees

<@limb:fedora.im>

16:13:07

same

<@tibbs:fedora.im>

16:13:24

Ruby is well out of the sphere of things I comprehend so I usually just stick to what the ruby folks say.

<@tibbs:fedora.im>

16:13:45

The ticket links to an older now-closed PR which has more dicsussion.

<@james:fedora.im>

16:13:46

Okay, I'll just close it and comment.

<@james:fedora.im>

16:14:07

Yeh, that one had a lot of discussion about how it wasn't perfect and could maybe be confusing.

<@tibbs:fedora.im>

16:14:31

I think vondruch is the main ruby person and he liked the PR but then there was discussion and I don't understand the outcome of it.

<@james:fedora.im>

16:14:31

!topic FPC PR#1292 https://pagure.io/packaging-committee/pull-request/1292

<@james:fedora.im>

16:14:46

I think we can just merge at least the first part of this.

<@tibbs:fedora.im>

16:15:25

Yes, there was agreement about that.

<@james:fedora.im>

16:17:30

Anyone know an easy way to alter a patch in a PR?

<@james:fedora.im>

16:17:50

I could import it locally and --amend it, I guess?

<@carlwgeorge:matrix.org>

16:18:47

not quite easy, but if you add the fork as a new remote and checkout the feature branch, you can amend the commit and add a note at the bottom "Merges: #1292" and it will show in the ui as the pr being merged

<@carlwgeorge:matrix.org>

16:18:59

yeah that

<@carlwgeorge:matrix.org>

16:19:37

as usual, github is nicer than pagure in this regard, because it has the "allow edits from maintainers" checkbox

<@james:fedora.im>

16:20:41

!topic Open Floor

<@tibbs:fedora.im>

16:25:12

Nothing here and I'm getting called away to get more paint.

<@limb:fedora.im>

16:25:56

Same. First part anyway.

<@james:fedora.im>

16:27:31

Okay, going to close ... enjoy your free 30m ;).

<@james:fedora.im>

16:28:47

!endmeeting

<@james:fedora.im>

16:29:16

Ahh, the bot is down due to switch reboots in iad2

<@limb:fedora.im>

16:29:35

Thanks all!