2025-08-25 18:00:11 <@alexsaezm:fedora.im> !startmeeting Go SIG meeting
2025-08-25 18:00:12 <@meetbot:fedora.im> Meeting started at 2025-08-25 18:00:11 UTC
2025-08-25 18:00:12 <@meetbot:fedora.im> The Meeting name is 'Go SIG meeting'
2025-08-25 18:00:16 <@alexsaezm:fedora.im> !topic Roll Call
2025-08-25 18:00:21 <@alexsaezm:fedora.im> Hi everyone! As always we'll wait ~5 minutes for everyone to join.
2025-08-25 18:00:27 <@buckaroogeek:fedora.im> !hi
2025-08-25 18:00:29 <@zodbot:fedora.im> Brad Smith (buckaroogeek)
2025-08-25 18:00:50 <@alexsaezm:fedora.im> o/
2025-08-25 18:01:17 <@buckaroogeek:fedora.im> Greetings!
2025-08-25 18:01:39 <@qulogic:fedora.im> !hi
2025-08-25 18:01:40 <@zodbot:fedora.im> Elliott Sales de Andrade (qulogic)
2025-08-25 18:02:32 <@mikelolasagasti:matrix.org> !hi
2025-08-25 18:02:37 <@zodbot:fedora.im> Mikel Olasagasti Uranga (mikelo2)
2025-08-25 18:05:27 <@alexsaezm:fedora.im> I see several issues in the tracker; two of them were updated a a few minutes ago.
2025-08-25 18:05:58 <@gotmax:matrix.org> !hello
2025-08-25 18:06:00 <@zodbot:fedora.im> Maxwell G (gotmax23) - he / him / his or they / them / theirs
2025-08-25 18:06:04 <@alexsaezm:fedora.im> o/
2025-08-25 18:06:18 <@alexsaezm:fedora.im> !topic Wrong naming for binary packages
2025-08-25 18:06:21 <@alexsaezm:fedora.im> !link https://pagure.io/GoSIG/go-sig/issue/63
2025-08-25 18:06:32 <@alexsaezm:fedora.im> I think this one is by mikel 
2025-08-25 18:06:41 <@mikelolasagasti:matrix.org> yes, just opened it
2025-08-25 18:06:57 <@mikelolasagasti:matrix.org> we've a bunch of binary packages with the wrong naming after adopting go-vendor-tools or in the process of doing it
2025-08-25 18:07:41 <@mikelolasagasti:matrix.org> does it make sense to track it on a main BZ ticket and have a BZ per package that is wrong ?
2025-08-25 18:08:04 <@alexsaezm:fedora.im> hmmmmm that's going to be a lot of BZ 😄
2025-08-25 18:08:13 <@gotmax:matrix.org> https://gitlab.com/fedora/sigs/go/package-data/-/blob/main/go-vendor-tools-users?ref_type=heads#L35-44
2025-08-25 18:08:16 <@gotmax:matrix.org> It's only 9 so far
2025-08-25 18:08:27 <@gotmax:matrix.org> And golang-x-mobile which hasn't been built yet
2025-08-25 18:08:46 <@gotmax:matrix.org> https://src.fedoraproject.org/rpms/golang-github-containerd-continuity/pull-request/1 is in progress, and I'd rather rename that package instead of merging that PR and doing it later
2025-08-25 18:08:57 <@mikelolasagasti:matrix.org> I believe many binaries are going to disappear sooner or later, I believe lot of helper/test binaries have been built that might not  have any real usage
2025-08-25 18:09:10 <@gotmax:matrix.org> Agreed
2025-08-25 18:09:26 <@gotmax:matrix.org> go2rpm included those binaries by default for library packages, but that didn't necessarily mean that anyone was using them
2025-08-25 18:09:26 <@alexsaezm:fedora.im> I have a question about renaming them... what happens with ELN?
2025-08-25 18:09:35 <@alexsaezm:fedora.im> they will change
2025-08-25 18:09:45 <@gotmax:matrix.org> (See the situation where there are three docker-distribution packages, for example)
2025-08-25 18:09:59 <@mikelolasagasti:matrix.org> ELN... I guess so
2025-08-25 18:10:07 <@gotmax:matrix.org> Which are the packages that are in ELN again?
2025-08-25 18:10:13 <@gotmax:matrix.org> ipp-usb and md2man?
2025-08-25 18:10:18 <@alexsaezm:fedora.im> yep
2025-08-25 18:10:18 <@mikelolasagasti:matrix.org> it's being tracked in https://github.com/fedora-eln/eln/issues/240 iiuc
2025-08-25 18:10:23 <@alexsaezm:fedora.im> and I third one I think
2025-08-25 18:10:29 <@buckaroogeek:fedora.im> I need to contact the maintainers on one of those
2025-08-25 18:10:30 <@mikelolasagasti:matrix.org> git-lfs
2025-08-25 18:10:41 <@gotmax:matrix.org> git-lfs doesn't have the golang-* name so that's alright
2025-08-25 18:10:58 <@gotmax:matrix.org> ipp-usb is a subpackage of  golang-github-openprinting-ipp-usb but that source package name would also change
2025-08-25 18:11:04 <@alexsaezm:fedora.im> cc yselkowitz: 
2025-08-25 18:11:13 <@gotmax:matrix.org> Ha, I was about to tag him also
2025-08-25 18:11:45 <@gotmax:matrix.org> But I don't think it's a huge deal; I think it's mainly making a simple change to the content-resolver data, not sure if anything else is needed
2025-08-25 18:12:43 <@alexsaezm:fedora.im> oh no no, but I was reading Mikel's ticket, and I saw the md2man reference, which is kinda critical in centos/rhel and I just wondered.
2025-08-25 18:14:11 <@gotmax:matrix.org> So back to Mikel's ticket...
2025-08-25 18:14:37 <@gotmax:matrix.org> You are suggesting filing Bugzillas against only those ~10 packages that I linked to?
2025-08-25 18:15:37 <@mikelolasagasti:matrix.org> yes... it may not make sense, but we need somehow to fix it so that was one idea to push for it
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-github-prometheus-prom2json
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-github-evanw-esbuild
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-x-*
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-honnef-tools
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> I recognize the following packages:
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> 
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-github-acme-lego
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-github-prometheus-alertmanager
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-github-prometheus
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-github-projectdiscovery-chaos-client
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-mvdan-gofumpt
2025-08-25 18:16:11 <@mikelolasagasti:matrix.org> golang-github-cpuguy83-md2man
2025-08-25 18:16:52 <@gotmax:matrix.org> golang-mvdan-gofumpt does not use go-vendor-tools yet
2025-08-25 18:17:06 <@gotmax:matrix.org> But should be renamed as part of that change
2025-08-25 18:17:36 <@mikelolasagasti:matrix.org> that's what I meant, not only for those that already changed, but as all of them will be (or not) converted they'll need to be renamed
2025-08-25 18:18:11 <@alexsaezm:fedora.im> I think I prefer several bugs (we can always have a bug tracking all together), we can keep tabs on the state of each one of them (not sure how much time renaming will take).
2025-08-25 18:18:38 <@gotmax:matrix.org> I don't want to file any tickets against packages that have not been converted yet, as that's currently opt-in until the Guidelines are approved and Go Vendor Tools becomes more official
2025-08-25 18:19:23 <@gotmax:matrix.org> But creating a tracking bug against go-vendor-tools and then filing bugs against the existing packages that have been improperly converted and need to be renamed that block the tracking bug now is probably fine 
2025-08-25 18:19:43 <@gotmax:matrix.org> But I agree with your point about packages with random test/utility binaries
2025-08-25 18:20:15 <@gotmax:matrix.org> If those packages are not used and/or are broken, they should just be orphaned and allowed to be automatically retired instead of spending time converting them to go-vendor-tools or renaming them
2025-08-25 18:21:42 <@alexsaezm:fedora.im> I bet there are several ones in this situation
2025-08-25 18:22:43 <@mikelolasagasti:matrix.org> last FESCo minutes were reporting non-responsive process for Eclipseo has been approved, so that one will orphan lot of those packages
2025-08-25 18:23:01 <@gotmax:matrix.org> That's true
2025-08-25 18:23:02 <@alexsaezm:fedora.im> *sigh* hope he is ok
2025-08-25 18:23:45 <@gotmax:matrix.org> Although he has so many packages that the Pagure API timed out when they tried to retrieve the list of packages that he maintains to orphan
2025-08-25 18:24:17 <@gotmax:matrix.org> But anyways, I do hope he is okay and am very appreciative of all the work he's done over the years to help the Go ecosystem in Fedora
2025-08-25 18:24:50 <@mikelolasagasti:matrix.org> it was great to meet him in-person for a few minutes at FOSDEM 
2025-08-25 18:25:27 <@mikelolasagasti:matrix.org> I really hope he is doing great and also thankful for all his help when I started 
2025-08-25 18:26:15 <@mikelolasagasti:matrix.org> so, regarding the ticket... I'll open a BZ main ticket against go-vendor-tools and create for the packages already converted
2025-08-25 18:26:39 <@gotmax:matrix.org> !action mikelo2 "so, regarding the ticket... I'll open a BZ main ticket against go-vendor-tools and create for the packages already converted"
2025-08-25 18:26:43 <@gotmax:matrix.org> Thanks
2025-08-25 18:27:06 <@gotmax:matrix.org> I retired a bunch of golang-* leaves yesterday as part of the orphaned packages process
2025-08-25 18:27:33 <@gotmax:matrix.org> Any orphaned golang-* package that is not a leaf is temporarily exempt from retirement
2025-08-25 18:27:38 <@mikelolasagasti:matrix.org> 106 of them 😅
2025-08-25 18:27:39 <@mikelolasagasti:matrix.org> https://gitlab.com/fedora/sigs/go/package-data/-/commit/fe3dfb551f738b03ce391a9712a0ec746ca6d964
2025-08-25 18:28:15 <@gotmax:matrix.org> So once they figure out the Pagure API issue, any package of eclipseo's that is still used will remain in limbo until that exemption is lifted
2025-08-25 18:28:42 <@gotmax:matrix.org> There's a note about it at the top of the orphaned packages report now; I assume people have seen it...
2025-08-25 18:29:12 <@gotmax:matrix.org> Okay... so it sounds like we made a decision about #63 and can move on?
2025-08-25 18:29:33 <@mikelolasagasti:matrix.org> yes
2025-08-25 18:30:49 <@alexsaezm:fedora.im> yep
2025-08-25 18:30:52 <@alexsaezm:fedora.im> let me....
2025-08-25 18:31:07 <@alexsaezm:fedora.im> !topic Perform mass rebuild after golang 1.25.0 GA is released 
2025-08-25 18:31:12 <@alexsaezm:fedora.im> !link https://pagure.io/GoSIG/go-sig/issue/62
2025-08-25 18:32:04 <@gotmax:matrix.org> I finished this last weekend (not yesterday, the one before...)
2025-08-25 18:32:44 <@gotmax:matrix.org> I closed I think over 100 FTBFS tickets that were broken because of the debuginfo thing, so I'd consider it a success
2025-08-25 18:33:40 <@gotmax:matrix.org> https://floss.social/@maxgot/115051191834620501 is the retrospective
2025-08-25 18:33:52 <@gotmax:matrix.org> It thankfully all worked out in the end...
2025-08-25 18:35:07 <@gotmax:matrix.org> I'm not sure if this is something we want to do in the future so that we don't have any packages built with pre-release Go compilers (the mass rebuild usually happens before the Go GA)
2025-08-25 18:35:11 <@gotmax:matrix.org> or if this should just be a one time thing because of the debuginfo problem that broke a bunch of packages that would've otherwise succeeded
2025-08-25 18:36:24 <@mikelolasagasti:matrix.org> I don't track how many changes exist between RC and GA, but if there are a few it makes sense to rebuild with final GA
2025-08-25 18:38:03 <@alexsaezm:fedora.im> I think we already discussed in the past doing mass rebuilds here and there. From the perspective of the ABI, it shouldn't be necessary, but we all know that there are always weird changes not only in the toolchain but in relation to other packages (like gcc in the previous release and debuginfod in this one). Also, I am considering moving everything to one single version of Go instead of one per release, so I guess mass rebuilds are a nice plus
2025-08-25 18:42:32 <@gotmax:matrix.org> Okay, so I guess we can consider it on a case-by-case basis (e.g., if there's some major bug or problem in one of the Go 1.26 RCs and we need to do it again next cycle)
2025-08-25 18:43:09 <@alexsaezm:fedora.im> Yeah, or if there is a disgusting, huge CVE, for example.
2025-08-25 18:43:29 <@gotmax:matrix.org> Exactly
2025-08-25 18:43:42 <@alexsaezm:fedora.im> if you prefer to make it a routine thing... not sure if there is any value on that apart from having an schedule?
2025-08-25 18:44:02 <@alexsaezm:fedora.im> like every month we do a mass rebuild
2025-08-25 18:44:20 <@gotmax:matrix.org> (I also have some updates about the Go Vendor work but have a hard cut off at 21:00 CEST) 
2025-08-25 18:44:49 <@alexsaezm:fedora.im> I don't think there is anything else to discuss if you want to move to the go vendor topic
2025-08-25 18:45:37 <@gotmax:matrix.org> I tagged https://pagure.io/GoSIG/go-sig/issue/51 for meeting if we want to discuss that more next time
2025-08-25 18:46:11 <@gotmax:matrix.org> There are some questions about how to handle stable branches, as it's pretty unusual to make mass changes (e.g., rebuilds) to branches other than rawhide
2025-08-25 18:46:50 <@alexsaezm:fedora.im> Do we move to open floor then and talk about the go vendor work?
2025-08-25 18:47:09 <@gotmax:matrix.org> SGTM, we can always come back to the other issue :)
2025-08-25 18:47:25 <@alexsaezm:fedora.im> !topic Open floor
2025-08-25 18:48:27 <@gotmax:matrix.org> I guess I'll start by copying what I wrote in the Golang channel yesterday
2025-08-25 18:48:34 <@gotmax:matrix.org>  I started working on a %gocheck2 macro/script with a similar interface to %gocheck but that uses Go modules mode and doesn't rely on the golist project
2025-08-25 18:48:40 <@gotmax:matrix.org> The current draft of the Packaging Guidlines are rendered at https://fedora.gitlab.io/sigs/go/packaging-guidelines-fork/packaging-guidelines/Golang/. I haven't had a ton of time to work on them, but they're coming along nicely. 
2025-08-25 18:48:57 <@gotmax:matrix.org> !info The current draft of the Packaging Guidlines are rendered at https://fedora.gitlab.io/sigs/go/packaging-guidelines-fork/packaging-guidelines/Golang/. 
2025-08-25 18:49:47 <@alexsaezm:fedora.im> so no golist after this?
2025-08-25 18:49:53 <@qulogic:fedora.im> Is this different from the `%gotest` I've been seeing?
2025-08-25 18:50:17 <@gotmax:matrix.org> %gotest has "always" been around 
2025-08-25 18:50:31 <@gotmax:matrix.org> It's just `go test` with linker flags and such
2025-08-25 18:51:10 <@qulogic:fedora.im> right, and in module mode, what specifically do we need extra?
2025-08-25 18:51:11 <@gotmax:matrix.org> This new script provides a similar interface to `%gocheck` with the ability to ignore specific import paths (the `-d` and `-t` flags)
2025-08-25 18:51:55 <@gotmax:matrix.org> I wanted to just switch the guidelines to only mention `%gotest`, but people seemed to rely on `%gocheck`'s features, so I didn't want to get rid of it completely
2025-08-25 18:52:05 <@gotmax:matrix.org> I originally wanted to just switch the guidelines to only mention `%gotest`, but people seemed to rely on `%gocheck`'s features, so I didn't want to get rid of it completely
2025-08-25 18:53:09 <@mikelolasagasti:matrix.org> does it make sense to hide the "awk" method to skip tests behind a macro?
2025-08-25 18:53:48 <@gotmax:matrix.org> It also no longer relies on the goipath macro or any of the `-z` lua stuff or assume that `%goprep` has been run
2025-08-25 18:54:07 <@gotmax:matrix.org> It just reads the go path from the go.mod file in the current directory
2025-08-25 18:54:57 <@qulogic:fedora.im> latest Go has a `-skip` flag, I wonder it that should be preferred now?
2025-08-25 18:55:17 <@gotmax:matrix.org> Is it `-skip` or `-ignore`?
2025-08-25 18:55:50 <@qulogic:fedora.im> it's `-run` to select, `-skip` to ignore
2025-08-25 18:55:59 <@gotmax:matrix.org> But yes, that's usually better, but sometimes those awk invocations are easier to format when there's a lot of test skips
2025-08-25 18:56:29 <@gotmax:matrix.org> Currently, `%gocheck2 -- -skip TestSomething -skip TestSomethingElse` works
2025-08-25 18:56:39 <@gotmax:matrix.org> (Anything after `--` is passed directly to `go test`)
2025-08-25 18:56:46 <@gotmax:matrix.org> But we could probably make that nicer
2025-08-25 18:57:08 <@gotmax:matrix.org> What about a `-s` flag?
2025-08-25 18:57:21 <@gotmax:matrix.org> So `%gocheck2 -s TestSomething -s TestSomethingElse`?
2025-08-25 18:57:56 <@gotmax:matrix.org> Okay, I can add that
2025-08-25 18:58:58 <@alexsaezm:fedora.im> to skip? I like it
2025-08-25 19:00:17 <@alexsaezm:fedora.im> we are at the top of the hour btw
2025-08-25 19:00:31 <@alexsaezm:fedora.im> do we want to keep going? or we should leave it for the next meeting?
2025-08-25 19:01:21 <@gotmax:matrix.org> I have to get somewhere, so maybe next metting?
2025-08-25 19:01:30 <@alexsaezm:fedora.im> sure
2025-08-25 19:01:33 <@mikelolasagasti:matrix.org> I just wanted to ask gotmax23 about the removal of `-x` flag. Do you plan to merge it soon?
2025-08-25 19:01:39 <@gotmax:matrix.org> But please take a look at https://fedora.gitlab.io/sigs/go/packaging-guidelines-fork/packaging-guidelines/Golang/ and provide feedback!!
2025-08-25 19:01:58 <@gotmax:matrix.org> I'm waiting for alexsaezm's feedback on that
2025-08-25 19:02:22 <@alexsaezm:fedora.im> answered
2025-08-25 19:02:24 <@mikelolasagasti:matrix.org> he added a +1 a few minutes ago, so I guess we're good
2025-08-25 19:03:03 <@gotmax:matrix.org> To be clear, you support removing it entirely, even on RHEL 19?
2025-08-25 19:03:06 <@gotmax:matrix.org> *RHEL 10
2025-08-25 19:04:01 <@alexsaezm:fedora.im> yeah
2025-08-25 19:04:19 <@gotmax:matrix.org> Okay, cool. I'll get on that.
2025-08-25 19:04:20 <@gotmax:matrix.org> Thank you
2025-08-25 19:04:43 <@alexsaezm:fedora.im> well it won't go away as easily on RHEL, but yes, it's too verbose and people can always add it
2025-08-25 19:06:31 <@gotmax:matrix.org> Well, I'd like it if we could continue backporting go-rpm-macros releases to RHEL, and I plan to remove the flag entirely from the next release
2025-08-25 19:06:59 <@alexsaezm:fedora.im> sure, it wont be a problem
2025-08-25 19:06:59 <@gotmax:matrix.org> So if it would prevent rebasing the RHEL package to the next release, I can be flexible and disable the flag conditionally
2025-08-25 19:07:09 <@gotmax:matrix.org> Okay, got it
2025-08-25 19:07:30 <@alexsaezm:fedora.im> it's just a matter of the schedule, but I don't see any reason why we don't want it remove
2025-08-25 19:08:05 <@alexsaezm:fedora.im> we are going to keep rebasing the package for sure, the last thing we want is to be away from Fedora with random changes that don't add any value to people
2025-08-25 19:08:39 <@gotmax:matrix.org> Cool, sounds like we're on the same page
2025-08-25 19:09:08 <@alexsaezm:fedora.im> yep
2025-08-25 19:09:20 <@alexsaezm:fedora.im> we should call it for today 🙂
2025-08-25 19:09:26 <@gotmax:matrix.org> Indeed
2025-08-25 19:09:31 <@alexsaezm:fedora.im> Thanks everyone!
2025-08-25 19:09:38 <@alexsaezm:fedora.im> and sorry for making this so long 🙂
2025-08-25 19:09:49 <@alexsaezm:fedora.im> we'll see each other in the next meeting!
2025-08-25 19:09:52 <@alexsaezm:fedora.im> !endmeeting