17:05:01 <mattclay> #startmeeting Ansible Testing Working Group
17:05:01 <zodbot> Meeting started Thu Jun 13 17:05:01 2019 UTC.
17:05:01 <zodbot> This meeting is logged and archived in a public location.
17:05:01 <zodbot> The chair is mattclay. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:05:01 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
17:05:01 <zodbot> The meeting name has been set to 'ansible_testing_working_group'
17:05:21 <Pilou> mattclay: o/
17:05:28 <mattclay> #info Agenda: https://github.com/ansible/community/issues/248
17:05:35 <mattclay> #chair Pilou pabelanger
17:05:35 <zodbot> Current chairs: Pilou mattclay pabelanger
17:05:43 <mattclay> pabelanger: Do you have any updates for us today?
17:07:15 <mattclay> Pilou: We can discuss your PR while we're waiting.
17:07:17 <mattclay> #topic https://github.com/ansible/ansible/pull/56392
17:08:21 <mattclay> Pilou: What did you want to discuss about that PR?
17:08:37 <Pilou> this one adds integration tests for consul
17:09:03 <Pilou> tests can be reviewed by working group members :)
17:11:15 <mattclay> Pilou: Tests are currently failing on that PR.
17:12:08 <Pilou> sanity test fails because i added doc for an undocumented parameter
17:14:45 <Pilou> "id" parameter is here since a long time
17:15:35 <mattclay> Is there anyone here who wants to volunteer to review the PR?
17:15:44 <mattclay> #chair sdoran
17:15:44 <zodbot> Current chairs: Pilou mattclay pabelanger sdoran
17:16:28 <sdoran> o/
17:16:48 <sdoran> I'll review that.
17:17:04 <Pilou> thanks
17:19:25 <sdoran> Since it's adding documentation for a parameter that has existed for a while, and is not new, can we ignore that sanity test failure? Or is there a way to properly do this without invoking a failure?
17:20:50 <mattclay> Yeah, for docs fixes for previously undocumented parameters we can ignore the failure, if that's the only failure.
17:22:08 <sdoran> Will that failure exit the sanity tests and potentially miss further sanity test failures?
17:23:58 <mattclay> No
17:25:13 <sdoran> 👍
17:26:46 <mattclay> Pilou: Do you know of any consul users that might want to review the changes?
17:27:24 <Pilou> no, i will ask on #ansible, good idea :)
17:31:42 <mattclay> #topic Open Floor
17:31:47 <mattclay> Does anyone else have something to discuss?
17:32:50 <Pilou> that's all for me (#56534 will wait for sivel :)
17:35:07 <pabelanger> mattclay: nothing too major to report, we are moving forward on getting all our network-integration tests green for zuul.ansible.com
17:35:19 <pabelanger> we are fixing issues in devel, and doing backports to stable branches
17:35:38 <pabelanger> we've also noticed a few github api issues, which we are trying to fix in zuul. That is an ongoing battle
17:42:40 <mattclay> pabelanger: Thanks for the update.
17:42:57 <mattclay> Does anyone have anything else before I end the meeting?
17:47:46 <mattclay> Thanks for coming everyone.
17:47:48 <mattclay> #endmeeting