16:04:16 <Goneri> #startmeeting Ansible VMware Working Group
16:04:16 <zodbot> Meeting started Mon Nov 25 16:04:16 2019 UTC.
16:04:16 <zodbot> This meeting is logged and archived in a public location.
16:04:16 <zodbot> The chair is Goneri. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:04:16 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:04:16 <zodbot> The meeting name has been set to 'ansible_vmware_working_group'
16:04:57 <Goneri> #chair jtyr
16:04:57 <zodbot> Current chairs: Goneri jtyr
16:05:18 <Goneri> #chair akasurde
16:05:18 <zodbot> Current chairs: Goneri akasurde jtyr
16:06:54 <Goneri> We don't have any agenda for today, does anyone want to speak about a specific topic?
16:07:36 <jtyr> I do
16:07:49 <jtyr> I would like to discuss https://github.com/ansible/community/issues/423#issuecomment-553451958
16:07:59 <jtyr> Forgot to join last time ;o)
16:08:17 <Goneri> #topic https://github.com/ansible/ansible/pull/63741
16:09:51 <Goneri> jtyr, how long is "too long"?
16:09:57 <jtyr> days
16:11:14 <jtyr> in better case hours
16:11:14 <Goneri> holyclow, indeed, this justify the feature. vmware_guest do the image look up to know if it needs to create a vmdk.
16:12:16 <Goneri> I suggest to use a key like `use_existing_disk: true` instead
16:12:50 <Goneri> I comment on the issue directly.
16:13:01 <jtyr> ok
16:13:36 <jtyr> `use_existing_disk` doesn't doesn't sound very expressive for this case tho
16:14:26 <jtyr> if you don't like `find_vmdk`, what about `check_vmdk_exists`?
16:19:44 <Goneri> what about just using `filename`? According to the doc, the image should already exist and so, nothing justify to do a look up on the datastore.
16:22:49 <jtyr> well that would be the best ... no loo up if you specify `filename`
16:23:36 <Goneri> great, if there is a look up with filename, could you update  the patch?
16:24:52 <jtyr> sure, do you want me to do it now?
16:25:33 <Goneri> no hurry, we can continue on the PR
16:25:36 <Goneri> #topic https://github.com/ansible/ansible/pull/63740
16:29:21 <Goneri> It looks good to me, I just put a comment.
16:29:54 <jtyr> ok
16:30:00 <Goneri> #topic https://github.com/ansible/ansible/pull/43435
16:31:27 <Goneri> the autoselect_datastore feature is kinda broken IMO, and needs a refactoring
16:31:29 <Goneri> e.g: https://github.com/ansible/ansible/issues/58541
16:32:35 <Goneri> also: https://github.com/ansible/ansible/issues/64764 https://github.com/ansible/ansible/issues/58068
16:34:00 <Goneri> pbidkar, do you have any opinion on those?
16:35:22 <jtyr> the problem I had was that I couldn't pass tests as the methods I'm using are not implemented in Go framework used for the testing ...
16:35:41 <jtyr> govmoni is the framework ...
16:38:21 <Goneri> jtyr, you can do something like that: https://github.com/ansible/ansible/blob/devel/test/integration/targets/vmware_vswitch/tasks/main.yml#L5-L6
16:39:41 <jtyr> I see ... so I only move my tests into this block and it should be fine?
16:40:50 <Goneri> yes, they will only be triggered when the test-suite is run on a regular lab
16:41:32 <jtyr> nice
16:43:20 <Goneri> and we should run the test-suite on regular lab soon
16:43:41 <Goneri> jtyr, do you have anything else to speak about?
16:44:20 <jtyr> not really ... I will address all your comments this week and I will try to come for the next meeting do re-review it ...
16:46:37 <Goneri> nice, I close the meeting then
16:46:39 <Goneri> #endmeeting