00:00:13 <nitzmahone> #startmeeting Azure Working Group
00:00:13 <zodbot> Meeting started Thu Nov 23 00:00:13 2017 UTC.  The chair is nitzmahone. Information about MeetBot at http://wiki.debian.org/MeetBot.
00:00:13 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
00:00:13 <zodbot> The meeting name has been set to 'azure_working_group'
00:00:44 <nitzmahone> #chair Kylie
00:00:44 <zodbot> Current chairs: Kylie nitzmahone
00:01:51 <jborean93> Hi
00:02:01 <nitzmahone> #chair jborean93
00:02:01 <zodbot> Current chairs: Kylie jborean93 nitzmahone
00:02:21 <Kylie> #topic PR request review
00:02:45 <Kylie> last time , we have action itme: nitzmahone/jborean93 review #32336, 32535, 32025, 32614
00:03:33 <nitzmahone> Yep, just started getting back to that today. I've done a couple of them already- working on ACI one right now
00:03:58 <jborean93> 32614 was merged yesterday
00:04:18 <nitzmahone> Part of what makes that process slower than usual is if it's a service we're unfamiliar with- we need to learn about the service and play with the module to see if the UI makes sense and fits with typical patterns...
00:04:52 <Kylie> Thank you Jordan.
00:04:52 <jborean93> also as an FYI I've started to collate some of these PRs here https://github.com/ansible/community/wiki/Azure%3A-Action-plan
00:05:07 <Kylie> Understand Matt. Anything could we do to fasten it?
00:05:50 <nitzmahone> I'm hoping to get through most of them today; just a lot of stuff happening last week, and hot items coming in ahead of the US holiday for the rest of this week.
00:05:55 <Kylie> Wonderful. Jordan.
00:06:31 <nitzmahone> I imagine once we get through a couple rounds of these that people will anticipate what we're looking for too, so hopefully will go faster over over time
00:07:06 <Kylie> Got it. When we write E2E for VMSS, ACS and functions, we also find out new bugs. As for bug fix, could azure module maintainers approve them?
00:08:02 <nitzmahone> So long as the changes don't alter the UI or significantly change the behavior of the module beyond fixing the bug, I'd say that's probably OK...
00:08:30 <nitzmahone> But if there's bigger changes required, we should probably discuss
00:08:51 <jborean93> There was one I came across yesterday that I think requires some more discussion around how to set the options
00:09:04 <nitzmahone> keyvault?
00:09:07 <jborean93> https://github.com/ansible/ansible/pull/32882
00:09:12 <jborean93> multiple network interfaces
00:09:25 <jborean93> sorry ip configurations
00:09:37 <Kylie> Submitted by Yuwei.
00:09:51 <Kylie> Anything you want to discuss here with Yuwei for 32882?
00:10:04 <nitzmahone> Is yuwei here?
00:10:53 <Kylie> O, sorry, I forgot she took sick leave. Let me remind her once she come back office.
00:11:41 <Kylie> Then let me leave space to you and Yuwei and Zim to see whether you could mentor them approve bug fixes to fasten the process.
00:11:41 <nitzmahone> The stuff I've been reviewing has so far looked pretty good, just a few minor changes and ready to merge.
00:11:49 <Kylie> Great.
00:12:13 <nitzmahone> Followup reviews on those will be much faster, obviously
00:13:00 <Kylie> Then how about this? Next week we could discuss how to define "big" bug fix. Then bug fix less than "big", let Azure module maintainers do the approval. Is it ok?
00:13:06 <nitzmahone> We had some problems this week with recent changes to the Azure Python SDK breaking existing modules, but I think we've got it sorted.
00:13:19 <nitzmahone> Sure, that sounds reasonable
00:13:41 <Kylie> We will add test against Azure Python SDK in the future.
00:13:47 <Kylie> #topic Red Hat Summit
00:14:13 <Kylie> Do you have plan to submit topic of Ansible to Red Hat Summit?
00:14:42 <jborean93> I probably won't be there so no :)
00:14:56 <nitzmahone> jimi-c and I have already submitted a lab proposal about Ansible module writing; hadn't planned on submitting any talks beyond that though
00:15:26 <nitzmahone> If our lab gets accepted, I'll be there, if not, I probably won't either
00:15:50 <Kylie> Lab, is it hands-on lab?
00:15:54 <nitzmahone> yes
00:16:23 <nitzmahone> Basically "how to write an Ansible module from scratch"
00:17:18 <Kylie> Do you know VSCode? A lightweight code editor? We are implementing an Ansible extension in VSCode with code snippet and auto-complete. Then you could easily use it to write your Ansible playbook.
00:18:09 <nitzmahone> neat
00:18:35 <jborean93> I've used VSCode but haven't tried the Ansible extension, just use a generic YAML one. Will have to try it out
00:19:08 <Kylie> Not published yet:( We are working on that. Once published, I definitely will let you know and listen to your feedback.
00:19:23 <jborean93> That sounds good, looking forward to seeing what it is like
00:19:47 <Kylie> #topic Documentation
00:19:53 <zikalino> perhaps we can share vsix in a few weeks so you can try earlier
00:20:09 <Kylie> Yes.
00:20:17 <Kylie> Ok, so zim is online.
00:20:32 <Kylie> Zim, any PR do you want to raise here or discuss here?
00:20:35 <zikalino> one of the things we did is parsing all the samples from the documentation so they are available as code snippets
00:21:13 <zikalino> yes, actually i have 2 prs right now which i would like to merge as soon as possible as all subsequent prs will depend on them.
00:21:15 <zikalino> https://github.com/ansible/ansible/pull/33077
00:21:18 <zikalino> and
00:21:45 <zikalino> https://github.com/ansible/ansible/pull/33173
00:22:04 <zikalino> these are azure_rm_sql_servers and azure_rm_sql_databases
00:22:38 <jborean93> I haven't looked at them in depth so far but can you make the module names non-plural?
00:22:47 <jborean93> e.g. azure_rm_sql_server and azure_rm_sql_database
00:23:04 <zikalino> well, and again i have some problem with testing (same as ACS module), missing Microsoft.Sql access
00:23:28 <zikalino> ok, i will do it
00:23:30 <nitzmahone> Not sure what you mean about missing Microsoft.Sql access - as in the provider, or?
00:23:48 <nitzmahone> Or do you mean around integration/CI testing?
00:24:18 <nitzmahone> (eg test instance isn't guaranteed to have the right Python modules installed)
00:24:21 <nitzmahone> or something else?
00:25:20 <zikalino> in the azure account that is used for testing "Microsoft.Sql namespace not available"
00:25:52 <nitzmahone> Is it a preview feature that needs to be enabled on the account or something?
00:25:56 <nitzmahone> (/subscription)
00:26:25 <zikalino> but i will talk to Yawei about it, he was looking into that, right now i can't enable integration testing...
00:29:00 <Kylie> We are writing some documentation for common Ansible E2E scenario. Matt, Jordan, do you have any insights how customers use Ansible for what E2E scenarios?
00:30:16 <jborean93> Well before I started at RH, I used it to spin up a new server and deploy an application to the server but that app is pretty niche
00:30:31 <jborean93> But the general concept applies
00:30:36 <nitzmahone> Maybe just taking some of the quickstart deployment templates or something and showing how to do the same thing with Ansible would be a good start.
00:31:02 <Kylie> Well received. Thank you.
00:31:07 <Kylie> Any other topic?
00:31:12 <nitzmahone> None here
00:31:34 <jborean93> I'm good
00:31:37 <Kylie> Thank you all. Please help take care of PRs.
00:31:40 <Kylie> #endmeeting