13:04:09 <andreasn> #startmeeting Cockpit weekly meeting 2016-04-25
13:04:09 <zodbot> Meeting started Mon Apr 25 13:04:09 2016 UTC.  The chair is andreasn. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:04:09 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
13:04:09 <zodbot> The meeting name has been set to 'cockpit_weekly_meeting_2016-04-25'
13:04:18 <andreasn> .hello andreasn
13:04:19 <zodbot> andreasn: andreasn 'Andreas Nilsson' <anilsson@redhat.com>
13:04:48 <andreasn> #topic Agenda
13:04:53 <dperpeet> .hello dperpeet
13:04:54 <zodbot> dperpeet: dperpeet 'None' <dperpeet@redhat.com>
13:05:06 <larsu> .hello larsu
13:05:07 <zodbot> larsu: larsu 'Lars Uebernickel' <lars@uebernic.de>
13:06:27 <dperpeet> * react playground
13:06:32 <dperpeet> * listing pattern updates
13:06:45 <dperpeet> * google summer of code
13:08:20 <andreasn> anything else?
13:09:11 <mulhern> .hello mulhern
13:09:12 <zodbot> mulhern: mulhern 'None' <amulhern@redhat.com>
13:09:25 <andreasn> #topic React Playground
13:09:42 <dperpeet> We've extended the playground package to now also create a "React Patterns" page (next to the "Design Patterns" page in the tools menu). React components for patterns are added there as they're created.
13:10:07 <dperpeet> They are a bit different form the old patterns in the sense that react components also share behavior
13:10:23 <dperpeet> so if they're used somewhere else, most parts ideally aren't copy pasted, but actually included
13:10:44 <dperpeet> the downside is that any changes here will have to be carefully reviewed
13:11:13 <dperpeet> lars is working on preparing base1 for react components
13:11:35 <andreasn> I get this little "Dialog closed: Canceled(no action)" text when I hit the button. Is that a bug or expected?
13:11:47 <andreasn> the Show Dialog button
13:12:02 <dperpeet> that shows the "return" state of the modal dialog
13:12:07 <larsu> the first component I want to add there is the terminal
13:12:15 <larsu> is anyone against moving terminal.html to that?
13:13:05 <andreasn> would it complicate things for the FreeIPA project. They use our terminal, right?
13:13:19 <dperpeet> to be more explicit: we have the dialog and select components right now, listings, terminal and other components are in progress
13:13:37 <larsu> andreasn: I don't know. That's why I'm asking :)
13:13:45 <dperpeet> larsu, could you specify which terminal.html?
13:13:46 <larsu> how are they using it? terminal.html in an iframe?
13:13:51 <andreasn> sgallagh: do you know?
13:14:04 <dperpeet> and whether you want to move it or change how it works
13:14:15 <larsu> dperpeet: systemd/terminal.html
13:14:28 <larsu> seems to be public API, if we have such a thing
13:14:45 <dperpeet> I don't see why that page needs to move
13:14:59 <andreasn> I'm not sure how they use it, and even if they do, or if it was just talk of it at some point
13:15:12 <petervo> andreasn, unless they are using the cockpit transport
13:15:23 <petervo> i don't think any changes we make will effect them
13:15:46 <dperpeet> I'd expect that the systemd/terminal.js script would change to use the react component
13:15:55 <dperpeet> -that
13:16:56 <larsu> exactly
13:17:04 <andreasn> but yeah, should be straight forward to move the terminal to react then
13:17:10 <dperpeet> on the topic, I think we can just say for now that larsu has pretty much finished moving the terminal stuff into a react component
13:17:14 <larsu> if all they're doing is including it in an iframe, they should be fine
13:17:45 <dperpeet> ok. end of topic I believe :)
13:17:46 <andreasn> cool
13:17:49 <andreasn> all right
13:18:01 <andreasn> #topic listing pattern updates
13:18:22 <dperpeet> peter and stef implemented the new listing pattern in angular and the playground
13:18:35 <dperpeet> I'm working on the react variant
13:18:51 <dperpeet> we discussed today that we'll continue using tables instead of divs
13:19:04 <andreasn> looks good so far!
13:19:11 <larsu> dperpeet: oh. Why?
13:19:18 <dperpeet> background: https://www.patternfly.org/list-view/ patternfly seems to use divs mostly now
13:19:25 <dperpeet> we want to align columns properly
13:19:30 <andreasn> I had to do a wipe of my /usr/share/cockpit directory and rebuild it, for things to bite
13:19:38 <andreasn> in case anyone else runs into that
13:19:47 <dperpeet> and many of our table views are tabular, e.g. list of running containers, services, errors, images, ...
13:20:16 <dperpeet> we won't have to change anything for this, since it's what we're doing, but worth noting
13:20:16 <petervo> dperpeet, should i do a quick fixup of selinux
13:20:26 <petervo> or are you close with the react changes?
13:20:40 <dperpeet> that's the other note: we proceeded differently from our usual behavior
13:21:00 <dperpeet> because of so many interleaved changes, we merged some things that broke other ui parts
13:21:09 <dperpeet> I expect to get a pr up for review today
13:21:39 <dperpeet> I would say that if that blocks or doesn't get done for some reason, we can do the fixup tomorrow
13:21:57 <dperpeet> petervo, what do you think?
13:22:10 <petervo> sounds good
13:22:45 <dperpeet> the playground listing pattern looks good
13:22:52 <dperpeet> thanks petervo, stefw
13:23:02 <dperpeet> and andreasn for the design :)
13:23:16 <dperpeet> having the row not change when toggling expanded state is very nice
13:23:37 <dperpeet> end of topic from my side
13:23:48 <andreasn> all right
13:24:00 <andreasn> #topic google summer of code
13:24:15 <dperpeet> ok, so cockpit has one student
13:25:01 <dperpeet> Harish Anand will work on getting systemd timers into Cockpit
13:25:04 <andreasn> nice
13:25:18 <andreasn> what's Harish irc nick?
13:25:20 <dperpeet> the community bonding period has begun
13:25:41 <dperpeet> there seems to be a naming conflict, but right now he's in here as harish__ I believe
13:26:05 <andreasn> harish__: hello!
13:26:10 <larsu> welcome harish__
13:26:24 <dperpeet> a timeline is here: https://developers.google.com/open-source/gsoc/timeline
13:26:42 <dperpeet> I expect harish will say something during the next meetings
13:27:02 <dperpeet> actual coding / work is scheduled to begin May 23rd
13:27:12 <larsu> what time zone are they in?
13:27:37 <dperpeet> I believe his working hours are his to share
13:27:47 <dperpeet> we haven't discussed that yet
13:28:01 <dperpeet> petervo and I will be mentoring
13:28:07 <larsu> ok. just wondering if the meeting time is good for him
13:28:13 <larsu> and not in the middle of the night
13:28:51 <dperpeet> I'm hopeful that as a student he won't let things like daylight dictate his waking hours :)
13:28:59 <dperpeet> no matter where he is
13:29:34 <dperpeet> to wrap it up, the end of the gsoc work period is in august
13:29:48 <sgallagh> andreasn: You pinged? (sorry, forgot to sign into IRC this morning)
13:30:05 <andreasn> sgallagh: do you know if freeipa is using the cockpit terminal?
13:30:12 <dperpeet> end of topic
13:30:34 <andreasn> thanks
13:30:39 <andreasn> #topic Open Floor
13:31:30 <sgallagh> andreasn: Not directly so far as I know
13:31:35 <andreasn> ah, ok
13:31:37 <sgallagh> Some end-users might use it for convenience
13:31:55 <andreasn> right, but it's not built in to the freeipa UI?
13:32:25 <dperpeet> larsu, on that note, it would be nice to get paste to work in the terminal!
13:33:15 <larsu> Ctrl+Shift+V?
13:33:22 <larsu> hm, yeah
13:33:34 <dperpeet> I never got any kind of paste to work
13:34:14 <dperpeet> we may have to look at cherry-picking some upstream stuff
13:34:23 <dperpeet> but not essential right now
13:34:43 <larsu> they have some weird prefix mode in which paste apparently works
13:34:53 <larsu> we're not tracking upstream?
13:35:31 <dperpeet> upstream pull requests
13:35:44 <dperpeet> we can meet discuss that some other time
13:35:57 <dperpeet> ping me before you start digging, I've looked already
13:36:35 <andreasn> ok, anything else for the meeting, or should I call it a close?
13:38:00 <andreasn> #endmeeting