14:31:06 <acozine> #startmeeting Docs Working Group aka DaWGs
14:31:06 <zodbot> Meeting started Tue Dec 10 14:31:06 2019 UTC.
14:31:06 <zodbot> This meeting is logged and archived in a public location.
14:31:06 <zodbot> The chair is acozine. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:31:06 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
14:31:06 <zodbot> The meeting name has been set to 'docs_working_group_aka_dawgs'
14:31:13 <acozine> is anybody around?
14:31:22 * samccann waves
14:31:28 <acozine> #chair samccann
14:31:28 <zodbot> Current chairs: acozine samccann
14:31:55 * samccann sits in comfy chair
14:32:36 * gundalow waves
14:32:51 <gundalow> in another meeting, though ping if there is anything
14:32:55 <acozine> I might need a blanket today . . . it's below zero (Fahrenheit) where I am, with wind chills I don't want to think about
14:33:02 <acozine> gundalow: hi!
14:33:11 <acozine> you need to re-think your meeting schedule!
14:33:13 <samccann> omgosh!!! that is cooooold
14:33:50 <acozine> it's cold, yup, though we'll probably get worse before winter is over
14:34:01 <acozine> right now it's about minus 1 degree air temp
14:34:12 <acozine> and it can get a lot colder than that here
14:34:55 <samccann> brrr
14:35:04 <samccann> 54 here :-)
14:35:11 <acozine> toasty!
14:35:18 <gundalow> acozine: I'm 15/17 files reviewed on Docs: User guide overhaul, part 2 #65474
14:35:27 <acozine> gundalow: awesome!
14:35:55 <acozine> though depending on which files are numbers 16 and 17, you might still have a slog ahead of you
14:36:09 <acozine> for any lurkers, the PR is https://github.com/ansible/ansible/pull/65474
14:36:27 <samccann> a good slog though... found it a great improvement
14:36:31 <acozine> the diff is pretty hard to read, because i moved a lot of things around
14:37:18 <acozine> but you can look at the resulting pages (for now . . . the testing site changes often) at http://docs.testing.ansible.com/ansible/devel/user_guide/index.html
14:37:53 <samccann> #info User Guide overhaul PR https://github.com/ansible/ansible/pull/65474 comments welcome
14:37:57 <acozine> see especially http://docs.testing.ansible.com/ansible/devel/user_guide/playbooks_filters.html
14:38:34 <samccann> #link  http://docs.testing.ansible.com/ansible/devel/user_guide/playbooks_filters.html  (subject to change as its the test site and gets updated frequently)
14:38:50 <acozine> also note that it's only on the `devel` version
14:39:54 <acozine> #topic DaWGs schedule
14:40:12 <acozine> We will not meet for two weeks in December
14:40:27 <acozine> December 24 and December 31 meetings are both cancelled
14:40:52 <acozine> we will pick up again in the new year, on January 7, 2020
14:42:00 <samccann> anyone have docs new years resolutions??  :-)
14:42:56 <acozine> heh, we could make one about the number of open PRs, but then we'd break it instantly
14:43:03 <samccann> like close 20 docs issues in the new year?
14:43:26 <samccann> well that's the joy of new years resolutions - they are broken on average I think within the first week.  Still fun tho
14:43:29 <acozine> surely we could make it 24 . . .  two per month
14:43:46 <samccann> for each of us?
14:43:57 <acozine> okay, you're on
14:44:02 <samccann> HAHAHAH
14:44:12 <acozine> 24 issues each in 2020
14:44:16 * samccann pauses...might regret this...
14:44:20 <acozine> heh
14:44:43 <acozine> the drama!
14:44:53 <samccann> #agreed samccann and acozine and anyone else who wants to play along - made New Year resolution to close 24 docs issues each in 2020
14:44:55 <acozine> will she commit it to #agreed?
14:45:03 <samccann> there. it's official!
14:45:05 <acozine> she does, and the CROWD GOES WILD!
14:45:13 <samccann> wwwwooooooooo!!!
14:45:31 <acozine> (picture a muppet audience here, all yelling and clapping)
14:46:01 <samccann> and those two grumpy guys up in the balcony heckling "I'll believe it when I see it"
14:47:33 <acozine> there we go!
14:47:41 <acozine> well, shall we look at some PRs?
14:48:00 <acozine> #topic PR review
14:48:03 <acozine> https://github.com/ansible/ansible/pull/65654
14:48:22 <acozine> good catch
14:48:29 <acozine> merging now
14:49:32 <samccann> how about this one - https://github.com/ansible/ansible/pull/65533
14:50:00 <acozine> heh, I love `duplidates`
14:50:14 <samccann> simple, but is asking how to handle backports to pre-existing PRs for the original fix. Can the OP cherry-pick and update those two backports?
14:50:26 <samccann> or does that mess up some sorta tracking??
14:51:09 <samccann> duplidates - when you overcommit on your calendar between two people you are dating simultaneously... duplidates...
14:51:13 <acozine> I think I'd just go into the backport branches and fix the typo there
14:51:26 <samccann> ok I'll add that comment and merge
14:51:30 <acozine> cool
14:52:28 <acozine> https://github.com/ansible/ansible/pull/65626 is failing due to indentation errors
14:52:34 <acozine> but it affects the filters page
14:53:02 <acozine> I'm going to ask the person to hold off until the overhaul is done, since I'd rather not rebase the filters page again
14:53:25 <samccann> heh yep
14:53:43 <samccann> this one https://github.com/ansible/ansible/pull/65519
14:53:58 <keylemon> acozine: i had a thought about that test script. if adding a third condition is totally out of the question it would need to be redone in python using hashlib to avoid any os dependency. but that is way more work since all the ci and such would also need changed
14:54:24 <acozine> #chair keylemon
14:54:24 <zodbot> Current chairs: acozine keylemon samccann
14:54:30 <acozine> keylemon: welcome!
14:54:41 <keylemon> oh sorry didnt realize there was a meeting.
14:54:53 <keylemon> hello everyone
14:55:02 <samccann> no worries. It's mostly open for discussion now
14:55:02 * acozine waves
14:55:08 <samccann> and welcome!
14:55:29 <acozine> it's a small group today, so anything goes
14:55:48 <keylemon> oh ok, still sorry to have interrupted like i did.
14:56:12 <keylemon> was just thinking about that test script.
14:56:30 <acozine> sure, let us get the current PR sorted and we can all take a look
14:56:32 <keylemon> https://github.com/ansible/ansible/pull/65112 this one for anyone else around
14:56:54 <acozine> so 65519 looks good and fred-sun chimed in, so presumably it's accurate
14:56:58 <acozine> I'll merge it
14:57:01 <samccann> kewl
14:58:15 <acozine> okay . . . 65112
15:00:21 <acozine> nice work getting it to pass CI, by the way
15:00:26 <acozine> keylemon: ^^^
15:01:08 <keylemon> thanks it was, uh i forget who, during the last week meeting which was awesome.
15:01:40 <acozine> the Ansible community rocks!
15:02:26 <acozine> I'm not entirely sure how to read sdoran's comment
15:02:30 <keylemon> yeah. so the last thing is adding in a condition for the mac command, or rewriting it.
15:03:03 <keylemon> he doesnt seem to want another condition for some reason, its not clear. and a case statement wont actually work i think
15:03:10 <keylemon> but it might
15:04:13 <acozine> are you willing to try a case statement out? if it works, I think it would be worth the extra code
15:04:36 <acozine> because I just understood why I get those error messages on my mac and nobody else sees them
15:04:47 <acozine> (it's all about me, naturally)
15:05:03 <keylemon> i would be more comfortable with another if rather than case. given what i know about case i am not sure how to fit it in here. i am up for learning though
15:05:16 <keylemon> and it looks like shasum on mac defaults to sha1 which makes it easy
15:05:48 <acozine> it's not sha1 (at least, not on my version of macOS
15:05:53 <acozine> here's the output from my mac:
15:06:05 <keylemon> yay outdated docs on random google searches
15:06:08 <acozine> https://www.irccloud.com/pastebin/M9l2nTvB/
15:06:32 <sdoran> I just put an example `case` statement in the PR. An extra conditional would be fine too.
15:06:50 <acozine> sdoran: thought you were on PTO?
15:06:56 <sdoran> This is me on PTO :)
15:06:59 <acozine> heh
15:07:00 <samccann> heh
15:07:16 * sdoran slowly fades into the background
15:07:46 <keylemon> i can knock out a quick addition if statement if that is fine with everyone. thanks sdoran for adding the example but would require some logic to sort out what os as well. acozine would you be able to check `man shasum` on your mac to see if it labels the default please?
15:09:00 <acozine> default algorithm is `1`:  -a, --algorithm   1 (default), 224, 256, 384, 512, 512224, 512256
15:09:11 <keylemon> perfect!
15:09:44 <keylemon> i can knock this out in a quick moment
15:09:55 <acozine> oh, I see what you meant before - the mac defaults to sha1 for the algorithm, even though the command is different
15:10:08 <keylemon> yeah. i was thinking i would have to add an argument
15:11:04 <acozine> keylemon: when it's ready, I'll pull your PR and test locally
15:11:37 <keylemon> awesome thanks. thinking through it to get it right the first time, though iteration is good
15:13:16 <acozine> no hurry
15:13:26 <acozine> meanwhile . . . https://github.com/ansible/ansible/pull/65617
15:14:02 <acozine> looks like cbudz addressed jborean's comments
15:14:57 <cbudz> hi all i'm here just splitting time with other meetings
15:15:03 <samccann> there's a comment on the issue to have the original issue creator take a look. So was gonna wait to see if that happens before merging
15:15:30 <samccann> oh wait... wrong cbudz pr .. nvm :-)
15:16:04 <acozine> phew, I thought I was losing it
15:16:08 <acozine> okay, merging
15:16:58 <acozine> closed a PR, closed an issue . . .
15:17:07 <acozine> I mean, merged a PR, closed an issue
15:17:15 <acozine> progress!
15:17:28 <samccann> is this another one that will clash with the user guide overhaul - https://github.com/ansible/ansible/pull/65346/files
15:17:33 <samccann> (or possibly fixed by it?)
15:19:37 <acozine> oh, well spotted
15:19:51 <acozine> let me check the user guide pages
15:20:01 <acozine> the overhaul PR may not touch that page
15:21:05 <acozine> we're good to merge 65346
15:21:07 <cbudz> i added one more PR a few days ago, but t didn't tag acozine
15:21:08 <cbudz> https://github.com/ansible/ansible/pull/65569
15:21:21 <acozine> the overhaul PR doesn't touch the `playboooks_reuse_roles` page
15:21:23 <cbudz> belay that, it idid
15:21:49 <acozine> cbudz: I haven't been paying much attention to GitHub pings lately
15:22:05 <samccann> ok THAT'S the one where there is a comment on the original issue so figured we'd wait a few days to see if they review the PR.
15:22:42 <samccann> https://github.com/ansible/ansible/issues/64643#issuecomment-563882359
15:23:31 <acozine> ah, gotcha
15:26:40 <acozine> cbudz: I think in a paragraph/section that small, I wouldn't add text in a `Note`, I would add it to the existing text.
15:26:47 <acozine> Something like, "Yes. ``vmware_guest`` can deploy a virtual machine with required settings on a standalone ESXi server. However, you must have a paid license to deploy virtual machines this way. If you are using the free version, the API is read-only."
15:27:29 <cbudz> Gotcha. I'll make that change this morning
15:28:22 <keylemon> acozine: new commit added and ci completed successfully. fixed up the logic a bit more as well
15:29:04 <acozine> 65346 had stale CI, I've marked it `rebuild_merge`
15:29:13 <acozine> keylemon: awesome
15:30:02 <samccann> possibly one last one - https://github.com/ansible/ansible/pull/65294
15:30:12 <samccann> looks like it addressed your suggestions and is ready to merge?
15:32:03 <acozine> yep, looks good, merging
15:32:54 <acozine> oops, we're over time
15:33:07 <samccann> good run of PR reviews!
15:34:09 <acozine> keylemon: merged
15:34:16 <acozine> thanks again for the improvement
15:34:32 <keylemon> thanks.
15:34:40 <keylemon> it ran ok on your mac?
15:34:43 <acozine> thanks samccann keylemon cbudz sdoran gundalow
15:35:38 <acozine> keylemon: it's running now, but I trust our CI system
15:36:00 <acozine> my hope is it will eliminate the errors on my mac too
15:36:23 <acozine> #info next week's meeting will be the last meeting of 2019
15:36:43 <acozine> thanks again, folks!
15:36:47 <acozine> #endmeeting