16:03:15 #startmeeting F21-blocker-review 16:03:15 Meeting started Mon Dec 1 16:03:15 2014 UTC. The chair is adamw. Information about MeetBot at http://wiki.debian.org/MeetBot. 16:03:15 Useful Commands: #action #agreed #halp #info #idea #link #topic. 16:03:20 #meetingname F21-blocker-review 16:03:20 The meeting name has been set to 'f21-blocker-review' 16:03:26 #topic Roll Call 16:03:27 * pschindl is here 16:03:29 morning everyone. 16:03:38 * roshi is here 16:03:39 * satellit listening 16:03:40 Good afternoon :) 16:03:47 who's around to review some blocker bugs? 16:03:47 * jreznik is here, the weather outside is that bad, blocker review meeting sound like warm and nice place to be 16:03:57 I'm here 16:04:28 * smccann is here 16:04:47 * kparal trying to convince anaconda devs to come and join us ;) 16:05:23 I'll try to help today. 16:05:25 ok, quick openstack P2P meeting just ended 16:05:47 P2P = someone standing at my desk asking for direction 16:06:20 jreznik: inorite? i nearly froze to death just opening my apartment door yesterday...and it only opens into a corridor 16:06:37 it's a baulmy 23F here. ;) 16:06:39 #chair tflink nirik sgallagh 16:06:39 Current chairs: adamw nirik sgallagh tflink 16:06:59 * adamw tries to remember how this thing works 16:07:00 adamw: all public transport collapsed today in Brno :) 16:07:11 I heard that happens in Canada. and polar bears, in your corridor, too 16:07:44 or maybe it was a comics 16:07:49 kparal: those deadbeats just won't stop hanging around, begging for seals 16:08:01 It's an oddball 57F in Westford today. 16:08:04 was 68F when I left this morning. it's currently 49F at my house, but the cold front isn't here in town yet where it's 65F. 16:08:08 but I know, with our sligtly bellow zero, we feel like the whole world is going to freeze... central europeans :) 16:08:10 Compared to 22F yesterday... 16:08:21 #topic The weather 16:08:40 20F now, 65F yesterday 16:08:42 go figure 16:08:55 yup. and I still don't have any firewood. 16:09:24 #info in weather news, it is cold enough in Brno that people enjoy being at a blocker meeting as long as it's inside, polar-bear-in-corridor cold in Canada, an 'oddball' 57F (whatever those weird made-up American numbers mean) in Westford, and 20F in whichever bit of the middle of America it is Roshi lives in 16:10:01 #info and 49F for danofsatx, which is what people in Texas think is cold. 16:10:17 #topic Introduction 16:10:17 Why are we here? 16:10:17 #info Our purpose in this meeting is to review proposed blocker and nice-to-have bugs and decide whether to accept them, and to monitor the progress of fixing existing accepted blocker and nice-to-have bugs. 16:10:17 #info We'll be following the process outlined at: 16:10:17 #link https://fedoraproject.org/wiki/QA:SOP_Blocker_Bug_Meeting 16:10:19 #info The bugs up for review today are available at: 16:10:21 #link http://qa.fedoraproject.org/blockerbugs/current 16:10:23 #info The criteria for release blocking bugs can be found at: 16:10:23 * danofsatx-work spent yesterday putting up Christmas decorations in shorts and a t-shirt 16:10:25 #link https://fedoraproject.org/wiki/Fedora_21_Alpha_Release_Criteria 16:10:29 #link https://fedoraproject.org/wiki/Fedora_21_Beta_Release_Criteria 16:10:31 #link https://fedoraproject.org/wiki/Fedora_21_Final_Release_Criteria 16:11:24 /me would like to state for the record that I'm going to oppose any new FEs at this point. I want RC2 to be Final, please. 16:11:43 sgallagh: does that including the branding bug? 16:11:47 *include 16:11:50 kparal: I think that's probably a blocker 16:11:53 nope 16:12:04 at least I didn't mark it as such 16:12:08 let's decide that when we get there :P 16:12:08 It's a significant impact to usability. 16:12:14 I agree 16:12:24 (And an extremely low-risk fix) 16:12:26 but could be that one FE accepted, even if not blocker 16:12:29 but hey, worse bugs were rejected as blockers before, so I no longer try :P 16:12:33 #info 4 Proposed Blockers 16:12:34 #info 5 Accepted Blockers 16:12:34 #info 7 Proposed Freeze Exceptions 16:12:34 #info 17 Accepted Freeze Exceptions 16:12:50 sgallagh: don't use that words - low risky :D 16:13:03 putting in branding was low risky 16:13:13 * satellit workstation and server had branded anaconda left screens for me 16:13:15 kparal: No, it wasn't. But let's move on 16:13:16 actually i don't think anyone said it was, they just decided we were going to do it anyway 16:13:30 satellit: it's not that the branding doesn't work, it's that it works...TOO WELL 16:13:34 but we'll get there. settle down, folks. 16:13:34 #topic (1169019) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 11: ordinal not in range(128) 16:13:34 #link https://bugzilla.redhat.com/show_bug.cgi?id=1169019 16:13:34 #info Proposed Blocker, anaconda, MODIFIED 16:13:47 +1 blocker. 16:14:32 yeah, these ones are fairly straightforward 16:14:44 I'm not too happy about the fix, because LANG can have potentially different syntax than LC*, but hopefully it won't break anything else, like spins or something 16:14:49 +1 to blocker, sure 16:14:56 +1 16:15:01 i didn't go through running every language and exhaustively documenting where it crashes, but it seems reasonable to take the two bugs I filed as meaning 'crashes all over the damn shop in non-English' 16:15:01 +1 16:15:13 +1 blocker 16:15:18 +1 blocker, /me will never understand how python works with locales/encoding blabla 16:15:27 Though I agree; the fix doesn't make me happy 16:15:52 so this is purely a spins-kickstart fix? or that + anaconda? 16:16:05 it's in liveinst, thus anaconda 16:16:21 I don't think the fix involves anything else, we can ask 16:16:31 ok 16:17:05 * kparal asking 16:17:25 kparal: no, that's all that is needed 16:17:29 (liveinst patch) 16:17:32 ok, cool. 16:17:34 proposed #agreed - 1169019 - accepted blocker - any language with translated size units is likely to crash all over the place in live installs, this violates any 'successful installation' criterion 16:17:39 ack 16:17:42 ack 16:17:44 ack 16:17:45 ack 16:17:55 ack 16:18:06 #agreed - 1169019 - AcceptedBlocker - any language with translated size units is likely to crash all over the place in live installs, this violates any 'successful installation' criterion 16:18:17 #agreed - 1169019 - AcceptedBlocker - any language with translated size units is likely to crash all over the place in live installs, this violates any 'successful installation' criterion 16:18:37 oh, roshi are you secretarializing? 16:19:29 yep 16:21:10 #info roshi will secretarialize 16:21:17 #topic (1169023) Many translations missing from anaconda 21.48.18 and 21.48.19 16:21:17 #link https://bugzilla.redhat.com/show_bug.cgi?id=1169023 16:21:17 #info Proposed Blocker, anaconda, MODIFIED 16:21:35 +1 blocker 16:21:57 +1 16:22:02 +1 16:22:11 +1 16:22:41 +1 blocker, affects many translations even translations that should be complete 16:22:45 +1 16:22:52 +1 blocker 16:22:57 proposed #agreed - 1169023 - AcceptedBlocker - this is a clear violation of the criterion requiring translations be present 16:23:03 ack 16:23:05 ack 16:23:09 ack 16:23:13 ack 16:23:16 ack 16:24:08 ack 16:24:12 ack 16:24:20 #agreed - 1169023 - AcceptedBlocker - this is a clear violation of the criterion requiring translations be present 16:24:53 #topic (1167965) logvol swap --recommended fails 16:24:53 #link https://bugzilla.redhat.com/show_bug.cgi?id=1167965 16:24:53 #info Proposed Blocker, python-blivet, VERIFIED 16:25:08 this one was accepted as an FE and fixed in RC1, I think, so discussing it becomes a bit academic 16:25:29 yeah... 16:25:41 just move it to an accepted fe and go on? 16:25:46 nirik: +1 16:26:03 works for me 16:26:11 ie, drop blocker since it's kinda moot. 16:26:43 will 16:26:46 will do 16:27:19 #agreed this was fixed and the fix tested in RC1, so we decided to drop it from blocker consideration as the question is mostly moot 16:27:32 #topic (1168748) Need final Fedora 21 build of spin-kickstarts 16:27:32 #link https://bugzilla.redhat.com/show_bug.cgi?id=1168748 16:27:32 #info Proposed Blocker, spin-kickstarts, ON_QA 16:27:50 this is kinda waiting on if we do a rc2 or not. 16:28:00 which, after the above 2 blocker adds, we are. 16:29:32 so, I would say spin what we have currently and submit update... unless there's any FE's that need spins-kickstarts changes. 16:29:56 well, it's a blocker by policy 16:30:15 right. so, yeah, +1 blocker definitely. 16:30:37 * nirik sees no fe's off hand that need any spin-kickstarts changes. 16:30:41 * handsome_pirate stumbles in 16:30:41 * danofsatx-work was away....damn users again 16:31:00 * handsome_pirate doesn't know how productive he'll be 16:31:07 * handsome_pirate just put away a bottle of rum. 16:31:18 +1 16:31:24 This looks like a +1 blocker by the numbers 16:31:28 +1 on this blocker 16:31:43 +1 16:32:59 handsome_pirate: well, get it out again. ;) 16:33:30 ... and share 16:33:36 proposed #agreed - 1168748 - this is a clear blocker under the criterion requiring a spin-kickstarts build that matches the release, but note it does not block image compose, as the package does not appear on the images. 16:33:45 Ew 16:34:00 ack 16:34:04 ack 16:34:06 ack 16:34:28 #agreed - 1168748 - this is a clear blocker under the criterion requiring a spin-kickstarts build that matches the release, but note it does not block image compose, as the package does not appear on the images. 16:35:00 ack (late) 16:35:11 ok, that's all the blockers, let's move on to proposed FEs 16:35:12 sgallagh, prime your -1 bot now... 16:35:14 #topic (1167658) custom partitioning: after you press Done for the first time, Reset All stops working 16:35:15 #link https://bugzilla.redhat.com/show_bug.cgi?id=1167658 16:35:15 #info Proposed Freeze Exceptions, anaconda, NEW 16:35:18 -1 16:35:26 -1 16:35:38 no on that one from everyone on the anaconda team 16:35:59 yeah, it kinda sucks but getting too late to play with it 16:36:07 there's no clear fix, it's a corner case, document and reject. ;) 16:36:07 sbueno: note we're voting FE not blocker now 16:36:17 adamw, yeah i know 16:36:22 the workaround for documentation is fairly clear - 'sorry, you lost all your lives, reboot and start over' 16:36:24 -1 16:36:38 /me plays the Mario death-sound 16:36:45 -1 16:36:56 Would be nice to have a fix, but ... 16:36:57 since there's no patch, maybe there's no sense in discuss it at all 16:37:03 yep 16:37:04 *discussing 16:37:05 -1 16:37:13 proposed #agreed - 1167658 - RejectedFreezeException - this is obviously a bit annoying, but it's too late for speculative FEs now, anaconda team doesn't have a clear fix for it, and it is workaroundable 16:37:16 Yeah, can we just auto-ignore any that aren't already in POST/MODIFIED? 16:37:24 ack 16:37:25 ack 16:37:32 ack 16:37:41 sgallagh: I think that makes sense 16:37:46 adamw: ack 16:37:47 ack 16:38:02 ack 16:38:15 sgallagh: sgtm 16:38:23 ack 16:38:31 #agreed - 1167658 - RejectedFreezeException - this is obviously a bit annoying, but it's too late for speculative FEs now, anaconda team doesn't have a clear fix for it, and it is workaroundable 16:38:44 well, sometimes the statuses are lies, but I can skip any we don't have fixes lined up for if you like 16:39:09 adamw: You and your "saying what I meant instead of what I said" 16:39:09 it doesn't take long to reject... but whatever works. 16:39:23 #info we will vote only on FEs that look like there's some kind of fix waiting to go, given the point we're at in the c ycle 16:39:37 I'd hate to miss something important, but hopefully we won't since they are just fe's 16:39:37 #topic (1168118) Custom UEFI layout with /boot/efi on second disk fails: is_valid_stage1_device not called on disks after the first 16:39:38 #link https://bugzilla.redhat.com/show_bug.cgi?id=1168118 16:39:38 #info Proposed Freeze Exceptions, anaconda, MODIFIED 16:39:53 so you might all want to start out by assuming -1 on this one, since i wrote the fix for it ;) 16:39:55 * kparal just asked vpodzime about this, I think he worked on it based on adamw patch 16:39:59 but srsly! 16:40:24 kparal: a fix for that is applied to anaconda-21.48.19-1, but adamw posted some improvements for it 16:40:27 kparal: my initial proposed fix is in 21.19, i have a somewhat-improved version in review now which i'd kinda prefer to go in 21.20 16:40:29 tl;dr: What's the impact, in brief? 16:40:40 so the scenario is this 16:40:47 you boot a UEFI install with two disks 16:40:54 you go to custom partitioning, and put /boot/efi on the second disk 16:41:03 anaconda complains your layout is invalid because it doesn't have a /boot/efi 16:41:46 you can work around it by going into the 'Full disk summary and bootloader' screen and selecting the second disk as the boot disk, but only *after* you create the /boot/efi partition (at least in my testing), and none of the errors you get indicate the problem 16:41:51 so, what do the improvements get us? and are they very invasive? 16:42:07 adamw: That sounds to me like a relatively sane Common Bugs entry. 16:42:11 * kparal invited vpodzime to join us 16:42:26 sgallagh: the thing that worries me is the initial condition is very confusing and you might not get to common bugs for it' 16:42:32 and the fix _is_ relatively low impact, i think 16:42:44 * handsome_pirate is thinking +1 for this one 16:42:48 +1 16:42:55 dlehman: do you have an idea how risky this patch is? 16:43:12 I'm sticking with -1 so far, unless someone from anaconda says on the record "there's no way this will break anything else" 16:43:21 nirik: with (either) fix, if you're installing to a platform that uses a partition as /boot, and you don't explicitly specify a boot disk, and there's a valid stage1 target partition on any selected disk, anaconda will use that instead of going into an error state 16:43:30 vpodzime: hey 16:43:30 kparal: done 16:43:34 * dlehman hasn't been following along, has to catch up 16:43:40 -1 FE, +1 Common Bugz 16:43:41 vpodzime: could you tell us how risky this patch can be? 16:44:01 do you think it's reasonable to add it to RC2? 16:44:20 which anaconda was in rc1 again? 16:44:22 * nirik looks 16:44:24 the original patch adamw posted seems to be safe 16:44:24 Noting that some of us are highly-resistant to any risk at all at this point. 16:44:28 i could see a very unlikely corner case where the first version of the patch might possibly have caused a crash, but the second version i think is pretty safe. 16:44:35 adamw: so it defaults to same disk as /boot instead of first disk? 16:44:36 (even the corner case for the first one was pretty absurd.) 16:44:44 dlehman: it's not about /boot , /boot is stage2 target 16:45:05 dlehman: it's about /boot/efi on UEFI , primarily 16:45:16 also fixes /boot/uboot on omapARM (not that i can test that) and prepboot on PPC64 (I tested that...took all afternoon in a vm) 16:45:23 so it's about stage1 devices that are partitions 16:45:26 yeah 16:45:38 and it picks the disk containing a potential stage1 instead of the first disk? 16:45:46 exactly 16:45:53 the first disk in the existing order that looks like it contains a valid stage1 target partition, if there is one 16:46:04 as long as the user hasn't explicitly nominated a boot disk 16:46:23 so people who have multiple installs or otherwise want to preserve their existing stage1 will have to pay attention? 16:46:49 well, i'm not sure it necessarily makes things worse there 16:47:19 say you have a /boot/efi on disk1 and you create a new one on disk2, in the current case we'd use the one on disk1... 16:47:33 well, in my case we would too, actually 16:47:37 it's a rather icky area honestly 16:48:36 dlehman: for the mounted partition case, actually, i think no, there's no possible 'have to pay attention; 16:48:37 sounds like it 16:48:41 so, the first cut of this was in -19? which we need for other things already anyhow? 16:48:52 because if they didn't want to use that partition as the stage1 target they wouldn't set it as the mount point, would theey? 16:49:00 the statement "it's a rather icky area honestly" does not incline me towards changing from a -1/Common Bugs vote... 16:49:08 when you say 'this partition is /boot/efi' what you are *doing* is selecting it as the stage1 target device 16:49:15 that's the only reasonable understanding of that action 16:49:19 hrm 16:49:39 if this bug existed in f20 I think that it's a bit late to be proposing it as a blocker for f21 now 16:49:46 I thought about the use cases described here and didn't come up with any potential issue 16:49:47 I'll default to what the anaconda guys think for this one 16:49:57 for my vote anyways 16:50:01 s/blocker/freeze exception/ ;) 16:50:03 it's slightly more questionable for the prepboot-type case (where the stage1 target is a non-mounted partition) but even there i think it's sane behaviour, we already pick a default if you don't explicitly pick a disk, we're just picking a better default 16:50:05 dlehman: Not a blocker 16:50:06 FE 16:50:08 dlehman: it's proposed as an FE 16:50:30 the question is whether to include it in RC2 or not 16:50:55 i do honestly think it's worth fixing the UEFI case 16:51:05 I agree with adamw here 16:51:11 this bug could be a reasonable explanation for several times we've seen people have trouble with UEFI installs and gone 'well huh, that shouldn't be happening' 16:51:53 I'll defer to those who have been working on it for a while. My head is nowhere near bootloaders and I can't seem to steer it that way. 16:51:55 i don't think it makes much sense to expect people to understand they have to select a 'boot disk' for the UEFI case, when we've been carefully explaining that the thing they need is a /boot/efi partition 16:51:56 but, hey. 16:52:22 the point of selecting a boot disk is to tell us where to put the stage1 device 16:52:31 adamw: I don't disagree that it's bad behavior. I just haven't heard convincingly that the fix won't cause other issues. 16:52:42 dlehman: the thing is it's an odd concept when the stage1 target is a partition, it just doesn't map well 16:52:43 And at this point, in that situation, I'd rather defer it. 16:53:06 adamw: it maps better than any other platform-agnostic model I've seen. 16:53:06 sgallagh: i'm really pretty confident in saying it won't cause anything that would make someone unhappy in the UEFI case. 16:53:13 sgallagh: it makes no change on platforms that have no special stage1 devices 16:53:21 dlehman: oh sure, it's just that being platform agnostic is inherently weird with bootloaders 16:53:23 sgallagh: well, it's still monday... 16:53:31 ;) 16:53:40 kparal: Do you *want* to be in hero-testing mode? 16:53:57 so for the record here's precisely what the change affects: 16:53:58 I guess I'm +0.5... 16:54:01 there's so little I wouldn't do for our users... 16:54:07 on BIOS it's effectively a no-op 16:54:10 same here 16:54:16 adamw: As I said, if someone from anaconda is willing to say "I doubt this will cause any new issues", I'll vote +1 16:54:24 on UEFI it is in effect but like I said I'm really pretty sure it's a good change 16:54:27 If no one is comfortable making that statement, I don't want to include it 16:54:32 I doubt this will cause any new issues 16:54:43 OK, then. 16:54:44 there you go! :) 16:55:05 I'm satisfied with that. +1 FE 16:56:01 +1 16:56:12 +1 16:56:13 * danofsatx-work is still -1 16:56:14 vpodzime convinced me, +1 16:56:22 adamw: how much tested is the new version of your fix? 16:56:22 +0.5 16:56:52 +1 16:57:00 kparal: i tested it in quite a few scenarios (the affected one, guided, custom-auto, with both two and only one disk) on UEFI, did a sanity test on BIOS, and tested the affected scenario on PPC64 16:57:01 the reporter tested it and found it fixed the issue 16:57:20 the initial reporter tested that it fixed his issue on Mac (his first test would've been with v1 of the patch, his most recent test with v2) 16:58:02 anyhow, sounds like we are mostly FE+ ? 16:58:14 aside from danofsatx-work. :) 16:58:18 Well, danofsatx-work appears to still be unconvinced. 16:58:24 * danofsatx-work always was a rebel 16:58:25 that guy needs more rum 16:58:26 I think we usually strive for consensus? 16:58:31 sgallagh: well, we try and get close. 16:58:38 what can i do to consense you, dan? 16:58:39 I'm amused by your optimism. 16:58:42 * adamw mails rum 16:59:48 It just doesn't feel right. Accept it as +∞/-1 and move on 17:00:17 adamw: I drank it ll! 17:00:34 #info anyone who wants to buy rum, don't bother going to look. handsome_pirate drank it all. 17:01:29 proposed #agreed 1168118 - AcceptedFreezeException - people are understandably worried about tweaking this at this point, but the affected case is clearly bad behaviour and would be good to improve, and there's a reasonable consensus the patch is unlikely to cause bugs or unexpected behaviour changes. 17:01:43 ack 17:01:48 abstain 17:01:49 ack 17:01:56 ack 17:01:58 (aside from your spelling of "behavior" ;-) ) 17:02:05 ack 17:02:19 you can still ack/nack danofsatx-work - you're just acking the wording and that it made sense as a sentence :p 17:02:42 sgallagh: Agreed, adamw is using that weird non-Murican spelling 17:02:44 I know 17:02:56 'cause 'Murica! 17:03:04 #agreed 1168118 - AcceptedFreezeException - people are understandably worried about tweaking this at this point, but the affected case is clearly bad behaviour and would be good to improve, and there's a reasonable consensus the patch is unlikely to cause bugs or unexpected behaviour changes. 17:03:14 goddamn it you'll take the Queen's spelling and you'll like it 17:03:29 #topic (1168717) Missing python-lxml BuildRequires 17:03:29 #link https://bugzilla.redhat.com/show_bug.cgi?id=1168717 17:03:29 #info Proposed Freeze Exceptions, anaconda, POST 17:03:42 this one seemed a bit odd 17:03:54 vpodzime: dlehman: do you know about it? does it affect any actual package builds? 17:04:09 * handsome_pirate wonders why it wouldn't make builds fail. 17:04:28 also the 'steps to reproduce' 17:04:43 package BuildRequires: aren't about people running 'make' in checked out git repositories... 17:04:53 -1 FE 17:05:04 -1 17:05:21 * adamw would like to understand the bug before -1ing it, but clearly tends to -1 17:05:34 it's needed for the anaconda help files 17:05:49 sbueno: "this target is not run in the build system" 17:06:33 That strongly implies that this change doesn't have any effect on the built RPMs (at least in a way that couldn't be solved post-release) 17:06:36 Do you disagree? 17:06:50 is this why clicking Help in anaconda never works? 17:07:12 it would if we could generate the help content files ;) 17:07:27 there's a help button in Anaconda? 17:07:29 sbueno: Are they generated at *runtime*? 17:07:31 haha 17:07:33 yeah, top right 17:07:41 sgallagh, no 17:07:55 but if it works, then we have to *test* it 17:07:57 * roshi ducks 17:08:07 roshi: +1!!! 17:08:56 * handsome_pirate wonders how we can cover making anaconda work in the future? 17:09:20 I'd lean more +1 if it made the help button work 17:09:31 so it does kind of suck that every time you click Help in anaconda you just get that placeholder 17:09:33 doesn't look great 17:09:40 yeah 17:09:42 this one just blows up during tarball generation 17:09:51 if you don't have python-lxml installed 17:09:51 but i'd be a bit worried about the scenario where we 'fix' it and it turns out some content in the actual help pages crashes the renderer, or something silly like that 17:09:52 that's it 17:10:13 mkolman: right, but then that means we have to use tarballs without the real help files, so we get anaconda package builds without help...right? 17:10:21 or is there more to that story? 17:10:22 and the help button should already work just fine BTW 17:10:24 I clicked on help when doing a live install last weekend and it seemed to work (at least when the network was set up). 17:10:28 oh, k. 17:10:30 nope 17:10:44 maybe i'm just unlucky with the screens I click it on 17:10:49 Welcome and hub both give the placeholder 17:11:00 RC1 ? 17:11:08 that should not happen 17:11:09 yeah 17:11:16 keyboard, network, they're all placeholding 17:11:16 I believe I was on one of the storage related screens. 17:11:21 but if this bug doesn't fix that, anyway, i'm -1 17:11:30 I checked with I think TC2 or TC4 17:11:40 * handsome_pirate isn't getting anything but placeholders 17:11:40 and every screen had help 17:11:46 * handsome_pirate is testing with RC1 17:11:51 just spun up a vm 17:11:57 could be another booboo in vpodzime's build? 17:12:03 Yeah, I see the placeholder on all screens on a Workstation Live 17:12:12 handsome_pirate: can you check the contents of /usr/share/anaconda/help/en-US/ ? 17:12:16 So, if this fixes that, I'm +1. This is something we really ought to fix. 17:12:24 mkolman: One sec 17:12:29 handsome_pirate: I think we already covered above that it doesn't address that 17:12:43 memo to self: don't ever do an anaconda tarball build without lots of help 17:12:45 adamw: nope, I pulled-in and built the help files 17:12:48 sgallagh: Sorry, was spinning up a vm to test and not reading :) 17:13:14 so anyway, what's the actual benefit of fixing *this* FE bug? 17:13:15 mkolman: Nothing there; server netinst image 17:13:18 /me remains -1 at this point. 17:13:21 if it doesn't fix something significant in the images, i'm -1 17:13:35 * danofsatx-work just realized he doesn't have RC1 builds here. 17:13:59 mkolman: vpodzime: handsome_pirate: let's discuss the missing-help in #anaconda for now, we can propose a blocker/FE for discussion later in the meeting if appropriate 17:14:03 handsome_pirate: there must be at least the placeholders 17:14:42 -1 17:15:00 -1 17:15:35 adamw: okay, so the help contents are only in the 19 build 17:15:46 proposed #agreed 1168717 - RejectedFreezeException - we're still not entirely clear on what this bug is for, but it seems fairly clear that fixing it won't magically make the release images better, so rejected. 17:15:47 (thus not in RC1) 17:16:13 ack 17:16:16 ack 17:16:24 ack 17:16:28 ack 17:16:32 mkolman: Aye, placeholders are there, but that's it 17:16:47 ack 17:17:08 #agreed 1168717 - RejectedFreezeException - we're still not entirely clear on what this bug is for, but it seems fairly clear that fixing it won't magically make the release images better, so rejected. 17:17:25 for the record, looks like the help texts are missing from RC1 due to a tarball generation mistake, should be fixed for RC2 17:17:36 #topic (1169332) Widget colors in anaconda totally changed in RC1, some widgets hardly visible 17:17:37 #link https://bugzilla.redhat.com/show_bug.cgi?id=1169332 17:17:37 #info Proposed Freeze Exceptions, fedora-productimg-workstation, ASSIGNED 17:17:44 hey, time for the fun one ;) 17:17:57 ok 17:18:07 I'll strongly advice to use a build that has the help content in place 17:18:12 Short version: the productimg packages added a few lines of CSS to position the logos 17:18:32 The expectation was that these would be merged with the existing CSS, but instead they were replacing it 17:18:47 I have packaged up a workaround for this that copies in the original CSS as well 17:18:48 In my case I clicked on the word help, which might be different than what you guys are talking out. I had a browser point to some generic anaconda help links that didn't end up answering the questions I had. 17:19:05 +1 here 17:19:17 I think custom part is most problematic 17:19:20 The risk is extremely low, as all it's doing is putting something back that should have remained there 17:19:24 Is this only workstation? 17:19:29 or all? 17:19:30 nirik: all products 17:19:30 nirik: No, it's all 17:19:37 * danofsatx-work will take sgallagh's recommendation on this one 17:19:38 ok. +1 reluctantly. 17:19:50 +1 17:19:55 Yeah, I don't love it either, but it's fix this or drop the branding 17:20:01 for usability issues +1 but not happy about it 17:20:02 +1 17:20:04 +1 for this, the combination of the effects is pretty bad 17:20:05 And I think the latter is more likely to break crap at this point than fixing it 17:20:18 +1 17:20:19 +1 17:20:24 if it makes anyone happier, think about the fact that we've been testing the *other* css all the way through release validation 17:20:33 if we don't +1 this, we'd be signing off on releasing some code we'd barely tested 17:20:41 the change here is to return the stuff we've been testing all along 17:20:55 adamw: almost 17:21:18 the only slight difference is the logo positioning 17:21:32 But I would categorize that as "barely registering" on the risk scale 17:22:16 well, if we don't accept this fe we still get the logo positioning change, right? we just lose all the other bits that have previously been included. anyhow, we have the votes 17:22:31 adamw: Yeah, that's a correct statement 17:23:04 proposed #agreed 1169332 - AcceptedFreezeException - the combination of broken elements here leads to a significantly degraded user experience, and is a clear regression from all previous tested composes 17:23:08 ack 17:23:10 ack 17:23:18 ack 17:23:42 ack 17:24:00 #agreed 1169332 - AcceptedFreezeException - the combination of broken elements here leads to a significantly degraded user experience, and is a clear regression from all previous tested composes 17:24:09 #topic (1166607) hawtjni: Spit runtime into subpackage 17:24:09 #link https://bugzilla.redhat.com/show_bug.cgi?id=1166607 17:24:09 #info Proposed Freeze Exceptions, hawtjni, ON_QA 17:24:28 adamw: That will need a compose override since we can't *realistically* test it (beyond hacking it into a live_ 17:24:36 (Still discussing the previous one) 17:24:45 sgallagh: sure, no problems. 17:25:10 ok, I had this one proposed, but I investigated it and the gains are not worth it. 17:25:13 -1 FE 17:25:17 so, -1 sure. 17:25:20 -1 17:25:34 * handsome_pirate wonders why this is a thing 17:25:37 -1 17:25:42 -1 17:25:56 -1 17:26:13 handsome_pirate: It's part of the long depchain for FreeIPA 17:26:34 The hope was that it would cut down some of the deps and reduce the image size. 17:26:37 proposed #agreed 1166607 - RejectedFreezeException - the benefits from this are not worth the risk of taking it at this point 17:26:41 ack 17:26:42 It only ended up saving a couple dozen megs 17:26:46 ack 17:26:54 ack 17:26:54 ack 17:27:00 ack 17:27:04 ack 17:27:14 aCK 17:27:31 #agreed 1166607 - RejectedFreezeException - the benefits from this are not worth the risk of taking it at this point 17:27:44 #topic (1150384) unicode_start is not started on boot 17:27:44 #link https://bugzilla.redhat.com/show_bug.cgi?id=1150384 17:27:44 #info Proposed Freeze Exceptions, systemd, ON_QA 17:27:56 wish someone had caught this earlier... 17:28:18 it seems a bit late to start fiddling, but otoh it sounds like kind of a bad bug 17:28:19 hmm, I have reported this years ago 17:28:21 * satellit missed new 1169440? 17:28:22 anyone have any more details? 17:28:31 satellit: we're not done yet 17:28:35 kparal: Was it fixed and regressed? 17:28:43 I don't think so 17:28:48 it was probably not fixed 17:28:49 * nirik voted in bug 17:28:52 If not, it's a continuing bug and I'm -1 to blocking on it here 17:29:11 Sorry, not a blocker, but you get my point 17:29:46 I'm wary of including any new systemd build at this point, since we never know what else is coming with it 17:30:20 -1 17:30:20 as a non-english user, I'm not happy about this. but including new systemd right now is risky 17:30:34 and there is an easy workaround 17:30:37 -1 17:30:46 so I guess -1 is more appropriate now 17:31:06 One moment 17:31:13 and it's true it has been broken in the past 17:31:28 OK, so I just looked into the systemd tree 17:31:35 216-12 only has a fix for this. 17:31:37 It *is* just this one patch that is going into -12 17:31:40 correct 17:31:48 And RC1 had -11 17:31:58 Does that change anyone's opinion? 17:32:09 (I'm moving from -1 to +/- 0) 17:32:45 sgallagh: can you link the patch? 17:32:59 one moment 17:33:04 * nirik is +1 still. 17:33:42 http://paste.fedoraproject.org/155540/45518714 17:33:52 (I can't remember the dist-git cgit address offhand...) 17:34:19 Looks like it adds a single action: reset vconsole state when changing console drivers 17:35:20 /me doesn't feel qualified to decide if this is dangerous or not 17:35:36 me neither 17:35:45 but it doesn't look that bad 17:36:27 kparal: Famous last words ;-) 17:36:41 what could possibly go wrong 17:36:46 * adamw really hates both choices here 17:37:07 Well, *it couldn't get any worse*. 17:37:41 /me tries to find halfline. 17:39:45 what's karma on -12 look like? 17:40:18 adamw: It's at +1 17:40:25 Only karma is from the reporter of the bug we're discussing 17:41:06 I'm going to move to a +0.5 on the grounds that it will be really easy to revert and respin if it turns out to cause problems. 17:41:16 true 17:41:23 (unlike many other systemd updates which carry lots of changes) 17:41:45 so long as it doesn't go to stable we don't need to do anything to the package, just respin RC3 without the package in bleed. anyhow 17:41:48 I think the benefit is worth the risk 17:42:18 yeah, unicode support really *should* be there w/o needing a workaround 17:42:38 keyword = should 17:42:56 well, I'm not in a position to say "must" :p 17:43:09 roshi: anyone can *say* it. 17:43:18 haha 17:43:24 fair enough 17:43:29 ok, fiiiine, reluctant +1 17:43:42 I'm OK with it 17:44:14 +1 17:44:24 -|- 1 17:44:37 danofsatx-work: EPARSE 17:44:52 I'd really like to see this fixed as I believe it has been broken since systemd came to Fedora 17:44:53 hmmm....that was s'posta be an iffy + 17:45:01 sgallagh: I think that's a +1 while riding a segway 17:45:15 /me snorts 17:45:34 Anyone want to come out against it? 17:46:08 not me 17:46:11 proposed #agreed 1150384 - AcceptedFreezeException - we're obviously reluctant to touch systemd this late, but the change is very limited and the bug seems fairly bad for many non-US users (and even some US users who speak those furrin languages). 17:46:23 ack 17:46:27 ack 17:46:51 ack 17:46:53 ack 17:46:57 #agreed 1150384 - AcceptedFreezeException - we're obviously reluctant to touch systemd this late, but the change is very limited and the bug seems fairly bad for many non-US users (and even some US users who speak those furrin languages). 17:46:57 patch 17:47:01 never mind 17:47:07 oh, sorry 17:47:16 ack 17:47:17 i can #undo if it's important? 17:47:18 you already voted, sgallagh, too late 17:47:21 It's not. 17:47:25 rgr 17:47:26 #topic (1168404) velocity has a runtime dependency on junit 17:47:26 #link https://bugzilla.redhat.com/show_bug.cgi?id=1168404 17:47:26 #info Proposed Freeze Exceptions, velocity, ON_QA 17:47:46 Same as the hawtjni one. -1 FE 17:47:57 -1 17:47:57 Didn't have the impact we wanted and isn't important enough to risk 17:48:01 -1 17:48:17 -1 17:48:48 -1 17:49:55 proposed #agreed 1168404 - RejectedFreezeException - the benefit of this change is not worth the risk of taking it at this point. 17:50:05 ack 17:50:21 ack 17:51:04 ack 17:51:18 ack 17:52:34 #agreed 1168404 - RejectedFreezeException - the benefit of this change is not worth the risk of taking it at this point. 17:53:01 arewedone? 17:53:07 i believe someone had another one to add 17:53:19 satellit: ^^ 17:53:20 was that you? 17:53:23 oh, satellit 17:53:31 pretty sure it was him 17:53:41 https://bugzilla.redhat.com/show_bug.cgi?id=1150384 17:53:56 1169440 appeared 17:53:59 no it is on FE list if refresh 17:54:28 wait, satellit and satellit_e is not the same person? 17:54:42 o.O 17:54:47 -e is my workstation test PC 17:54:58 fedora has many satellites 17:55:00 so there is just one you! ok 17:55:01 is this possibly just related to the translations? or they are there but rendered wrong? 17:55:03 including the orbital laser death ray 17:55:10 adamw: Shhh, they're not supposed to know about those 17:55:12 rendering I think 17:55:35 only in liveinst in SoaS does it occur 17:55:35 #topic (1169440) SoaS anaconda is missing font does not display some language samples on first screen 17:55:36 #link https://bugzilla.redhat.com/show_bug.cgi?id=1169440 17:55:36 #info Proposed Freeze Exceptions, spin-kickstarts, NEW 17:55:41 satellit: I don't see any screenshot 17:55:53 sorry late entry 17:55:57 nirik: I don't think so, i think it's likely missing fonts, but let me grab an image and see 17:56:14 but what fonts? ;) 17:56:21 Possibly another artifact of the vpodzime release? 17:56:34 satellit: Did it work properly on TC4? 17:56:37 satellit: do you have a final TC4 image around? is that one OK? 17:56:56 It is important as sugar is used in many 3rd world countries 17:57:24 I have seen it in all testing lately but did not appreciate problem 17:57:57 satellit: When did you first see it? 17:58:01 Which compose? 17:58:23 several versions ago....need to go back and check sorry 17:58:41 That's fine, just needed to rule something out 17:58:57 There was a bad anaconda and I was hoping this could be traced to that 17:59:24 sgallagh: anaconda's tarball doesn't contain fonts 17:59:32 OK, good to know 17:59:39 * satellit it has been there for quite while when think back... 17:59:54 so kickstart? 18:00:37 * adamw testing 18:03:37 * adamw confirms the bug in rc1 18:03:38 checking tc4 18:04:10 if the only change required to fix this is to add fonts to the SoaS live kickstart i could be +1 18:04:47 same here 18:04:55 yeah, broken in tc4 too 18:04:58 so i'm guessing it's fonts 18:05:15 i'll add a note to the bug of what languages seem to be missing characters 18:05:41 +1 conditional on it being constrained to the SoaS kickstart. -1 for any other reason without re-review. 18:05:46 so this bug would be up to pbrobinson to track down fonts? or is there some way to know what we are missing? 18:06:20 also, if we accept this we should make sure we wait on making the final spin-kickstarts package until these commits are done. 18:06:45 lorax templates include the font packages used for squashfs.img 18:06:56 (I mean non-live) 18:07:04 nirik: i can take a swing at it, i'm good at that sort of thing. 18:07:08 ok. 18:07:15 thanks... 18:07:19 +1 here provided we can get it quickly. ;) 18:07:42 +1 18:07:45 +1 18:07:57 * adamw votes same as sgallagh, +1 if only change is to SoaS kickstart (or maybe comps, but not if it requires too much time we wouldn't need otherwise) 18:08:15 but wait - SoaS is non-blocking. I realize this is a regression, but.... 18:08:41 danofsatx-work: This isn't a blocker bug 18:08:43 this is FE... not blocker 18:09:04 danofsatx-work: Basically we're saying "if it can only break SoaS, go for it" 18:09:10 understood.... 18:10:19 if we have to change anything outside of SoaS, we're not doing it 18:10:34 note the impact of this isn't just the anaconda welcome screen 18:10:39 and if it takes too long and we want to do a rc2 and it's not done... too bad. 18:10:40 if the fonts are missing it means the live won't be usable in those languages 18:11:17 note: given that everything else on the blocker list looks to be ready to go, I'm going to push for an RC2 compose sometime today. 18:11:28 sounds like a plan to me 18:11:37 * satellit soas does have a way to change languages and keyboards in control panel once it starts 18:11:40 oh, for sre. 18:12:02 we need an anconda build with the things we accepted. 18:12:05 yeah 18:12:22 and can probibly push some more stuff stable from fe's 18:12:25 (that were in rc1) 18:12:35 i'll be on it, after this meeting 18:12:40 do we want to go through accepted blockers? 18:12:59 anything worrying? 18:13:00 i don't think there was anything much to look at there 18:13:05 are we going to have an #agreed for this soas one? 18:13:09 They're all either MODIFIED, ON_QA or VERIFIED 18:13:12 So we're probably oka 18:13:18 i think all the ones prior to the meeting are VERIFIED 18:15:18 I see 2 "NEW" in accepted FEs 18:15:36 proposed #agreed AcceptedFreezeException We will accept a fix for SoaS if it is constrained to SoaS. 18:15:47 1098735 and 1135720 18:15:47 whoops, sorry 18:15:51 forgot i didn't close this one 18:15:51 danofsatx-work: Not our problem. If they aren't fixed, too bad, so sad. 18:15:54 danofsatx-work: that doesn't matter. 18:15:57 ack 18:16:00 ack 18:16:03 patch 18:16:07 ok, no prob 18:16:07 (bug number not mentioned) 18:16:11 ack 18:16:12 adamw: Ah, whoops 18:16:21 proposed #agreed - 1169440 - AcceptedFreezeException - we will accept a fix for SoaS if it is constrained to SoaS. 18:16:27 ack 18:16:27 ack 18:16:29 ack that onw 18:16:33 ack 18:16:47 ack 18:19:21 #agreed - 1169440 - AcceptedFreezeException - we will accept a fix for SoaS if it is constrained to SoaS. 18:19:46 #info all open accepted blockers from before this meeting were VERIFIED, do not need to be reviewed 18:19:59 so I believe we're now all set to get RC2 out the door, thanks very much for all the work from everyone 18:20:07 #topic Open floor 18:20:10 any other business? 18:20:11 OK, so all that's left appears to be to ask the anaconda folks to build .20 and get it out 18:20:16 I have none 18:20:30 not for a blocker meeting anyways :) 18:20:32 Then file an RC2 compose request 18:22:28 that's an adamw action item. We're done ;) 18:23:38 sgallagh: that and look at the soas FE. 18:24:00 also get the final version of the stage1 patch reviewed and acked and tested...don't worry, it's all in hand. :P 18:24:00 adamw: I'd recommend doing that in parallel to the anaconda builds. 18:24:13 Because frankly, I don't see a huge value in delaying everything else for it 18:24:30 sgallagh: we don't have a dgilmore for ~5 hours anyway. 18:24:39 But it's in your capable hands now. 18:24:53 soas is still listed on blocker bugs as proposed 18:24:53 thanks for coming, everyone! ending meeting in a minute or two 18:25:03 satellit: It takes 30 minutes 18:25:05 satellit: the page updates every half an hour, be patient. 18:25:14 thanks sorry 18:30:37 #endmeeting