16:01:52 <geppetto> #startmeeting fpc
16:01:52 <zodbot> Meeting started Thu Sep  7 16:01:52 2023 UTC.
16:01:52 <zodbot> This meeting is logged and archived in a public location.
16:01:52 <zodbot> The chair is geppetto. Information about MeetBot at https://fedoraproject.org/wiki/Zodbot#Meeting_Functions.
16:01:52 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
16:01:52 <zodbot> The meeting name has been set to 'fpc'
16:01:52 <geppetto> #meetingname fpc
16:01:52 <geppetto> #topic Roll Call
16:01:52 <zodbot> The meeting name has been set to 'fpc'
16:02:25 <geppetto> I'm here, but not much has been happening … so it's mostly a "let me know if there's something you want to talk about" meeting.
16:02:34 <geppetto> Also maybe merge lua, again ;)
16:02:44 <geppetto> #chair tibbs
16:02:44 <zodbot> Current chairs: geppetto tibbs
16:02:47 <geppetto> #chair decathorpe
16:02:47 <zodbot> Current chairs: decathorpe geppetto tibbs
16:04:02 <decathorpe> oh yes I'm here
16:05:41 <decathorpe> I commented on the lua guidelines PR with feedback three weeks ago but there were no updates since
16:05:41 <tibbs> I'm back.
16:06:21 * geppetto nods
16:07:29 <tibbs> We could potentially just fix up the lua stuff directly; I don't think there is much disagreement about the overall concept.
16:08:24 <decathorpe> probably
16:08:27 <geppetto> Yeh, I thought decathorpe's comments where mainly small things anyone could fixup … would have been nice if the OP had updated it, but it is 9 months old PR :(
16:09:00 <geppetto> If everyone agrees there's nothing big that needs changing, I'd be fine with merging it.
16:09:07 <tibbs> I feel bad about expecting a quick response when we didn't give one.
16:09:32 <tibbs> Do we want to merge and fix up, or pull into a separate PR, fix that and then merge?
16:09:47 <decathorpe> I'm fine with both
16:09:53 <tibbs> Not that I know git well enough to actually do that.
16:10:21 <decathorpe> but right now the asciidoc syntax is messed up, so it won't render right, so if merge + fixup later, "later" shouldn't be "much later" :)
16:11:15 <tibbs> True it would be better not to merge something we know has broken formatting.
16:11:38 <tibbs> Do you know the git magic needed to pull that PR into one of your own and get it rebased/fixed up?
16:11:51 <decathorpe> I think I do
16:12:01 <tibbs> If not, might have enough time to figure it out today.
16:15:37 <geppetto> Yeh, it'd be nice if this was easy (doing a few quick fixes on top of a PR, before merging) … but I also don't know the correct git magic to do it.
16:16:20 <geppetto> I'm fine just commenting that it's fine to merge after the minor fixes have been done.
16:16:38 * decathorpe is already fixing things
16:16:43 <geppetto> Then either the OP can do it, or one of us … and then one of us can hit the merge button.
16:16:47 <geppetto> Cool
16:16:50 <geppetto> decathorpe++
16:16:50 <zodbot> geppetto: Karma for decathorpe changed to 6 (for the release cycle f38):  https://badges.fedoraproject.org/tags/cookie/any
16:17:02 <geppetto> #topic Open Floor
16:17:12 <geppetto> Anything else anyone wants to talk about?
16:17:19 <tibbs> I know how to pull a PR into a local branch for rebasing and editing, but not how to convert that into my own PR.
16:17:35 <tibbs> I have nothing.
16:18:31 <decathorpe> https://pagure.io/packaging-committee/pull-request/1298
16:19:33 <geppetto> I thought there was a way to push to the original PR, but I don't care enough to not just add a comment to the old PR and merge the new one.
16:19:55 <tibbs> I don't think so, since you would have to have write permissions on their fork.
16:19:58 <geppetto> Want me to hit the merge button decathorpe?
16:20:24 <decathorpe> if you want 😅️ as far as I can tell, it's fine
16:22:13 <geppetto> done
16:22:42 <geppetto> Ok, we can all go eat lunch now and say we did something ;)
16:23:17 <decathorpe> lunch? more like, FESCo meeting, then dinner ;)
16:23:47 <tibbs> I haven't managed to have breakfast yet....
16:25:28 <geppetto> #endmeeting