2025-04-02 13:59:56 <@t0xic0der:fedora.im> !startmeeting Git Forge Meeting
2025-04-02 13:59:59 <@meetbot:fedora.im> Meeting started at 2025-04-02 13:59:56 UTC
2025-04-02 13:59:59 <@meetbot:fedora.im> The Meeting name is 'Git Forge Meeting'
2025-04-02 14:00:10 <@t0xic0der:fedora.im> !info this is meeting about the Fedora git forge replacement this meeting template can be found at https://codeberg.org/fedora/gitforge-migration
2025-04-02 14:00:21 <@t0xic0der:fedora.im> !topic roll call 
2025-04-02 14:01:18 <@t0xic0der:fedora.im> !hi
2025-04-02 14:01:19 <@zodbot:fedora.im> Akashdeep Dhar (t0xic0der) - he / him / his
2025-04-02 14:01:58 <@lenkaseg:fedora.im> !hi
2025-04-02 14:02:00 <@zodbot:fedora.im> Lenka Segura (lenkaseg)
2025-04-02 14:02:01 <@dkirwan:fedora.im> o/
2025-04-02 14:04:14 <@t0xic0der:fedora.im> I will wait until 5 minutes past the hour, but it looks like this one would be underpopulated 
2025-04-02 14:05:09 <@t0xic0der:fedora.im> !topic completion kudos
2025-04-02 14:05:40 <@t0xic0der:fedora.im> !info #12 was closed today 
2025-04-02 14:05:43 <@t0xic0der:fedora.im> !link https://codeberg.org/fedora/forgejo-deployment/issues/12
2025-04-02 14:05:55 <@t0xic0der:fedora.im> David Kirwan++ for working on this!
2025-04-02 14:05:57 <@zodbot:fedora.im> t0xic0der has already given cookies to dkirwan during the F41 timeframe
2025-04-02 14:06:19 <@t0xic0der:fedora.im> !info #11 was closed yesterday
2025-04-02 14:06:24 <@t0xic0der:fedora.im> !link https://codeberg.org/fedora/forgejo-deployment/issues/11
2025-04-02 14:06:37 <@t0xic0der:fedora.im> lenkaseg++ for working on this!
2025-04-02 14:06:39 <@zodbot:fedora.im> t0xic0der has already given cookies to lenkaseg during the F41 timeframe
2025-04-02 14:07:16 <@Zlopez:matrix.org> !hi
2025-04-02 14:07:17 <@t0xic0der:fedora.im> For folks looking to participate in our efforts, please find our project board here
2025-04-02 14:07:19 <@t0xic0der:fedora.im> !link https://codeberg.org/fedora/forgejo-deployment/projects/13486
2025-04-02 14:07:19 <@zodbot:fedora.im> Michal Konecny (zlopez)
2025-04-02 14:07:36 <@t0xic0der:fedora.im> And our communications over here #fedora-forgejo:fedoraproject.org 
2025-04-02 14:10:08 <@t0xic0der:fedora.im> !topic Discussion about planning meeting timings
2025-04-02 14:11:17 <@t0xic0der:fedora.im> Earlier today, folks gathered at the EMEA friendly time, and it was decided that we would like to have only one planning meeting earlier at 0900UTC to 1000UTC
2025-04-02 14:12:24 <@t0xic0der:fedora.im> Unless anyone objects - This will be the last instance of the planning meeting on this time, and we would move the planning meeting over to the 0900UTC to 1000UTC weekly time as agreed upon before
2025-04-02 14:12:57 <@nphilipp:fedora.im> !hi
2025-04-02 14:12:59 <@zodbot:fedora.im> Nils Philippsen (nphilipp) - he / him / his
2025-04-02 14:15:50 <@t0xic0der:fedora.im> !agreed Moving of planning meeting over to 0900UTC-1000UTC time, once every week instead of having two planning meetings
2025-04-02 14:15:52 <@Zlopez:matrix.org> I was on the morning meeting and the time is better for EMEA folks, so no objection from me
2025-04-02 14:16:08 <@lenkaseg:fedora.im> All god for me as well!
2025-04-02 14:16:14 <@lenkaseg:fedora.im> All good for me as well!
2025-04-02 14:16:33 <@t0xic0der:fedora.im> !topic Discussion about the purpose of the Fedora fork of Forgejo
2025-04-02 14:17:23 <@t0xic0der:fedora.im> In the standup yesterday and in the planning call today, we agreed upon not wanting to maintain a fork of Forgejo and instead limit our changes to minimal patches that can be applied retroactively
2025-04-02 14:18:04 <@t0xic0der:fedora.im> Any contributions that are to be made - They are to be made upstream and we will maintain the Fedora fork of Forgejo only to check the compatibility of our changes that pertain to us alone
2025-04-02 14:18:23 <@t0xic0der:fedora.im> Please feel free to add, folks.
2025-04-02 14:19:02 <@lenkaseg:fedora.im> I would have a question about that. So the development of fedora specific changes will happen in the dev environment of upstream forgejo
2025-04-02 14:19:45 <@lenkaseg:fedora.im> How do we test the changes? It can easily happen that our chnges will not be compatible with the upstream test suite
2025-04-02 14:19:52 <@dkirwan:fedora.im> Will make things much easier.. when we get the RPM built for sure.. will simplify the image build and headaches related to keeping everything synced with upstream development
2025-04-02 14:20:08 <@lenkaseg:fedora.im> so will we be patching the tests as well, or have our CI on our fork?
2025-04-02 14:20:21 <@t0xic0der:fedora.im> Specifically, the `forgejo` branch, yes but as that would be synced too, it makes little sense to open up a pull request at Forgejo's (i.e. upstream's end) as the changes pertain to us alone.
2025-04-02 14:20:46 <@Zlopez:matrix.org> I think the CI on our fork is not bad idea
2025-04-02 14:21:17 <@t0xic0der:fedora.im> Having a CI in our fork sounds good but we'd have to write the tests for the changes that we add.
2025-04-02 14:22:36 <@t0xic0der:fedora.im> It is important to note that we would want to keep our changes (that are Fedora Project specific) as minimal as possible and instead, if there are any global changes - consider contributing to the upstream.
2025-04-02 14:23:17 <@t0xic0der:fedora.im> Any objections or concerns on this? I will wait for a couple more minutes before setting this to AGREED.
2025-04-02 14:25:52 <@lenkaseg:fedora.im> So the rpm will be following the forgejo releases with our patches applied on top (+ patches of the tests, in case the test suite will be part of the spec)
2025-04-02 14:26:15 <@t0xic0der:fedora.im> The source tarball, you mean? Yep. 
2025-04-02 14:26:29 <@t0xic0der:fedora.im> !agreed The Fedora Project fork of Forgejo is maintained ONLY to test Fedora Project specific changes and any global changes are to be sent upstream as we will not maintain a Fedora Project fork for global changes
2025-04-02 14:26:37 <@t0xic0der:fedora.im> Moving on
2025-04-02 14:27:10 <@t0xic0der:fedora.im> !topic Discussion about the branching mechanism for the Fedora fork of Forgejo
2025-04-02 14:27:22 <@t0xic0der:fedora.im> lenkaseg: Over to you.
2025-04-02 14:28:12 <@t0xic0der:fedora.im> Related ticket -> #25
2025-04-02 14:28:15 <@t0xic0der:fedora.im> !link https://codeberg.org/fedora/forgejo-deployment/issues/25
2025-04-02 14:29:15 <@lenkaseg:fedora.im> So, after discussions with @jednorozec, the branching schema shold follow the uptream one. Upstream's stable branches will be synced with forgejo actions to fedora's v<x>/forgejo branches
2025-04-02 14:29:15 <@lenkaseg:fedora.im> Ah, ok, thanks!
2025-04-02 14:30:04 <@lenkaseg:fedora.im> Then there's fedora fork's main branch, which would be a sync of the latest upstream stable branch with fedora's changes applied on top
2025-04-02 14:31:28 <@lenkaseg:fedora.im> And then there's forgejo branch, which we are not sure if it's worth keeping
2025-04-02 14:32:17 <@lenkaseg:fedora.im> Could serve for testing our changes on latest upstream's forgejo branch changes? Would it be worthy?
2025-04-02 14:33:41 <@t0xic0der:fedora.im> FWIW - I think we need to ensure that our specific changes play well with the point release based branch (i.e. `vX.X/forgejo`) and the rolling branch (i.e. `forgejo`) if we wanna ensure that the Fedora specific changes do not suddenly break in the future.
2025-04-02 14:33:48 <@lenkaseg:fedora.im> During the sync, if there would be any merge conflicts I guess it could open a PR for manual handling..
2025-04-02 14:34:30 <@Zlopez:matrix.org> Maybe the forgejo branch could be used to test devel changes in advance
2025-04-02 14:34:35 <@t0xic0der:fedora.im> But apart from that - I agree that it is probably not worth maintaining the `rolling` branch for global changes. Folks can fork `forgejo/forgejo` repository instead to their own namespaces and contribute to the upstream for that. 
2025-04-02 14:35:10 <@dkirwan:fedora.im> forgejo branch is basically the upstream main branch?
2025-04-02 14:35:19 <@t0xic0der:fedora.im> David Kirwan: Yes
2025-04-02 14:35:27 <@dkirwan:fedora.im> So dont mak any changes t here
2025-04-02 14:35:41 <@dkirwan:fedora.im> just keep upstream forgejo synced to our fork forgejo branch
2025-04-02 14:35:49 <@dkirwan:fedora.im> same with upstream v10 and v11 to our v10 and v11
2025-04-02 14:36:02 <@lenkaseg:fedora.im> only they have it called forgejo
2025-04-02 14:37:33 <@lenkaseg:fedora.im> Alright then!
2025-04-02 14:37:53 <@lenkaseg:fedora.im> So that will be another action
2025-04-02 14:38:37 <@t0xic0der:fedora.im> Question - Do we maintain a `main` branch from one of the point release-based branches like we do or should we simply push our changes to the synced branches (with the same name as the upstream)?
2025-04-02 14:38:52 <@dkirwan:fedora.im> its pretty tricky...
2025-04-02 14:39:07 <@dkirwan:fedora.im> but we need to be able to start with v10 at the moment, and put all our changes based on that..
2025-04-02 14:39:17 <@dkirwan:fedora.im> v11 goes live end of april I think
2025-04-02 14:39:33 <@dkirwan:fedora.im> our main branch is probably fine to continue using it as we currently are..
2025-04-02 14:39:39 <@t0xic0der:fedora.im> I was not aware of the fact that the `main` branch of Fedora fork was actually not tracking `forgejo` of upstream but rather, `v10.0/forgejo` of the upstream that led to some confusions.
2025-04-02 14:39:52 <@dkirwan:fedora.im> but just gotta figure out how best to rebase all our commits on top of v10 cleanly!
2025-04-02 14:40:40 <@t0xic0der:fedora.im> That just makes it a lot more important to ensure that the Fedora Project specific changes are minimal, and global changes are made to the upstream instead. 
2025-04-02 14:41:10 <@lenkaseg:fedora.im> For the moment quite easily, it's just the UI changes, let's see in the future! It would not be bad to keep our changes somehow separate in different dirs for example, if that's possible
2025-04-02 14:41:13 <@dkirwan:fedora.im> Will be so difficult to maintain if we dont!!
2025-04-02 14:41:52 <@dkirwan:fedora.im> question, what do you think about keeping our fedora specific changes.. in a completely seperate RPM?
2025-04-02 14:42:09 <@t0xic0der:fedora.im> It makes little to no sense when the upstream has it configured and we can sync changes from there. 
2025-04-02 14:42:09 <@t0xic0der:fedora.im> The lockfile gave us some pain - Which made me wonder if at all we'd wanna have Renovate configured for our fork.
2025-04-02 14:42:27 <@t0xic0der:fedora.im> !link https://codeberg.org/fedora/forgejo-deployment/issues/20
2025-04-02 14:43:22 <@t0xic0der:fedora.im> The patches would be applied to the source tarballs that we fetch from the upstream `forgejo/forgejo` during building so the answer is `YES` 
2025-04-02 14:43:47 <@t0xic0der:fedora.im> nils: can probably fill in the gaps here with respect to how he wants to pursue the packaging ordeal
2025-04-02 14:43:58 <@t0xic0der:fedora.im> !link https://codeberg.org/fedora/forgejo-deployment/issues/16
2025-04-02 14:45:39 <@nphilipp:fedora.im> David KirwanAkashdeep Dhar (he/him/his) Shipping our custom themes, assets etc. in a separate package is a sound approach I guess, just code customization would have to be patches in the `forgejo` package
2025-04-02 14:47:27 <@nphilipp:fedora.im> That could even ship custom configuration (e.g. `/etc/forge/conf/fedora.conf`) and service file (`/usr/lib/systemd/system/forgejo-fedora.service`). If we want that – we can also put this in Ansible I guess.
2025-04-02 14:47:48 <@nphilipp:fedora.im> (A lot of guessing…)
2025-04-02 14:47:57 <@dkirwan:fedora.im> the config might be best handled further up the chain.. 
2025-04-02 14:48:01 <@dkirwan:fedora.im> but maybe safe defaults?
2025-04-02 14:48:13 <@t0xic0der:fedora.im> Agreed
2025-04-02 14:48:59 <@dkirwan:fedora.im> upstream currently has a lot of dynamic config generation from config in secrets..
2025-04-02 14:49:31 <@dkirwan:fedora.im> bit of crazy juggling in init containers at launch time
2025-04-02 14:50:27 <@dkirwan:fedora.im> if we really wanted to clean some of that up, again its better dealt with contirbuting upstream ;o
2025-04-02 14:51:16 <@nphilipp:fedora.im> Not sure if we want forgejo generating (i.e. able to write) its config, or what am I missing?
2025-04-02 14:52:13 <@t0xic0der:fedora.im> Specifics specifics - Let us pursue this further in the #fedora-forgejo:fedoraproject.org room, folks as we're down to the last eight minutes of the meeting.
2025-04-02 14:52:20 <@nphilipp:fedora.im> As is, the package takes a config file template and fills in generated secrets the first time the service is started
2025-04-02 14:53:07 <@dkirwan:fedora.im> At launch, some of the config is dyamically created at present .. seems overly complex no idea why its being done this way... but if we rip it out we're straying.. and need to patch.. 
2025-04-02 14:53:48 <@nphilipp:fedora.im> I didn’t have to patch anything to prevent forgejo from trying to mess with the config (and it can’t, permissions eh)
2025-04-02 14:54:14 <@dkirwan:fedora.im> its probably related to if the containers are killed, moved to different hosts, some of the URIs are dynamically upodated to indicate where the containers are running now etc
2025-04-02 14:55:02 <@t0xic0der:fedora.im> Sounds like a bunch of redneck engineering but would have to delve deeper to make sense of it all...
2025-04-02 14:55:17 <@t0xic0der:fedora.im> !topic Open floor
2025-04-02 14:57:01 <@dkirwan:fedora.im> We have a workshop at flock planned dont we? Hopefully will get to use the time to tackle some strategic issues 
2025-04-02 14:58:01 <@t0xic0der:fedora.im> We should have some folks from Forgejo on the ground as well during Flock To Fedora 2025 so that should help iron out the specificities of why something has been done in a certain manner...
2025-04-02 14:58:03 <@nphilipp:fedora.im> Ugh… yeah we don’t want that, but I guess this can be fixed or worked around (config key to say "no touch config", passing in node-specific config where necessary, …)
2025-04-02 14:58:36 <@dkirwan:fedora.im> its just at container start time, once the init containers complete, then forgejo container starts
2025-04-02 14:58:43 <@dkirwan:fedora.im> and at that point then there is no more changes
2025-04-02 14:59:26 <@dkirwan:fedora.im> so yeah guessing its going to be something related to handling changes dynamically to where containers are running for example
2025-04-02 14:59:59 <@dkirwan:fedora.im> or maybe its an intern POC that made it to prod
2025-04-02 15:00:04 <@dkirwan:fedora.im> 🤷
2025-04-02 15:00:22 <@t0xic0der:fedora.im> Folks, please feel free to join us at #fedora-forgejo:fedoraproject.org room to participate
2025-04-02 15:00:22 <@t0xic0der:fedora.im> Closing time! 
2025-04-02 15:00:32 <@t0xic0der:fedora.im> Please do not say that
2025-04-02 15:00:41 <@t0xic0der:fedora.im> !endmeeting