2024-02-12 19:15:32 <@mikelolasagasti:matrix.org> !startmeeting
2024-02-12 19:15:35 <@meetbot:fedora.im> Meeting started at 2024-02-12 19:15:32 UTC
2024-02-12 19:15:35 <@meetbot:fedora.im> The Meeting name is 'Fedora Golang'
2024-02-12 19:16:13 <@mikelolasagasti:matrix.org> !meetingname Go SIG meeting
2024-02-12 19:16:26 <@mikelolasagasti:matrix.org> first time doing this 😅
2024-02-12 19:17:08 <@salimma:fedora.im> on Matrix you mean? :)
2024-02-12 19:17:17 <@mikelolasagasti:matrix.org> ever!
2024-02-12 19:17:24 <@mikelolasagasti:matrix.org> never had to host a meeting
2024-02-12 19:17:43 <@mikelolasagasti:matrix.org> !topic new package naming
2024-02-12 19:18:45 <@mikelolasagasti:matrix.org> so, it seems go2rpm doesn't work with the new naming spec when the package has two numbers (or more?)
2024-02-12 19:18:58 <@mikelolasagasti:matrix.org> I reported this in https://pagure.io/GoSIG/go2rpm/issue/34
2024-02-12 19:19:41 <@salimma:fedora.im> is gotmax23 here
2024-02-12 19:19:46 <@mikelolasagasti:matrix.org> I also realized that `go2rpm` and `go-rpm-macros` updates for F39 and F38 are stalled. 
2024-02-12 19:19:49 <@mikelolasagasti:matrix.org> https://bodhi.fedoraproject.org/updates/FEDORA-2023-60969403d0
2024-02-12 19:19:52 <@mikelolasagasti:matrix.org> https://bodhi.fedoraproject.org/updates/FEDORA-2023-06dd18eecb
2024-02-12 19:20:04 <@mikelolasagasti:matrix.org> not sure if only eclipseo can push them to stable
2024-02-12 19:21:05 <@gotmax:matrix.org> mikelolasagasti: I started working on patch to fix the naming issue
2024-02-12 19:21:06 <@mikelolasagasti:matrix.org> Michel Lind🎩: are you a proven packager? if so, do you have perms to push it?
2024-02-12 19:21:08 <@salimma:fedora.im> I wonder if the code is borrowed from rust2rpm
2024-02-12 19:21:21 <@gotmax:matrix.org> Hmm, and I'm not sure about that go2rpm update
2024-02-12 19:21:38 <@gotmax:matrix.org> I submitted new versions of go-rpm-macros, but it didn't obsolete the old update
2024-02-12 19:21:45 <@salimma:fedora.im> mikelolasagasti: I'm a proven packager, but I'm not sure about overriding someone's bodhi update. I can try
2024-02-12 19:22:13 <@mikelolasagasti:matrix.org> gotmax23: maybe you can release 1.10.1 with the merged PR about `%goname` and make these obsolete?
2024-02-12 19:22:16 <@salimma:fedora.im> in rust2rpm, the need to add _ sometimes arose if the crate name ends in a digit, and you make a compat package that involves adding the version to the end
2024-02-12 19:22:23 <@salimma:fedora.im> so there's confusion if you don't separate the two with a _
2024-02-12 19:22:28 <@salimma:fedora.im> in this case 14 is the version though
2024-02-12 19:23:20 <@mikelolasagasti:matrix.org> packages are tested and have positive karma. I've been using it for a while. The problem is that eclipseo vanished again
2024-02-12 19:23:45 <@salimma:fedora.im> oh yeah I can press push
2024-02-12 19:23:51 <@gotmax:matrix.org> Let me fix that go-rpm-macros update
2024-02-12 19:23:57 <@salimma:fedora.im> should I? unless there's another pending update about to go out
2024-02-12 19:23:59 <@gotmax:matrix.org> I have one in progress already
2024-02-12 19:24:22 <@mikelolasagasti:matrix.org> ok, if gotmax23 can obsolete the current ones it's fine also
2024-02-12 19:24:36 <@mikelolasagasti:matrix.org> but good to know you're a proven packager Michel 😅
2024-02-12 19:24:38 <@gotmax:matrix.org> Meh, I guess we can push it. The newer one doesn't have sufficient karma yet.
2024-02-12 19:25:15 <@salimma:fedora.im> link to the newer one? the other option is to just give it enough karma before the next push :)
2024-02-12 19:25:15 <@gotmax:matrix.org> Done
2024-02-12 19:25:40 <@gotmax:matrix.org> Ah, nevermind
2024-02-12 19:25:45 <@gotmax:matrix.org> > Cannot submit go-rpm-macros ('0', '3.3.0', '1.fc38') to stable since it is older than ('0', '3.3.1', '1.fc38')
2024-02-12 19:26:00 <@gotmax:matrix.org> I'll Obsolete those updates and add the new go2rpm builds to the current one
2024-02-12 19:26:45 <@mikelolasagasti:matrix.org> !action gotmax23 to update go2rpm an go-rpm-macros for F39 & F38
2024-02-12 19:26:59 <@gotmax:matrix.org> Done!
2024-02-12 19:27:23 <@mikelolasagasti:matrix.org> great!
2024-02-12 19:28:04 <@gotmax:matrix.org> https://pagure.io/GoSIG/go2rpm/pull-request/35 should fix the naming issue
2024-02-12 19:28:16 <@mikelolasagasti:matrix.org> !action gotmax23 to investigate https://pagure.io/GoSIG/go2rpm/issue/34
2024-02-12 19:29:02 <@mikelolasagasti:matrix.org> awesome!
2024-02-12 19:29:08 <@zodbot:fedora.im> mikelo2 has already given cookies to gotmax23 during the F39 timeframe
2024-02-12 19:29:35 <@mikelolasagasti:matrix.org> so both issues around go2rpm topic has been addressed
2024-02-12 19:29:47 <@mikelolasagasti:matrix.org> anyone has another topic that want's to follow up with?
2024-02-12 19:30:25 <@gotmax:matrix.org> I did a mass rebuild of Go application packages yesterday for 1.21.0
2024-02-12 19:30:51 <@gotmax:matrix.org> https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/rebuilds2/rebuild.py is the script I used
2024-02-12 19:30:58 <@mikelolasagasti:matrix.org> and alexsaezm learnt how to do it, I guess we need to document it somewhere.
2024-02-12 19:31:12 <@gotmax:matrix.org> https://bodhi.fedoraproject.org/updates/FEDORA-2024-256b176c60 and https://bodhi.fedoraproject.org/updates/FEDORA-2024-22078a7091 are failing gating
2024-02-12 19:31:17 <@gotmax:matrix.org> Not sure what to do about that
2024-02-12 19:31:38 <@mikelolasagasti:matrix.org> !action alexsaezm document how to do mass-rebuilds
2024-02-12 19:31:46 <@gotmax:matrix.org> Now that we have the mandatory go-sig maintainership policy thing, anyone theoretically should be able to do mass rebuilds without provenpackager privileges
2024-02-12 19:32:18 <@salimma:fedora.im> oh, interesting, this is actually blocking push, or just blocking the automatic push to Rawhide?
2024-02-12 19:33:03 <@gotmax:matrix.org> The tests need to be either waived or fixed
2024-02-12 19:34:33 <@mikelolasagasti:matrix.org> who can or should check that?
2024-02-12 19:34:42 <@gotmax:matrix.org> I guess I'll send emails to the maintainers unless someone else wants to :)
2024-02-12 19:35:11 <@gotmax:matrix.org> I could just waive the tests, but ideally the maintainers could look at it and either fix the failure or confirm that they're false positives
2024-02-12 19:36:07 <@mikelolasagasti:matrix.org> I think you contacting them it's the best option
2024-02-12 19:36:09 <@mikelolasagasti:matrix.org> or raising a BZ
2024-02-12 19:39:19 <@buckaroogeek:fedora.im> Did I see a mass rebuild for 1.22 also? I seem to recall a commit in the kubernetes repo
2024-02-12 19:39:30 <@mikelolasagasti:matrix.org> !action gotmax23 to contact podmain maintainers over https://bodhi.fedoraproject.org/updates/FEDORA-2024-256b176c60
2024-02-12 19:39:36 <@gotmax:matrix.org> Oops, I meant 1.22.0
2024-02-12 19:39:52 <@gotmax:matrix.org> Thanks for catching it!
2024-02-12 19:40:12 <@gotmax:matrix.org> How's this?
2024-02-12 19:40:18 <@gotmax:matrix.org> Hi,

weldr-client was rebuilt yesterday as part of a mass rebuild of Go packages for the golang 1.22.0 update. The package's gating tests are failing[1] which is preventing pushing the update. Can you please look at the failure and either confirm that it's a false positive so I can waive it or submit a new build with fixed tests?

Thanks,

Maxwell


[1] https://bodhi.fedoraproject.org/updates/FEDORA-2024-22078a7091
2024-02-12 19:40:27 <@mikelolasagasti:matrix.org> I'm thinking also that selective-mass-rebuild over CVE reports should be documented... 
2024-02-12 19:40:44 <@gotmax:matrix.org> I don't really have a good process for that yet
2024-02-12 19:40:50 <@mikelolasagasti:matrix.org> weldr-client or podman?
2024-02-12 19:41:01 <@gotmax:matrix.org> They both have issues
2024-02-12 19:41:13 <@gotmax:matrix.org> I would copy-paste that and change the package name for the podman maintainers
2024-02-12 19:41:23 <@mikelolasagasti:matrix.org> I'm fine with the message
2024-02-12 19:41:34 <@gotmax:matrix.org> Cool. Thanks!
2024-02-12 19:41:41 <@gotmax:matrix.org> Having to merge back commits to old branches gets messy with the CVE rebuilds
2024-02-12 19:41:58 <@gotmax:matrix.org> I can work on a better script for that next
2024-02-12 19:42:30 <@mikelolasagasti:matrix.org> my "issue" is that there are several BZs opened that require building against an updated golang package
2024-02-12 19:43:02 <@mikelolasagasti:matrix.org> sometimes something like a mass rebuild is enough, but for things like F38 it's a bit messy as you mention
2024-02-12 19:44:09 <@mikelolasagasti:matrix.org> I'm fine if the soluitons is a commit rawhide commit,  rebasing for current Fedora releases and only rebuilding the affected release
2024-02-12 19:45:00 <@mikelolasagasti:matrix.org> should I add an action on tha to you gotmax23 ? I can open issues in the go-sig project to track it
2024-02-12 19:45:42 <@gotmax:matrix.org> What I've done in the past is check repositories and merge back commits from rawhide if the branches are in sync and otherwise create a different commit on the new branch
2024-02-12 19:46:07 <@gotmax:matrix.org> I had some messy scripts to determine that, but I'd like to make it better if we're going to be doing this on a more regular basis
2024-02-12 19:46:24 <@gotmax:matrix.org> Feel free to create an issue in the go-sig trackerr
2024-02-12 19:46:27 <@gotmax:matrix.org> Feel free to create an issue in the go-sig tracker
2024-02-12 19:46:36 <@mikelolasagasti:matrix.org> ok
2024-02-12 19:47:17 <@mikelolasagasti:matrix.org> !action mikel to open issue in go-sig to track CVE fixing script creation
2024-02-12 19:47:40 <@mikelolasagasti:matrix.org> on the FTBFS front, I've been fixing a few that were about to be retired and others that I had in my plate
2024-02-12 19:48:10 <@zodbot:fedora.im> gotmax23 gave a cookie to mikelo2. They now have 7 cookies, 2 of which were obtained in the Fedora 39 release cycle
2024-02-12 19:48:28 <@mikelolasagasti:matrix.org> I'm worried about `golang-github-acme-lego` as updating it requires new packages. Not sure if package is widely used. I'm not using it myself
2024-02-12 19:49:09 <@mikelolasagasti:matrix.org> I also saw `golang-sigs-k8s-kustomize` requires some extra work.
2024-02-12 19:49:50 <@mikelolasagasti:matrix.org> and `golang-gvisor` I believe will be the most complex one. Fale was requiring a new version for a package. I have not looked at it yet... not sure if I'll have time
2024-02-12 19:49:54 <@gotmax:matrix.org> Yeah, golang-github-acme-lego doesn't seem to have anything that depends on it
2024-02-12 19:50:09 <@mikelolasagasti:matrix.org> it brings the `lego` binary
2024-02-12 19:50:18 <@mikelolasagasti:matrix.org> that it's a certbot like tool
2024-02-12 19:50:27 <@mikelolasagasti:matrix.org> that it's a `certbot` like tool
2024-02-12 19:50:39 <@gotmax:matrix.org> Right
2024-02-12 19:51:04 <@gotmax:matrix.org> Vendoring it always an option
2024-02-12 19:51:33 <@gotmax:matrix.org> I'm planning to vendor aerc in https://src.fedoraproject.org/rpms/aerc/pull-request/5, but I still need to figure out licenses
2024-02-12 19:51:48 <@mikelolasagasti:matrix.org> the eternal dilemma on vendoring... 
2024-02-12 19:52:25 <@gotmax:matrix.org> I guess the question is whether we should keep it as vendored or let it get retired
2024-02-12 19:53:01 <@mikelolasagasti:matrix.org> I can have a look what the missing deps are, it may be easy to fix, but then reviewing can take ages :(
2024-02-12 19:53:52 <@mikelolasagasti:matrix.org> the `rclone` update will require +10 new packages
2024-02-12 19:54:47 <@mikelolasagasti:matrix.org> maybe this is something FESCO (?) can discuss, current situation doesn't scale
2024-02-12 19:55:37 <@mikelolasagasti:matrix.org> I guess this requires a large discussion, so not a topic for today
2024-02-12 19:55:52 <@mikelolasagasti:matrix.org> any other topic? 
2024-02-12 19:55:58 <@gotmax:matrix.org> 

> At the moment golang projects packaged in Fedora SHOULD be unbundled by default. It means projects are built from dependencies packaged in Fedora.
> 
> For some project it can be reasonable to build from bundled dependencies. Every bundling needs a proper justification.
2024-02-12 19:56:39 <@gotmax:matrix.org> I'd say that it's ultimately up to us to decide whether it's realistic to unbundle a package or if using vendoring is justifiable
2024-02-12 19:57:32 <@mikelolasagasti:matrix.org> what I'm "afraid" of is that if we start bundling stuff lot of packages will be leaves and can be retired. But then when someone tries to have an unbundled package it will find that lot of packages have been retired
2024-02-12 19:57:56 <@gotmax:matrix.org> That's a valid concern
2024-02-12 19:58:02 <@mikelolasagasti:matrix.org> and un-retiring a package (review + unretiring ticket) takes longer than importing it (just review)
2024-02-12 19:58:30 <@gotmax:matrix.org> On the other hand, I worry that all of our library packages are becoming increasingly out of date and potentially buggy or vulnerable
2024-02-12 19:58:48 <@mikelolasagasti:matrix.org> agree
2024-02-12 19:59:13 <@mikelolasagasti:matrix.org> as said, this requires more discussion
2024-02-12 19:59:20 <@gotmax:matrix.org> Definitely
2024-02-12 19:59:25 <@mikelolasagasti:matrix.org> any other topic we want to discuss today?
2024-02-12 19:59:39 <@mikelolasagasti:matrix.org> I think we had a great session today :D
2024-02-12 19:59:57 <@gotmax:matrix.org> Definitely!
2024-02-12 19:59:59 <@salimma:fedora.im> apologies, got sidetracked in the FESCo meeting next door
2024-02-12 20:00:32 <@salimma:fedora.im> I guess that's one thing to note, this meeting now overlaps with FESCo in the second half hour
2024-02-12 20:00:41 <@salimma:fedora.im> but on the other hand this meeting is normally short
2024-02-12 20:02:00 <@mikelolasagasti:matrix.org> I think in the past there was some discussion about having this session at a different hour/day
2024-02-12 20:02:18 <@mikelolasagasti:matrix.org> if it overlaps with FESCO we can discuss about it
2024-02-12 20:02:29 <@mikelolasagasti:matrix.org> or maybe ask FESCO to change it 😅
2024-02-12 20:03:34 <@mikelolasagasti:matrix.org> !action alexsaezm check if go-sig bi-weekly meeting requires rescheduling due to conflict with FESCO meeting and maybe team member preferences
2024-02-12 20:03:54 <@mikelolasagasti:matrix.org> I'll overload Alex with tasks, he is not here today, so he can't decline them :P
2024-02-12 20:04:14 <@mikelolasagasti:matrix.org> anything you can to discuss about Michel Lind🎩 ?
2024-02-12 20:04:21 <@mikelolasagasti:matrix.org> or should we end today's session?
2024-02-12 20:06:38 <@mikelolasagasti:matrix.org> !endmeeting