#golang:fedoraproject.org log

<@alexsaezm:fedora.im>

18:00:44

!startmeeting Go SIG meeting

<@meetbot:fedora.im>

18:00:45

Meeting started at 2024-06-17 18:00:44 UTC

<@meetbot:fedora.im>

18:00:45

The Meeting name is 'Go SIG meeting'

<@alexsaezm:fedora.im>

18:00:59

!topic Roll Call

<@alexsaezm:fedora.im>

18:01:13

Hi everyone! (like always, we can wait a few minutes for everyone)

<@buckaroogeek:fedora.im>

18:01:25

Greetings

<@mikelolasagasti:matrix.org>

18:01:36

!hello

<@zodbot:fedora.im>

18:01:38

Mikel Olasagasti Uranga (mikelo2)

<@buckaroogeek:fedora.im>

18:01:51

!hello

<@zodbot:fedora.im>

18:01:51

Brad Smith (buckaroogeek)

<@eclipseo:fedora.im>

18:02:03

agree

<@eclipseo:fedora.im>

18:02:17

!hello

<@zodbot:fedora.im>

18:02:18

Robert-André Mauchin (eclipseo)

<@mikelolasagasti:matrix.org>

18:02:18

Will you or should I?

<@eclipseo:fedora.im>

18:02:44

i don't exactly have much time these days sorry

<@mikelolasagasti:matrix.org>

18:03:14

no worries, I’ll take care of it

<@alexsaezm:fedora.im>

18:04:27

Anyone has an issue in particular? I don't see movement in the tickets. Should we jump right away to the Open Floor?

<@mikelolasagasti:matrix.org>

18:04:44

^ this

<@buckaroogeek:fedora.im>

18:05:00

There was that issue with golang in rawhide on aarch64

<@alexsaezm:fedora.im>

18:05:07

the ld one?

<@mikelolasagasti:matrix.org>

18:05:08

we’ve hundreds of package in that situation

<@alexsaezm:fedora.im>

18:05:52

so we have two things going on. The golang issue in aarch64 with ld that Brad Smith found and the empty %files from mikelolasagasti , right?

<@eclipseo:fedora.im>

18:06:19

what is the fix spec side? the underscore thing?

<@mikelolasagasti:matrix.org>

18:07:46

For which issue?

<@eclipseo:fedora.im>

18:08:19

debugsourcelist

<@eclipseo:fedora.im>

18:09:36

what causes it initially? new rpm version runs debuginfo extract even without build and generate buildrequires section?

<@mikelolasagasti:matrix.org>

18:10:31

Affects source only packages

<@mikelolasagasti:matrix.org>

18:10:52

Those where the define debug… has to be defined

<@mikelolasagasti:matrix.org>

18:10:58

(On the phone sorry)

<@mikelolasagasti:matrix.org>

18:11:22

Failing specs have rather old spec without that entry

<@mikelolasagasti:matrix.org>

18:11:57

Old specs were OK but started to fail few weeks ago

<@mikelolasagasti:matrix.org>

18:12:18

Koschei can help to track, but was many macro package updates

<@eclipseo:fedora.im>

18:12:36

yeah we added to new spec because generate buildrequires needed it, i reported that problem upstream back then

<@alexsaezm:fedora.im>

18:12:52

Does Koschei show the error in any form? as a failing build?

<@mikelolasagasti:matrix.org>

18:13:14

Now, why old packages were fine until a few weeks ago but new (~<2 years) packages required the entry

<@eclipseo:fedora.im>

18:13:23

seems to be linked redhat-rpm-config 289 which introduces reproductibility macros

<@mikelolasagasti:matrix.org>

18:15:21

I guess we can script to add the define in the specs

<@eclipseo:fedora.im>

18:15:23

/usr/lib/rpm/macros.d/macros.build-reproducibility and add-determinism binary was introduced but no idea what they do

<@eclipseo:fedora.im>

18:16:36

ah no my mistake

<@eclipseo:fedora.im>

18:16:46

it was the move from 289 to 292

<@eclipseo:fedora.im>

18:17:58

and https://src.fedoraproject.org/rpms/redhat-rpm-config/c/89546cd879491b034fc5a5a53ee9f738add5d9b3?branch=rawhide

<@eclipseo:fedora.im>

18:17:58

we have https://src.fedoraproject.org/rpms/redhat-rpm-config/c/7a1571ee808ba13b129eab7a7ed3869e77740c3e?branch=rawhide

<@eclipseo:fedora.im>

18:25:55

probably easy fix but time consuming

<@alexsaezm:fedora.im>

18:26:22

What would be the best approach?

<@mikelolasagasti:matrix.org>

18:26:36

Update specs 😅

<@eclipseo:fedora.im>

18:26:40

grep

<@eclipseo:fedora.im>

18:26:59

fd -e spec -0 | xargs -0 rg --files-without-match "debug_package"

<@alexsaezm:fedora.im>

18:28:00

🫠

<@eclipseo:fedora.im>

18:28:14

fd -e spec -0 | xargs -0 rg --files-without-match "debug_package" | xargs -0 rg --files-without-match "\%build"

<@alexsaezm:fedora.im>

18:29:33

Is there a way to batch clone all of the affected repos? I never checked if I can clone all of the go sig packages

<@eclipseo:fedora.im>

18:29:51

i already have all the go repo sync every day

<@mikelolasagasti:matrix.org>

18:29:53

we can take the list from koschei and loop

<@eclipseo:fedora.im>

18:30:14

grokmirror

<@mikelolasagasti:matrix.org>

18:30:50

using https://src.fedoraproject.org/lookaside/rpm-specs-latest.tar.xz to detect and then clone + do stuff

<@mikelolasagasti:matrix.org>

18:30:55

don't know bout grokmirror

<@eclipseo:fedora.im>

18:31:29

grokmirror clone and sync the git repo locally

<@alexsaezm:fedora.im>

18:32:19

didn't know about the tool, sounds cool.

<@alexsaezm:fedora.im>

18:32:21

Any volunteer ? :) I can offer myself

<@mikelolasagasti:matrix.org>

18:34:42

i can help, but will be out a couple of day thsi week and next one

<@mikelolasagasti:matrix.org>

18:34:57

we've time until f41 is branched

<@alexsaezm:fedora.im>

18:35:27

I have time this week (at least for now)

<@eclipseo:fedora.im>

18:38:46

<@eclipseo:fedora.im>

18:38:46

sudo dnf install grokmirror

<@eclipseo:fedora.im>

18:38:46

<@eclipseo:fedora.im>

18:38:46

mkdir ~/fedoraproject

<@eclipseo:fedora.im>

18:38:46

<@eclipseo:fedora.im>

18:38:46

mkdir -p /var/lib/fedoraproject/mirror

<@eclipseo:fedora.im>

18:38:46

<@eclipseo:fedora.im>

18:38:46

chown -R user:user /var/lib/fedoraprojec

<@eclipseo:fedora.im>

18:38:46

<@eclipseo:fedora.im>

18:38:46

~/.config/grokmirror/repos-golang.conf https://eclipseo.fedorapeople.org/repos-golang.conf

<@eclipseo:fedora.im>

18:38:46

~/.local/bin/post-pull-hook-golang.sh https://eclipseo.fedorapeople.org/post-pull-hook-golang.sh

<@eclipseo:fedora.im>

18:38:46

<@eclipseo:fedora.im>

18:38:46

~/.config/systemd/user/grokmirror-golang.timer https://eclipseo.fedorapeople.org/grokmirror-golang.timer

<@eclipseo:fedora.im>

18:38:46

<@eclipseo:fedora.im>

18:38:46

~/.config/systemd/user/grokmirror-golang.service https://eclipseo.fedorapeople.org/grokmirror-golang.service

<@alexsaezm:fedora.im>

18:39:51

I need to save that :D

<@alexsaezm:fedora.im>

18:39:52

!action: @alexsaezm will look into the debugsourcefiles empty.

<@alexsaezm:fedora.im>

18:40:12

Not sure if the bot got the action...

<@alexsaezm:fedora.im>

18:40:18

!action @alexsaezm will look into the debugsourcefiles empty.

<@alexsaezm:fedora.im>

18:40:28

now, the colon was messing it

<@zodbot:fedora.im>

18:40:35

alexsaezm gave a cookie to eclipseo. They now have 50 cookies, 3 of which were obtained in the Fedora 40 release cycle

<@alexsaezm:fedora.im>

18:41:18

Regarding the other issue, I will also look into the missing ld message, didn't have time yet, but I have tomorrow.

<@buckaroogeek:fedora.im>

18:41:27

<@alexsaezm:fedora.im>

18:41:34

!action @alexsaezm will look into the failing golang aarch64 build

<@buckaroogeek:fedora.im>

18:41:48

on rawhide

<@alexsaezm:fedora.im>

18:42:04

right :D

<@alexsaezm:fedora.im>

18:42:10

yeah, on rawhide

<@alexsaezm:fedora.im>

18:42:18

any other topics?

<@mikelolasagasti:matrix.org>

18:43:21

CVE-2024-24789

<@mikelolasagasti:matrix.org>

18:43:36

~1h ago a bunch of BZs have been opened for that CVE

<@mikelolasagasti:matrix.org>

18:43:54

it would be great to rebuild affected packages and for that to have the script to do so

<@mikelolasagasti:matrix.org>

18:44:10

"golang: archive/zip: Incorrect handling of certain ZIP files"

<@alexsaezm:fedora.im>

18:46:13

hmmmmm that one is related to 1.22.4 which is failing right now in Rawhide

<@alexsaezm:fedora.im>

18:46:24

but I can do the rebuild for the other ones

<@mikelolasagasti:matrix.org>

18:47:05

the CVE has been opened against all packages that use archive/zip, so first golang needs to be fixed/updated and after all the affected packages

<@alexsaezm:fedora.im>

18:47:17

yep

<@alexsaezm:fedora.im>

18:47:31

I'll take that action too, I'll fix golang as soon as I can

<@alexsaezm:fedora.im>

18:47:44

!action @alexsaezm rebuild packages affected by CVE-2024-24789

<@alexsaezm:fedora.im>

18:49:02

any other issues?

<@buckaroogeek:fedora.im>

18:49:40

Nothing from me

<@mikelolasagasti:matrix.org>

18:50:05

reviews :/

<@mikelolasagasti:matrix.org>

18:50:19

I'll appreciate this https://bugzilla.redhat.com/show_bug.cgi?id=2277225 to unblock glab update

<@eclipseo:fedora.im>

18:50:51

rg --files-without-match "debug_package" -g "*.spec" -0 | xargs -0 rg --files-without-match "%build" -g "*.spec" | wc -l  74ms  fish

<@eclipseo:fedora.im>

18:50:51

743

<@eclipseo:fedora.im>

18:51:04

rg --files-without-match "debug\_package" -g "_.spec" -0 | xargs -0 rg --files-without-match "%build" -g "_.spec" | wc -l

<@eclipseo:fedora.im>

18:51:04

743

<@eclipseo:fedora.im>

18:51:10

small task

<@eclipseo:fedora.im>

18:51:34

will do

<@alexsaezm:fedora.im>

18:53:39

awesome

<@alexsaezm:fedora.im>

18:54:21

I guess we can call it for today :)

<@alexsaezm:fedora.im>

18:55:17

Thanks everyone! Enjoy the rest of the day :)

<@alexsaezm:fedora.im>

18:55:18

!endmeeting