<@alexsaezm:fedora.im>
18:00:22
!startmeeting Go SIG meeting
<@meetbot:fedora.im>
18:00:23
Meeting started at 2024-07-29 18:00:22 UTC
<@meetbot:fedora.im>
18:00:23
The Meeting name is 'Go SIG meeting'
<@alexsaezm:fedora.im>
18:00:31
!topic Roll Call
<@alexsaezm:fedora.im>
18:00:31
Hi everyone! (like always, we can wait a few minutes for everyone)
<@mikelolasagasti:matrix.org>
18:00:39
!hello
<@zodbot:fedora.im>
18:00:40
Mikel Olasagasti Uranga (mikelo2)
<@buckaroogeek:fedora.im>
18:00:50
!hello
<@zodbot:fedora.im>
18:00:51
Brad Smith (buckaroogeek)
<@mikelolasagasti:matrix.org>
18:06:15
should we start?
<@alexsaezm:fedora.im>
18:06:18
yeah
<@alexsaezm:fedora.im>
18:06:27
I usually put a 5 minutes timer :D
<@alexsaezm:fedora.im>
18:06:38
so, we have several issues today: https://pagure.io/GoSIG/go-sig/issues?status=Open&tags=meeting&close_status=
<@alexsaezm:fedora.im>
18:06:58
3 of them new :D
<@alexsaezm:fedora.im>
18:07:24
!topic Retire godep https://pagure.io/GoSIG/go-sig/issue/56
<@alexsaezm:fedora.im>
18:07:43
We can start with the new ones, being this the "oldest" of the new ones :D
<@alexsaezm:fedora.im>
18:08:09
So, godep is deprecated in upstream, as it was from a time before the modules
<@alexsaezm:fedora.im>
18:08:52
I talked earlier today with mikelolasagasti about it and apparently we can remove it for the Fedora 41.
<@alexsaezm:fedora.im>
18:08:56
I am all for it
<@mikelolasagasti:matrix.org>
18:09:19
+1 also from my side and I see gotmax23 added the +1 in the ticket
<@gotmax:matrix.org>
18:09:47
Indeed
<@buckaroogeek:fedora.im>
18:09:48
probably best but do not know enough to comment
<@gotmax:matrix.org>
18:10:00
Although, retirements are currently broken in rawhide
<@mikelolasagasti:matrix.org>
18:11:17
oh crap, I retired `golang-helm-3` yesterday :/
<@buckaroogeek:fedora.im>
18:11:19
ditto
<@mikelolasagasti:matrix.org>
18:12:05
but the spec is gone from https://src.fedoraproject.org/lookaside/rpm-specs-latest.tar.xz
<@gotmax:matrix.org>
18:12:08
mikelolasagasti: I'd leave a comment in https://pagure.io/releng/issue/12192 asking them to handle the reitrement manually
<@gotmax:matrix.org>
18:12:31
koji list-pkgs --show-blocked --tag f41 --quiet --package golang-helm-3 would show BLOCKED if it was properly retired
<@gotmax:matrix.org>
18:12:38
`koji list-pkgs --show-blocked --tag f41 --quiet --package golang-helm-3` would show BLOCKED if it was properly retired
<@mikelolasagasti:matrix.org>
18:13:26
it does not
<@gotmax:matrix.org>
18:13:33
Right
<@mikelolasagasti:matrix.org>
18:15:22
so... we wait until that issue is fixed?
<@alexsaezm:fedora.im>
18:15:48
we have until the 13th of the next month
<@alexsaezm:fedora.im>
18:15:53
(the freeze)
<@alexsaezm:fedora.im>
18:15:57
we can wait a little bit
<@alexsaezm:fedora.im>
18:16:15
if not, remove it and ask in the ticket sounds good to me
<@buckaroogeek:fedora.im>
18:16:21
of course next month is 2 days away....
<@gotmax:matrix.org>
18:16:51
I don't see much of a problem with retiring it now and leaving a comment in the ticket
<@gotmax:matrix.org>
18:17:01
Otherwise, we're more likely to forgot
<@alexsaezm:fedora.im>
18:17:02
but next month sounds like we have more time :D
<@alexsaezm:fedora.im>
18:17:11
sounds good to me
<@mikelolasagasti:matrix.org>
18:17:20
ok, I'll retire it now then and add a comment in the ticket
<@zodbot:fedora.im>
18:18:20
alexsaezm gave a cookie to mikelo2. They now have 12 cookies, 1 of which were obtained in the Fedora 40 release cycle
<@gotmax:matrix.org>
18:18:20
I left a comment about golang-helm-3 and another package I need retired
<@zodbot:fedora.im>
18:18:27
gotmax23 gave a cookie to mikelo2. They now have 13 cookies, 2 of which were obtained in the Fedora 40 release cycle
<@alexsaezm:fedora.im>
18:19:13
We have more topics about retiring packages, we can move to them
<@alexsaezm:fedora.im>
18:19:23
!topic Retire golang-github-siddontang-goredis and golang-github-ledisdb https://pagure.io/GoSIG/go-sig/issue/57
<@alexsaezm:fedora.im>
18:19:42
Same story, old packages
<@alexsaezm:fedora.im>
18:20:00
they are not supported by upstream
<@mikelolasagasti:matrix.org>
18:20:24
done https://src.fedoraproject.org/rpms/godep/c/e2a6c3128835bc9676bb8a63deadf556d79f26a7?branch=rawhide
<@mikelolasagasti:matrix.org>
18:21:52
those packages are ownd by eclipseo but I think he is MIA again. The server database builds, but direct dependency doesn't and both are deprecated. We can leave the ticket open in case he comes back and revisit it before F41 is released?
<@gotmax:matrix.org>
18:22:54
I think that's alright
<@alexsaezm:fedora.im>
18:23:14
I leave the ticket open and tagged then
<@mikelolasagasti:matrix.org>
18:23:26
I foudn these two cleaning ftbfs packages
<@mikelolasagasti:matrix.org>
18:23:51
cleaning & fixing
<@alexsaezm:fedora.im>
18:24:05
I bet is the same for the remaining ticket...
<@gotmax:matrix.org>
18:24:11
Since there's not a huge chain of broken deps here, I'm not super worried about retiring it ASAP
<@mikelolasagasti:matrix.org>
18:24:29
neither, but I would like to keep track
<@gotmax:matrix.org>
18:24:41
Definitely
<@mikelolasagasti:matrix.org>
18:25:27
so, alexsaezm can you keep tracking and/or pinging eclipseo next meetings?
<@alexsaezm:fedora.im>
18:26:46
absolutely
<@gotmax:matrix.org>
18:27:01
Should we move on to #58 Retire golang-vitess and golang-sigs-k8s-kustomize dependencies
<@alexsaezm:fedora.im>
18:27:09
yep
<@alexsaezm:fedora.im>
18:27:19
!topic Retire golang-vitess and golang-sigs-k8s-kustomize dependencies https://pagure.io/GoSIG/go-sig/issue/58
<@mikelolasagasti:matrix.org>
18:27:48
these two packages were retired due to FTBFS policy and were not updated in a while
<@mikelolasagasti:matrix.org>
18:28:22
I tried to track golang-vitess's and it's depencies review bz's... but I found none... which is weird
<@mikelolasagasti:matrix.org>
18:28:35
like if eclipseo had a trick to get repos without reviews
<@mikelolasagasti:matrix.org>
18:29:16
anyhow, those packages are leaves currently. I think cleaning them unless someone wants to bring original packages back is safe.
<@gotmax:matrix.org>
18:29:26
I agree
<@gotmax:matrix.org>
18:29:40
I have a script that can handle mass retirements already
<@gotmax:matrix.org>
18:30:13
It's used for the Orphaned for more than 6 weeks retirements, but the message can be changed and then it can be re-used
<@mikelolasagasti:matrix.org>
18:30:54
I was thinking about doing a `for i in foo bar baz; do fedpkg retire "Retire because it's a leave"; done` 😅
<@gotmax:matrix.org>
18:31:25
!link https://pagure.io/releng/pull-request/12224#
<@mikelolasagasti:matrix.org>
18:31:28
I was thinking about doing a `for i in foo bar baz; do fedpkg clone $i; cd $i; fedpkg retire "Retire because it's a leave"; done` 😅
<@gotmax:matrix.org>
18:32:10
So it'd be `python retire.py --list <newline_separated_list_of_packages_file> retire --message <message>`
<@gotmax:matrix.org>
18:32:42
It worked well when we did something like this last year
<@gotmax:matrix.org>
18:32:50
!link https://fedoraproject.org/wiki/Changes/Mass_Retire_Golang_Leaves
<@gotmax:matrix.org>
18:33:15
I don't think we need a change proposal again, but definitely an announcement on the ML
<@mikelolasagasti:matrix.org>
18:33:46
gotmax23: as you control better than the rest of us the tooling, can you take care of the ones listed in the ticket?
<@gotmax:matrix.org>
18:34:18
Okay
<@mikelolasagasti:matrix.org>
18:34:39
thanks
<@gotmax:matrix.org>
18:34:50
Do you mind assigning it to me and then announcing on the golang ML that we're retiring <list of packages> and it'll happen next week?
<@zodbot:fedora.im>
18:34:51
alexsaezm gave a cookie to gotmax23. They now have 32 cookies, 2 of which were obtained in the Fedora 40 release cycle
<@mikelolasagasti:matrix.org>
18:35:04
yes, I will
<@gotmax:matrix.org>
18:35:10
Thanks!
<@alexsaezm:fedora.im>
18:36:38
So we can move to another issues>
<@alexsaezm:fedora.im>
18:36:39
?
<@gotmax:matrix.org>
18:36:50
I think so
<@gotmax:matrix.org>
18:36:55
or open floor?
<@alexsaezm:fedora.im>
18:37:04
There is at least one more that I want to discuss
<@gotmax:matrix.org>
18:37:15
Sounds good
<@alexsaezm:fedora.im>
18:37:18
I am going to skipp #54 because the next action is in my plate
<@alexsaezm:fedora.im>
18:37:46
oh
<@alexsaezm:fedora.im>
18:37:50
you just closed it :D
<@alexsaezm:fedora.im>
18:37:56
I was going to ask if we can close #53
<@alexsaezm:fedora.im>
18:38:00
that's it then :D
<@alexsaezm:fedora.im>
18:38:08
we can go to open floor
<@gotmax:matrix.org>
18:38:11
Hehe
<@alexsaezm:fedora.im>
18:38:31
!topic Open floor
<@mikelolasagasti:matrix.org>
18:39:04
I can start 😅
<@alexsaezm:fedora.im>
18:39:13
Please :)
<@mikelolasagasti:matrix.org>
18:39:45
I've been doing different things lately like fixing ftbfs trying to get as less ftbfs bz's as possible
<@mikelolasagasti:matrix.org>
18:40:24
yesterday I imported `helm` after Brad Smith's review and gotmax23 comments. Thanks for your fast comments!
<@mikelolasagasti:matrix.org>
18:40:58
today I merged the change to get `golang-github-acme-lego` fixed. It took a few new packages to be reviewed, so thanks alexsaezm for your work here.
<@gotmax:matrix.org>
18:41:08
Thank you!
<@buckaroogeek:fedora.im>
18:41:24
thanks
<@mikelolasagasti:matrix.org>
18:41:31
my next task is to fix & update `rclone` and get `restic` also updated.. Will ping you alexsaezm for reviews ;)
<@gotmax:matrix.org>
18:41:52
Am I remembering correctly that a lot of things (transitively) depend on golang-github-acme-lego?
<@mikelolasagasti:matrix.org>
18:41:57
I'm also thinking on bringing `kustomize` back as a vendored package. Maybe you can review it Brad Smith as you did with `helm` :D
<@alexsaezm:fedora.im>
18:42:37
Sure, I'll be near your home in a few months, you can pay me in beers
<@mikelolasagasti:matrix.org>
18:43:08
it has many deps on cloud provider sdks and other specific libraries yes
<@mikelolasagasti:matrix.org>
18:43:23
similar to `rclone`
<@mikelolasagasti:matrix.org>
18:43:35
in fact as some are shared iirc
<@gotmax:matrix.org>
18:44:11
Oh, but what about other packages using it as a library?
<@gotmax:matrix.org>
18:44:20
It looks like it's only there to provide the lego cli?
<@mikelolasagasti:matrix.org>
18:44:32
`fedrq whatrequires 'golang(github.com/go-acme/lego*)' -F source` shows nothing
<@gotmax:matrix.org>
18:44:55
Right
<@mikelolasagasti:matrix.org>
18:45:13
seems so, and although vendoring it may be easier, as some deps are shared I preferred to keep the old way
<@gotmax:matrix.org>
18:45:34
Makes sense
<@mikelolasagasti:matrix.org>
18:46:05
hopefully the update will create some leaves that I'll report tomorrow once the script is executed
<@gotmax:matrix.org>
18:46:28
Cool
<@gotmax:matrix.org>
18:46:50
Did you have something else or should I go?
<@mikelolasagasti:matrix.org>
18:46:53
I was trying also to get rid of jose2 we're close to it 😅
<@mikelolasagasti:matrix.org>
18:47:17
yes... I wanted to ask you about the go-vendor-tools for EL9 scenario
<@gotmax:matrix.org>
18:47:36
Ah right, I saw a notification about that
<@mikelolasagasti:matrix.org>
18:48:12
it would be useful to bring `opentofu` and `helm` to EL9
<@mikelolasagasti:matrix.org>
18:48:18
and EL10 in the future
<@gotmax:matrix.org>
18:48:38
Although, now I can't find the notification
<@mikelolasagasti:matrix.org>
18:48:42
`opentofu` is already in EL9, but not using go-vendor-tools, and would make things much easier
<@gotmax:matrix.org>
18:48:43
Was that on the Gitlab tracker?
<@mikelolasagasti:matrix.org>
18:48:51
btw, you did an awesome job with that tool!!!
<@mikelolasagasti:matrix.org>
18:48:56
yes
<@mikelolasagasti:matrix.org>
18:48:58
issue 10
<@mikelolasagasti:matrix.org>
18:49:12
https://gitlab.com/fedora/sigs/go/go-vendor-tools/-/issues/10
<@buckaroogeek:fedora.im>
18:49:51
I agree - and it is getting better
<@gotmax:matrix.org>
18:50:41
I guess I don't see any blockers to getting it into EPEL 9
<@gotmax:matrix.org>
18:51:02
I already ahve branches for the two Python deps of go-vendor-tools, just need to build them
<@gotmax:matrix.org>
18:51:19
The one question about go-vendor-tools is license detection
<@gotmax:matrix.org>
18:51:33
Currently, two detectors are available: trivy and askalono
<@gotmax:matrix.org>
18:51:40
The default in the stable releases is trivy
<@gotmax:matrix.org>
18:51:51
But was considering switching it to askalono
<@gotmax:matrix.org>
18:52:09
The bottom line is that these types of tools are never perfect
<@gotmax:matrix.org>
18:52:18
So it's a question of which is less bad
<@mikelolasagasti:matrix.org>
18:52:59
which one is easier to package for EL9? that can be a important factor to consider
<@buckaroogeek:fedora.im>
18:53:18
currently askalono seems to be a bit better
<@gotmax:matrix.org>
18:53:40
I would probably end up packaging both
<@gotmax:matrix.org>
18:53:56
One isn't necessarily easier than the other
<@gotmax:matrix.org>
18:54:46
go2rpm automatically generates a go-vendor-tools config with `backend` set to whatever was used originally
<@gotmax:matrix.org>
18:54:56
So if we change the default, things shouldn't break
<@gotmax:matrix.org>
18:55:42
I'm kind of inclined to keep it with trivy to avoid changes when askalono isn't clearly the better option
<@mikelolasagasti:matrix.org>
18:55:56
I don't have a hard opinion here
<@gotmax:matrix.org>
18:56:03
Fair enough
<@gotmax:matrix.org>
18:56:07
I'll give it some more thought
<@gotmax:matrix.org>
18:56:11
The other issue was the Docker stack
<@gotmax:matrix.org>
18:56:48
Sorry, did someone have anything else to add about go-vendor-tools first?
<@mikelolasagasti:matrix.org>
18:57:24
I wanted to suggest a feature for it, but can revisit after docker stuff
<@gotmax:matrix.org>
18:57:37
Okay
<@gotmax:matrix.org>
18:57:49
With docker, I worked on revamping the packaging and submitting reviews
<@gotmax:matrix.org>
18:58:01
They have been sitting around for a few months
<@mikelolasagasti:matrix.org>
18:58:13
I'm not able to find or identify them in https://fedoraproject.org/PackageReviewStatus/reviewable.html
<@gotmax:matrix.org>
18:58:20
And right now, I'm definitely not up to maintaining everything entirely myself
<@gotmax:matrix.org>
18:59:05
Hmm, not sure
<@gotmax:matrix.org>
18:59:10
https://bugzilla.redhat.com/show_bug.cgi?id=2274561 is one of the reviews
<@alexsaezm:fedora.im>
18:59:15
if you need help maintaining those tools, ping me :)
<@alexsaezm:fedora.im>
18:59:30
I more than happy to help
<@mikelolasagasti:matrix.org>
18:59:46
I'll review it tomorrow
<@gotmax:matrix.org>
19:00:20
Okay
<@gotmax:matrix.org>
19:00:41
I guess before I import them, I'd want someone to commit to being the primary maintainer
<@gotmax:matrix.org>
19:01:30
I had a few hours to sit down and refactor the packaging, but I don't think I'll have the time to maintain the packages long term
<@gotmax:matrix.org>
19:02:07
Other than docker-cli and moby-engine needing to be built in a sidetag for updates (they depend on each other), it shouldn't be too difficult for someone to pick up
<@buckaroogeek:fedora.im>
19:02:13
You already added me to containerd and moby-engine. I tend to defer to sergio however
<@mikelolasagasti:matrix.org>
19:02:29
I would need to understand the <del>mess</del> stack to be able to help
<@gotmax:matrix.org>
19:02:52
:nod:
<@gotmax:matrix.org>
19:03:24
Brad Smith, do you mind if I assign docker-cli and docker-compose-switch to you after importing them
<@gotmax:matrix.org>
19:03:39
Or would you prefer if someone else was the primary maintainer?
<@buckaroogeek:fedora.im>
19:03:44
Go ahead.
<@gotmax:matrix.org>
19:03:59
Okay, great!
<@gotmax:matrix.org>
19:04:16
Let me know if you have any questions about the side tag build process
<@buckaroogeek:fedora.im>
19:04:20
I do not use docker much on Fedora but always willing to build
<@buckaroogeek:fedora.im>
19:04:24
Ok
<@gotmax:matrix.org>
19:04:45
docker-cli and moby-engine depend on each other at runtime
<@gotmax:matrix.org>
19:04:54
So they need to be updated together in a side tag
<@gotmax:matrix.org>
19:05:26
I was thinking that maybe keeping them as part of one source package is a better idea afterall
<@gotmax:matrix.org>
19:05:32
It makes the packaging a lot more complicated
<@gotmax:matrix.org>
19:05:35
But makes updates easier
<@buckaroogeek:fedora.im>
19:05:44
moby-engine is seriously out of date. Sergio suggested waiting to F42 for the next up date
<@gotmax:matrix.org>
19:06:12
https://src.fedoraproject.org/rpms/moby-engine/pull-request/21 is the update
<@gotmax:matrix.org>
19:06:16
But it's waiting on the reviews
<@buckaroogeek:fedora.im>
19:06:23
ok
<@gotmax:matrix.org>
19:06:32
And I think that PR is a couple minor versions behind now
<@gotmax:matrix.org>
19:06:41
Docker is released relatively frequently
<@buckaroogeek:fedora.im>
19:06:48
v 27 is out
<@gotmax:matrix.org>
19:07:10
Right
<@gotmax:matrix.org>
19:07:35
I'll try to get those Docker reviews all up to date
<@buckaroogeek:fedora.im>
19:07:59
ok
<@gotmax:matrix.org>
19:08:07
And then I can import the docker-cli package once mikelolasagasti reviews it and assign it to Brad Smith
<@gotmax:matrix.org>
19:08:13
Is that still okay with everyone?
<@buckaroogeek:fedora.im>
19:08:44
I am also working on cri-o and cri-tools as versioned rpms
<@buckaroogeek:fedora.im>
19:08:47
ok by me
<@gotmax:matrix.org>
19:08:59
Good like with cri-o!
<@gotmax:matrix.org>
19:09:25
mikelolasagasti, did you want to bring your go-vendor-tools RFE quickly here or is it better left for the issue tracker after the meeting?
<@buckaroogeek:fedora.im>
19:09:26
:)
<@gotmax:matrix.org>
19:09:33
*luck
<@gotmax:matrix.org>
19:09:37
But yes :)
<@mikelolasagasti:matrix.org>
19:09:37
ok
<@mikelolasagasti:matrix.org>
19:11:15
I've two packages using `go-vendor-tools` and the packages share a few dependencies. One of the dependencies is `github.com/BurntSushi/toml` and in both I had to add a `licensing.licenses` tag for the `vendor/github.com/BurntSushi/toml/COPYING` file. I was thinking if having a list that can be updated with known licenses could help.
<@mikelolasagasti:matrix.org>
19:12:05
a list in `go-vendor-tool` that could be consulted automatically if the file is detected and added to `go-vendor-tools.toml`
<@gotmax:matrix.org>
19:12:09
https://gitlab.com/fedora/sigs/go/go-vendor-tools/-/issues/27
<@gotmax:matrix.org>
19:12:31
I was thinking more of a local cache on the user's system when I opened that
<@gotmax:matrix.org>
19:12:51
Are you suggesting that we keep a mini database in go-vendor-tools?
<@mikelolasagasti:matrix.org>
19:13:03
yes
<@mikelolasagasti:matrix.org>
19:14:30
but I also understand that even if it's a nice feature it won't be used widely and would require go-vendor-tools releases with updated db
<@gotmax:matrix.org>
19:14:42
Right
<@gotmax:matrix.org>
19:15:00
I guess a local cache would be a good start and not too difficult to implement
<@alexsaezm:fedora.im>
19:16:21
We are a little bit over the hour. Should we continue this on the next meeting?
<@gotmax:matrix.org>
19:16:34
Yeah, I think so
<@mikelolasagasti:matrix.org>
19:16:39
+1
<@alexsaezm:fedora.im>
19:16:51
Awesome. Today's meeting has been really productive :D
<@alexsaezm:fedora.im>
19:16:55
thank you everyone!
<@gotmax:matrix.org>
19:17:01
Thanks everyone!
<@zodbot:fedora.im>
19:17:09
gotmax23 gave a cookie to alexsaezm. They now have 8 cookies, 1 of which were obtained in the Fedora 40 release cycle
<@zodbot:fedora.im>
19:17:12
mikelo2 gave a cookie to alexsaezm. They now have 9 cookies, 2 of which were obtained in the Fedora 40 release cycle
<@buckaroogeek:fedora.im>
19:17:18
thanks. Get better gotmax23
<@zodbot:fedora.im>
19:17:23
mikelo2 gave a cookie to gotmax23. They now have 33 cookies, 3 of which were obtained in the Fedora 40 release cycle
<@alexsaezm:fedora.im>
19:17:25
Yeah take care!
<@alexsaezm:fedora.im>
19:17:30
!endmeeting