14:02:46 <abompard> #startmeeting hubs-devel
14:02:47 <zodbot> Meeting started Tue Oct 10 14:02:46 2017 UTC.  The chair is abompard. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:02:47 <zodbot> Useful Commands: #action #agreed #halp #info #idea #link #topic.
14:02:47 <zodbot> The meeting name has been set to 'hubs-devel'
14:02:55 <abompard> #topic Roll Call
14:02:58 <abompard> .abompard
14:03:00 <abompard> oops
14:03:03 <abompard> .hello2
14:03:04 <zodbot> abompard: abompard 'Aurelien Bompard' <aurelien@bompard.org>
14:03:08 <shaily> .hello2
14:03:09 <zodbot> shaily: shaily 'None' <shaily15297@yahoo.com>
14:03:22 <sayan> .hello sayanchowdhury
14:03:23 <zodbot> sayan: sayanchowdhury 'Sayan Chowdhury' <sayan.chowdhury2012@gmail.com>
14:03:29 <abompard> #chair sayan shaily
14:03:29 <zodbot> Current chairs: abompard sayan shaily
14:03:54 <abompard> mizmo: are you around?
14:04:07 <mizmo> abompard: i am
14:04:13 <abompard> cool!
14:04:18 <abompard> #chair mizmo
14:04:18 <zodbot> Current chairs: abompard mizmo sayan shaily
14:04:19 <mizmo> having network issues but here :)
14:05:37 <abompard> Any more people?
14:05:49 <abompard> OK, they'll join later :)
14:06:03 <abompard> #topic Action items from last meeting
14:06:46 <abompard> mizmo working on hubs devel bounties, to be posted after outreachy application period closes
14:06:51 <abompard> mizmo working on search designs for outreachy project
14:07:00 <mizmo> yep
14:08:40 <abompard> any news on that mizmo?
14:08:54 <mizmo> nope :( have not made any progress yet
14:09:03 <abompard> okay!
14:09:12 <mizmo> did a bit of research on search but nothing new since last mtg
14:09:29 <abompard> Let me re-action them then
14:09:43 <abompard> #action mizmo working on hubs devel bounties, to be posted after outreachy application period closes
14:10:08 <abompard> #action mizmo working on search designs for outreachy project
14:10:52 <abompard> #topic Status Updates
14:11:04 <abompard> who wants to go first?
14:11:12 <sayan> I can go first
14:11:16 <abompard> thanks
14:11:53 <sayan> So, last week I reviewed the abompard's patch on building the react widget loading much more faster
14:12:31 <sayan> and started writing the IRC widget modal on top of the base abompard created
14:13:36 <abompard> sayan: did you use the layout in my repo?
14:13:39 <sayan> I am started migrating the first step of the Choose Nickname modal, spend some time going through the halp widget for reference
14:13:42 <sayan> abompard: yes
14:13:49 <sayan> abompard: I built on top of that
14:14:16 <sayan> abompard: now I would like to know how to collaborate?
14:14:54 <abompard> sayan: ok let's talk about that after the meeting
14:14:57 <abompard> if you don't mind
14:15:02 <sayan> abompard: ok
14:15:22 <sayan> just continuing with the updates
14:15:49 <abompard> OK. mizmo anything else on your updates?
14:15:58 <sayan> I have written the code, but the modal is still not working, so probably will debug with abompard after meeting
14:16:01 <mizmo> nope :(
14:16:15 <abompard> OK no problem!
14:16:27 <abompard> shaily: what about you?
14:17:19 <shaily> hi! i had started working on implementing the Link validator, but kind of got lost in finding the right way of doing so
14:17:30 <shaily> there are a lot of regex patterns for this purpose
14:17:36 <shaily> so I was just looking around
14:17:50 <shaily> although I feel inclined to go with Django's URL validator, given that it will be well tested
14:18:10 <shaily> Talking of 1.11, the incoming PR still uses 1.3's
14:19:49 <shaily> I looked at what was available in PyPI but there wasn't much
14:20:19 <abompard> shaily: yeah I think that if it doesn't cover every case straight from the start it's to too bad
14:20:40 <abompard> not sure we'll need unicode domain names straight away ;-)
14:20:46 <abompard> for example
14:21:08 <abompard> Is there another pull request that you'd be interested in looking at?
14:21:14 <shaily> sure
14:21:28 <abompard> shaily: btw when you can't reach me on IRC feel free to email me
14:21:38 <shaily> okay
14:21:52 <shaily> also, i looked at last meeting's logs and there was a discussion about react. are we planning to use that for all widgets?
14:21:58 <shaily> i've been working on adding markdown to Sticky Notes
14:22:07 <shaily> https://pagure.io/fork/shaily/fedora-hubs/commits/sticky-markdown
14:22:13 <sayan> shaily: not for all widgets, but those which really can take advantage of it
14:22:40 <abompard> shaily: cool! I'll review your PR when you send it
14:22:57 <abompard> yeah, we want to keep having the possibility to make simple widgets without react
14:24:14 <abompard> Alright, if that's all for the Status Updates, let's move along
14:24:33 <fm-hubs> pagure.pull-request.comment.added -- anar commented on PR #400 on fedora-hubs https://pagure.io/fedora-hubs/pull-request/400#comment-36381
14:24:42 <abompard> Any tickets that we should talk about?
14:25:01 <sayan> sticky-markdown should not need React
14:25:15 <abompard> sayan: yeah probably not
14:26:00 <shaily> should i put a checkbox for an option to have a markdown sticky, or should it be always be markdown?
14:26:24 <abompard> shaily: I think it can be always-on markdown
14:26:29 <shaily> okay
14:26:29 <sayan> abompard: let's discuss issue #355 so that it helps shaily
14:26:41 <sayan> that should be quick
14:26:56 <sayan> Yeah, always markdown
14:27:06 <abompard> #topic Ticket The sticky widget should use Markdown to render
14:27:15 <sayan> #link https://pagure.io/fedora-hubs/issue/355
14:27:45 <abompard> So yeah, always markdown. Also, please don't forget a small unit test
14:27:45 <shaily> I guess I'll have to make a custom view for it, since the default view renders <input type="text"> for the parameters, and we would probably want <textarea>?
14:27:55 <shaily> sure
14:28:07 <sayan> Yeah
14:28:09 <abompard> shaily: indeed.
14:28:29 <abompard> Hmm this is not entirely obvious with the current framework
14:28:41 <abompard> I'll think of something
14:29:02 <shaily> I found one widget that was doing so - Halp
14:29:10 <sayan> for all the markdown textarea input I have built, I usually keep two fields one that stores the markdown and another is the converted text
14:29:32 <abompard> shaily: yeah but its config is in React
14:30:08 <sayan> when the markdown text is saved the text is converted from markdown and saved
14:30:45 <abompard> with the current system, if you want anything more complex than text input fields you need to have a react-based widget. I'd like to have a simpler way
14:31:15 <shaily> sayan: we want to save plaintext, right? then render it in markdown in the template
14:31:30 <shaily> abompard: does it specify the custom view using the routes registered in __init__.py?
14:31:44 <shaily> i'm trying to understand how that's working
14:31:49 <fm-hubs> pagure.pull-request.comment.added -- anar commented on PR #400 on fedora-hubs https://pagure.io/fedora-hubs/pull-request/400#comment-36382
14:31:52 <abompard> shaily: that's gone since the move to react
14:32:28 <sayan> shaily: convert to HTML and store in the DB, and then render it
14:32:42 <abompard> sayan: you'd store the HTML in the DB?
14:32:50 <sayan> abompard: yes
14:33:07 <abompard> sayan: what about storing the markdown in the DB and converting to HTML on display?
14:34:08 <sayan> abompard: so this is how I am saying, store the markdown in case the widgets needs to be edited
14:34:27 <sayan> have another field sticky_html where you store the markdown converted to html
14:34:49 <abompard> sayan: for what reason? caching?
14:35:22 <sayan> abompard: yeah, caching can be done
14:35:40 <sayan> but converting to HTML on each display would be time consuming
14:36:16 <abompard> sayan: since the widget is async anyway, I'm not sure we're talking of a significant perf boost here. And if caching is what we need we could still use a Cached Function
14:36:56 <abompard> I'm reluctant to store cached data in the DB
14:37:24 <abompard> it /feels/ more at home in the cache itself :)
14:37:31 <sayan> abompard: yeah, Cached Function should work here
14:38:35 <sayan> but just not doing the same repeated operation of convert markdown to HTML
14:38:59 <fm-hubs> pagure.pull-request.comment.added -- anar commented on PR #400 on fedora-hubs https://pagure.io/fedora-hubs/pull-request/400#comment-36383
14:39:21 <abompard> OK, shaily how about using a CachedFunction for the conversion?
14:39:57 <abompard> Also, I'll think of something so you can have a textarea in the config without having to write a React widget
14:40:53 <shaily> CachedFunction sounds good to me, it'll invalidate when the user edits the widget, just like WidgetWorkshop :)
14:41:30 <abompard> Yeah. I think invalidation will be automatic in that case since the cache key depends on the config value
14:42:15 <shaily> Also, I was thinking of doing the plaintext to markdown conversion client side, using a JS library because I couldn't get lists to work on the python markdown module.
14:42:25 <shaily> I would look into fixing that, but I was thinking we'll present the user with both the plaintext and a live markdown view / preview?
14:42:56 <abompard> hmm, markdown conversion in python should work
14:43:19 <abompard> I'd be very surprised if there was no proper way to convert from markdown in python
14:43:22 <sayan> yeah, markdown conversion in python works.
14:43:30 <shaily> so we want to do it server side?
14:43:39 <sayan> done that, maybe sit down and debug the issue
14:43:53 <sayan> yeah, convert on server side and use cached function
14:43:57 <abompard> shaily: if you're using a cached function, you're server-side anyway
14:44:06 <shaily> plaintext to markdown
14:44:26 <shaily> oh, i'm a little confused
14:44:27 <sayan> it would be markdown to html
14:44:36 <shaily> okay, sorry yeah
14:44:38 <shaily> makes sense
14:44:50 <shaily> the user types in markdown, its converted to HTML
14:44:58 <abompard> yea
14:45:03 <sayan> shaily: yeah
14:45:19 <shaily> cool
14:46:40 <abompard> #action abompard find a way to have textareas in the widget configuration panel without having to write a React widget
14:47:02 <fm-hubs> pagure.issue.comment.added -- sayanchowdhury commented on ticket fedora-hubs#355: "The sticky widget should use Markdown to render" https://pagure.io/fedora-hubs/issue/355#comment-471733
14:47:12 <shaily> abompard: why does react have to come in here?
14:47:32 <shaily> is there no way we could redirect it to a custom HTML template
14:47:51 <shaily> i haven't checked that yet
14:47:59 <abompard> shaily: it should have to :-) Currently no, but that's one of the ways to do it
14:48:55 <abompard> I have an idea that's simpler though. I'll do some tryouts
14:49:12 <shaily> okay
14:49:20 <abompard> OK, if that's all I'll move to Open Floor
14:49:33 <sayan> sure
14:49:35 <abompard> #topic Open Floor
14:50:26 <sayan> I have nothing for open floor
14:51:33 <abompard> OK.
14:51:42 <abompard> Let's end the meeting then
14:51:46 <abompard> in 5 sec.
14:51:57 <abompard> #endmeeting