14:01:47 #startmeeting hubs-devel 14:01:47 Meeting started Tue Oct 31 14:01:47 2017 UTC. The chair is sayan. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:01:47 Useful Commands: #action #agreed #halp #info #idea #link #topic. 14:01:47 The meeting name has been set to 'hubs-devel' 14:01:53 #topic Roll Call 14:02:00 .hello sayanchowdhury 14:02:01 sayan: sayanchowdhury 'Sayan Chowdhury' 14:02:04 .hello shaily 14:02:05 shaily: shaily 'None' 14:02:25 .hello2 14:02:26 abompard: abompard 'Aurelien Bompard' 14:02:31 .hello anar 14:02:32 anar: anar 'Anar Adilova' 14:03:01 mizmo, are you around? 14:03:09 .hello duffy 14:03:10 mizmo: duffy 'Máirín Duffy' 14:04:50 #chair abompard mizmo anar shaily 14:04:50 Current chairs: abompard anar mizmo sayan shaily 14:04:57 #topic Action items from last meeting 14:05:47 * mizmo working on search designs for outreachy project 14:05:49 * mizmo working on hubs devel bounties, to be posted after outreachy 14:05:51 application period closes 14:05:53 * sayan to check out on how to create rooms and bridge IRC in matrix 14:05:55 automatically 14:06:04 has nothing to report on her action items yet :( 14:06:34 pagure.pull-request.comment.added -- abompard commented on PR #419 on fedora-hubs https://pagure.io/fedora-hubs/pull-request/419#comment-38118 14:07:20 mizmo: I will re-action them 14:07:28 #action mizmo working on search designs for outreachy project 14:07:33 thanks sayan 14:07:41 #action mizmo working on hubs devel bounties, to be posted after outreachy application period closes 14:08:15 I tried out last week the idea of have a plumbed room, where we add the integration of irc and keep listening to the messages 14:08:54 there are two types of room in matrix, plumbed and portal. the plumbed being the native matrix rooms 14:09:07 and the portal being the rooms like irc rooms 14:11:16 so, the view.matrix.org that we were looking for the matrix channel is basically a plumbed room with added address of #freenode_#matrix:matrix.org 14:11:25 due to which the logs are public 14:11:38 abompard: mizmo: there is an API endpoint to create rooms 14:11:59 (which was easily searchable) 14:12:09 oh good 14:12:11 but could not find anything to manage the integrations 14:12:27 abompard: probably need to see how riot does that? 14:13:11 sayan: yeah, it's probably using an API somewhere, but I don't know which one 14:13:27 mizmo: for the time being did you see the MVP irc widget (embedding a irc iframe) which abompard made? 14:14:04 sayan, mizmo: I was about to deploy it to hubs-dev so we could test it but I need to pass a PR first 14:14:31 but it'll land in hubs-dev soon, I'm sure 14:14:34 sayan: i didnt 14:14:44 abompard: can you show a screenshot now? 14:16:02 sayan, mizmo: I'm just using https://kiwiirc.com/ in embedded mode 14:16:07 with the channel pre-set 14:16:31 yeah 14:17:57 what are the other items from the MVP that are left? 14:18:01 So I have a couple PRs to get through and then I'll update hubs-devel 14:18:10 and we can focus on the other MVP items 14:18:30 https://pagure.io/fedora-hubs/roadmap?status=Open&no_stones=&milestone=Production 14:19:35 abompard: yes, I saw the PRs I will review them tomorrow 14:19:38 #action abompard to ask jcline about FMN sending notifications back on the bus 14:19:51 ^ that's necessary to get the Streams page working 14:19:57 abompard: yes 14:20:49 abompard, oh, now that I finished re-writing the backend, that should be easy now 14:21:06 jcline: great! :-) 14:21:11 jcline: awesome 14:21:20 The only question really is formatting 14:21:32 jcline: I don't suppose you'll turn that on before the next Fedora release right? 14:22:09 * sayan brb, goes for some water 14:22:13 abompard, the next release being 28 or 27? 14:22:17 jcline: we can discuss formatting later if you need some input 14:22:22 f27 14:22:32 Oh yeah, definitely not 14:22:36 thought so :) 14:22:43 I still don't have it in staging, waiting on a infra ticket 14:22:48 okay 14:22:58 I'll knock up a PR and we can talk formatting on that 14:23:08 if I can help you with that in any way please chime in 14:23:10 * sayan back 14:23:38 abompard, will do. It should be a small patch :) 14:23:45 fantastic 14:24:25 jcline: when you've just completed a rewrite, everything looks like a small patch ;-) 14:24:37 haha 14:24:39 Haha, yeah 14:24:59 Although the re-write got rid of a lot of code so that also helps 14:25:17 :+1: 14:25:30 * sayan checks the other tasks left for MVP 14:26:42 abompard: okay, then going forward let's fix these issues 14:26:52 the ones in https://pagure.io/fedora-hubs/roadmap?status=Open&no_stones=&milestone=Production 14:26:55 pagure.issue.comment.added -- abompard commented on ticket fedora-hubs#388: "The Feed widget should not store data in Redis" https://pagure.io/fedora-hubs/issue/388#comment-476127 14:27:08 and then we can come back to the IRC widget implementation with the Matix 14:27:11 pagure.issue.edit -- abompard edited the close_status and status fields of ticket fedora-hubs#388 https://pagure.io/fedora-hubs/issue/388 14:27:12 pagure.issue.assigned.added -- abompard assigned ticket fedora-hubs#388 to abompard https://pagure.io/fedora-hubs/issue/388 14:27:29 sayan: agreed. 14:27:41 * abompard is sorry for spamming the channel 14:28:05 abompard: search widget we plan to build during outreachy? 14:28:27 sayan: yeah, so I think that we should get rid of the search box for the MVP 14:28:57 abompard: yes, I was thinking something as a feature parity 14:29:04 but that might be too much work 14:29:19 basically to turn on and off 14:29:22 sayan: feature parity with what? 14:29:43 abompard: so right now we have maintain a list of widgets in the config 14:30:15 rather something like a management command to turn off or on a widget 14:31:11 sayan: wouldn't that just be commenting out the widget line in the config? 14:31:20 are you thinking of something different? 14:32:09 abompard: so, after you comment, you have to deploy it 14:32:19 rather we can have something on fly to remove/ add widgets 14:33:03 just an idea, we can skip it. 14:33:12 sayan: deploy it? oh you mean deploy the config and restart the server? 14:33:32 abompard: yes 14:33:36 Do you think it's something that will happen often when hubs is in prod? 14:35:37 still not sure on that 14:36:21 but I don't think the idea is worth investing time right now in 14:36:28 OK. 14:37:01 If you think of other important issues for the MVP, please feel free to open a ticket and we can discuss it there 14:37:11 Anyways, we will remove the search widget from the UI for the MVP 14:37:19 I will create the issue for the same and fix it 14:37:29 :+1: 14:38:32 abompard: I am taking up this issue then 14:38:35 https://pagure.io/fedora-hubs/issue/387 14:38:52 abompard: do you want to take up #390? 14:38:55 https://pagure.io/fedora-hubs/issue/390 14:39:09 yep! 14:39:14 But that needs discussion 14:39:24 abompard: yeah 14:39:37 and mizmo is probably the best person for that 14:39:51 i can take a look 14:40:09 I think anything that will have data using the FAS details could be kept as default? 14:40:14 mizmo: great, thanks :) 14:41:08 i dont think thats a good basis to decide to keep a widget 14:41:14 we should have a minimal set of only the most useful info imho 14:42:34 the thought behind it was we should have a empty widget displayed to the user 14:42:49 mizmo: agreed 14:43:37 mizmo: can you draft a list of minimal default widgets? 14:43:45 and comment to that issue 14:43:53 sayan: sure that was what i was planning to do for 390 14:44:10 #action mizmo to draft a list of minimal default widgets for 390 14:44:11 :+1: 14:44:14 im pretty sure ive written such a list before, though 14:44:21 thanks 14:44:26 maybe lost in the ticket queue 14:44:41 I think we move to Open Floor now 14:44:46 #topic Open Floor 14:44:53 will make it easier to write again anyway :) im not concerned 14:45:04 i've been working on a TODO, and i need a second opinion on something. should i discuss it now, or after the meeting? 14:45:10 mizmo: abompard: shaily anar: you have something to share for open floor 14:45:16 mizmo: unfortunately it looks like pagure only searches in issue titles 14:45:22 shaily: you can do it now 14:45:58 im wondering if the outreachy accpetance process is complete 14:45:59 i think the deadline was today or tomm 14:46:31 mizmo: deadline is today 14:46:55 did you make a decision and send it in? 14:47:03 I wanted to ask a quick question about issue (https://pagure.io/fedora-hubs/issue/391) 14:47:26 do you think we should have 1 generic widget for all of them, or separate for each? 14:48:03 I am thinking about creating new widget(s), btw 14:48:11 * mizmo looks 14:48:23 anar: yeh it's much better to have 1 generic widget for all of them i think 14:48:25 anar: I would be in for a single generic widget rather n-numbers 14:48:35 and in the config the user can specify which 14:48:47 actually the person might even want to see all issues they filed across multiple queues 14:48:47 that would be very useful 14:49:37 sounds reasonable 14:49:46 mizmo: yeah that'd be cool 14:50:11 the widget could have a dropdown to filter within different issue trackers 14:50:54 abompard: mizmo: btw, I will be on PTO next week on Tuesday 14:51:11 cool, i think i can handle it :) 14:51:16 Monday and Tuesday, I will be on PTO 14:51:21 anar: i can do a mockup for you 14:51:33 pagure.issue.comment.added -- duffy commented on ticket fedora-hubs#391: "Widget suggestion: bugs filed by someone" https://pagure.io/fedora-hubs/issue/391#comment-476132 14:51:40 mizmo: would appreciate it :) 14:52:04 sayan: OK I'll do the meeting 14:52:23 so there's a utility that returns a list of packages owned by a given username 14:52:26 (hubs.utils.packages.get_user_packages) 14:52:28 this list is cached for 5 minutes if caching is enabled 14:52:31 the TODO suggests changing this cache invalidation trigger to the appropriate messages from the fedmsg bus 14:52:34 i have the list of messages from fedmsg's docs 14:52:36 i'm trying to figure out how to get them to trigger the cache invalidation since there's no CachedFunction instance here yet 14:52:39 should i add a separate check for the appropriate messages in the triage daemon? 14:52:42 right now, the daemon yields tasks for two things - user notifications and widget CachedFunction checks 14:52:49 * shaily is sorry for multiple messages :| 14:53:11 abompard: add in your name in here https://etherpad.gnome.org/p/hubs-meeting 14:53:57 shaily: yeah that makes sense to me 14:54:09 abompard: cool, i'll go ahead with it 14:54:32 anybody has anything else to share or we can go over and end the meeting 14:54:45 yep, 1 more thing 14:54:56 anar: go ahead 14:55:34 i've noticed that not all widgets' cached functions have unit tests (like pagure_pr) 14:56:03 indeed, we're pretty low on the unit tests side 14:56:10 do you think it makes sense to implement tests for them? 14:56:17 anar: yep! 14:56:21 anar: always 14:56:22 :) 14:57:09 alright then :D, i'll probably start implementing tests for some of them one by one 14:57:14 anar: +1 14:57:29 thanks 14:57:30 going over and ending the meeting in 14:57:32 3. 14:57:35 2 14:57:38 1. 14:57:39 #endmeeting